- 02 Aug, 2019 40 commits
-
-
Miyoung Shin authored
This CL renames mojo to mojom in //fuchsia for consistency with the rest of the chromium. fuchsia/mojo => fuchsia/mojom Bug: 806965 Change-Id: I1f36512ddb418a5a644c546f88fc51ca47cf1a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722168Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683451}
-
Eric Karl authored
This effectively reverts commit 7e8de286. Reason for revert: Testing whether this change was responsible for the latency regression seen in crbug.com/959048. This isn't a true revert, as that CL no longer reverts cleanly, but this restores our previous behavior. Bug: 935630, 959048 Change-Id: Iefb4bd614b5802cfa24a8cb459e62842cfa6d4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698629 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683450}
-
Alex Gough authored
Change-Id: Id153287f26cb6a646fc8c6276093e045cbc88e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730606 Auto-Submit: Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683449}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cba141f276a8..f0390f88f270 Created with: gclient setdep -r src-internal@f0390f88f270 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:964650,chromium:None Change-Id: Ica74d18642915610a483e9d60c1eeb29d9b80967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732156Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683448}
-
Ovidio Henriquez authored
This change updates the Native File System API permissions model to consider the write guard content setting when determining permissions. The write guard determines whether sites are allowed to ask for permission to save to the original files selected by the user through the Native File System API. Bug: 985101 Change-Id: I3ee844ee634ed55b93a6b1e08cd9b8bdad67239b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707430Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#683447}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d22ae8d8. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6790530d "[WPT/common/security-features] Make subresourceContext unmodified" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Idcf544a1c010e6125b6663882d98c1fc8f6ac328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732169Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683446}
-
Hiroki Nakagawa authored
This CL changes the code generator of upgrade-insecure-requests tests to add tests for top-level classic shared worker script loading. The test files (shared-worker-(redirect-)upgrade.https.html) are generated by external/wpt/upgrade-insecure-requests/support/generate.py. Bug: 917532, 989399 Change-Id: If4a3f27c6c8fe08e55dc8d86a8cbf925596490fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728570 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#683445}
-
Matt Giuca authored
This reverts commit 4ccdb965. Reason for revert: https://crbug.com/990203 (introduces a flaky test that fails at certain times of day) Original change's description: > Handle empty timezone on in-session set date time dialog > > Bug: 988107 > Change-Id: Ia9c12a9342342bc080f73ddbe5ba86531b29997e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724696 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683159} TBR=michaelpg@chromium.org,agawronska@chromium.org,hgrandinetti@chromium.org Change-Id: I73c1230760be4eda32238fe9cacf8255fa56f15e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988107, 990203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732074Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#683444}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/56f3a7b90d37..574b951188bb git log 56f3a7b90d37..574b951188bb --date=short --no-merges --format='%ad %ae %s' 2019-08-02 jiawei.shao@intel.com Support BC formats as the first extension in Dawn Created with: gclient setdep -r src/third_party/dawn@574b951188bb The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I8b20722dbd354f19a6708b03dde083e46d673b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683443}
-
Misha Efimov authored
Bug: b/138454468 Change-Id: Ie96c1c3693bfff15d6c39b3fa563462207f4ecc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731430Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683442}
-
Sammie Quon authored
This happens when entering overview normal, then exit via swiping up swipe up on shelf. So we have to update the rounded corners on the normal window, even when a window is minimized. Test: manual Bug: 989149 Change-Id: I85791484fba9ea165e554c09b6d89a893ce5e2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727689Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#683441}
-
Alexey Baskakov authored
This is universal function which can be used by extensions-independent WebApp system as well. In next CLs: We will erase bookmark_app_extension_util.cc|h. TBR=ortuno@chromium.org Bug: 901226 Change-Id: Ibaa2e425c9a9519851d744a0cba928bd24f43e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730554Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#683440}
-
Jacques Newman authored
This was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1692384 due to failure on failure on linux-chromeos-rel ChromeVoxPanelTest.LinkMenu As of https://chromium-review.googlesource.com/c/chromium/src/+/1708415 This test no longer fails. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1646877 Original Change description: > Expose visibility-hidden elements > > This change allows visibility-hidden elements to be returned from > UIA_DescribedByPropertyId and UIA_LabeledByPropertyId. To allow for > this, visibility-hidden elements had to be exposed to the AX tree. > This change can be observed in the update to > AXObject::ComputeAccessibilityIsIgnoredPassThrough(). > > Given: > <div id="a" aria-label="foo" style="visibility:hidden"> </div> > <div id="b" aria-labelled-by="a"> </div> > > When doing TextAlternative calculation for b, we know we are > "in_aria_labelled_by_traversal", therefore we do not check to see > if the node "IsHiddenForTextAlternativeCalculation", therefore > correctly calculating the name for node "b". > But, when we are doing TextAlternative calculation for node "a", > we do not know if node "a" is the target of aria-labelledby, and > is not considered to be "in_aria_labelled_by_traversal", so the > name is an empty string: "". > This is an issue, as the UIA_LabeledByPropertyId on node "b" > returns node "a", and node "a" has an incorrect name of empty > string. > > For purposes of computing a non-recursive text alternative, > if an ignored and IsHiddenForTextAlternativeCalculation node > is included in the tree, assume that it is the target of > aria-labelledby or aria-describedby, since we can't tell > yet whether that's the case. If it isn't exposed, the AT > will never see the name anyways. > > This new behavior is only applied when calculating the > TextAlternative for the ignored node directly, not in the > recursive case. This ensures this new behavior is only applied > to the ignored node, and does not influence the name calculation > of other nodes. Bug: 651614 Change-Id: I6ec57cbd36606890eaf1fd4e72d8442cae2442ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730851Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#683439}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24146be8336f..59bb8cce842c git log 24146be8336f..59bb8cce842c --date=short --no-merges --format='%ad %ae %s' 2019-08-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@59bb8cce842c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Ibf7a3588e8fe63883415a846ff1fdef27362d243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730505Reviewed-by:
-
Justin Cohen authored
This reverts commit ae5d1b92. Reason for revert: This is still failing on ToTiOS. Needs more investigation. Original change's description: > Revert "Disable RememberCertDecision test." > > This reverts commit 7b9599f6. > > Reason for revert: Speculative revert to see if anything changed. > > Original change's description: > > Disable RememberCertDecision test. > > > > TBR=rohitrao@chromium.org > > > > Bug: 973635 > > Change-Id: Ibdd73fa2c40cbea322e22271dc02017cd2d9326a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656589 > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#668609} > > TBR=rohitrao@chromium.org,eugenebut@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 973635 > Change-Id: I69295a9f56101678466744e38279a01f814503c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729400 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682940} TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973635 Change-Id: If0f3d1855fae70340fbe6f55f1b3ca60335058e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732349Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683437}
-
Donn Denman authored
TBR=twellington@chromium.org BUG=990135 Change-Id: Id7207b3f8e98f545d38d6404bb5f0a6e5cab905c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732158Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#683436}
-
John Lee authored
This CL adds the basic elements needed to display the tab strip and adds some basic placeholder HTML, CSS, and text to the UI. Bug: 989131 Change-Id: I8f74dfb3b35b84ba349a6e6e44fd67fca2bbe117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726664 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Rachel Wong authored
Bug: 985205 Change-Id: Ie5a202cf4b78ee8464d8837beb79a929fd1c7052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730450Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#683434}
-
Eric Willigers authored
The marker shorthand serializes as 'none | <marker-ref>' https://svgwg.org/svg2-draft/painting.html#MarkerShorthand If marker-start, marker-mid and marker-end do not all have the same value, it serializes as the empty string. Change-Id: I2c3fbcfd308119a7f258a7f269f93f092fabbfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724707 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#683433}
-
Justin Cohen authored
TBR: rohitrao Bug: 989550 Change-Id: I717c4edcdfccd37ce09a95e270ee6908a400ff10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730556 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683432}
-
Lindsay Pasricha authored
Disable testActivityServiceControllerCantPrintUnprintablePages and testOpenActivityServiceControllerAndCopy These were previously just disabled using the EARL_GREY_TEST_DISABLED macro but that should only be used when it's a partial disable, not for when a test is disabled across the board. Bug: 747622,864597 Change-Id: I5ef336aeefeb50e8984d5e149dc2241d6ae63f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697288 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#683431}
-
Maksim Ivanov authored
Extend interface of the PinDialogManager class to allow dynamically adding and removing custom PIN dialog host implementations. This will be used in follow-up CLs for supporting showing the PIN request on Chrome OS Login/Lock screens. Bug: 964069 Change-Id: I238a3af5b110bf434d9af7bbbfa109d6575721cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730896 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683430}
-
David Benjamin authored
The histogram has expired and I don't currently have the cycles to chase this one down. (On the client, the correct mitigation is to reject *all* connections without renegotiation info, so this would only have been a half-measure anyway.) Bug: 975173 Change-Id: Ib64f4796abe057cf5df606c56926e45682d8cecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727093 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#683429}
-
Collin Baker authored
TabStripModel constructs a placeholder TabGroupVisualData when a group is created, but there was previously no way to update it user-defined parameters. This adds a method, SetVisualDataForGroup(), that updates the TabGroupVisualData associated with a group. The method notifies observers of the change. BrowserTabStripController responds to this change by telling TabStrip to update the visual state of the group. Bug: 905491 Change-Id: I2092c95a8a751cb0046bfec448c5e684665302ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724281 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#683428}
-
Justin Cohen authored
It appears tapping or swiping back to a different custom user agent broken after iOS 12.2 with SlimNav enabled. TBR: rohitrao Bug: 990186 Change-Id: I5662684c405b030a176b75b25f00071473fb092a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731146Reviewed-by:
-
Tim Song authored
This fixes the problem of the launcher closing after clicking on the\ app info drop down menu item on ChromeOS. Note this CL partially reverts the mash changes made in https://chromium-review.googlesource.com/c/chromium/src/+/897470 TEST=unit test + manually verified BUG=987304 Change-Id: If92559f5d205d41db94c63aaf01090011552ff2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726756 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Robert Sesek authored
This has been present for two milestones, which should be sufficient to clean up a harmless file. Bug: 973882 Change-Id: I9506284bc480ea3d38fa5e2dd21491355857e9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731017Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683425}
-
Sky Malice authored
virtual/blink-cors/http/tests/fetch/serviceworker-proxied/thorough/cookie-base-https-other-https.html virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/cookie-base-https-other-https.html virtual/blink-cors/http/tests/fetch/serviceworker/thorough/cookie-nocors-base-https-other-https.html TBR: zmin@chromium.org Bug: 990145, 990146 Change-Id: I637b12c4bf06f37eceed41374e4c8f8051eeecf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731105Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683424}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d014b3d5541d..3bd52c2334a0 git log d014b3d5541d..3bd52c2334a0 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 achuith@chromium.org chromite/lib: Add achuith to device.py and device_unittest.py 2019-08-01 dhanyaganesh@chromium.org config: make eve critical again. Created with: gclient setdep -r src/third_party/chromite@3bd52c2334a0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia823152e0bc3c2b64c4057465a7666d31cf2ecb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732032Reviewed-by:
-
Xiyuan Xia authored
- Replace tablet mode observing part of TabletModeClient with ash::TabletMode calls; - TabletModeClient -> TabletModePageBehavior to better reflect what the remaining part does; Bug: 974238 Change-Id: I009e970ee2d9bbf8e94a294f84a5beb8aaf76258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717823 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#683422}
-
Kyle Horimoto authored
This dialog failed to load fully when cellular SIM was locked due to a JavaScript error trying to access CrOncStrings. This bug was exposed due to another CL [1] which defaults the Cellular network's name to "Cellular" if there is no SIM card (and, thus, no carrier name to show in its place). In this case, the "Cellular" string is actually a field of the CrOncStrings object, but that object was not defined in the dialog. This CL defines the object and eliminates the error. Note that it may be a good idea to refactor CrOncStrings usage; I've filed [2] to investigate this issue. This CL also adds myself as an OWNER for this directory, since I'm now the networking lead. This directory was accidentally skipped in [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1660263 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=990121 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1532905 Bug: 983484 Change-Id: I748f300616d54ee9e1ff167371396647e58cfc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731952 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#683421}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/593b1a6ca228..369f9e5df60b git log 593b1a6ca228..369f9e5df60b --date=short --no-merges --format='%ad %ae %s' 2019-08-01 geofflang@chromium.org GL: Support Rectangle textures as sources for glCopyTextureCHROMIUM. 2019-08-01 syoussefi@chromium.org Vulkan: Enable passing ES2 multisample tests Created with: gclient setdep -r src/third_party/angle@369f9e5df60b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:982294 Change-Id: I93c11f49d229f69a68ce873e41b01f5c25ac74b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730528Reviewed-by:
-
Jun Mukai authored
It turns out layer_tree_host_ can be nullptr in tests which passes unexpectedly on bots other than UBSan bots. This CL fixes this behavior. Bug: 989936 Test: compositor_unittests on the UBsan gn flags Change-Id: I6e8ff606709b07f19e6309e3b5a96ca240f0de99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731954Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#683419}
-
Xinghui Lu authored
See: https://docs.google.com/document/d/1E1uyto12NGe9kZFpqH8T8pRyhaOdzcKwHW51RETw-0Q/edit Bug: 979119 Change-Id: I21c84f254c90d17884b3038ab3ec23121994d6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730580 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683418}
-
Joel Hockey authored
Added AppBrowserController::HasTabstrip to allow System Web Apps to turn on browser FEATURE_TABSTRIP. The tabstrip is required for CrOS chrome://terminal. Bug: 846546 Change-Id: I3f1a6ebafd7b32be51bde17d7ad31526b8cd1ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714121Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#683417}
-
Daniel Bratell authored
The blink::ParsedContentType::Mode type had an alias blink::Mode which made that type name unavailable or caused shadowing warnings for other code in the blink namespace. It makes sense that code has to write ParsedContentType::Mode instead of Mode since that will be clearer. Change-Id: Ie20089fdde14fe0aea4b2beb6f8ab82aa955fdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732089Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#683416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5833269d4277..cba141f276a8 Created with: gclient setdep -r src-internal@cba141f276a8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ibac8a9edf77be251af8d3ab5aa26dee744324855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731021Reviewed-by:
-
Daniel Rubery authored
I extended the following four metrics because they showed an unexpected jump in M73 that I couldn't immediately explain: SBClientDownload.SignedBinaryDownload SBClientDownload.ExtractSignatureFeaturesTime SBClientDownload.DownloadRequestTimeoutDuration SBClientDownload.DownloadRequestTimeoutStats If the changes in M73 turn out to be expected, I'll remove these metrics as well, since we don't have any immediate plans for them. I removed the following SBClientDownload metrics because we don't have any immediate plans to use them: SBClientDownload.ZipTooBigToUnpack SBClientDownload.DownloadFileWithoutDiskImageExtensionHasKolySignature SBClientDownload.DmgFileHasExecutableByType SBClientDownload.DmgFileHasNoExecutableByType SBClientDownload.DmgFileFailureByType SBClientDownload.DmgFileArchivedBinariesCount SBClientDownload.DmgTooBigToUnpack Bug: 975430, 969936, 984257, 988872 Change-Id: I722cd40948513a42f53c64e4d8e4ba9bf05123de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725321Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
-
Xing Liu authored
On each user action, the client now can receive the custom data map. This CL adds the custom data to impression proto. We will plumb this data to the client and add this data to impression tracker in a following CL. Bug: 977255 Change-Id: I4b9552bf30c620a66d466cf6eeabc0f2549666fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717703 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683413}
-
Eric Karl authored
The following tests are flaky. Disabling them for now. MediaSourceTest.Playback_VideoAudio_WebM WebRtcDataBrowserTest.CallWithSctpDataAndMedia WebRtcDataBrowserTest.CallWithDataAndMedia Bug: 990116 Change-Id: I6164f487483ea1a5cb74490553146ca0c1dfb59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730784 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683412}
-
