- 18 Sep, 2020 40 commits
-
-
Lan Wei authored
We do not need WPT test expectation files for WPT tests except the infrastructure tests, so we should remove third_party/blink/web_tests/external/wpt/pointerevents/ pointerlock/pointerevent_pointermove_in_pointerlock.html.ini. Bug: 1086154 Change-Id: Ie964d783cdf4cd5754de7df0e7262cf5fc3e4696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418975 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#808482}
-
Jeffrey Kardatzke authored
This adds support for setting the HDCP Content Type when enabling HDCP for output protection. The two values are Type 0 and Type 1. Type 0 is equivalent to HDCP 1.4, so it shares the same value as the prior protection setting for that to minimize code changes. This will then be plumbed through to the Chrome OS CDM Factory Daemon to enable it to turn on and query output protection. BUG=b:168230642,b:153111783,b:132039686 TEST=Unit tests pass, works with full set of changes on prototype Change-Id: I19f5ab7e0f1d1b57062e0b77e864e55144afce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413087 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#808481}
-
Jeff Yoon authored
* Roll all iOS builders (goma, webrtc, fyi, mac, try) to 12a7209 * Roll all upstream iOS tests to run on 12a7209 Bug: 1128632 Change-Id: Ia18f2391e9aea21c92d867612bc43a140ef96fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411403 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808480}
-
Charlie Hu authored
'font-display' has been migrated from feature policy to document policy in (https://chromium-review.googlesource.com/c/chromium/src/+/2036518). This CL cleans up some misnames after the migration. Change-Id: I2edc1611a8b5f53997ad152661ba18284eac669a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404147Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#808479}
-
Travis Skare authored
Bug: 1093377 Change-Id: I4df1bf7bdfe6efe0cbf09b20b9815e7f9eebfeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364655 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#808478}
-
Lei Zhang authored
Add a new "-u" switch to list_flags.py to search for unused flags. It checks the obvious files that should reference flags. Change-Id: I0f9b050b2adcafd0a612bae93f2e4ef08cdf0e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416851 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808477}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e69a13d838d..c884631f9942 2020-09-18 johnstiles@google.com Migrate Derivatives tests to golden outputs. 2020-09-18 csmartdalton@google.com Lift SkMeasureAngleInsideVectors and SkFindBisector to public SkGeometry API 2020-09-18 brianosman@google.com SkSL: Cleanup interpreter intrinsics, etc. 2020-09-18 csmartdalton@google.com Don't simplify a stroked shape if it isn't closed 2020-09-18 nifong@google.com Add a define causing debugger to use an older clip feature If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I3dbbbd426e10a4e6f1c4368923bf8fa47c8c9e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808476}
-
Shimi Zhang authored
In this CL, we register listener for content editable element including <input> and <textarea> elements. This is used to notify that the browser side that there will be a handler for touchstart event, so it needs to send the event to the renderer. Please refer to the bug for more information about the overall design. Bug: 1126778 Change-Id: I35457d5f1ca02c943b5bf594c06a6a70e2c6e3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401786 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808475}
-
Ankit Kumar 🌪️ authored
Update pdf/ to use gfx::*F instead of pp::Float* - pp::FloatRect to gfx::RectF - pp::FloatSize to gfx::SizeF - pp::FloatPoint to gfx::PointF or gfx::Vector2dF gfx::FloatPoint is replaced by gfx::Vector2dF where we need to store the vector difference between two points. All other instances have been replaced by gfx::PointF. Noteworthy points: - In pp::FloatRect, Union() is a utility method which takes in two rects and returns a rect with the specified operation of input rects. Whereas in gfx::RectF, Union() is a member method which modifies the rect in-place. All usage of Union() which are replaced in the CL modify the rect in-place. Added conversions between gfx::RectF and pp::FloatRect, with tests. Bug: 1101101 Change-Id: I57ca3bddd16da1328cbe462e60be862be3811ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413769Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#808474} -
Chromium WPT Sync authored
Using wpt-import in Chromium e50ef635. With Chromium commits locally applied on WPT: b943d006 "[COOP] Access reporting with 2 reporters." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I0f9b8c43988139c0422edee444e9bb2073a00995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419271Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808473}
-
Mark Yacoub authored
The CL fixes the following issues: 1. When looping over pending modeset requests, do not depend on the dynamic vector size. 2. If the display modeset has failed, do not always select the next available mode, check that it's valid first. 3. Retry configuring displays when any of them fail, not just the last one. 4. Use default values for unittest variables. BUG=b/168800852 TEST=should configure multiple displays even after the first mode is rejected. display_unittests Change-Id: I285d02f4b7f653588b53c48655cc05514264242d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417008Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#808472}
-
Eugene Zemtsov authored
Switched from using parses' object pointers to using ids and looking them up when needed. Bug: 1129422 Change-Id: Ib1e618a048406c5d50290a9512ee455f03f1d28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416863Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808471}
-
Nektarios Paisios authored
This is a reland of 6772afd3 Tests failures in PDF tests were caused by out-of-date expectations which are now fixed. Original change's description: > Stops computing an artificial accessible name from inner text on Mac > > When an object on Mac is focusable but has no value or name, we compute its accessible description > from its inner text. > Unfortunately, we were adding a space between the concatenation of each piece of text coming from each child object > which creates a mismatch between the text offsets returned by AXPosition and text markers vs. the actual text contents. > If extra spaces are needed, they should be added by Blink, not by the browser. > This patch removes the code that computes the inner text completely since > no other screen reader announces focusable items unless they have an accessible name, > and it is not proper to add an accessible name if there is none. > > AX-Relnotes: On Mac and same as on all other platforms, navigating by tab now does not announce > the text contained in a large container such as a table row if that container is focusable. > > R=dmazzoni@chromium.org > > Change-Id: Iac5f321113595a2372df03bb119ab1c7a6f1bbf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308649 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794574} Change-Id: I04ff746943b97d76f90849da558aec7dba3022d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356004 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#808470}
-
dpapad authored
In the new UI layout, the PDF area can be resized in two ways 1) expanding/collapsing the sidenav 2) resizing the entire window Because of #1, the previous approach of listening for the Window's 'resize' event is no longer sufficient. Therefore a ResizeObserver is used which works for both #1 and #2. Bug: 1121351 Change-Id: I6fd895a55e4630f9562c8d8ea38dc7d4fc6ebb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391335Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808469}
-
Dominic Mazzoni authored
Original: http://crrev.com/c/2404164 Reverted: http://crrev.com/c/2416357 due to issue with death test. Replace the hand-written code to parse each enum from ax_enums with a templatized function that builds a map from string to attribute value on-demand. This saves a little bit of manual effort each time someone updates an enum. Note that these parsing functions are only used by the automation API. Bug: None Change-Id: Ib710f15f2596b04d30ca177b8141b2dc953ed5c1 AX-Relnotes: N/A Tbr: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418850Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808468}
-
Caleb Raitto authored
We can then divy these up amongst the team and rename them without causing excess merge conflicts. Produced by: gen_web_feature_mojom.py: import sys startingValue = int(sys.argv[1]) numEntries = int(sys.argv[2]) for i in range(startingValue, startingValue + numEntries): print(' kIdentifiabilityStudyReserved%d = %d,' % (i, i)) gen_enums_xml.py: import sys startingValue = int(sys.argv[1]) numEntries = int(sys.argv[2]) for i in range(startingValue, startingValue + numEntries): print(' <int value="%d" label="IdentifiabilityStudyReserved%d"/>' % (i, i)) Bug: 973801 Change-Id: Ica729a243defb580e9dcbf18fa1a433938581cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416259 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#808467}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib49002b92910784299238b52019db57343b9ffaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808466}
-
manukh authored
At one point, the document provider expected responses with http status codes of 200 with a specific error code in the response body. This was deprecated in favor of responses with 400 & 499 http status codes. For a while, the provider handled both. Now that the backend exclusively employs the new responses, it's safe to remove the original 200 backoff handling. Change-Id: Ie79fedaa6e0930db3f32aefedd3ccde699f984a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416561Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808465}
-
Lukasz Anforowicz authored
CORS-for-content-scripts has shipped in M85 - afterwards, the UKM and UMA metrics should only be logged for allowlisted extensions. In M87 we have removed the allowlist (r807240) which means that the metrics can't be utilized going forward. Additionally, we would proceed with deprecating the allowlist, even if the metrics would show that some extensions might still be _hypothetically_ affected. For the reasons listed above, this CL removes the UKM and UMA metrics for CORS-for-content-scripts. This corresponds roughly to reverting the following CLs: r739693 (UMA) and r750700 (UKM). Note that Rappor has been added in r746508, but has been already removed in r768003 (and therefore this CL doesn't touch any Rappor-related code or files). Bug: 920638, 1125776 Change-Id: I5b410d9e17a19ae0d3eec8727317ae940bf1896c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396712Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#808464}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/97813ea40eea..5bfca93e1a51 2020-09-18 jmadill@chromium.org Fix roll script for CIPD deps. 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 6ccc0d9ba0ff to c9f4fb2fccda (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Ib28763d86697ba8b8ecc917dc598eea3bddde9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808463}
-
Nnamdi Theodore Johnson-Kanu authored
- Before this CL a console error was thrown in cellular_setup.js in onPageChange_() because this.currentPage_ value is undefined before cellular_setup ui is attached. Bug: 1093185 Change-Id: I754fc9d8c0d751a3232032f2e266aa686eeb6225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414989 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808462}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad83951e..576f2f50 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I37788affc7b3b8f293aa0d6aa73bbd941002a022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418615Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808461}
-
Mustafa Emre Acer authored
Bug: 1129548, 1129804 Change-Id: I9fd896a4059042dae5fdde3bca31af50f302d13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419258 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#808460}
-
Lukasz Anforowicz authored
After r807668, the RenderFrameHostImpl::UpdateSubresourceLoaderFactories is no longer affected by the race with an in-flight navigation. Therefore, this CL removes the stale comment that talked about the race. Note that in UpdateSubresourceLoaderFactories it was possible to determine that the in-flight navigation should be preferred over the last committed navigation (for calculating the URLLoaderFactoryParams), because UpdateSubresourceLoaderFactories sends the new factory *to* the renderer (and therefore the renderer will receive the new factory *after* the in-flight navigation commits). Such determination is not possible for RenderFrameHostImpl::CreateNetworkServiceDefaultFactory because it is exposed via //content/public API and therefore we don't know if the caller will use the results of CreateNetworkServiceDefaultFactory for 1) sending an IPC *to* the renderer or 2) responding to an IPC sent *from* the renderer. Therefore the CL leaves unchanged the old comment and behavior of CreateNetworkServiceDefaultFactory. Bug: 1056949 Change-Id: Ib7689891b3b9b4bad6b4e66fe0997ece358ef8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419331Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#808459}
-
Justin DeWitt authored
Change-Id: I637a52d02bb62195efcfad0bff41aa47afb6eaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410649Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808458}
-
Kent Tamura authored
This CL adds "-internal-media-controls-segmented-track" and "-webkit-slider-runnable-track" to shadow_element_names.json5. This CL has no behavior changes, and is a preparation to port LayoutSliderTrack to LayoutNG. Bug: 1040826 Change-Id: I6558e1221dc748091b2972fc6e5e7452346206df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418271 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808457}
-
ckitagawa authored
We are planning to experiment on beta in M87. This sets up the field trial config so the experiment can be prepared for beta rollout in finch. Launch Bug is https://crbug.com/1008520 Bug: 994742 Change-Id: I4bac78b3e65b3f60bb49e1d8167852c2ba9e9855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418893 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#808456}
-
Alexis Hetu authored
In the context of replacing SwiftShader GL with SwANGLE (ANGLE + SwiftShader Vulkan), which doesn't plan on adding support for rectangle textures, make sure tests which use rectangle textures are skipped when the feature is not supported. Bug: chromium:1061151 Change-Id: Ie0467a5aecdd024bcbb28c5e058d2588cc3bb5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418976Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808455}
-
Luke Zielinski authored
Change-Id: I966fc253ab338522bdcf5c09c8523a53748ce406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418477 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#808454}
-
Ian Kilpatrick authored
Original change description: > This patch ensures that we always have a "consistent" fragment-tree (or > rather a portion of a fragment-tree if we have legacy nodes). > Previously it was possible for a fragment-tree to become inconsistent > whenever we performed layout from a subtree root. Now when we layout > from a node like this, we rebuild the "spine" of the tree. > After this change we'll be able to remove most "PostLayout" calls, > except where they are used for building this "consistent" tree. The first change had two issues. 1) Cloning a part of the fragment tree which had its layout-objects removed from the tree. The fix for this specific issue is to stop re-building the spine of the tree when we encounter an object which needs layout. 2) AbstractInlineTextBox holding a stale pointer to an NGFragmentItem. The fix for this specific issue is to call: DetachAbstractInlineTextBoxesIfNeeded on any NGFragmentItem(s) which have an associated LayoutText. Bug: 1066616 Change-Id: Iade8d4c2e7ae9129863d3b295271da944ffec81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418978Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808453}
-
Kent Tamura authored
This CL applies LayoutObjectFactory to RangeInputType::CreateLayoutObject() and SliderTrackElement::CreateLayoutObject(). This CL adds LayoutObjectFactory::CreateSliderTrack() for SliderTrackElement. - The function returns LayoutNGBlockFlow for LayoutNG - The constructor of LayoutSliderTrack should take Element*. CreateObject<> requires it. This CL has no behavior changes because RangeInputType::TypeShouldForceLegacyLayout() still returns |true|. Bug: 1040826 Change-Id: Id4ba89f09e5ff16f6b5f1f7d5c477162395beaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419091 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808452}
-
Andrew Grieve authored
This reverts commit f43f03fe. Reason for reland: Added missing "await" Original change's description: > Revert "SuperSize: Fix missing access token for diffs" > > This reverts commit a26b32ce. > > Reason for revert: Missed an "await" > > Original change's description: > > SuperSize: Fix missing access token for diffs > > > > Also: > > * Throws a more explicit exception for failed fetch. > > * Stops setting Cache-Control: no-cache > > > > Bug: None > > Change-Id: I380207b32497f1cb5467ff62bcd3c857dc03ff58 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418799 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808406} > > TBR=agrieve@chromium.org,mheikal@chromium.org > > Change-Id: I0a264d02d6066034e9eb23c854520c0e1c55672f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419122 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808441} TBR=agrieve@chromium.org,mheikal@chromium.org # Not skipping CQ checks because this is a reland. Bug: None Change-Id: Ie4ea9ffdaab2cd7c0e23b516fba016e57e3ae6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419123Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808451}
-
Connie Wan authored
Buggy behavior: When moving >=3 tabs in bulk, tabs would get moved farther and farther apart due to this: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/extensions/api/tabs/tabs_api.cc;l=1477;drc=9eb09ede880e6cb9f4d58ff003dcd52815b4a45c (The new_index was already being updated to the actual inserted index at each move). This change is dependent on crrev.com/c/2414994 due to this: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/extensions/api/tabs/tabs_api.cc;l=1471;drc=9eb09ede880e6cb9f4d58ff003dcd52815b4a45c Change-Id: Ib2b61daf56d1b7e4f054cc57b332c4d150e272aa Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414778Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#808450}
-
Michael Hansen authored
This updates the title on the button that opens the device name dialog and removes the label above the text field in the dialog. These changes are to match updated specs in the Nearby Share strings spec. Bug: b:161297140 Change-Id: If77ed7f29cd2ce9f2ae37c810baebfe38688c251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417057Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#808449}
-
Natalie Chouinard authored
This resource override on API 26 does not appear to be necessary anymore. Tested on Android O emulator. More background on b/67327250. Bug: 1129668 Change-Id: I234e42b580f95bcc430353cfec29243c3f69b819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417536Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#808448}
-
Sammie Quon authored
This will help prevent regressions like the one caused by crrev.com/c/2189575. See [1] for more details on the regression. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1125403 Test: merged crrev.com/c/2189575 and test failed Bug: 1129000 Change-Id: Ia2a79fda1553ad0298a064b957e122f2a0e2b962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416734 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#808447}
-
Tom Sepez authored
Replace a boolean enabling javascript with a tri-state enum and plumb through to the appropriate code. No functional change yet introduced. Building with PDF_ENABLE_XFA will still result in a chromium with XFA support fully enabled. We do not yet ship chrome built with this option. Bug: chromium:62400 Change-Id: Idbbc8de6033cf3ed90d3eb3ecbb9a2ef0a32b623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417091 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808446}
-
Daniel Rubery authored
This launch has been rolled out to all Canary/Dev users for a few days, and we don't see any stability impact. Since this code only triggers on a small proportion of downloads from Advanced Protection users (~50,000 users), we don't expect our code paths have actually been executed much in the wild. We can be reasonably confident we aren't causing problems for non-APP users, however. Change-Id: I9a3cf16459d839623ac8417a032dce031cbed798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402134 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#808445}
-
Yulun Wu authored
Bug: 1110766 Change-Id: I9a77bfbdc6c19679d82ea01bfaf25fc70e7483ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416763Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808444}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70026f9d14f0..03fd7930c651 2020-09-18 terelius@webrtc.org Allow more than 2 encoders in RtcEventLogEncoderTest 2020-09-18 yinwa@webrtc.org Minor fixes to avoid crash on some traces that have unexpected data. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id6451d5aa107ccc8cab127d537999b26d7f0dd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418844Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808443}
-