- 21 Oct, 2020 40 commits
-
-
Dominic Farolino authored
This reverts commit e89e7092. Reason for revert: http://crbug.com/1122182#c19 adds the debugging info we need on Android, so we can perform minidump analysis Original change's description: > [Prefetch]: Don't DCHECK if recursive prefetch token is set. > > This reverts commit a55089af. > crbug.com/1122182 is blocking minidump analysis for now. > > Bug: 1132770, 1123715 > Change-Id: I15910a86667d242d3da419e4ed9a274e2a82fea8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474854 > Reviewed-by: Dominic Farolino <dom@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Auto-Submit: Mugdha Lakhani <nator@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817771} TBR=kinuko@chromium.org,dom@chromium.org,nator@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132770 Bug: 1123715 Bug: 1122182 Change-Id: Ic24cdc3b5a8a5bb453e4ddf525ac85d52ddbaef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485552Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#819277}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2e6434aadb1..9f9ea0f6f024 2020-10-21 szuend@chromium.org [ts] Type-check object_ui/ObjectPopoverHelper.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ide21bfeef878a68ebd78708f535f6da328663eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819276}
-
Nidhi Jaju authored
This reverts commit b52b97cb. Reason for revert: It is breaking external/wpt/streams/idlharness.any.html based on bisection. Original change's description: > Remove NotEnumerable from Transform Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from transform streams. > > Bug: 1093862 > Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006 > Commit-Queue: Nidhi Jaju <nidhijaju@google.com> > Reviewed-by: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819230} TBR=ricea@chromium.org,nidhijaju@google.com Change-Id: I7176391031e4bbf89960fe6d7f358a520d06dd21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487745Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819275}
-
Yue Li authored
Bug: b/169453041 Test: Run TranslationResultLoaderTest.* in chromeos_components_unittests Change-Id: I47769ca8e86847fac34130eaa9048ff128c44f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484333Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#819274}
-
Sergey Ulanov authored
Skia requires VK_IMAGE_USAGE_SAMPLED_BIT, VK_IMAGE_USAGE_TRANSFER_SRC_BIT and VK_IMAGE_USAGE_TRANSFER_DST_BIT usage flags to be set for wrapped Vulkan images. These flags were not set in SysmemBufferCollection for buffers that were created with BufferUsage::SCANOUT usage. As result these images couldn't be wrapped in Skia images. Update SysmemBufferCollection::InitializeImageCreateInfo() to set the required usage bits. Bug: 1140763 Change-Id: If9e980701f109519eb25ce753251082c693eedf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488910 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819273}
-
Side Yilmaz authored
DownloadManagerService#resumeDownload function may triggered for OTR profiles. However, download shouldn't be resumed if the native is not initialized yet. This CL blocks to resume download initiated from OTR profile, if native has not initialized yet. Bug: 1138139, 1099577 Change-Id: I46e6e0b47474f760150754f57e8805466c937449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471738Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819272}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d2f82c00aeb..41d4c65a3396 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c4593127cbdd to cca03ca6bfe9 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I77a1ce61fe92b98450be7de8c991b334aa2d692a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489224Reviewed-by:
-
Jose Dapena Paz authored
GCC fails to resolve default move constructor of AutocompleteMatch, as SplitAutocompletion move constructor is not declared noexcept. Adding default declarations fixes the issue. Bug: 819294 Change-Id: I64e32608bbdd24015a4a65f398b37de9465c5b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485527Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819270}
-
Koji Ishii authored
TBR=yosin@chromium.org, tkent@chromium.org Change-Id: Ie60dfeb5432fd32de2a93d2909abb141e1172117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487922Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819269}
-
Jose Dapena Paz authored
GCC build breaks because we are declaring an attribute in the wrong place of a function definition: ../../base/compiler_specific.h:125:27: error: attributes are not allowed on a function-definition 125 | #define NO_SANITIZE(what) __attribute__((no_sanitize(what))) | ^~~~~~~~~~~~~ ../../base/allocator/partition_allocator/pcscan.cc:221:57: note: in expansion of macro ‘NO_SANITIZE’ 221 | size_t PCScan<thread_safe>::PCScanTask::ScanPartition() NO_SANITIZE("thread") { | ^~~~~~~~~~~ Bug: 819294 Change-Id: Iff1a3ec8c4b2765c7d95c45a1951fa7f0714a86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485545Reviewed-by:Tom Sepez <tsepez@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819268}
-
Jose Dapena Paz authored
libstdc++: do not pass a unique_ptr directly to stream insertion operator in CrossThreadMediaSourceAttachment. Fix build error using libstdc++: ../../third_party/blink/renderer/modules/mediasource/cross_thread_media_source_attachment.cc:578:37: error: no match for ‘operator<<’ (operand types are ‘std::basic_ostream<char>’ and ‘std::unique_ptr<blink::WebMediaSource>’) 578 | << ", web_media_source=" << web_media_source; | ^~ ~~~~~~~~~~~~~~~~ | | | std::unique_ptr<blink::WebMediaSource> This is because libstdc++ does not provide an operator<< implementation for std::unique_ptr (but libc++ does provide it). Bug: 957519 Change-Id: I344b0f289d625b036e6bd4cafac1000cff6f23ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486260Reviewed-by:Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819267}
-
Jiewei Qian authored
This is a cleanup after BMO launch. SWA no longer uses extension related components. Bug: 1065748 Change-Id: I96e631a1ce5372bed458a4ff2010140950ae70c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485356 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#819266}
-
David Tseng authored
This was left out (somewhat intentionally) in an effort to optimize the init/read path. However, this appears to be occasionally causing the process to hit resource limits on linux causing no new threads in the process to be created. Sample error: 2020-10-21T00:37:18.448831Z ERROR chrome[19371:19371]: [tts_service.cc(29)] E1020 17:37:18.448238 19371 thread.cc:68] Thread create failed: Resource temporarily unavailable R=dmazzoni@chromium.org Fixed: 1140617 Test: continually read long text over and over again. Observe no crash. Change-Id: Ie811b6ecc7e2bce9f898dc7cbd351cdfe5e4503d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489028 Auto-Submit: David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819265}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9d160b0bba68..e2147a58a233 2020-10-21 jmadill@chromium.org Add missing condition_variable include. 2020-10-21 syoussefi@chromium.org Vulkan: Support vertex attribute aliasing for non-matrix types 2020-10-21 jmadill@chromium.org Perf Tests: Add stdout printing arg to bot mode. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I8ebc271c04ed794ff7fea1dc6635ddf10bebde10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489223Reviewed-by:
-
Luciano Pacheco authored
Note: per [1] JS modules must be served with text/javascript HTTP Content-Type. Change file_manager_jstest_base.cc to add Content-Type headers. [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules Bug: 1133186 Change-Id: I6a5436984052d74af267634f6fe0db70424b51a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470039Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#819263}
-
Aya ElAttar authored
As SystemFeaturesDisableList policy just launched, so its UMA stats is still needed. Bug: 1140030 Change-Id: I38191d0519554a215248e024acc8a86dd4f39402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487088Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819262}
-
sauski authored
CL stops appending table names into queries and inlines them directly instead. Bug: 1117381 Change-Id: I4cb5adc389f1685606ffa519383493a594e6bfac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485061Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#819261}
-
Joel Hockey authored
go/chrome-ss/b025494050650332c0d6964cb82b977199bd9fd0 go/chrome-ss/8d3b3f36cf84c787244001584e2b8425be3e7549 Bug: 953310 Change-Id: Ie6114823134d43026cdbaace7bc364e531884ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489122 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Fergal Daly authored
This reverts commit a9b6d2bd. Reason for revert: Causing builder to fail. First fail was 8 changes after this. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 Original change's description: > Use set_fixed_width() in c/b/ui/views dialogs > > Does not address subfolders which will be done in separate chunks. > > Bug: 1128500 > Change-Id: Id3caa97d0d59b4700b888c5bca5f89f69d4c64d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485148 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Auto-Submit: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819061} TBR=ellyjones@chromium.org,pbos@chromium.org Change-Id: I0d03cb731d03bf7ba11d836769bd2513c25f1366 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128500,1140866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489380Reviewed-by:
-
Chris Hamilton authored
This will be used in upcoming instrumentation logic. BUG=1080672 Change-Id: Ic465c9277e7c84c56183691554937f231fc6a340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487848 Auto-Submit: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819258}
-
jchen10 authored
ChromeOS only uses 1 mailbox for all yuv planes, while the current VideoFrameYUVConverter assumes 1 mailbox for each plane. So that's the cause of the bug. To fix that, we have to use CopySubTexture instead. This also adds ABGR video frame support for Android. Bug: 1137947, 1135073 Change-Id: I600df595cf849aeee01ed39e2e36b2297dfc2d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486568 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819257}
-
Manu Cornet authored
Bug: 1136145, 1056219 Change-Id: I3fe051a8bdb30224a8d20b0f404d4c03f2eac80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467940 Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
David authored
Doc: http://go/backlight-better-crash-report#heading=h.148xm9y8bm2q Note: Choosing to make this an optional field in JSErrorReport in case future non crashReportClients don't have access to the browser process. Bug: b/169635499, b/167109810 Change-Id: I3d351fe2cc797fecb45b03e3a359db1be66fda20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483945Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#819255}
-
Hoch Hochkeppel authored
Adding a class to represent the Windows RandomAccessStream class within tests, as well as basic unit tests to validate the test class behaviors. This class behaves similarly to the Windows equivalent, except it includes gtest validations for expected usage and schedules all async operations through a ThreadTaskRunner. Bug: 1035527 Change-Id: Id0ce1af8995260fdcb0c2a06c6408819afc4dfbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487818Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819254}
-
Morten Stenshorne authored
It would be tricky to locate the right fragment in PositionForPoint(), in cases where a node generates more than one fragment. A much easier solution is to remember which fragment we hit. Move fragment item specific code out of LayoutNGBlockFlowMixin's PositionForPoint() into the new NGPhysicalBoxFragment method PositionForPoint(). Also call this method from HitTestResult::GetPosition() if we stored a fragment during hit testing. For now we'll only do that for inline formatting contexts, since NGPhysicalBoxFragment's PositionForPoint() doesn't support block children yeyet. Bug: 829028, 1043787 Change-Id: Ifc9f3245f832bdebd2a20dbd6ebe73ca3289d80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485219Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#819253}
-
Piotr Tworek authored
This class is used as and allocator passed to std::vector. In case of libstdc++ however the allocator is inherited by std::_Vector_impl which breaks chromium builds against libstdc++. Ref: https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/bits/stl_vector.h#L129 Bug: 957519 Change-Id: I85b6d8160d3be1dc11de28c4d58fbb1510398701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485064Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Thomas Lukaszewicz authored
Bug: None Change-Id: I80a296b678ce5ad7577c937035cd45a9bf54b30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488383Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819251}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/792630c498fc..f736cabba58b 2020-10-20 sokcevic@google.com Add retry on git push failure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I3d1bc35dc47d11a35d87f6c9c1e4cb74a64c58d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488922Reviewed-by:
-
Oliver Chang authored
Bug: 1140770 Change-Id: I0c9877f5cb24bb66c86df3577caee71a9fdca102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487742 Commit-Queue: Oliver Chang <ochang@chromium.org> Auto-Submit: Oliver Chang <ochang@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#819249}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2fb0633adec8..7a0246ff177e 2020-10-21 abennetts@google.com Reduce the data serialized in _FormatAndPostBugCommentOnComplete tasks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1140309 Tbr: skyostil@google.com Change-Id: I4034b94fea0a19cae4bd767de0e2586737ef4f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488931Reviewed-by:
-
Morten Stenshorne authored
Only RootInlineFormattingContext() understood LayoutFlowThread, and only ContainingNGBlockFlow() checked if we actually found an NG block flow. We still require the object to be inline (non-inlines shouldn't need this anyway). This doesn't affect anything right now, but I'm working on some changes that will require flow-thread-awareness. Bug: 1061423 Change-Id: If7b490d8e872de67d7a74723228f3d72f73028ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487081Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a87909398b71..e38a448746e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:912681 Tbr: fergal@google.com Change-Id: Iadd54a58e896f743402fc7c611f87aab7a638588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489220Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819246}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ie7f8846b200a481729861602db724b10d1fc225b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488156Reviewed-by:
-
Yuke Liao authored
This CL ensures that all tests are run when changes are made to build/lacros to avoid accidental breakages. Change-Id: I8d4d056d3e551b7786249f2be43d6513c3422af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488980Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819244}
-
Yuke Liao authored
This CL starts using ToT ash-chrome on linux-lacros-rel to run tests. Bug: 1129223 Change-Id: Icc8c51ff0ae6863b999c81d153c5a5905f0961ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487872Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819243}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e9c99e93e75e..cca03ca6bfe9 2020-10-20 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 7156d3e3140b to 4f79c8405028 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I69cd792b021cd3d47705766b6ed66f4af093b745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488928Reviewed-by:
-
Darren Shen authored
Android API [1] allows it, so we should too. [1] https://developer.android.com/reference/android/view/inputmethod/InputConnection#setComposingRegion(int,%20int) Bug: b/170796179 Change-Id: Iabb31d34e56f46a3b05dd53324b19169af0a53fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483943Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#819241}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ui/base. R=thakis@chromium.org Bug: 1113033 Change-Id: Ic45fa9c79f34412f38dd2632123c2d819f1692f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477442Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#819240}
-
Andrey Kosyakov authored
... it's a WeakPtr after all. Bug: 1140263 Change-Id: I4bcc7890f67b1220b756d97c53c64de012c52756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488988Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819239}
-
Tal Pressman authored
Currently, renderer-side objects (RenderFrame, RenderView, etc.) assume the AgentSchedulingGroup outlives them, but this is not the case if the disconnect handler is called before they are destroyed. After this CL, the ASG's lifetime will match the RenderThread's, and it will be destroyed when the RenderThread is destroyed. This is OK for now, since we currently only have a single ASG per process and the host's lifetime matches the RenderProcessHost's. In the meantime, kouhei@ is working on properly shutting down ASGs via an IPC, similar to other objects. Bug: 1137580, 1138942 Change-Id: Iab02cecf3cd828a0b84f2bc29e451d1a591422ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478622 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
