GitLab

Only depend on the aliased protobuf runtime rather than the real target.
This also updates a deprecated method usage (valueOf) since it is no
longer available in the latest runtime.

TBR=mechanical changes

Bug: 1114836
Change-Id: I8896cd81e17c4fbd9dc368b5906618fe743d124e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357634
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798751}

This CL removes some apparent includes on non-media //chrome code. Most
of the changes are simply removing obsolete includes. In one case, a
Profile dependency is replaced with components-friendly UserPrefs.

Bug: 1057100
Change-Id: I6a476e4cb7ee17234b4f398bd11d3d1246c7c5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354624
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798750}

In order to support WebSockets from a system context:
    · Don't apply throttling to WebSockets with a process ID of zero.
      (I.e. those from the browser process itself.)
    · Require that the render frame ID be zero if the process ID is
      zero.

The assumption that a zero process ID is the browser is taken from
|HasRawHeadersAccess| [1].

[1] https://source.chromium.org/chromium/chromium/src/+/master:services/network/network_service.cc;l=605;drc=23f61cb65a94208dc2c4728e895e87d47f64a8b6

Change-Id: I149dff7b92f856a659c5ae05822bee69658bf8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356933Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798749}

Accessibility label for the gear button in the NTP's Discover feed
header. Uses the same text as Clank.

Bug: 1085419
Change-Id: I9522aa1b5a9c13bb6c4ebbb2a757e4088beec440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359736Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Cr-Commit-Position: refs/heads/master@{#798748}

Bug: 1000959
Change-Id: Ieed509995513719fb46a0161fa3819bd3ea295e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359233
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#798747}

Bug: 1102464
Change-Id: I40cfff907592e18cb615c3a1f90e24784181f21c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358738
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798746}

* Inline temps
* constexpr
* Format
* Shorten code
* Avoid unnecessary precision loss
* Improve naming
* Narrow scope

Bug: none
Change-Id: I457b636ca926654fb01e34f2d201e547d9070265
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359005Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798745}

For users who don't have Google as their default search engine, change
Discover feed header to "Discover by Google".

Bug: 1085419
Change-Id: I3fde4099d7694ef80853d8b0e1c93ea0aac129ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343844Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Cr-Commit-Position: refs/heads/master@{#798744}

This is a reland of 0ab91ac7

The original CL did not update clipboard_recent_content_ios_unittest.mm,
which needed updates to use the new asynchronous behavior. It also adds
a check in clipboard_recent_content_impl_ios to filter out URLs with
invalid schemes. This existed in the synchronous version, but was left
out of the asynchronous.

Original change's description:
> Fix iOS Omnibox Clipboard Suggestions to not immediately read clipboard
>
> The basic idea here is to factor out the match creation methods. On iOS
> 14, if the clipboard contains content, we create a blank match of the
> correct type (one without any destination_url). Then, when the match
> is selected for opening, we can ask the clipboard_provider for a new
> match using the proper text, and open that one instead.
>
> For other platforms, we can keep using the old method, where we access
> the clipboard immediately and construct the destination_url at match
> creation time. iOS 14 also uses this behavior if there is cached
> clipboard content.
>
> Bug: 1105869
> Change-Id: I70d26f4bcc485e4dc9073db2257161355adc8a40
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346290
> Commit-Queue: Robbie Gibson <rkgibson@google.com>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Reviewed-by: manuk hovanesian <manukh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#797671}

Bug: 1105869
Change-Id: Id2102a3ef8f461e4345e065b2eef86ab040781b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355946Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#798743}

In order to promote browser_tests to CI to be shariffed to prevent
regressions.

Bug: 1111979
Change-Id: I753704f84ec05337e834c38b1dc1bbcc90a9cf9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357962
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Auto-Submit: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798742}

This reports data: and sandboxed iframes as always origin-isolated,
according to the window.originIsolationRestricted property. This is
done regardless of the process isolation state or the presence/absence
of the Origin-Isolation header.

The web platform tests were revamped in the following ways:

* Sandboxed iframes and data: URL tests were split into -yes and -no
  variants, to ensure that the parent frame didn't influence the
  result. For sandboxed iframes in particular, the -no variant was not
  tested previously, and was failing until after the code changes here.

* Additional tests for javascript: URLs were introduced, as an earlier
  version of this CL would trigger a DCHECK on opaque-origin pages
  navigating to javascript: URLs.

* Shared code was factored out. The .html files are now just wrappers
  that delegate to resources/*-test.mjs files.

Bug: 1095653
Change-Id: I69a1f388250d1364dd33c365c936a76546add5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334103Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798741}

Roll ChromeOS Broadwell AFDO profile from 86-4183.48-1597052523-benchmark-86.0.4232.0-r1 to 86-4183.59-1597658380-benchmark-86.0.4232.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ifdc8311c60a226f247de3aee4d25b262ab070b81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360262Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798740}

Since webview_power_usage.sql now calculates app power usage and total
device power usage, this change updates the corresponding tbmv3 metric
to output these values.

Bug: b/159154163
Change-Id: Ia0f788e357837e056ed04b1bd252f9a26d2d07de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354834Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798739}

This reverts commit 647d93e9.

Reason for revert: crbug/1116821 - causing crashes
TBR=ryansturm@chromium.org,falken@chromium.org,rkaplow@chromium.org

Original change's description:
> Add PerfectHeuristics UKM event, and metric for DelayAsyncScriptExecution
>
> This CL introduces the PerfectHeuristics UKM event, along with a boolean
> metric for when a blink::ScriptRunner comes across an async script
> before the script element's node document has finished parsing. The
> PerfectHeuristics UKM event is logged in the UkmPageLoadMetricsObserver.
>
> See the Google-internal UKM privacy review:
> https://docs.google.com/document/d/1UqkpGXc4LEh5jzzVR8fCVVTuCuG2mwvhQTuCy36zT3g/edit#
>
> See the Perfect Heuristics [1] project document (currently
> Google-internal).
>
> [1]: https://docs.google.com/document/d/1Y7uF76Gq0VlJZky2j7x-lbD1_awH64eW0WRg1bNLuFs/edit
>
> R=​falken@chromium.org, nhiroki@chromium.org, ryansturm@chromium.org, sophiechang@chromium.org
>
> Bug: 1086227
> Change-Id: I71954491a1a559c2e1244a543092f1b8f38b8136
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340845
> Commit-Queue: Dominic Farolino <dom@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798393}

TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org,dom@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1086227,1116821
Change-Id: I0131884d123e2122fa674097381293174795fecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359573
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798738}

Remove 'lengths-2.html' from test expectation file since
it started passing recently.

Bug: 6606
Change-Id: Ib3a849f26fda7d343eee66106801bf8dc828961f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359037
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#798737}

https://swiftshader.googlesource.com/SwiftShader.git/+log/abe07b943855..e7cd224e55fa

2020-08-17 capn@google.com Don't rely on VectorType::get() default parameter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: If61c65b68bdf2cb1f8f2e0894d4ecf965a312fc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360254Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798736}

Visiting an ephemeron pair checks if the key is alive. It did not
check if the key was in construction. If that check happens on a
concurrent thread (that didn't happen to mark the key before) then
there is no sync between the threads (the in construction check is
generally used as the sync) and the is a data race between creating
the key and concurrently checking if it's alive.

This CL adds an in construction check for the key as a sync point.
If the ephemeron key is in construction, we treat it as marked and
trace the value (the key will be marked by the end of GC). This
allows concurrent marking to handle the value rather than leave it
for the mutator thread.
The key is marked either by the write barrier when pushing it to the
HashTable, as a previously in-construction object if we get a marking
step with no stack, or conservatively during the atomic pause (if it's
not marked by regular marking).

Bug: 1116801
Change-Id: I2b75bbca3a8986285c905eb024560c4ad2525826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358744Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798735}

Bug: 1087530
Change-Id: Ibd93974dfa6563a42e9e12133fe6d61bd5628a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342250
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798734}

Consider tabs still being restored in the total incognito count stored
in the tab state metadata file when serializing. Also group ids/urls
for tabs still being restored with their respective models.

BUG=1111594

Change-Id: I85482d4f9cc936966a8aaff672b49cb1a839cd67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358380
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Theresa  <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798733}

At some point initially (I think)? chrome_elf_unittests was
a very thin binary that could not link in //base/test/launcher
to run as a regular chromium gtest-based test.

However, that appears to have changed quite a ways back is a
regular chromium gtest-based test. However, it was still configured
as a "raw" test, which meant that we could only look at the
exit code from the test and not rely on it conforming to the
normal chromium gtest command line API.

This CL fixes that.

Bug: 816629
Change-Id: I184af40d56feb01050a2ddcec020827250a51b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354664Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#798732}

Field name for downloading stage should be in sync with the server
side proto. It is |downloading_stage| on the server side, hence
the field name on client side should be downloadingStage.
Currently it is downloadStage.

For reference, server side proto is:
https://source.corp.google.com/piper///depot/google3/chrome/cros/reporting/api/proto/extension_install_events.proto;l=55?q=chrome%2Fcros%2Freporting%2Fapi%2Fproto%2Fextension_install_events.proto&ct=os&sq=package:piper%20file:%2F%2Fdepot%2Fgoogle3%20-file:google3%2Fexperimental

Bug: 1108257
Change-Id: I4f5826beb1ea9e54b094b7a598966f72e3e8895b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356385Reviewed-by: Anqing Zhao <anqing@chromium.org>
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#798731}

Previously it returns thinkness in DPI (or window length), and the
callers may scale it to a viewport length, but sometimes the scale was
missing, causing the scrollbar to be too thin in highdpi and other
bugs.

Now let all ScrollbarTheme methods use viewport lengths.

This fixes bug 1049412, and other bugs, such as
- scrollbar margin was not adjusted for highdpi;
- thumb minimum length was not adjusted for highdpi;
- default width of LayoutTextControl didn't consider highdpi for the
  hypothetical vertical scrollbar.

Bug: 1049412
Change-Id: Id7281db8e96f78db7c9a6633a1b43dc160da6f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358995Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798730}

Conditions are:
- Onboarding feature should be targeted to "new" users
- "New" users are users who haven't interacted w/ Assistant in 28+ days
- Once shown in a user session, we should continue to show onboarding
  in that user session until an Assistant interaction takes place
- Once shown in any user session, we should continue to show onboarding
  in each subsequent user session until we reach a maximum of 3

This CL also deprecates Warmer Welcome which is being replaced by the
new onboarding feature.

Bug: b:157510970
Change-Id: If60ac0e9f7d87aaf2240e76a5ba4e5fe06e8dd5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324801
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798729}

Bug: 1113287
Change-Id: I0dd3b14bc9538b71686e9dbac9b258eaec0a2015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356749Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798728}

Change-Id: I472582eaea658d2ee8a4c157a0161611d2aca2e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359229Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798727}

This reverts commit 19a1e60d.

Reason for revert: crbug.com/1117192

Original change's description:
> Add tracing support for mojo handle kinds
> 
> Support tracing of mojo handle and remote/receiver kinds. Thus provide
> more precise debugging information for developers. Also avoid
> generating fallback literals for base::trace_event::ValueToString.
> 
> Bug: 1103623
> Change-Id: Ib01e79f7ae0aba64cabda3aea87cc1d1aed3b921
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356005
> Commit-Queue: Karel Král <karelkral@google.com>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798588}

TBR=rockot@google.com,altimin@chromium.org,karelkral@google.com

Change-Id: I3fc0ca207c2b99324083c8f512903cf74757f8bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1103623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359083Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798726}

BUG=webrtc:6625

Change-Id: I840ccfe138b544ba4956eda6382ac4f3897a8720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352807
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798725}

Bug: 1000959
Change-Id: Ia0bed864089e14ad413a409fb646706b17cc96fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359232
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#798724}

This reverts commit a0c9fe7f.

Reason for revert: Appears to be the culprit for https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/14160?

Original change's description:
> Adding androidx.window to android_deps
> 
> Also fixes warning in android_deps where buildCompile or test targets were
> triggering vulnerability errors when they aren't shipped.
> 
> androidx.window is being added to implement Web APIs related to dual screen
> and foldable devices. See:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/_1_ljYsaqrU/m/qOoHJ7MhAgAJ
> 
> TBR: OWNERS check broken for new android_deps OWNERS file
> Change-Id: I350a1f464be2ecb0111004c89aaa87477c7e7e96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354599
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Auto-Submit: Sam Maier <smaier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798709}

TBR=yfriedman@chromium.org,wnwen@chromium.org,smaier@chromium.org

Change-Id: Iea77c415621965f007da4eb7f322d0332eb6214e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358587Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798723}

The 'none' default allowlist has been removed from the spec, as it was
never used, and further spec changes have made it unlikely that it will
be usable in the future.

Bug: 1095641
Change-Id: Ib7b5eae2e022f726dc6dc616ef3382f2d82861df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354419Reviewed-by: Charlie Hu <chenleihu@google.com>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798722}

This CL makes views_unittests and extensions_unittests to run in
non-experimental mode so that it's Sheriffed to prevent regressions.

Bug: 1111979
Change-Id: Ifb403b5a63fe2a7424445a32006ce919972f5fe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358055
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Auto-Submit: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798721}

If a prerender finishes after a navigation, the page_ is no longer the
correct one. Adds an early return case from the previous DCHECKs.

Bug: 1116966
Change-Id: Iee1ca67d1a257a2390ff372dff94634db079197c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359552
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798720}

This reverts commit db50a5ab.

Reason for revert:

Regression on a few metrics: http://crbug.com/1116715

Original change's description:
> fieldtrial_testing_config for DiscardCodeCacheAfterFirstUse
> 
> We intend to make a wider rollout/experiment of the feature to discard
> the code cache. No changes are expected in the lab. Update the config to
> confirm no effect on bots.
> 
> Bug: 1045052
> Change-Id: I5c0a6443f9cefac93391d957a1fcefffc72adea3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356709
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Egor Pasko <pasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798280}

TBR=pasko@chromium.org,holte@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1045052
Change-Id: Ie0d3d9c45320bd61a6959f467185b72596dc439c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358833Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798719}

R=chrisha

Bug: 1080672
Change-Id: I4b24d1e77e9dcc228d606f6d484127b04ca0dadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339219
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798718}

Adding a new feature flag to allow enabling the WebShare functionality
on the platforms (OS and Chrome OS) where it is being actively
developed.

http://crbug.com/1035527

Change-Id: I5cd9274457c86c957360ff7e6a0b61f1c474e124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357091Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#798717}

Bug: 1116440
Change-Id: I969ef6466a56fdd8d4d76cc2d8abbeeeff830536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356969
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798716}

This allows the recipe to specify which gn should be run.

Bug: 1098864
Change-Id: Ia7d770b1783ca4d0d44596f7f82481f92da8d16a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357453
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798715}

Previously, boolean PolicyValue is missing a constructor with type
specification on PolicyValue class. It caused some inconvenience
on code generation and testing. With the introduction of enum
PolicyValue, this becomes more obvious because enum type's constructor
also comes with a type parameter.

In order to simplify the codegen and testing logic, this CL adds a dummy
constructor for boolean type PolicyValue.

Note: the constructor with type parameter aims to distinguish policy
values that have same C++ type representation but different policy value
type, e.g. IncDouble and DecDouble, Enum and Int.

Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798714}

Using wpt-import in Chromium 8c4380f2.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I4ef0f8a93b00f250a20106dadd0ac3dfda806d61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358585Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#798713}

This patch extracts out the stacking context grouping properties from
ComputedStyle::HasGroupingProperty, and uses this for the stacking
context decision. This has the effect of not creating a stacking context
for clip which, unlike clip-path, does not create a stacking context:
  https://drafts.fxtf.org/css-masking-1/#propdef-clip

Bug: 1115003
Change-Id: I4bd5d3c61a2bb34a56a089cbeaca260fc9bf2eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358473
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798712}