GitLab

I will revert this CL after a few canaries.

Bug: 839751
Change-Id: I823ec7c2eb47df905869d3f4f74c89e59a1433be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246596
Auto-Submit: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779391}

Tab group header title chips are not centered in the tab group header.
Instead, they "tuck into" the stroke on the left side of the first tab
in the group. This looks good when the group is expanded, but bad when
the group is collapsed, because the title (unlike the underline stroke)
looks off-center.

We considered two approaches to fix this:
1. center the title in the existing header size
2. expand the header so the margin on the right side matches the left

We chose (2) because it prevents visual jitter in the title chip when
expanding and collapsing, as well as automatically aligning the title
with the stroke.

Bug: 1094040
Change-Id: Ie5e6252b56f7fdf612c580d403bd1b198bb2710c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249055
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779390}

This CL hooks up the Always Show Full URLs option via OmniboxEditModel
to the path-hiding omnibox UI experiments. Users will now be able to
opt out of reveal-on-hover and show-on-interaction to always show the
full URL without any elisions.

Bug: 1094760
Change-Id: I3d5f15e7fcb6863701f00042daee9867fcbcf0bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246863
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779389}

This will be useful in some download item cleanup.

Bug: none
Change-Id: Iac4793db8fc13cdb935cee0360aee1f128fb8d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245346Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779388}

This test is passing, but doesn't actually do anything for a couple of
reasons:

1. The first POST commit used a deprecated style of navigation without a
   NavigationEntry this fails automatically with bad message 216 since
   cross-document navigations require a NavigationEntry in
   RenderFrameHostImpl::DidCommitNavigationInternal(). This is fixed
   by using NavigationSimulator.
2. In NavigationControllerImpl g_check_for_repost is set to false for
   all tests. Even if a repost happened in this test the repost dialog
   would never show or increment the counter. This is fixed by adding a
   Scoped*ForTesting class similar to those for thread restrictions to
   permit showing a repost dialog in a test.

I'm surprised the bad message didn't trigger a test failure...

Bug: 1095727
Change-Id: I32906017fe2b931d459544b27c437691b92e08a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247079Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779387}

Opacity is sampled based on iteration time, which in turn is calculated
from the animation clock. As the clock has microsecond precision and
floating point rounding errors can further reduce the precision, a
relaxed tolerance is required for the opacity calculation.

Bug: 1094141, 1094473, 1094561
Change-Id: I59710951a5cb167362d2c6ec18710530d487a1b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248754Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779386}

This CL contains manual modifications to a handful of tests that use
Shadow DOM v0 and Custom Elements v0, to attempt to upgrade them to
WCv1. This CL also includes the movement of several tests (which turned
out to be V0 only tests) to the web-components-v0-only folder, which
will eventually be deleted.

Bug: 937746
Change-Id: Ibf0bc44ad0e7e97b79e489abad29463496888161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248496
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779385}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cac292283bfa..99f100357776

2020-06-17 tvanderlippe@chromium.org Fix node output for Ninja actions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I84e19075b4046bc88a4bf6ef1edb81b366b98f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249716Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779384}

Bug: 1021774
Change-Id: Idbcc46bdd1cf942221ac9c986fa010fd35fd4c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248545Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779383}

This patch changes |RecalcFloatingDescendantsVisualOverflow|
to use |PostLayoutChildren| when traversing fragment tree,
to avoid reading stale |NGPhysicalFragment|.

This patch is speculative.

Bug: 965639, 1095577
Change-Id: I86d8f054832f921d91bb8949f3aa956e940de7e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249281Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779382}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I10a179268fdcefe85d414ad37917e0cc0f9ec999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248631
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779381}

Previously, arc kiosk had a different autolaunch workflow than other
kiosks, this made it much harder to debug autolaunch issues for
different kiosk types. We are changing that.

Bug: 1015383,1085104
Change-Id: If71456cf7312ef233e3dccd1f1be69be8cd3d3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231065
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779380}

Changed const char to constexpr char

Bug: None
Change-Id: Ib52da28f638cfb6030aebaf659027fd64e9a6f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247736Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Viviane Yang <viviy@google.com>
Cr-Commit-Position: refs/heads/master@{#779379}

Bug: 1094335
Change-Id: I44617ec720910a8b5b1e03af27375089d48f23be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240868
Commit-Queue: Roberto Moura <mouraroberto@google.com>
Auto-Submit: Roberto Moura <mouraroberto@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779378}

At the moment Marble does not return text responses, but only TTS.
This will only be supported in a future release.
To allow teamfooding of the Marble on ChromeOS feature using today's
1.46s branch, this CL introduces a
|enable_on_device_assistant_tts_as_text|
flag that converts the Marble TTS to text that is displayed to the user.

Bug: b/157169287
Change-Id: I2870a02c8c1ebe4f48e6dea9c1ede0337de030f9
Tests: manually tested.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240309
Auto-Submit: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#779377}

This CL does the following:
- Adds the ability for InfoBarCompactLayout.java to prepare infobar
  icons. This support is copied in from //chrome's
  InfoBarCompactLayout.java now that InfoBarLayout.java is available in
  //weblayer.
- Uses the now-componentized translate infobar icon in //weblayer's
  translate infobar.

BUG=1025620

Change-Id: I2d7cf05a0ec629017c715b4a690210e99ae4722a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238167
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779376}

Bug: 1061575
Change-Id: I8744e057675cc8f4e7bca79c6d4bce4cfcf6acd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248727
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779375}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20aa34ea8ddc..e2fbb30f588e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC mmentovai@google.com,ioanap@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: mmentovai@google.com,ioanap@google.com
Change-Id: I9bad31881d765b8948735eee673097914ed052be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249712Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779374}

This CL adds the needed declarations in the in-product help backend
for Tab Groups. No configuration is checked in. This IPH will be
configured via Finch. fieldtrial_testing_config.json parameters will
be added later.

This also adds TabGroupsIPHController which observes the TabStripModel
for events we care about, sending them to the backend. It will later
trigger a promo in the tab strip when allowed by the backend.

Bug: 1022943
Change-Id: I2ef065dccd400595e43a578bf8f2830fc85d907a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243935Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779373}

Bug: 1095716
Change-Id: I39407684996e68de23752973182de12ffdb38682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249065
Commit-Queue: Vincent Boisselle <vincb@google.com>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779372}

Adjusts the placement of the Access Context Auditing feature flag guard
in the service factory to prevent erroneous instantiation of the service.

Bug: 1083384
Change-Id: I93872191a59e6a48be06044ec71b0d403a3738d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249960Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#779371}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

TBR=kinuko

Bug: 1031540
Change-Id: I11f6bd375b17f0d62f50c960756c07dd20d102e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247895
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#779370}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Ibbee5a552dc140af4f6ca01cfcf6aa4f1a3b1c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249799
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779369}

This CL merges /#page-info-refactoring with /#improved-cookie-controls.

Bug: 1063824
Change-Id: If3578cd4413a0e171ce59932608913ecf3f6469f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247735Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779368}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I58c1887f9e2e3f491682d212412d225998591a3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249676
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779367}

This optional GUID is populated with the underlying
NetworkStateProperties GUID field. If the Device does not have an
associated network, the field will be empty.

Bug: chromium:1085092
Change-Id: I5531022b887a9136a80c2f37d9398b3df663d3b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247146
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779366}

Per TAG review discussion [1], this change updates the set()
method as follows:

Promise<void> set(USVString name, USVString value);
Promise<void> set(CookieInit cookieInit);

dictionary CookieInit {
  required USVString name;
  required USVString value;
  USVString? domain = null;
  USVString path = "/";
  DOMTimeStamp? expires = null;
  CookieSameSite sameSite = "strict";
};

[1] https://github.com/WICG/cookie-store/pull/141

Bug: 1087580
Change-Id: Ic22ae0bc7dfc3df71ac849b9acd894316fe01377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220556Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779365}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I0d181f221f5f4dfe54c96d525191a69031e8b1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249740
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779364}

[Passwords] Add 32-bit checksum field to AutofillRandomizedValue for crowdsourcing change password urls.

Bug: 1095605
Change-Id: I3b7b40b7a9612e9c199697d9359e70fa857a7af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246594
Commit-Queue: Jonathan Mengedoht <mengedoht@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779363}

The AutofillProvider interface was added for downstream coding when
the Android autofill feature was first introduced. It wasn't
necessary now.

This patch shall also reduce the binary size a little bit.

Bug: 1094377
Change-Id: I8896fbaa6260750d8b9e92df9ed67b4f5a0b26c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248170Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779362}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Ie5cb39f54fb8d0cccc03dd02ce13755169d6f8ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248687
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779361}

https://skia.googlesource.com/skia.git/+log/f5cd604cb9d0..1443609db494

2020-06-17 djsollen@google.com Revert "Update zlib DEPS"
2020-06-17 djsollen@google.com Update zlib DEPS
2020-06-17 johnstiles@google.com Enable implicit-fallthrough warnings on Clang.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: djsollen@google.com
Change-Id: Ifde08f500d8e3d10098274bac140fe3e3594d92f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249711Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779360}

This CL changes the way the UserAgent is stored and used.
Now the UserAgent to be used when loading a page is stored in the
WebState. Each NavigationItem is storing the UserAgent that was used
when the item was loaded. This is the UserAgent that is used to display
the option (request Mobile/Desktop) and to reload the page when
navigating back/forward.

As the UserAgent is now in the WebState, it has to be restored as part
of the session restoration. This also allows the UserAgent to be kept
when the preloader is used, as the session is restored.

When the mobile/desktop version is requested, the NavigationManager is
updating the UserAgent of the WebState.

Bug: 1049094, 1076855, 1078343
Change-Id: I459ec728f01da814ba23bafc0aa7fb1e185f95e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193994Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779359}

CableDiscoveryData uses memcpy, without including the header that declares
it. So include <cstring> is required.

Bug: 819294
Change-Id: I1b8157d2565dc1333be51c6371de1f84374ceb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247037
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#779358}

Bug: 819294
Change-Id: I073c5b4200b92736ba533c176fb116f83f3ee8ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248758
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#779357}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

TBR=jorgelo

Bug: 1031540
Change-Id: I4e85df6fa0687ec8b891d77f1fb788acf309b28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248763
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779356}

When user with child account tries to modify timezone preference, prompt
parent access code validation dialog. Timezone changes can only be
applied if the validation success.

Bug: 997310
Change-Id: I90e1b5ebd79f5ca92dcc32223d637f37615e6699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210749Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779355}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I5040ce1488344ab719ff53b71286958b655798a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248764
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779354}

This is a bunch of tests that are broken by the fact that the RFH
changes after navigation.

Change-Id: I10578a56bbb382dd1e41a57f645e75d5ff51a3ba
Bug: 1064944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245166Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779353}

Some permissions tests rely on a prompt being shown when requesting
location access, but location access is automatically denied when
geolocation is turned off in system settings. This causes flakes on
certain bots that don't have geolocation enabled.

Bug: 1094586
Change-Id: I08a6b5add43a90ea40ad99ec5272373ceaf03ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246925Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779352}