- 17 Sep, 2016 30 commits
-
-
elawrence authored
BUG=598338 Review-Url: https://codereview.chromium.org/2347923002 Cr-Commit-Position: refs/heads/master@{#419362}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b22608753f37..ff40d4569c8b $ git log b22608753..ff40d4569 --date=short --no-merges --format='%ad %ae %s' 2016-09-16 aiolos Remove reference builds for Android-K compatible 64bit Chrome. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2343313002 Cr-Commit-Position: refs/heads/master@{#419361}
-
dcheng authored
Less comments, more type safety. BUG=581865 R=danakj@chromium.org TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2014103002 Cr-Commit-Position: refs/heads/master@{#419360}
-
estark authored
When the Security.showCertificateViewer command is received by the browser, it should show the certificate for the visible entry, not necessarily the last committed entry, because there might be a transient entry for an interstitial overlaying the last committed entry. BUG=647759 Review-Url: https://codereview.chromium.org/2344113003 Cr-Commit-Position: refs/heads/master@{#419359}
-
joedow authored
Updating per PM feedback. BUG=645540 Review-Url: https://codereview.chromium.org/2342313004 Cr-Commit-Position: refs/heads/master@{#419358}
-
servolk authored
BUG=645626 Review-Url: https://codereview.chromium.org/2342963003 Cr-Commit-Position: refs/heads/master@{#419357}
-
lazyboy authored
This is because they are only available/needed on chromeos. On my local test setup, I see a reduction of 6672 bytes in chrome binary: gn gen out/Release --args=' use_goma=true is_clang=true \ is_component_build=true proprietary_codecs=true ffmpeg_branding="Chrome" \ safe_browsing_mode=1 enable_google_now=true is_debug=false \ dcheck_always_on=true ' ninja -C out/Release chrome With this change: ls -al out/Release/chrome: -rwxr-x--- 1 lazyboy eng 61439904 Sep 15 16:03 out/Release/chrome Without this change: ls -al out/Release/chrome: -rwxr-x--- 1 lazyboy eng 61446576 Sep 15 16:04 out/Release/chrome BUG=376319 Test=Expect no visible change. Review-Url: https://codereview.chromium.org/2344783004 Cr-Commit-Position: refs/heads/master@{#419356}
-
dgozman authored
It's not inteneded to be used in main. BUG=none Review-Url: https://codereview.chromium.org/2348013002 Cr-Commit-Position: refs/heads/master@{#419355}
-
chrishtr authored
Instead, put a PaintController on the root FrameView and paint into it with the "classic" non-composited path. BUG=646188 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2322073006 Cr-Commit-Position: refs/heads/master@{#419354}
-
dgozman authored
This prevents the toggling when user just wanted to select text. Note that simple click usually clears the selection and element will be toggled. BUG=none Review-Url: https://codereview.chromium.org/2346873005 Cr-Commit-Position: refs/heads/master@{#419353}
-
xdai authored
BUG=626752 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2332483002 Cr-Commit-Position: refs/heads/master@{#419352}
-
piman authored
BUG=646814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2344273003 Cr-Commit-Position: refs/heads/master@{#419351}
-
pkotwicz authored
These includes are included as part of the runtime_library_javatests target BUG=None Review-Url: https://codereview.chromium.org/2344953002 Cr-Commit-Position: refs/heads/master@{#419350}
-
jbudorick authored
BUG=619055 Review-Url: https://codereview.chromium.org/2348693004 Cr-Commit-Position: refs/heads/master@{#419349}
-
vmpstr authored
This patch adds checks to see which call site is invoking a CheckAndIssueSignals without a tile_task_manager_. Code inspection didn't point at any obvious culprits. Hopefully these checks will. R=danakj BUG=642927 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2341323003 Cr-Commit-Position: refs/heads/master@{#419348}
-
boliu authored
BUG=625089 Review-Url: https://codereview.chromium.org/2349043002 Cr-Commit-Position: refs/heads/master@{#419347}
-
eroman authored
BUG=634443 Review-Url: https://codereview.chromium.org/2337373003 Cr-Commit-Position: refs/heads/master@{#419346}
-
dschuyler authored
Updating Polymer to get mouse cursor change from Pull Requests we submitted. BUG=425627 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2346073003 Cr-Commit-Position: refs/heads/master@{#419345}
-
foolip authored
In dictionary_v8.cpp, the extra null check was wrong or redudant depending on nullabilty: * If the member isn't nullable, then passing null should throw TypeError. * If the member is nullable, then a null check is already emitted earlier, and so that part of the condition is always true. The affected dictionaries were identified by looking at the resulting changes in the generated bindings. Any affected member was made nullable so that this change in itself is not observable, but the right behavior is achieved if those changes are individually reverted. A few cases that were not given TODOs: * MessageEventInit, because the existing TODO is appropriate. * MediaStreamEventInit, because it has no spec and MediaStreamEvent's corresponding attribute is already nullable. * SpeechRecognitionEventInit, because it has no spec. SpeechRecognitionEvent's attributes were made nullable because they can now in fact be null. A number of spec issues were discovered, linked with the TODOs. BUG=647693 Review-Url: https://codereview.chromium.org/2342393002 Cr-Commit-Position: refs/heads/master@{#419344}
-
yuweih authored
Previously we assumed that DestopView.onAttachedToWindow() will only be called after DesktopView.init() is called but this is not true when we enter split screen mode. Since the lifecycle of View.onAttached... and View.onDetached in relate to Activity.onCreate() and Activity.onDestroy() is not well documented and behaves quite surprisingly, it may be better to just rely on the lifecycle of the activity itself. This CL removes DesktopView's onAttachedToWindow() and onDetachedFromWindow() overrides and handles initialization and invalidation by Desktop's onCreate() and onDestroy(). BUG=647823 Review-Url: https://codereview.chromium.org/2348563004 Cr-Commit-Position: refs/heads/master@{#419343}
-
piman authored
BUG=632626 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2349613002 Cr-Commit-Position: refs/heads/master@{#419342}
-
mmenke authored
BUG=none Review-Url: https://codereview.chromium.org/2346863003 Cr-Commit-Position: refs/heads/master@{#419341}
-
tedchoc authored
BUG=560466 Review-Url: https://codereview.chromium.org/2348583002 Cr-Commit-Position: refs/heads/master@{#419340}
-
kbr authored
BUG=618447, 619264 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=cwallez@chromium.org, zmo@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2350503002 Cr-Commit-Position: refs/heads/master@{#419339}
-
khushalsagar authored
This is the final patch in the series that abstracts the LayerTreeHost class to provide an implementation that run the impl thread components in-process (single-threaded and threaded compositor). This renames that existing implementation to the LayerTreeHostInProcess. Next up, we add an implementation that handles remoting the content provided to the compositor across a network boundary. BUG=625283 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2340143002 Cr-Commit-Position: refs/heads/master@{#419338}
-
rajendrant authored
BUG=646184 Review-Url: https://codereview.chromium.org/2333063002 Cr-Commit-Position: refs/heads/master@{#419337}
-
sczs authored
UIApplication OpenURL(). The function will use the non deprecated method if its available (iOS10+) BUG=622735 Review-Url: https://codereview.chromium.org/2340873002 Cr-Commit-Position: refs/heads/master@{#419336}
-
djacobo authored
Some links open a new tab while navigating, given that we redirect some of the traffic to ARC, it can be necessary to close any unused tab. Since we are closing the contained WebContents on a tab, we need to make sure the callback within the UI doesn't get called twice, since intent picker has an observer for the WebContents. BUG=647806 TEST=manual test Review-Url: https://codereview.chromium.org/2347273002 Cr-Commit-Position: refs/heads/master@{#419335}
-
prasadv authored
Revert of Add a broken page to dummy_benchmark.noisy_benchmark_1 (patchset #1 id:1 of https://codereview.chromium.org/2334323003/ ) Reason for revert: Reverting the changes to as we have enough revisions to perform bisect FYI jobs Original issue's description: > Add a broken page to dummy_benchmark.noisy_benchmark_1 > > *PERF SHERRIF: this CL intentionally breaks dummy_benchmark.noisy_benchmark_1 > for intergration testing purpose. > > BUG=646628 > NOTRY=true > > Committed: https://crrev.com/522a347da44b43e8bbf58ad29e246dc3dab3872c > Cr-Commit-Position: refs/heads/master@{#418971} TBR=nednguyen@google.com,sullivan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646628 Review-Url: https://codereview.chromium.org/2345393002 Cr-Commit-Position: refs/heads/master@{#419334}
-
kainino authored
Enables support on non-ANGLE desktop platforms (Mac/Linux) and GLES platforms supporting NV_sRGB_formats (Tegra). This is tested by WebGL conformance test conformance/extensions/webgl-compressed-texture-s3tc-srgb.html BUG=630498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2337833002 Cr-Commit-Position: refs/heads/master@{#419333}
-
- 16 Sep, 2016 10 commits
-
-
bradnelson authored
BUG=None TEST=None R=sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk BUG=646185 Review-Url: https://codereview.chromium.org/2342353003 Cr-Commit-Position: refs/heads/master@{#419332}
-
dschuyler authored
This CL changes the ripple to trigger on mouse down rather than mouse up. This better matches other uses of paper-ripple. BUG=645190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2341593002 Cr-Commit-Position: refs/heads/master@{#419331}
-
dschuyler authored
This CL moves the circle/dot part of the toggle button slightly. It also adjusts the shadow and translation. These adjustments are needed for the compact toggle button. BUG=646003 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2344083002 Cr-Commit-Position: refs/heads/master@{#419330}
-
rockot authored
Passes an IPC::Channel* to OnFilterAdded instead of IPC::Sender*. This is changing so that filters can use more than just the Sender interface of the Channel, and namely so they can get at remote associated interfaces. BUG=612500 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2349713003 Cr-Commit-Position: refs/heads/master@{#419329}
-
yusufo authored
Adds no-op APIs to cache navigation info for custom tabs like url, title and content screenshot and send them via a callback to the client app. BUG=647342 Review-Url: https://codereview.chromium.org/2348573002 Cr-Commit-Position: refs/heads/master@{#419328}
-
slan authored
Currently, HTTP/1.0 requests are causing http_server.cc to crash. Code shouldn't crash when it is supplied with bad data. Simply move into an error state and close the connection instead. BUG= Review-Url: https://codereview.chromium.org/2314073003 Cr-Commit-Position: refs/heads/master@{#419327}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/1a9a50a459c9e3c081719d3e835cac213c319136 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/7e16cf303221bbcf81d632924e19ddc888da9c3b owners.py: partial fix for owners-check perf regression (nick@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=642793 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2349733004 Cr-Commit-Position: refs/heads/master@{#419326}
-
dtseng authored
https://docs.google.com/document/d/1IZ7HtM0BZlMgNyYo6AUHGL84k RTnH4qt3fd-hXqfjvs/edit# Review-Url: https://codereview.chromium.org/2339093003 Cr-Commit-Position: refs/heads/master@{#419325}
-
sczs authored
Xcode 8 should be installed upstream already, so in order to land changes than use iOS10 SDK we need to update the bots. BUG=none Review-Url: https://codereview.chromium.org/2347943002 Cr-Commit-Position: refs/heads/master@{#419324}
-
sandersd authored
This size was incorrectly reduced in commit 8cbe5d69. This commit also adds DVLOG()s to most methods. These should have been there from the beginning. BUG=647723 Review-Url: https://codereview.chromium.org/2345633006 Cr-Commit-Position: refs/heads/master@{#419323}
-