- 05 Dec, 2019 40 commits
-
-
Hesen Zhang authored
- This CL creates utils for update notification service. - Implemented and tested CalculateDeliverTime, which will be used in building notification params. Bug: 1013685 Change-Id: Ibdf465e9b1d0285c02bac8bca5ac602e2b048e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947923Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721815}
-
Alexey Baskakov authored
The code in web_apps.cc|h is inspired by the ExtensionApps class implementation. WebApps publisher doesn't support AppInstanceRegistry for now. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Next thing missing: Implement WebAppContextMenu for AppServiceAppItem. Bug: 1029221 Change-Id: I5bf2523d62b8ad990b8f7ca9017a1347903abd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941534Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#721814}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/bluetooth as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - BluetoothRemoteGATTDescriptor::Create Bug: 939691 Change-Id: I439ce17703a6a0a37ac1d690dd26c14f1cf467ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950044Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#721813}
-
Andrey Kosyakov authored
Change-Id: I0f8cd7d661ae8ca928dac8ff003760a501075d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951088Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#721812}
-
David Black authored
This CL adds UMA histograms for proactive suggestions views that are shown inline in Assistant UI. Proactive suggestions views are rendered from HTML, so we use deep links to bridge the web impression event over to the native side for UMA logging. The new histograms are: - Assistant.ProactiveSuggestions.ViewImpression - Assistant.ProactiveSuggestions.ViewImpression.ByCategory - Assistant.ProactiveSuggestions.ViewImpression.ByVeId The latter two histograms allow for in depth analysis of impression events while the former histogram is recorded for all impressions. Bug: b:144875278 Change-Id: I42cb9e784e0e495c01672177d66e872f3d66d0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947548Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#721811}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/460dca5483db..69c83f87ced1 Created with: gclient setdep -r src-internal@69c83f87ced1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1027182 Tbr: jbudorick@google.com Change-Id: Icd4cbe7a3f5aeaaba5456d0edd41c55342f45a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721810}
-
Christopher Grant authored
This change should be a no-op in terms of build output, and has been tested by diffing APK/AAB output (other than a correction in Trichrome6432, a currently unused config). The change prepares to support 32-bit only Monochrome and Trichrome configs on 64-bit build configurations. The following is happening here: - Support all four version number variations. - Make any target that builds on both 32 and 64-bit explicit about it's configuration. Eg. "monochrome" on 64-bit implies a 32-bit browser, with a 64-bit Webview companion library. - Refactor logic for readability. Bug: 1027573 Change-Id: Ia37a9011717e7c2269cc9b87e817e1e9fd6ef888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940355Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#721809}
-
Dan Harrington authored
This change: - moves feed library tests into chrome/android/feed/core/javatests - adds required robolectric annotations (sdk=...) - adds test files to junit target - disables a few tests that do not yet pass - renames variables to conform to chromium style Note, https://chromium-review.googlesource.com/c/chromium/src/+/1940719 has this same change without the required variable renaming. Bug: 1024945 Change-Id: I07653ae0eaec053cbbe5823067d57ced8212d109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940725Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#721808}
-
Michael Crouse authored
This change clears all host model features from memory and from the optimization guide store when the browser history is cleared. Bug: 1001194 Change-Id: Ibf158f4128cc18c7279bea08a73fd2ac0f0b9fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951553Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#721807}
-
llin@chromium.org authored
Bug: b/144800297 Test: unittests Change-Id: I41066e4e7aaf69aea8878709bf7576d3eb923004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949732 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721806}
-
Collin Baker authored
Ideally, this IPH will show on the first close to show the user how to reopen it. The promo is incomplete and still needs visual polish. Note that this does not enable the IPH. To test it, set chrome://flags. Bug: 1028388 Change-Id: Ib37ff99ae6f3b3a531f56d9615fb06ae5a174a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949664Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#721805}
-
Ahmed Mehfooz authored
Bug: 1026073 Change-Id: I14ce8ac49020b797a11f9a5dfa51678c802bf293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950891 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721804}
-
Markus Handell authored
This change adds getters for currently stored primary ID, transfer characteristics ID, matrix coefficient ID, and range ID. The change also adds a test case for making sure they don't regress. Bug: 1013590 Change-Id: I6da4d567591649e08a57e9bf8d6ed69f732bd26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950974 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721803}
-
Shuo-Peng Liao authored
VDPipeline senses its VideoDecoder cannot produce compositor renderable output format by asking VD to call its PickDecoderOutputFormat(). When it is called, VDPipeline instantiates an ImageProcessor to see if it can convert any VD's supported output format to a renderable format. VDPipeline defines a PickFormatCB for VD to ask VDPipeline which output format shall be used. The callback is assigned to VDPipeline supported VD via its constructor. Currently V4L2SliceVideoDecoder is modified. For ImageProcessorFactory, it adds a CreateWithInputCandidates() factory method that instantiate an ImageProcessor to see if it can convert any of VD's supported output formats to a valid renderable format. The knowledge of which format is renderable is provided by VDPipeline::PickRenderableFormat(), which is currently implemented by hardcoding known renderable formats. Bug: 1004727 Test: pass vda_tests --use_vd --gtest_filter=-*Reset* on Kukui, remaining failure might cause by crbug.com/1023703 Test: pass VD test on Kevin and Eve, which uses V4L2SVD and VaapiVD Change-Id: I2aaf6a6fad347fe1b43a30e56a8f1a9ced84f1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911068Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721802}
-
Liquan (Max) Gu authored
If PageInfo is instantiated with a webContents that is not from a tab, a crash would happen. This CL is to allow for such a webContents in this case. How would it crash? The webContents not coming from a tab does not have TabSpecificContentSettings attached to it. If PageInfo is initiated with this webContents, PageInfo tries to use TabSpecificContentSettings and causes a null pointer exception. The general idea of this CL is that, for each PageInfo instantiation, create TabSpecificContentSettings for WebContents who does not have it. This CL belongs to a larger change of extending the usage of PageInfo dialog to the webContents of PaymentHandler UI. Bug: 999196 Change-Id: Ifdcf15e61193d93f9a669d93111507b32dc91b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944627 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721801}
-
Ken Rockot authored
There is really no reason to expect the pre-test browser shutdown not to race with storage commits. This changes the pre-test to effectively wait for a commit before exiting (by queueing a usage request and waiting for the reply), ensuring that the database is opened and pending operations are scheduled before the browser terminates and the actual test goes on to verify the persistence of data. Fixed: 1027940 Change-Id: I58eac4ec5fc9d547f8e10f5f2d12cbf41c6d12ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951765 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#721800}
-
Aidan Wolter authored
This allows other programs to utilize the FeatureListCreator without pulling in all of chromecast:browser. Bug: None Test: CQ Change-Id: Ibab85c394f17d21a53ce1b682e85a5620b17c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945086Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#721799}
-
Julian Pastarmov authored
Currently only the Windows implementation is fully viable. Mac and Linux work but will generate a new secret at every invocation. Bug: 996077 Test: unit_tests Change-Id: Idfa789fa68913f373e3bd2ac02d1194ab249df94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939889 Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721798}
-
Chase Phillips authored
This CL renames ScopeMatches() to IsUrlWithinScope and makes it more general so a later change can use it for scope validity checks. Bug: 999001 Change-Id: I69c504753cb6be09aa2ed6f359372b27198083e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935043 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#721797}
-
Jonah Chin authored
This is a prerequisite for out of process rasterization of canvas. Patch 1: Remove disabling deferral in Canvas2DLayerBridge::WritePixels The idea here is to flush the recording (to execute all queued commands) then call SkCanvas::WritePixels. This is already its behaviour. First patch is essentially a revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1754228 Patch 2: Remove kCanvasAlwaysDeferral flag and any usages of is_deferral_enabled_. Removing the flags since deferral is now always enabled. Patch 3/4: Remove test suite that turns off CanvasAlwaysDeferral Removed all references to disable-deferred-rendering virtual test suite. Also removed any test disablements for this suite. Should likely merge the bugs for those disabled tests into crbug.com/1023273 Bug: 1023273 Change-Id: Ifb16f20e63c058990a91e4975fdf86a4dfc79ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915284 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721796}
-
nancy authored
BUG=1011235 Change-Id: I8de563d0dccff8db1b1a6229c2bdd68c8bb77e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939991 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721795}
-
Yuki Shiino authored
Re-implements SymbolScopeNode._insert_symbol_definition to cover more general combinations of SequenceNode and SymbolScopeNode. Bug: 839389 Change-Id: I3a9163e2a47795e5e5035edf7021ef1d1d715432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948685Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#721794}
-
Toni Barzic authored
DragWindowFromShelfController now notifies home screen controller that the home is about to show when the app window animation to shelf starts. The goal is to start shelf and hotseat transition to home screen state sooner, as the window scale animation starts, instead of when the window animation completes. Additionally, updates ShelfLayoutManager::CalculateHotseatState to return accurate state for home screen and overview when handling shewlf drag completion. BUG=1026902 Change-Id: Ie6a8ae797bdafd3cdcb6f3296a1dae1a08f803d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951565 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#721793}
-
Julie Jeongeun Kim authored
This CL cleans up URLLoaderPtr, one of old Mojo types, from URLLoaderTest with replacing it with PendingRemote<URLLoader>. Bug: 955171 Change-Id: Ib875590e46a7c5ec1f186c53cf3914016fd51b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949806Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#721792}
-
Julie Jeongeun Kim authored
This CL updates struct members from mojom files with pending_remote. These members have been converted to new Mojo types already from C++ code. The reason that it worked with old Mojo types from mojom files is that new Mojo types support compatibility. So, this CL updates mojom files to generate new Mojo types. Bug: 955171 Change-Id: Ic2bf1aeec232cf376862b97cbcdf06500f2ed0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950049Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#721791}
-
Xiaohan Wang authored
Move it out of RendererFactorySelector and rename it to RendererFactoryType which is shorter. Also does some misc cleanup: - Make it an enum class - Use kCamelCase style - Use kMaxValue which is recommended - Use std::map for |factories_| Bug: 1018372 Change-Id: I87c4b2a56eae1b00c885aa43379f96896736d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951418 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#721790}
-
chrome://media-appTrent Apted authored
The file handler spec changed in r720766. Update the chrome://media-app manifest.json to the new spec and add a regression test. Bug: 1023742 Change-Id: I54cce5105c5193ea4e847e7ebab5a8f590f16201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949829 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#721789}
-
Kai Ninomiya authored
Bug: chromium:985142 Change-Id: Ifa9b692c47def3cbe1f3b030467a0bb122a2cfd9 TBR: cwallez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951895Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#721788}
-
Roberto Carrillo authored
This should avoid the issue where code coverage instrumentation gets confused about which of the two copies of the compiled code (dav1d_8bit vs dav1d_10bit) is executed, and results in counter overflows. R=mmoroz,dalecurtis@chromium.org,sajjadm,liaoyuke Bug: 1030350 Change-Id: I8b1c93e27017622022e0562957f1f72cf85eecdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951976 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721787}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/391d4f3130da..270946946c93 git log 391d4f3130da..270946946c93 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 thestig@chromium.org Fix wrong integer type CPDF_SecurityHandler::GetUserPassword(). Created with: gclient setdep -r src/third_party/pdfium@270946946c93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030583 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I089bf4bf8a06008f4f0d5e1c1f32b17d0ae49cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721786}
-
Yngve N. Pettersen authored
This allows embedders to customize this kind of startup operations without editing chromium Change-Id: Ic020b13a87b4e59d7156385da37555683d2418a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944392 Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#721785}
-
Natalie Chouinard authored
Remove feature-specific autofill code from PreferencesLauncher to AutofillProfileBridge. This is a prerequisite to modularizing PreferencesLauncher as described in go/clank-preferences-refactor. Bug: 1029194 Change-Id: I50bb9579d3733084b0de83045c0df8a7092ae514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941275Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#721784}
-
Taylor Bergquist authored
This animation is not to spec - this is partial progress towards that animation which I'm landing because it's convenient to do so. Bug: 1024009 Change-Id: I96e0233c1b755dc8f8b9cb33aac59e8bcf16efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949678 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721783}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c4a669a1bfc2..989b6154e4ff git log c4a669a1bfc2..989b6154e4ff --date=short --first-parent --format='%ad %ae %s' 2019-12-04 ajwong@chromium.org Reduce LogcatMonitor timeout to 10ms. Created with: gclient setdep -r src/third_party/catapult@989b6154e4ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1021686 Tbr: sadrul@google.com Change-Id: Ic4aa069bd8dc6c224315aa76dc79b4c356ab0b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951409Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721782}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f3456e3314b..e3c25715ec2b git log 5f3456e3314b..e3c25715ec2b --date=short --first-parent --format='%ad %ae %s' 2019-12-04 jmadill@chromium.org gn: Minor improvements. 2019-12-04 syoussefi@chromium.org Vulkan: Optimize unused uniform cleanup in glslang wrapper 2019-12-04 syoussefi@chromium.org Re-enable atomic counter tests on !windows 2019-12-04 jmadill@chromium.org Vulkan: Fold read access into write flags on buffer writes 2019-12-04 shrekshao@google.com Turn on fboRenderMipmap for D3D11 2019-12-04 courtneygo@google.com Split out core.compute_shader expectations 2019-12-04 courtneygo@google.com Add Compute Shared Memory Size Validation Created with: gclient setdep -r src/third_party/angle@e3c25715ec2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1023747,chromium:4173 Tbr: geofflang@google.com Change-Id: I7473328956aa65bbc3a71c145c9428686f2e34f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721781}
-
Daniel Murphy authored
During a refactor, the filename used for memory dumps was dropped. This fixes that. R=rockot@chromium.org Bug: 1028623 Change-Id: I439eff20e0ddd19329a100a84be33dcd5f482073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951779 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#721780}
-
Eric Willigers authored
The Mac icons for minimal-ui are not implemented yet. Desktop minimal-ui will initially ship on Chrome OS, Windows and Linux. Bug: 1028393 Change-Id: If3fc14a7829ce3a9fe866eceb92b09ce6b2b8a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952043 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#721779}
-
Takumi Fujimoto authored
Disable tests that were determined by Findit to be flaky. TBR=bsazonov,szermatt Bug: 1030217, 1030559, 1030561, 1030683, 1030903, 1030562, 1030558, 1030218 Change-Id: If58bf930e3963dadac6682cab38674f30fee1efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951894Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721778}
-
Varun Khaneja authored
I haven't removed the pref entirely since that can be used as-is later. Fixed: 1030815 Change-Id: Ie93427232fbb5f3a8086b0faa66f7a14dedb3a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951658Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721777}
-
Albert Chaulk authored
Resources still get produced frequently, but because no TextureDrawQuads are produced the associated mailboxes don't get cleaned up Fix this by also including the resource, so that the compositor will trigger the usual cleanup path Bug: b/145355036 Test: manual test on device Change-Id: Ia364aef10fba5b5af67eb440b30a30bdb6a12361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949345 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#721776}
-