GitLab

The current All Sites page forces users to go into site
details to clear data for any site with only 1 origin
listed in the siteGroup. This change saves the user from
having to do so, and lets them clear data and reset
permissions directly from the all sites page.

Bug: 997258
Change-Id: I186439d73330f8489149f849e68dfc98db2b26c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884579
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720744}

Pulls latest stable of wayland-protocol to get a few minor spec fixes
to xdg-shell stable before we implement support for it.

Also pulls in latest stable of wayland core, as the in-tree version at
the time of commit is 3.5 years old, with upstream containing many
fixes since then.

Bug: 997631
Change-Id: I135ef605635b9f50576d078cd024aa7901805126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937075
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720743}

Verified different states of tests from top 275 autofill list.
This meant adding a 25 that had been failing previously and doing
an audit of failure reasons.

Also, sorted them in the json file as the states should be steady now.

Includes update to cipd version for autofill wpr/test files.

Bug: 984664
Change-Id: I0b506140dd62679e5fef5928cff160ac0694476f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937508Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#720742}

Much more Cr50 versions were released since last update, this patch
brings the enum list up to date.

The same python script (now attached to the bug) was used to generate
version strings for all images.

BUG=chromium:728134
TEST=None

Change-Id: I4c276cd61ce0c2e021d9d2d884fb878d29c9c27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946453
Auto-Submit: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720741}

suppress.py outputs XML tags in sorted order, which makes seeing the
changes difficult when suppressions.xml is not sorted. I've re-ordered
tags in this file so that running suppress.py results in no diff beyond
missing comments.

Added a note at the top to suggest inserting tags in sorted order.

There should be no material changes to suppressions.xml in this CL.

Change-Id: I43b8ad4928bc6262e486bcba71aa2c0bb282c1f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947227Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720740}

Wire up QRCode sharing feature to the sharing hub.

Bug: 1009124
Change-Id: Ie3aa5723f90ec7ea54989e7ebe85dff1fc3dd42e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888736
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720739}

Instead of the averages the CI_095 was being used for comparison.
This bug was introduced at:
https://chromium-review.googlesource.com/c/chromium/src/+/1856824

Bug: chromium:1029946
Change-Id: If8486e10c12fe620a3b7256d14d8590cfbc2ab0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947047Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720738}

This metric was set to expire in M77, but is used in conjunction with
the others that do not expire to understand the browser landscape and
Chrome's default usage on the device.  Removing M77 because this is an
ongoing thing we'd like to track.

Change-Id: I263a73f145fb6bd44e496bb2afbb42295eb808f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625270
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720737}

Bug: 854362
Change-Id: I3efd2b9294204005ff02d55eccfae91507b44550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928237
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720736}

Bug: 1007645
Change-Id: Iae95405396c6bc7b1eef1cf91113bcb16c53e134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942748Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720735}

https://chromium.googlesource.com/openscreen/+log/fddca10f23f5..1ab48f99911c

$ git log fddca10f2..1ab48f999 --date=short --no-merges --format='%ad %ae %s'
2019-11-29 jophba Fix for Chrome-only fuzzer code compile bug
2019-11-27 rwkeane mDNS: Publisher Skeleton
2019-11-22 miu Minify platform/api/time.h by splitting-out traits definitions.
2019-11-27 rwkeane mDNS: Responder + Publisher API
2019-11-27 mfoltz [OSP] Remove name aliases.
2019-11-26 miu Move SerialDeletePtr to util, clean-up ScopedWakeLock platform/api.
2019-11-26 mfoltz [Open Screen] MdnsQuerier shared and unique record support.
2019-11-26 mfoltz [Open Screen] Add missing alias.

Created with:
  roll-dep src/third_party/openscreen/src

Change-Id: I9b4190d335a862738d43ce8118583fc27695d62f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946692
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720734}

This was an existing TODO from a previous round of review.

BUG=974391

Change-Id: If2776d1146e757795ceb1abcae949886094fc97a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937581
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720733}

With https://crrev/c/1925239, PrintingControllerImpl.getInstance() will
always give an non-null instance, we don't need to check if it is null
or not anymore.

Chrome for Android doesn't support less than KitKat, so we could remove
few checks and annotations now.

Bug: None
Test: Current tests should pass, manually tested window.print() and share
Test: menu code paths.
Change-Id: Ia0a9e41c0eef6d693b39547646e462bb4af4292c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928629Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720732}

Move below unit tests to AppService folder, because they use
AppServiceAppModelBuilder for test:
CrostiniAppModelBuilderTest
ExtensionAppModelBuilderTest
InternalAppModelBuilderTest

BUG=1016159

Change-Id: I2aef91d4bb3b847a8861dca6b692bd0d92f0c4de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942897Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720731}

Bug: 1010213
Change-Id: I53f0d6a2bb4939fc229dbe6a730fa185a1c2da9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940278Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Anqing Zhao <anqing@google.com>
Cr-Commit-Position: refs/heads/master@{#720730}

Check if ContentCaptureReceiver is valid before start capture.
Also, add a DCHECK() to the other call site of
ContentCaptureReceiverForFrame().

Bug: 1029678
Change-Id: Iaed486b6a7e9b322174e06fc0469defd5babb2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947284Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720729}

This CL provides an API to the embedder for receiving crash notifications,
and triggering upload or deletion of crashes.

It is designed so that the notification can be used to trigger an upload
job to execute later (potentially in a different process) without fully
initializing weblayer.

A number of things in the minidump_uploader (chiefly MDUploadCallable ->
MinidumpUploader) have been forked. The intention is to unfork immediately
after this patch. Doing so will address existing TODOs in the component,
and address some existing separation of concerns issues.

Bug: 1027076
Test: run_weblayer_support_instrumentation_test_apk -f '*CrashReporterTest#*'
Change-Id: I86b9b37830014c468fd69cf99a67f6f00809f9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940271
Auto-Submit: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720728}

This makes the usage a little more clear, especially in a future world where
(hopefully) no one is running the `cros chrome-sdk` scripts directly, subsequently
making the phrase "cros_chrome_sdk" meaningless.

As we replace/deprecate Simple Chrome, this arg will start showing up in many
build files, so it's important that its purpose is clear in its name.
eg: http://crrev.com/c/1922977/9/ui/events/ozone/BUILD.gn

Bug: 937821
Change-Id: I967aa9498ed04e351b9423bc75939632ad01fd7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925330
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720727}

Make sure to add a renderer-side safebrowsing throttle in order
to check renderer initiated url loads using the safebrowsing API.
This also ensures that resource requests for e.g. .js and .svg
files are also checked. This approach matches the behavior in
WebView and Chrome. Due to the addition of methods the original
safebrowsing initialization sequence is slightly changed (see
below for details). Additionally the ResourceContext destruction
has to happen on the IO thread (see below for details).

In particular in this patch:
- Add and implement ExposeInterfacesToRenderer method to make
  sure renderer can execute safebrowsing calls.
- Move safebrowsing_service initialization to the
  ExposeInterfacesToRenderer() method because it is executed
  before CreateURLLoaderThrottles.
- Implement UrlLoaderThrottleProvider in weblayer/renderer/
  which amongst other things adds the
  safe_browsing::RendererURLLoaderThrottle.
- Implement RenderThreadStarted() and
  CreateURLLoaderThrottleProvider() methods for
  ContentRendererClient.
- Update build and deps files accordingly.
- Also make sure to destroy ResourceContext on the IO thread
  (otherwise profile destruction sequence can result in a
  DCHECK, see crbug.com/1029317).

BUG=1015418,1028659,1029317

Change-Id: I67482a450d1974a8b14cb07f4fbedd14e4983e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937173
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720726}

Bug: 875700
Change-Id: I81cd3b54b1119e9475ee4653efcd4817d4ea4a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943786Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720725}

-VP9.2/3 decoder check has been moved into
 ContentRendererClient::IsSupportedVideoType ->IsDefaultSupportedVideoType
 -> IsVp9ProfileSupported

Bug: internal b/144324034

Test: Cast from Google Play Movie to Android TV and check the result of
VP9.2 query.

Change-Id: Idbfacd1feddcc6d65083c7c3d06778f8bbd0c569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927411Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720724}

This is a mostly mechanical refactor done with Android Studio, with a
few additional manual renames of symbols and comments.

TBR=twellington@chromium.org

Bug: 1029146
Change-Id: Ia57c2d2083a690cbc3dcc57e1901fe28fd4f4621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946790Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720723}

Implement SharedImageBackingD3D::ProduceSkia and supporting methods.

Bug: 1021118,1002316
Change-Id: Ia699bddfa08469b9e151018eca6c5206620cb731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938707
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720722}

Bug: 1018201
Change-Id: I7848d39c74e17a8c397847c0aa96e8612bc14669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933588
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720721}

This is just some followup cleanup from:
https://chromium-review.googlesource.com/c/chromium/src/+/1902474

Bug: 1022214
Change-Id: I2f7c53cfc74a1a482a931143c06d8457d98d16fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910810
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720720}

The fact that it isn't running appears to have been an oversight.

Bug: 1029936
Change-Id: I4c70311bca05f2088fd0e99112512a015524bd95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946875
Commit-Queue: Erik Chen <erikchen@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720719}

This reverts commit 6a52c6f8.

Reason for revert:

Findit has probably misidentified this CL as the culprit in those changes. If the error had
something to do with locales or binary size that would make sense, but this CL does not
touch the files involved.

It looks like this CL (https://crrev.com/c/1945994) has reverted a change that actually
affects the relevant file:

   /build/scripts/slave/recipe_modules/chromium/resources/ninja_wrapper.py

Original change's description:
> Revert "refactor android locales in locales.gni"

> This reverts commit 15204aaf.

> Reason for revert:

> Findit (https://goo.gl/kROfz5) identified CL at revision 720636 as the
> culprit for failures in the build cycles as shown on:
> https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE1MjA0YWFmMDdlYWZmNTkzZDdhM2Q2ZDdlYjdhNjljOGI5MGE1NWEM
>
> Sample Failed Build: https://ci.chromium.org/b/8895149418482727520
>
> Sample Failed Step: compile
>
> Original change's description:
> > refactor android locales in locales.gni
> >
> > This CL refactors build/config/locales.gni but makes no actual
> > changes to what locales are used.
> >
> > The primary change is to remove android_chrome_omitted_locales
> > and replace it with android_non_bundle_locales.
> > This list should be used directly instead of subtracting omitted
> > locales from locales.
> >
> > Additionally the list all_chrome_locales was added as the superset
> > of all supported locales.  Platform specific lists are made by
> > subtracting from this list.
> >
> > No changes were made to the iOS and Mac locale lists names.
> >
> > Bug: 812837
> > Change-Id: I26e9c1b2d40397a6ed02777db55c44be93060050
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939962
> > Commit-Queue: Trevor  Perrier <perrier@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Ted Choc <tedchoc@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#720636}
>
>
> Change-Id: I91d7824e9e0b292c3376556947cbe4aced6bd0be
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 812837
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947226
> Cr-Commit-Position: refs/heads/master@{#720650}

Change-Id: I29644d0edd27a9d8bc5f6c29d8bc86fe9b47322d
Bug: 812837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945998
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720718}

Extend --enable-text-fragment-anchor flag expiry to M83.

Bug: 919204
Change-Id: I0605d90747b9f891826ec1b8c7f5614990aa4454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946454
Commit-Queue: Nick Burris <nburris@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720717}

Transitive JUnit deps are now supported.

BUG=966644,951455

Change-Id: I274a55af55015b9287336164ae7caf9d12ebcdba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945359Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720716}

conformance/extensions/oes-texture-float-with-video.html
conformance/extensions/oes-texture-half-float-with-video.html
conformance/textures/misc/texture-upload-size.html
conformance2/textures/misc/tex-image-with-bad-args-from-dom-elements.html

Restrict the existing Win Intel Flaky suppression of
conformance/extensions/oes-texture-float-with-video.html
to D3D11, looking at crbug.com/825338, this is where it was reported.

TBR=bsheedy

Bug: 1026468
Change-Id: I37318e826f109d3a148b1e4f64262491aac324f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946878Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720715}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=japhet@chromium.org

Bug: 891670
Change-Id: I20f6d248ef6e288252dad8462e0712a0b4974bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945811
Auto-Submit: Carlos Caballero <carlscab@google.com>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720714}

Regression introduced in https://chromium.googlesource.com/chromium/src/+/7752898dcc9445b41397a9a75bd7e5cb4f1c10bb

R=rch@chromium.org

Bug: 1026194
Change-Id: I5b1c3b193d2d4dcb0aa17af4d8b7a3eca82c33a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932419Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720713}

This reverts commit f8263a71.

Reason for revert: tree closure due to "undefined symbol: MediaAppUiBrowserTest::AppJsTestLibrary"
from https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Builder/16846

Original change's description:
> Hook up chrome://media-app as a file handler for image/*
> 
> Adds a consumer for window.launchQueue in chrome://media-app that
> opens the file and sends it to the existing loadBlob(), which sends
> the blob to the unprivileged guest app to load.
> 
> Adds an integration test that ensures launch params passed via the
> AppService OpenApplication() will correctly open an image in the media
> app.
> 
> SystemWebAppManagerBrowserTest is refactored away from extensions slightly.
> Rather than use extensions::browsertest_util::LaunchAppBrowser(), it uses
> LaunchService::OpenApplication(AppLaunchParams) directly. Mostly this just
> avoids having to fetch the Extension* only to use extension->id() to get the
> app_id back again.
> 
> Bug: 996088, 1023742
> Change-Id: I85624e93618d82ccce1c80d04d21d81303579a99
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913282
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720681}

TBR=xiyuan@chromium.org,tapted@chromium.org,ortuno@chromium.org

Change-Id: I06542d5e52317f7ac0bba6685822662366b4b689
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996088, 1023742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947883Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720712}

Do not call -dismissViewControllerAnimated:completion: on
|self.baseViewController|, since the receiver of the method can be
dismissed if there is no presented view controller. On iOS 12
SKStoreProductViewControllerDelegate is responsible for dismissing
SKStoreProductViewController. On iOS 13.0 OS dismisses
SKStoreProductViewController after calling -productViewControllerDidFinish:
On iOS 13.2 OS dismisses SKStoreProductViewController before calling
-productViewControllerDidFinish: Calling
-dismissViewControllerAnimated:completion: on |self.baseViewController| on
iOS 13.2 will dismiss base view controller and break the application UI.
According to SKStoreProductViewController documentation the delegate is
responsible for calling deprecated dismissModalViewControllerAnimated: so
the documentation is clearly outdated and this code should be resilient to
different SKStoreProductViewController behavior without relying on iOS
version check (see crbug.com/1027058).

Bug: 1027058
Change-Id: Ib3918930b9950e79b088f14b3d0424e42d7b5c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928590
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720711}

As noted in the comment next to one of the DCHECKs,
RewriteUrlForNavigation has non-deterministic behavior in practice.

This is particularly relevant to Reader Mode, which includes a random
string into the distiller's URL, causing each call to the URL-
generating method to be different.

Bug: 992073
Change-Id: I78eb582adc48c9fe90a460adeeab9efc66d9fea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873957
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720710}

This analyzer is specific to chromium/src, so
it can be added to the chromium project config,
where it is a little more convenient to edit.

This CL is related to
https://chrome-internal-review.googlesource.com/c/infradata/config/+/2255124,
which removes the definition from

In addition to moving the definition, this also:
 - Changes the input type from FILES to GIT_FILE_DETAILS,
   since I believe the recipe doesn't use the FILES input.
   This means that the analyzer can start earlier.
 - Changes the component to one under Internals>Metrics
   to help the metrics team triage bug reports.
 - Organizes the file into sections, each ordered
   by analyzer name.

Change-Id: I3084e347d7f03dc1b6dbd9386bee82c79bbdf20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947164Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720709}

This CL removes the gap between infobar and bottom sheet to make them work more
nicely. Bottom sheet's top shadow height dimension needs to be bigger.

Bug: 1025098
Change-Id: I0264d19b2ab75efbdee3a4cadc697ea7ebc1a9ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943783Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720708}

Disabling flaky tab drag tests needed to land field trial config change for compositor priority experiments.

Bug: 1027606, 1028386
Change-Id: I23b3794f8baf1e3f2ee12ff6456f570ef0ce3099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931540
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720707}

Bug: 1029152
Test: with Tast
Change-Id: I935c6b4feaa6e80e5c738a838c1329c4deb59036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940309Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720706}

I have made some change to support multi touch point actions, so we can
try to enable this test again to see if it is no longer flaky.

Bug: 1011225
Change-Id: I3b896e6afc842f4bb0e78c2f9f900c4d5e0a8c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946986Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720705}