- 13 Nov, 2019 40 commits
-
-
sczs authored
- If the card will be uploaded the Modal with the ToS needs is shown before. - Creates SaveCardModalDelegate that its used by the Modal to Save the Card. - Adds a currentCardSaved property to the ModalVC in order to disable the SaveButton if the card has been already saved. Bug: 1014652 Change-Id: I3dadaf24b307c8ffe3b68d499e9ef3840c299623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913023 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#715045}
-
Andrew Grieve authored
Moved from manual deps into //third_party/android_deps: * Guava-jre * AutoService * ErrorProne It looks like this CL adds other libraries, but they are just those that already existed within errorprone-ant.jar. This updates how ErrorProne is invoked to the JDK9+ method of being a proper javac plugin. This move necessitated moving the above libraries into android_deps, because the version of Guava that was already in android_deps was conflicting with our non-android_deps one. Change-Id: Iaa0f927263baaec8180808769f97db9c5393ad18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885951 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#715044}
-
Patrick Noland authored
Bug: 1023533 Change-Id: I3c2165499bda87ae070982402ec5b5db02d2a776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913077Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#715043}
-
Peng Huang authored
This method is for deserializing paint ops from binary data, and append paint ops to the PaintOpBuffer. It can be used for reusing PaintOpBuffer to avoid re-allocating PaintOpBuffers. It will be useful for multithread chrome GPU experimental. It needs to deserialize paint ops from command buffer, and store it in shared image. This change allows reusing existing PaintOpBuffer. Bug: None Change-Id: I2f86b6c62f454495e591bbd841b8aa7156780e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906938Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715042}
-
Alex Keng authored
This change addresses two rendering issues: 1) The rounded corner changes dynamically when the value is close to 0. The fix is to re-implement the value track using a rectangle plus clipping (same approach as <progress>). 2) The thumb doesn't completely cover the track when the value is 0 or maximum. The fix is to shrink the background track by 1px on both ends Note the thumbs is also changed to solid color per design and kProgressValue/kSlider/kDisabledSlider/kHoveredSlider are introduced for different color designs between upstream and downstream. Test: range-appearance-basic.html (3 new test cases for extreme values) Bug: 1021232 Change-Id: Id9a5df157e42335f7afafa75376a461b85abc7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911663 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#715041}
-
Elly Fong-Jones authored
This change introduces DialogDelegate::set_buttons as a replacement for overriding DialogDelegate::GetDialogButtons(), and changes all the trivial overrides to use the new setter instead. Future CLs will remove all the other overrides and eventually remove the original method. Bug: 1011446 Change-Id: I0735a217f581edfb25ddc4a118ebffe5d24e900e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912801Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715040}
-
Anqing Zhao authored
Previously, ReportUploader is designed for reporting ChromeDesktopReportRequest on Windows, Mac and Linux. To supporting Chrome OS, now we change this class a little bit to reuse its logic. Bug: 1010213 Change-Id: I724d203534ec1a831700842181aec4f1121b6d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908542Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#715039}
-
Xianzhu Wang authored
This will make the paint chunk id more meaningful and stable. Change-Id: I5aaacc183c2c359fcfe8b44e3ac17c1a00f9d4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912637 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715038}
-
Ken MacKay authored
Use mixer service for everything. Optionally move the mixer to a separate process. Bug: internal b/138938216 Change-Id: Ica1bd713babeda31ba267b657fc86ffc720ea651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895702Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#715037}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I04573cf4f3a953a604225c715a1da356befd9887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715036}
-
Simon Que authored
CI builders: - fuchsia-x64-dbg - linux-archive-dbg - linux-archive-rel - linux-bfcache-debug - linux-fieldtrial-rel - linux-oor-cors-rel Try builders: - dawn-linux-x64-deps-rel - fuchsia-angle-rel - fuchsia-compile-x64-dbg - fuchsia-x64-dbg - gpu-fyi-try-linux-intel-rel - linux_android_dbg_ng - linux_angle_deqp_rel_ng - linux_angle_ozone_rel_ng - linux_chromium_compile_dbg_ng - linux_layout_tests_composite_after_paint - linux_layout_tests_layout_ng_disabled - linux_optional_gpu_tests_rel - linux-angle-rel - linux-blink-rel - linux-libfuzzer-asan-rel Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I17a32e57cd786d205f0f84bf36bd31974d723742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875858 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#715035}
-
Peng Huang authored
This reverts commit fdda085d. Reason for revert: Reland with fixing. Original change's description: > Revert "Add vulkan information in about::gpu page" > > This reverts commit 2ef6fce8. > > Reason for revert: This CL broke GPU FYI Win x64 DX12 Vulkan Builder (dbg) > > https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20DX12%20Vulkan%20Builder%20%28dbg%29 > > lld-link: error: obj/gpu/vulkan/vulkan/vulkan_instance.obj: locally defined symbol imported: public: __cdecl gpu::VulkanInfo::VulkanInfo(void) (defined in obj/gpu/config/vulkan_info/vulkan_info.obj) [LNK4217] > > > Original change's description: > > Add vulkan information in about::gpu page > > > > This CL adds VulkanInfo in GPUInfo, and then send it to browser > > process with GPUInfo. And it will be serialized to binary data and pass > > to about:gpu page for displaying. > > > > This CL adds a vulkan_types.mojom generated from vulkan header file. > > The structs in that files have many fields. It increases binary size. > > The increasing is expected. > > > > Bug: 887018 > > Change-Id: I2725326091ef47c3034939b3970d0e5bbaf6dc3f > > Binary-Size: Size increase is unavoidable (see above) > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868832 > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Reviewed-by: Jonathan Backer <backer@chromium.org> > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#714424} > > TBR=penghuang@chromium.org,backer@chromium.org,zmo@chromium.org,kbr@chromium.org,tsepez@chromium.org,alexmos@chromium.org > > Change-Id: I3b0aff2cfcfa8b65df2ca9109325451567cf8039 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 887018 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913565 > Reviewed-by: Chris Blume <cblume@chromium.org> > Commit-Queue: Chris Blume <cblume@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714714} TBR=penghuang@chromium.org,backer@chromium.org,zmo@chromium.org,kbr@chromium.org,tsepez@chromium.org,alexmos@chromium.org,cblume@chromium.org Change-Id: I2061c0a8508be602777467b7ae16cb51827bf5f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914294Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715034}
-
Daniel Murphy authored
This change moves the TransactionalLevelDB system into the Storage Service directory. Bug: 1015212 Change-Id: I4851810fc3d5bf031a97eacd935ad6394a9a49b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900154 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#715033}
-
Peter Kasting authored
Bug: 1003612 Change-Id: Idae4e5c015df0d9ee09129f26c8679892e42955e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913603 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715032}
-
Jesse McKenna authored
This change adds a new file "Last Path" to the user-data directory containing the path of the last chrome.exe that ran using it. The implementation mimics the "Last Version" file implementation, so the last-run chrome.exe path is updated each time chrome.exe is launched. This will be used by Progressive Web Apps, whose launcher executables will be located inside the user-data directory, to find the correct chrome.exe to launch. Bug: 960245 Change-Id: I0ec658d414dd1a67f03f7d02e645f21f03191360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891121Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#715031}
-
Michael Montvelishsky authored
Bug: none Test: build & run Change-Id: If79049c13291f1ebfcd627c690dd1e33ee9a94ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903622 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#715030}
-
Hector Carmona authored
Bug: 1015194 Change-Id: I71947da1d8f77365244496754518d1d722c234d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912802 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#715029}
-
Maks Orlovich authored
The way post-doom operations worked --- including completion of an optimistic create --- is by appending a callback to a table in the backend, to be invoked upon the doom's completion. This living in the backend meant that if the backend went away the operation would be quietly cancelled with no callback invocations, which is generally what is desired for backend operations... but in case of optimistic create, we have already returned an entry pointer, and entry operations do not get cancelled (and the entry is also expecting a callback to exit the IO pending state). Therefore, extract the table into a separate object with a refcount which entries can hang on to for a bit after backend destruction. This required making cancellation of ops that needed it be done explicitly. It also turned out this was not actually covered by tests, so a test was added for that as well. Bug: 1015774, 1016140, 1016251 Change-Id: Ib2bf64ead3b581795ba75b4d3c866f6f567a1a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888272 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715028}
-
Megan Jablonski authored
Change-Id: I0ca748b3e9e0db012057f690ae676f6c5f5cfbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913711Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715027}
-
Sergey Poromov authored
Add "UploadZippedSystemLogs" feature to the config. Bug: 940648 Change-Id: I2a1277eb37fbc8d6da20861a1adf1933f0e03d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914365 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#715026}
-
Dana Fried authored
Previous to this, a page would have to be unoccluded and visible in order to create a new renderer, though the presence of a video capturer would prevent the page from being unloaded. This allows hover cards and the new touch tabstrip to cause tabs restored when the browser reloads to render. Previously, some tabs would never render until the user actually selected them. Failure to generate thumbnails after browser restore was one of the biggest complaints about hover cards in the user study that was done earlier this year. Bug: 1020782 Change-Id: I06a23c39ade22e15bef60798faca9fd4cdae53ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908060Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#715025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57d0093ac901..1ba6deba4dfb Created with: gclient setdep -r src-internal@1ba6deba4dfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If0102945a9e35042d54fb0cf059918e5433143b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914602Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715024}
-
Morten Stenshorne authored
Float fragmentation currently doesn't work if the float is "inside" a line. But three existing (but disabled) tests actually had no lines, so they already behaved correctly. The expectation, however, was that we created a dummy line beside the floats (which we did, back in the days), but this is no longer the case, so I just removed that. Bug: 915929 Change-Id: I6b5d04c044860d1225b155fc9c7e70512602b398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913254Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#715023}
-
Matt Menke authored
Wire NetworkIsolationKey through ProxyResolver API and all implementations. Also wire it through the Proxy Resolver Service API. net/ isn't yet passing a NetworkIsolationKey() to the ProxyResolver API, so this shouldn't affect behavior yet. Bug: 1021661 Change-Id: Ia9dab8ac7b5062ea85435022e85d1f1720c7da76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906247 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715022}
-
Hongchan Choi authored
When the tear-down process of BaseAudioContext occurs rapidly along with the destruction of an associated ExecutionContext, a scheduled task from the audio rendering thread can attempt to access `this` pointer of BaseAudioContext. This CL add a check to verify the validity of an ExecutionContext before the function accesses the `this` pointer for the audio graph lock. Test: Ran the repro case locally with this patch for 20 minutes and no UAP occurred. Bug: 1023810 Change-Id: I8e5b960b50aca5b0dcee52b5886804af2515806e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913872Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715021}
-
Chris Lu authored
Adds a new "constants" source_set to avoid any chrome/app dependencies. Bug: 987646 Change-Id: I8fc61687cabc0618e43a7dcc92c30c5cf694e6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906893Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#715020}
-
Alex Clarke authored
This requires the following changes: * It must be possible for the Java App to turn DevTools on. To implement this I opted for an interface similar to AwDevToolsServer. * Telemetry expects the DevTools version query contain a product with a recognizable version number. This requires overriding ContentBrowserClientImpl::GetProduct * Telemetry expects DevTools targets to be discoverable, this requires overriding the DevToolsManagerDelegate. Bug: 1022812 Change-Id: Idae5ac1aa05e700781c96181d3fec0ab3776003c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906151 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715019}
-
Fabrice de Gans-Riberi authored
* Enables reporting of user-mode debugging to debug DevToolsPerContextListeners. * Remove DISALLOW_COPY_AND_ASSIGN in WebEngineDevToolsController implementations. * Add test enabling both user and debug-mode debugging. Bug: 1018371 Change-Id: Ie38c1c9318190e1e9c374f9ccf86a749aa531027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898473 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#715018}
-
Sven Zheng authored
We currently do not have sufficient tools to repro failure on bot without enable the test. Bug: 956016 Change-Id: I89a97d78310fbae96016909196e56cd33ead9230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914295Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715017}
-
Fabrice de Gans-Riberi authored
Bug: 1023510, 1023514, b/143383209 Change-Id: I36be0f276455b8d7441e0cb541a7c3f74cede5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907472Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#715016}
-
Cliff Smolinsky authored
This change makes a few updates to the certificate viewer css: - Adds minheights to the three sections of the details tab - Changes layout to relative - Updates to use flex instead of -webkit-box (per presubmit) Bug: 1023970 Change-Id: Ia782ced8132be1ece4237b86eb5692297f2dd9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913574Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715015}
-
Anastasia Helfinstein authored
I've realized that the ordering of the functions in the node classes, while it makes sense to me, is fairly arbitrary. Reorder the functions to group by type (private/setters and getters/static/etc.) and alphabetize within those groups. This is a pure refactor. It changes no logic nor behavior, it only reorders the functions in the file. Bug: None Change-Id: I38d75a90df01070a817eb8847b7121d220193183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902535 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715014}
-
Koji Ishii authored
This patch adds |NGTextOffset| to represent a range of a text for miscellaneous text-related classes in LayoutNG. Start with |NGInlineCurosr| to avoid multiple calls to get |start| and |end|, each of them to compute the current object, but we can apply this to more classes in following patches. Bug: 982194 Change-Id: I79cd67bf6e9737f5af7e4d928212f6f01326f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911862Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#715013}
-
Jordy Greenblatt authored
This is the implementation of the out-and-back routing DOM focus design for OS Settings [1]. Compare the tip of tree [2] behavior with the post-fix [3] behavior. [1] https://docs.google.com/document/d/1iNewLPex50WuF2ByJa3w250q_WdBbwCfVIo8C5RM6-w/edit?usp=sharing [2] https://drive.google.com/open?id=1aVRaRrwsMGxYiQ3_FXWSyekeMWOVkCo8 [3] https://drive.google.com/open?id=1A5iVSDgTa7ciqy2rK52B0qqEulw-mR18 Bug: 1003992 Change-Id: I1510a6c231270b3509ebd0c45750979781ee4a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900152Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#715012}
-
Tsuyoshi Horo authored
After this CL, navigation to primary URL of web bundle from network works. But navigation inside web bundle and history navigation doesn't work yet. Bug: 1018640 Change-Id: I1c25dfa7ff52de99da07f094cca2fd7d0de1e500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883468 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#715011}
-
Simon Que authored
Bug: None Change-Id: Iaf6e3974a884e61b4edb7a8c0d7c2df06385f284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910981 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#715010}
-
Theresa Wellington authored
Move chrome/android/java/.../appmenu/ (excluding a handful of classes) to its chrome/browser/ui/android/appmenu/ and create a separate build target for the app menu. Also splits appmenu classes and resources between public and internal/ BUG=966644 Change-Id: I9d477981827078f2f0be1dc3929234ef3cdef958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903844 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#715009}
-
Vasilii Sukhanov authored
RemoveAllChildViews() deletes all the child views, thus, turning some members holding dangling pointers. The code should NULL them. Bug: 1023941 Change-Id: I642cff0f1a22e0c894fe4a46421a91182d662c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914364Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#715008}
-
James Cook authored
It runs in the browser_tests suite, so it should be named browsertest. Bug: none Change-Id: I795699ff791031218f4e63b1ab63fa6c13987517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913121 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#715007}
-
Matt Menke authored
Wire NetworkIsolationKey through ProxyResolverV8[Tracing]. ProxyResolver itself still doesn't support NetworkIsolationKeys. Bug: 1021661 Change-Id: Id82eee857606c593f924a6d7ac213898aeb64c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904606 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715006}
-