- 12 Dec, 2017 40 commits
-
-
Christos Froussios authored
This reverts commit 6dd82658. Reason for revert: Suspected of breaking multiple webkit_layout_tests. E.g. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/13134/steps/webkit_layout_tests Original change's description: > Media Controls: Move new controls to SVG icons > > Move the new media controls to SVG icons so they are no longer blurry in > some situations. > > BUG=788305 > > Change-Id: I3f97be618152c2d8cc00653ab8ff63de260c7d13 > Reviewed-on: https://chromium-review.googlesource.com/814296 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523411} TBR=mlamouri@chromium.org,beccahughes@chromium.org Change-Id: If2c4643d5e6455c86fb1afdc5a68f20279eaaeec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788305, 794159 Reviewed-on: https://chromium-review.googlesource.com/822611 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#523422}
-
Dominik Röttsches authored
This reverts commit b071f305 and changes the hb_set page size to 8192. Attempt at keeping performance regressions in check without having to patch back the hb_set implementation to the pre 1.6.1 version. Bug: 782220 Change-Id: I9959d452fc944fd15092490beb45bbfc7f396d97 Tbr: kojii, eae, behdad Reviewed-on: https://chromium-review.googlesource.com/821546Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#523421}
-
Louis Romero authored
Bug: none Change-Id: I743fc93f8da98b734a746e2983a7c1f651458824 R: xam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/789885Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#523420}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14ae91d2..7fcbcafb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If53ece9c4e8514cc8a119e2cccd670e81590d2a2 Reviewed-on: https://chromium-review.googlesource.com/822270Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523419}
-
Peter Conn authored
This reverts commit 532b7d7a. Reason for revert: 794139 Original change's description: > Fix Android WebView crash when an app loads a JavaScript URL during navigation. > > When there's an ongoing navigation, if the app loada a JavaScript URL we create > a temporary NavigationRequest in NavigatorImpl::RequestNavigation. However the > call to RenderFrameHostManager::GetFrameHostForNavigation was resetting the > speculative RFH of the original NavigationRequest since the site instance of a > JavaScript load is always the same as the existing frame. > > Bug: 793432 > Change-Id: I5a25eea9a8733cd5cebe71f700b30ebb4c0b1710 > Reviewed-on: https://chromium-review.googlesource.com/820453 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523264} TBR=nasko@chromium.org,jam@chromium.org Change-Id: I1e08c1de84199879576782a8719e4a771d66248b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 793432 Reviewed-on: https://chromium-review.googlesource.com/822610Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#523418}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ba096c0dc3ba..376fd31ad485 $ git log ba096c0dc..376fd31ad --date=short --no-merges --format='%ad %ae %s' 2017-12-11 mtklein remove vfpv4 requirement for SkJumper on ARMv7 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I1fef7678eb8ca99b9ba2840f53f7e8bc8f93a99f Reviewed-on: https://chromium-review.googlesource.com/822370Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523417}
-
Morten Stenshorne authored
Bug: 788337,776051,792435,792437,636055,792446,794136 Change-Id: I933ece936b79323bfcdf16cc96fd3475f42349f6 Reviewed-on: https://chromium-review.googlesource.com/822254Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#523416}
-
Morten Stenshorne authored
Call NGBreakToken::ShowBreakTokenTree() to dump the break token tree. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I30b8cc33c5444c61d6c58285af1dd379f2f9f89a Reviewed-on: https://chromium-review.googlesource.com/820990Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#523415}
-
Christos Froussios authored
It is flaky TBR=tommi@chromium.org Bug: 794102 No-Try: True Change-Id: I38156a0706eff64c6a60a21ad343fba1ce67949e Reviewed-on: https://chromium-review.googlesource.com/822430Reviewed-by:
-
Lalit Maganti authored
Bug: 728199 Change-Id: I440814aa37c687ab68fea5717cee36a051a4908d Reviewed-on: https://chromium-review.googlesource.com/800553Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#523413}
-
Rune Lillesveen authored
Even if the first background layer has none for image, we may have subsequent layers with images. The previous implementation did an early exit if both images in the first layer were null. Implement VisuallyEqual without using operator== to fix this issue for all layers without missing the optimization that different background positions do not trigger a repaint if the background image for the layer is none. Bug: 793773 Change-Id: I846c75b2c4c273bcebecdf84685d834d946926b1 Reviewed-on: https://chromium-review.googlesource.com/822074 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#523412}
-
Becca Hughes authored
Move the new media controls to SVG icons so they are no longer blurry in some situations. BUG=788305 Change-Id: I3f97be618152c2d8cc00653ab8ff63de260c7d13 Reviewed-on: https://chromium-review.googlesource.com/814296 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#523411}
-
Javier Fernandez authored
Selection with floats has a weird and unpredictable behavior. The root cause is that floats are not considered valid HitTest candidates. There are many other cases where float elements are ignored when traversing the tree looking for the closes element to a specific LayoutPoint. This patch address just one of this cases, where floats are children of a in-flow block-level box. Bug: 758526 Change-Id: I918af3ee21aa1070fa03a9fe1073205cc0a57300 Reviewed-on: https://chromium-review.googlesource.com/643106Reviewed-by:
Philip Rogers (OOO) <pdr@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#523410}
-
Christos Froussios authored
A SequencedTaskRunner will be used to guarantee no race conditions between the two clients of libsecret. Bug: 782851 Change-Id: I6549f867a14378d019404429bab42008fca548a7 Reviewed-on: https://chromium-review.googlesource.com/803954 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523409}
-
Ioana Pandele authored
This button is behind a flag and doesn't currently do anything when tapped on. The rest of the functionality will be added in follow-up CLs. The button should be disabled whenever there are no saved passwords displayed. General design: https://docs.google.com/a/chromium.org/document/d/1miKr2x0PTNIKgt3RQeur51ICQ66uszlYAmFXJONbG_0/edit?usp=sharing Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I95bd4b3ad3b04a52e93488def7744e85d7172ffe Reviewed-on: https://chromium-review.googlesource.com/809424Reviewed-by:
-
Yuki Shiino authored
Converts NotificationPermissionCallback from callback interface to callback function according to Notifications API spec. https://notifications.spec.whatwg.org/#api Bug: 569301, 658073 Change-Id: I113b20009304009a2fe00eb7c4fd9f4a54b4c67f Reviewed-on: https://chromium-review.googlesource.com/821152Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#523407}
-
Yang Guo authored
This is due to an upcoming change to v8::ScriptCompiler::CompileFunctionInContext. Affected tests: fast/events/window-onerror-10.html fast/frames/sandboxed-iframe-forms.html http/tests/devtools/domdebugger/domdebugger-getEventListeners.js security/lazy-event-listener.html virtual/mouseevent_fractional/fast/events/window-onerror-10.html R=marja@chromium.org Bug: v8:7172, chromium:70895 Change-Id: Ie28f4ba706cf9eef0e2b680c2b037081034757fd Reviewed-on: https://chromium-review.googlesource.com/822070Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#523406}
-
Shanmuga Pandi M authored
Bug: 771800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I710238913e0400c1eabb24351116ab445c79739a Reviewed-on: https://chromium-review.googlesource.com/821812Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523405}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/e188f9648ada..a31a5a7b4ab3 $ git log e188f9648..a31a5a7b4 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 perezju [Devil] Provide device_utils.ListProcesses Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id5d04266f5f998a4d81e1d90e8d0043f27ff58dd Reviewed-on: https://chromium-review.googlesource.com/822152 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523404}
-
Morten Stenshorne authored
The spec says the following about an object with column-span:all [1]: "When space is limited, it may be impossible to find room for the spanning element. In these cases, user agents may treat the element as if none had been specified on this property." So... user agents MAY? In other words, it's not a requirement, and therefore we cannot test this. [1] https://www.w3.org/TR/css-multicol-1/#column-span (and then scroll down some) Bug: 788337 Change-Id: I404a763397294c83c6611e3722f809cfa0f5a389 Reviewed-on: https://chromium-review.googlesource.com/822113Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#523403}
-
xzhan96 authored
Corresponds to Clients.claim() method, allows an active service worker to set itself as the controller for all clients within its scope. This CL mojofies the following legacy IPCs: ServiceWorkerHostMsg_ClaimClients ServiceWorkerMsg_DidClaimClients ServiceWorkerMsg_ClaimClientsError BUG=772793 Change-Id: I50b9ee74fc67eb035578a30c78552092d57b2b6c Reviewed-on: https://chromium-review.googlesource.com/816600 Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#523402}
-
Becca Hughes authored
The timeline currently is 2px high. This converts the surrounding margins into padding so the surrounding area will pick up touch events and make it easier to scrub. BUG=784363 Change-Id: I9ff370d5e0724a8e833aebc1fb2cde309dedd316 Reviewed-on: https://chromium-review.googlesource.com/819631 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Christos Froussios authored
This reverts commit 6745e12d. Reason for revert: Test raw-headers-for-protected-document.js is flaky (mostly failing) Original change's description: > DevTools: do not report raw headers and cookies for protected subresources. > > In case subresource request's site needs to have its document protected, don't > send raw headers and cookies into the frame's renderer. > > Bug: 793692 > Change-Id: I9f41adfe35717eec284130f89ac92ecc78089969 > Reviewed-on: https://chromium-review.googlesource.com/821410 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523364} TBR=creis@chromium.org,pfeldman@chromium.org Change-Id: I2f4abad2167c23cf6218fe1806eeadb212ccb430 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 793692,794128 Reviewed-on: https://chromium-review.googlesource.com/822190 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
When a token is requested, HasCacheEntry() is called in StartCacheLookupRequest(). This call can potentially remove the cache entry. Therefore when getting the cache entry right after, it would be not available anymore. HasCacheEntry() method should never exist, since there is no warranty that the same cache entry would be returned by GetCacheEntry() on the next line of code. To solve the problem, StartCacheLookupRequest() is renamed to InformConsumerWithCacheEntry(), and only GetCacheEntry() is used. Bug: 791695 Change-Id: Ie22c520cb0f2e2feec84781908b33ba2d0e791e5 Reviewed-on: https://chromium-review.googlesource.com/817200Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#523399}
-
rhalavati@google.com authored
The default network traffic annotation value is removed from FakeSocket. Bug: 656607 Change-Id: Ie52e1f41de788e0d7119ddc77c6d7641c192b56e Reviewed-on: https://chromium-review.googlesource.com/817441Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#523398}
-
Becca Hughes authored
The "HasUserReceivedUserGestureBeforeNavigation" bit is currently local to Blink and activation delegation will require that we can access this bit across cross origin iframes. This means we need to replicate this across processes. The tests include coverage for feature policy to ensure it works correctly with the delegation. BUG=767389 Change-Id: Ia9c11c62bb9a2e195fbfefc09d53a32de73cddd5 Reviewed-on: https://chromium-review.googlesource.com/788955Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Bug: 785770, 794073 Change-Id: I0e4ee3a24ee3b480fe88022fc489f231ad779990 Reviewed-on: https://chromium-review.googlesource.com/821335Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#523396}
-
Becca Hughes authored
This adds two histograms to MediaEngagementPreloadedList. The first is used when the list is loaded and will allow us to see if the loads are failing and why. The second is used when the list is checked and will allow us to see if the list has not been loaded or is empty, as well as how often the list is matching. BUG=787464 TBR=jwd@chromium.org Change-Id: Ibc24ffcf2c18856297be4cc5017d3b937257967c Reviewed-on: https://chromium-review.googlesource.com/813754 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/40ca2087ef07..ba096c0dc3ba $ git log 40ca2087e..ba096c0dc --date=short --no-merges --format='%ad %ae %s' 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ c7abc0803..629a64498 (1 commit) Created with: roll-dep src/third_party/skia BUG=793115 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ie18d4d01aee31720b5698d251c2f4a26210676b4 Reviewed-on: https://chromium-review.googlesource.com/822034Reviewed-by:
-
Morten Stenshorne authored
The multicol spec [1] changed at some point from saying to clip overflow at the middle of column gaps, to saying that we shouldn't clip at all. A lot of tests got adjusted to match this some time ago [2], but this one was left behind. [1] https://www.w3.org/TR/css-multicol-1/#overflow-inside-multicol-elements [2] https://github.com/w3c/web-platform-tests/commit/b554395c79e502eee8cab95266461e607fa1d8e4 While Blink generally follows an old version of the spec, and therefore clips, it miraculously fails to do so here. So the test passes, now that it has been corrected. Bug: 788337 Change-Id: I1b1e556102461e5442058f54d612fa7f696456c2 Reviewed-on: https://chromium-review.googlesource.com/822094Reviewed-by:
-
Christos Froussios authored
It is flaky TBR=olka@chromium.org Bug: 794080 No-Try: true Change-Id: Ice21dfb49a600f10443f3797b6d9be2086756473 Reviewed-on: https://chromium-review.googlesource.com/821545 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9771aa49..14ae91d2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifb4251fd6ec03b651c91c6816d1bc31104fb284e Reviewed-on: https://chromium-review.googlesource.com/821693Reviewed-by:
-
Yutaka Hirano authored
We have two experiments, and currently enabling both would confuse ResourceLoadScheduler. This CL fixes that. Bug: 785770 Change-Id: Iedcd31b85b83dae8397c992e3c769addd9dba956 Reviewed-on: https://chromium-review.googlesource.com/816775 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523390}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c7abc08034a3..629a64498dde $ git log c7abc0803..629a64498 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 oetuaho Fix HLSL integer pow workaround Created with: roll-dep src/third_party/angle BUG=793115 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I838b7ab46d5c9f4573da56c3232511bb6ea72d23 Reviewed-on: https://chromium-review.googlesource.com/822052Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523389}
-
Mounir Lamouri authored
Setting the internal muted state based on the muted content attribute when the attributes have been parsed instead of waiting for the children to be parsed. This allows edge cases such as checking for `muted` in a <script> inside the element to return the correct value. This is fixing all the HTML tests for the muted attribute that Blink used to fail. Bug: 350303 Change-Id: I51c00abdf40b36d2222ddca2be69d61a0286f657 Reviewed-on: https://chromium-review.googlesource.com/819555 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
Yoichi Osato authored
Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iafc4c16aac974aa50bbd79960179ba17a3dff7cb Reviewed-on: https://chromium-review.googlesource.com/821337Reviewed-by:
-
Koji Ishii authored
This patch implements all the rest of logic to compute visual overflow for NGPhysicalTextFragment. In doing so, this patch also refactors text-emphasis logic to share with the pre-NG code. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib800a9b4264dfe724d59fdb220e7c0d43513685a Reviewed-on: https://chromium-review.googlesource.com/776638Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523386}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-webvtt-tc016-align-positioning.html 2. track-webvtt-tc017-line-position.html 3. track-webvtt-tc018-align-text-line-position.html 4. track-webvtt-tc019-cue-size.html 5. track-webvtt-tc020-cue-size-align.html Bug: 782555 Change-Id: I09431fad43b9dc574f14d7ca8387aa38587c5825 Reviewed-on: https://chromium-review.googlesource.com/821990Reviewed-by:
-
Yuki Awano authored
- Do not reroute events if it is targetted to the tray or its descendants, or if target of the event has window of the tray as a transient ancestor. - When network info bubble is shown, the bubble is active but the tray itself is not active. The bubble is shown as another widget. The bubble should receive key events in this case. If the handler reroutes key events in this case, the tray is closed when esc key is pressed while the bubble is shown. information icon. Press esc key to close the info bubble. Confirm that it only closes the info bubble. Bug: 758530 Test: Open network section of system tray by click. Click the Change-Id: I0df0c81e4df28785f16fdefb9af37a73f00ef604 Reviewed-on: https://chromium-review.googlesource.com/776255Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#523384}
-
Mike West authored
Implements the changes to fragment processing described in https://github.com/whatwg/url/pull/347, which adds a new "fragment percent-encode set" which contains the C0 control percent-encode set, along with: * 0x20 SPACE * 0x22 (") * 0x3C (<) * 0x3E (>) * 0x60 (`) This brings our implementation into line with Firefox. Bug: 758523 Change-Id: I25de642017ccb69473626a327ad194b3431a11ed Reviewed-on: https://chromium-review.googlesource.com/719004 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
