- 16 Jan, 2019 40 commits
-
-
Donn Denman authored
Adds support for persisting and later reporting user interaction to the server in support of the offline sanitized click-log. BACKGROUND: This change allows the server to log outcomes from interactions and associate them with the privacy-safe documents in the Search Index. See go/cs-sanitized for more details on this design. DESIGN OVERVIEW: When the server recognizes a document it generates a random EventID and logs it to sawmill and returns it to the client in the response to the Resolve request. The client passes the EventID up to Java and persists it in local device storage along with the user-interaction outcomes. The next time the user makes a Resolve request the client checks for previous data, and if present it sends it as part of the Context to the server (and erases it from storage). DETAILS: This CL introduces a new interface ContextualSearchInteractionPersister to persist user interactions, and an implementation that uses local storage. The manager detects a new parameter for the EventID returned in the Resolve request. It stores this and an encoded set of bits that describe the user-interaction for that event in local storage. Any subsequent Resolve request checks for a previous EventID and when non-zero sends it along with the user-interaction results in CGI params to the server. Support for these params on the client and server have already landed. If the server never sends an Event ID to log, then the client won't change it's behavior. The server does not yet send these Event IDs. BUG=872902 Change-Id: Ief9a95625b16a4b0a3be5325ed1adadff9c791b9 Reviewed-on: https://chromium-review.googlesource.com/c/1170352 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#622993}
-
Becky Zhou authored
Bug: 921450 Change-Id: Ie95bfa29d5c0ab52288bfd87a3554fc90ed42074 Reviewed-on: https://chromium-review.googlesource.com/c/1409360 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#622992}
-
Adrienne Walker authored
Converted via https://github.com/mangini/gdocs2md, links converted by hand, and diagrams screenshotted from google docs. Change-Id: Ie0e9d158128c6c9b21f405a8a25def44a309c79c Reviewed-on: https://chromium-review.googlesource.com/c/1410174Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#622991}
-
Justin Cohen authored
This will be used to enable breakpad uploads for DCHECKs in canary. Bug: 919094 Change-Id: I8e76db99696e7a948d2d740f0568cba41b1b4dce Reviewed-on: https://chromium-review.googlesource.com/c/1410992 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#622990}
-
Steve Kobes authored
This makes it more obvious that generate_token.py is to be used in conjunction with --origin-trial-public-key. Change-Id: Ia6fc0c17519013804c10461c3d41cc9323bbb16c Reviewed-on: https://chromium-review.googlesource.com/c/1412808Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#622989}
-
Jérôme Lebel authored
Once the AuthenticationFlow is finished, -GoogleServicesSettingsCoordinator.authenticationFlow needs to be set to nil. Change-Id: Ib9878141580dbfd2d7a70a81b0ac87c1255d67b7 Reviewed-on: https://chromium-review.googlesource.com/c/1409447Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#622988}
-
Sammie Quon authored
Test: Added test which failed before this change Bug: 922129 Change-Id: I350ad4f5cc375eb512ffb9c3c040716f2445c41c Reviewed-on: https://chromium-review.googlesource.com/c/1412936Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#622987}
-
Akihiro Ota authored
This test asserts that articles within feeds report non-zero PosInSet and SetSize, while those not contained within a feed report PosInSet and SetSize of 0. Change-Id: I52a2c480b08e5e3ac8434f4cb02e64bb44466cad Reviewed-on: https://chromium-review.googlesource.com/c/1385022 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#622986}
-
Kevin Marshall authored
This reverts commit dc1f268d. Reason for revert: Linker error broke win32-rel. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/9704 Original change's description: > Invoke shortcut parser from scanner > > R=csharp > > Bug: 802092 > Change-Id: I635bbb5dfe9ac259038de7c4bdb164d69a7ce59a > Reviewed-on: https://chromium-review.googlesource.com/c/1388936 > Commit-Queue: Joe Mason <joenotcharles@google.com> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622939} TBR=csharp@chromium.org,joenotcharles@google.com Change-Id: I035a8af7a53cd23946fda28460ae367a9e790ef8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 802092 Reviewed-on: https://chromium-review.googlesource.com/c/1413893Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#622985}
-
Peter Kasting authored
The theory is that these are flaky because they're reading/writing app-global properties while other tests may be changing them. By making them interactive, this flakiness ought to go away. Bug: 396344 Change-Id: I1a695ffc9581d2f8193445d95d56d30d83fc0bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1410504Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#622984}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8432ec24a326..e229a0e3c5f8 git log 8432ec24a326..e229a0e3c5f8 --date=short --no-merges --format='%ad %ae %s' 2019-01-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e229a0e3c5f8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7b4a78cc71e9dfc9a00113768bcc4c8590293833 Reviewed-on: https://chromium-review.googlesource.com/c/1412802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622983}
-
David Benjamin authored
LoginHandler has generic code to manage LoginModel observing for the subclass, but only LoginHandlerAndroid uses it. LoginHandlerViews defers to LoginView. Mirror that in ChromeHttpAuthHandler to align the two paths. (LoginHandlerAndroid forwards the signal to ChromeHttpAuthHandler anyway, so the common code isn't really saving much.) The goal here is to simplify interactions between LoginHandler and its subclasses, along the way to cleaning up the ownership. Bug: 908926 Change-Id: If44e76f452966d2767022770ee3ab91d020d5f6c Reviewed-on: https://chromium-review.googlesource.com/c/1388033Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#622982}
-
Owen Min authored
The cloud reporting extension is separated from the on-prem report extension and has a new extension id. Bug: 922140 Change-Id: Ic6d38b8ba29b12f485cac8e9017979b4a4341b45 Reviewed-on: https://chromium-review.googlesource.com/c/1413058 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#622981}
-
Katie D authored
Adds padding below the element so that we ensure a scroll happens even if the window is too small or too large. Bug: 921523 Change-Id: I13d857d3180eebfe28cf6e28ea83b6df72fb5f52 Reviewed-on: https://chromium-review.googlesource.com/c/1410082Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#622980}
-
Mason Freed authored
In non-BGPT mode, we only need to do a kGraphicsLayerUpdateLocal update, and in BGPT mode, we now call SetNeedsCommit() directly from PropertyTreeManager::EnsureCompositorTransformNode, so no graphics layer update is needed at all. Bug: 895109 Change-Id: I970b29bc05a43720cfb9747bfcfa50e42dc8639e Reviewed-on: https://chromium-review.googlesource.com/c/1403639Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#622979}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b45db6642d1..83de8a6f8c0e git log 1b45db6642d1..83de8a6f8c0e --date=short --no-merges --format='%ad %ae %s' 2019-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f3179a6a1763..d3e0e84ce7e1 (1 commits) 2019-01-15 halcanary@google.com Documentation: be explicit about non-shaping Created with: gclient setdep -r src/third_party/skia@83de8a6f8c0e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: If666f5d27207a6929a7ba5639b60484019754b6d Reviewed-on: https://chromium-review.googlesource.com/c/1412295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622978}
-
Sylvain Defresne authored
The class base::NoDestructor is a simpler way to define a static global value (aka a singleton) than base::{LazyInstance,Singleton} and is the recommended pattern to use. The changes were automated using a custom one-shot script, then fine tuned by hand (to remove unnecessary classes, ...). This fixes usages in src/ios/chrome/browser/web_state_list. This CL was uploaded by git cl split. Bug: none Change-Id: I5f3110c566d3d0dfa11ffe801a7622d4d96400a2 Reviewed-on: https://chromium-review.googlesource.com/c/1411695Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#622977}
-
Robert Ogden authored
If the threshold for slow page triggering is max, it is somewhat silly to check if ECT is offline. Change-Id: I5fa65d6a5f4cbe107fb018f34206f843cbe19682 Reviewed-on: https://chromium-review.googlesource.com/c/1410065 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#622976}
-
rbpotter authored
This code is only used for printers with origin DEVICE, which is only valid on Chrome OS. Bug: None Change-Id: I160f74fae988e9e17cc9b3b3235f2717575d1bb9 Reviewed-on: https://chromium-review.googlesource.com/c/1407263Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#622975}
-
Sadrul Habib Chowdhury authored
LocalSurfaceIdProvider is only used when surface-sync is turned off. The only use of DefaultLocalSurfaceIdProvider instances are currently for cases where surface-sync is unconditionally turned on. So DefaultLocalSurfaceIdProvider is never actually used. BUG=none Change-Id: I3ae41482de3def55a3888d5133ccc593e5980d8d Reviewed-on: https://chromium-review.googlesource.com/c/1409734Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#622974}
-
Austin Eng authored
This adds a WebGL test using attribute arrays to better compare performance with the WEBGL_multi_draw extension Bug: 890539 Change-Id: I89641a1e8daf6d05ab274a896aedcc0d205f3b5d Reviewed-on: https://chromium-review.googlesource.com/c/1401051Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#622973}
-
Andres Calderon Jaramillo authored
This CL modifies the SolidColorAnalyzer so that a color is not required to be opaque to be considered solid. The motivation is that in the rendering.desktop:blur_rotating_background story, the two blurring foregrounds were being drawn as texture quads because they are translucent. With this CL, they can be drawn as solid color quads thus avoiding textures. The initial change (patchset #3) was relatively simple: remove the alpha == 255 restriction from the IsSolidColor() function and possibly do a manual SrcOver alpha blend in case, e.g., a translucent drawRect is done on top of another drawRect. The blend code was adapted from ui/gfx/color_utils.cc::AlphaBlend(). Unfortunately, this caused some web_tests failures (see patchset #4). Although the differences are not visible, two of the tests are not shown in Gerrit because they could not be rebaselined since they're reftests: compositing/background-color/background-color-alpha.html and virtual/stable/compositing/background-color/background-color-alpha.html. My exploration suggested rounding problems in the alpha premultiplication prior to setting the solid color uniform in the GL shader, so I changed the PremultipliedColor() function in gl_renderer.cc to use a similar premultiplication logic as SkARGB32_Blitter::SkARGB32_Blitter [1], and now all relevant web_tests pass (see patchset #5). After this, there were some unit test failures in cc and viz. I addressed the cc failures by making FakeRasterSource::CreateFilled() return a non-solid-color raster source to ensure that picture layers using it can have tilings. I addressed the viz failure by rebaselining the failed test as the visual difference is very little (there is a difference but it's hard to appreciate in Gerrit). While fixing these failures, I discovered a bug in my previous solid color code changes where a raster source was incorrectly being detected as solid color in certain cases. I fixed that bug and added test cases. All this was done as of patchset #8. [1] https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkBlitter_ARGB32.cpp?l=676-680&rcl=ccb0a307c136760e0b0c33c4f66c3e58a3f98334 Bug: 917058 Test: foregrounds in the story are now drawn as solid color quads. Change-Id: I6d70ccb7c28b356cfbc81a856a17192b6d743933 Reviewed-on: https://chromium-review.googlesource.com/c/1387385 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#622972}
-
Tibor Goldschwendt authored
TBR=mthiesse@chromium.org Bug: 863064, 884321 Change-Id: I490f9f252c1a378067c72420562a178ae54b6d79 Reviewed-on: https://chromium-review.googlesource.com/c/1409817 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#622971}
-
Kush Sinha authored
Chrome OS Account Manager UI never displays freshly migrated accounts. It checks for |AccountManager::IsTokenAvailable| && |account_info.full_name.empty()| as a heuristic for checking whether an account fetch is pending for a particular account. This does not work anymore after http://crrev.com/c/1404254 because |AccountManager::IsTokenAvailable| now returns |true| for dummy Gaia tokens. |account_info.full_name.empty()| is of course |true| too since the account fetch is guaranteed to fail. Fix this by removing the check. It does not add much value. TBR=droger@chromium.org Bug: 833797 Change-Id: I3ca7953b16aa3af564ee1e1874f78ec281cfbf26 Reviewed-on: https://chromium-review.googlesource.com/c/1406976 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#622970}
-
Ryan Hamilton authored
t=17922 [st= 4] HTTP_STREAM_JOB_CONTROLLER_ALT_SVC_FOUND --> alt_svc = "quic www.google.com:443, expires 2019-02-13 14:31:44" --> is_broken = false Change-Id: Ib312b4ef7f3e0fdd4e0e9e8396ebe37bd5847f13 Reviewed-on: https://chromium-review.googlesource.com/c/1410125 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#622969}
-
Daniel Ng authored
Flags for enabling/disabling crostini apt search (experimental feature) go/chrome-apt-search Bug: 921429 Change-Id: Ie15fb190df45e766c3daa31bdef112e58e0ff71a Reviewed-on: https://chromium-review.googlesource.com/c/1408708Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Josh Pratt <jopra@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#622968}
-
James Darpinian authored
We don't need to know the width of pointers ahead of time to make our stack trace regexes. They can simply accept both pointer widths. This removes the need to specify or detect the architecture in some cases. Change-Id: Ib0222635ac1c6953ed0cb0dbec10ecd8af63317f Reviewed-on: https://chromium-review.googlesource.com/c/1410272Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#622967}
-
David Tseng authored
Bug: b:122847803 Change-Id: I26733d0f99de34bebfb0e80a2e6db5719f677d9a Reviewed-on: https://chromium-review.googlesource.com/c/1412811Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#622966}
-
wutao authored
ksv inits the side tabs twice to reduce latency: first only inits the default category to show users, and then inits all categories in the background. However, in the second init, the view heirarchy changes, which causes OnBlur on the Tab. This patch only updates the tab contents in the second init in order to keep the focus. Bug: 920409 Test: manual. Change-Id: Id8bdba5cd5ca38d6a8f8490029cfda756733c8ec Reviewed-on: https://chromium-review.googlesource.com/c/1406239 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#622965}
-
Marijn Kruisselbrink authored
Last year I rewrote a lot of the blob system while converting from IPC to Mojo, but never updated this readme file. This should at least make it less out of date, even though there are probably still gaps. Bug: 816716 Change-Id: Ibdb30a1b4c464227ed46319585eab20d7a516e7c Reviewed-on: https://chromium-review.googlesource.com/c/1410503 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#622964}
-
Jesse Selover authored
This moves certificate verification to within the handshake, instead of a separate step afterwards, which allows us to verify the certificate before prompting for client certificates. It also means that certificate errors result in incomplete handshakes, so this also changes SSLClientSocket unit tests not to expect connected sockets after certificate errors. Bug: 347402 Change-Id: I0a93da1dee5be697fa7d5c74aae206d370f97d5b Reviewed-on: https://chromium-review.googlesource.com/c/1259123 Commit-Queue: Jesse Selover <jselover@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#622963}
-
Peter Kasting authored
Bug: 396347, 445155, 911949 TBR: kylixrd Change-Id: I72d14d9cc3a80be89c039c654204fd0b38fb6dbc Reviewed-on: https://chromium-review.googlesource.com/c/1413659Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#622962}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a483fac90dbf..c7f416c0c994 git log a483fac90dbf..c7f416c0c994 --date=short --no-merges --format='%ad %ae %s' 2019-01-15 enga@chromium.org Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Created with: gclient setdep -r src/third_party/dawn@c7f416c0c994 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4cb38f3b38a2e5894207e452535ec62a0ede6fe9 Reviewed-on: https://chromium-review.googlesource.com/c/1412506Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622961}
-
Philip Rogers authored
This patch marks the following test as flaky: virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html Bug: 922249 Change-Id: I3ac94c04a7ee10da9d6543510639f32f5c074c4a Reviewed-on: https://chromium-review.googlesource.com/c/1413399Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622960}
-
Fredrik Söderquist authored
Copying/assigning a Length is not just a trivial copy, so when possible, use a const Length& to avoid making a copy (saving some small bit of footprint and hopefully a few CPU cycles too). Change-Id: Idd1633b4198a8af62c46c27c36751e7961eb356f Reviewed-on: https://chromium-review.googlesource.com/c/1411693Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#622959}
-
Eric Orth authored
Follows the same pattern as the recent addition of TXT and PTR support. Like PTR support, filters root domain from results because it is not well-handled by our host resolution stack (eg, we do not allow querying the root domain), and there is no expected Chrome usecase where we would need such results. Bug: 914402 Change-Id: Ie4ff8ffc3d79a81fa5c1e9a3b3868415401b09d2 Reviewed-on: https://chromium-review.googlesource.com/c/1374729Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#622958}
-
Xiaocheng Hu authored
This reverts commit 656da9a4. Reason for revert: The use-of-unitialized-memory issue is fixed. Original change's description: > Revert "[BidiCaretAffinity] Deduplicate NGCaretNavigator left and right handling" > > This reverts commit e7ec3462. > > Reason for revert: Use of uninitialized memory: crbug.com/894651 > > Original change's description: > > [BidiCaretAffinity] Deduplicate NGCaretNavigator left and right handling > > > > Since left and right handling is symmetric, this patch collapses them to > > reduce code duplicacy. It also makes it easier to implement more > > complicated cases in NGCaretNavigator. > > > > Bug: 894651 > > Change-Id: I8cdc94c32bfa3fb6646c40750167e69561548797 > > Reviewed-on: https://chromium-review.googlesource.com/c/1407502 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622687} > > TBR=yosin@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > Change-Id: I9a5c3fb1bd3c95c9411c1a3247f8c4e367461283 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 894651 > Reviewed-on: https://chromium-review.googlesource.com/c/1411917 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622807} TBR=yosin@chromium.org,battre@chromium.org,eae@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org Change-Id: I39066019319bf27f7b4c08125692ad5abb48de1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894651 Reviewed-on: https://chromium-review.googlesource.com/c/1413272Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#622957}
-
David 'Digit' Turner authored
Adjust all callers of the legacy entry points to use base::trace_event::Arguments instead, and remove the code from TraceLog class. R=oysteine@chromium.org,primiano@chromium.org Bug: 898794 Change-Id: Ie47d731f4a4904f2beea83eb52785d9a7ad895be Reviewed-on: https://chromium-review.googlesource.com/c/1409517Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#622956}
-
Lakshmi Kumar Dabbiru authored
It happens in both Name fix flow and CVC fix flow UIs. Screenshots Name fix flow - https://screenshot.googleplex.com/KOKtqaYzPmV.png CVC fix flow - https://screenshot.googleplex.com/VM1o1H5OpXF.png (overlapping buttons and asking UX is happy with the change) Bug: 913646 Change-Id: I575be1678f1ce73bdc06f2d1ad9952c992991bc8 Reviewed-on: https://chromium-review.googlesource.com/c/1405723 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#622955}
-
Finnur Thorarinsson authored
Sync with the design that passed UI review: - Remove the Select All/Undo button from toolbar. - Add sharing disclaimer at top ("what you select will be shared with..."). - Add Select All checkbox as top item in RecyclerView. - Remove Undo State when undoing Select All (undoing now clears all). - Remove blue row selection background highlight. - Show animated checkmark for contacts selected. Bug: 860467 Change-Id: I78764414aac2397728b86ff761f50f9b3d15bc2f Reviewed-on: https://chromium-review.googlesource.com/c/1398283 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#622954}
-