- 29 Sep, 2020 20 commits
-
-
Liquan (Max) Gu authored
Change: * onWebContentsForRequestAvailable() was called two times when bottomSheetController.requestShowContent() failed in PaymentHandlerCoordinator. One is in PaymentHandlerCoordinator; one is in ServiceTabLauncher. Now, onWebContentsForRequestAvailable() guaranteed to be called only once - in ServiceTabLauncher only. Bug: 1132972 Change-Id: Iba288b1287e034a35ff83994f5f675b5df463527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435739Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811465}
-
Collin Baker authored
Bug: 1106523 Change-Id: I36cbf3d0de3c5e4a229874f2d505016772fb6d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432384Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#811464}
-
Nnamdi Theodore Johnson-Kanu authored
- Add close button functionality - Update ESim flow ui to use iron pages screenshot: https://screenshot.googleplex.com/A7ZxANAamWYTxs3.png Bug: 1093185 Change-Id: I755d40eefa068398a6a3c1cab6428f8f5aed7ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424830 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811463}
-
Adam Langley authored
Previous changes have left cut points where the change in QR key structure was split off. This change contains the remainder of those changes. It doesn't quite make CableDiscoveryData V1-only, but it's a lot closer. BUG=1002262 Change-Id: Id57aec7f09d574720ed57a49e1482eb6890e3947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430324 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#811462}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/printing This CL was uploaded by git cl split. R=rbpotter@chromium.org Change-Id: I2e8c8fbca3a293b1ac93a7a82f9a821e05bc9554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435194 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811461}
-
Caitlin Fischer authored
There's a note in media_switches.cc indicating that this feature is okay to be removed. Bug: 1126640 Change-Id: Ie4c87b13fb573327038753ea30a59708df3bc691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427213Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811460}
-
Andrew Shulaev authored
Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: I1910c2ad1c47d00f069d6c70dbc7dc6e1ef2eedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434929 Auto-Submit: Andrew Shulaev <ddrone@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#811459}
-
Andrew Shulaev authored
File removed from allowlist does not seem to have occurrences of neither base::Callback nor base::Bind Bug: 1007635 Change-Id: I89d65021176a4182fa7dccf2eb79e5e3093c0f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435387 Auto-Submit: Andrew Shulaev <ddrone@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/306fc502cf96..62139fcca727 2020-09-28 cwallez@chromium.org Use typed integers for the ExecutionSerial 2020-09-28 cwallez@chromium.org D3D12: Use typed integers for the ExternalMutexSerial 2020-09-28 cwallez@chromium.org D3D12: Use typed integers for the HeapVersionID If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I195d50621bdc7e97f23f45457846b497ea9134cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436929Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811457}
-
Russ Hamilton authored
Bug: 973801 Change-Id: Ia87925e48d9f0953b5f4e3a2d89472129e4ecee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432424Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#811456}
-
Ana SollanoKim authored
In this change the function GridGap() is implemented to get the row or column gap of the grid. If the gap is not defined, then the function returns 0. This result is added to the current_inline_offset and current_block_offset. A unit test was also introduced to validate the result. Bug: 1045599 Change-Id: I7e1c86db5bb266131fa2bdc9720674794ac1edf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430486 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#811455}
-
Jenny Zhang authored
When user invokes feedback from lacros-chrome, we will send the request via crosapi mojo call to ash to show Feedback ui, so that the feedback report will be sent from ash, which includes both ash and lacros user log. The chrome version string in feedback report will contain both ash and lacros versions if Lacros is allowed/supported and launched in the session. Bug:1119925 TEST: 1. Open Lacros browser, send a feedback report by clicking "Report an issue" under Help menu. 2. Verify the report can be found at http://listnr site. The chrome version string should have both lacros and ash version strings, for example, "Lacros 87.0.4266.0 dev, Ash 87.0.4266.0 dev". 3. Verify the report contains both system_logs.zip and histograms.zip. The system log should contain ash log data and lacros user log from /home/chronos/user/lacros/lacros.log under "lacros_user_log" section. Change-Id: Iecc94ef9c50d6993159aebd9d3ac305e3f9a5896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408883Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#811454}
-
Ken Rockot authored
This records the network connection type any time it changes. Also adds an enum histogram value for the new 5G type that was recently added to the ConnectionType enum. Bug: 1127134 Change-Id: I5a7d1306b69c4714a8b24a5462871aa0842121d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431589 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811453}
-
Yoshisato Yanagisawa authored
Bug: crbug.com/1105814 Change-Id: I99da69983014a3c7df8d71c62226d6893d556d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434892Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#811452}
-
Dominic Farolino authored
This CL moves the RouteProvider implementation from ChildThreadImpl, to RenderThreadImpl. This is because RenderThreadImpl is the only type of ChildThread(Impl) that uses this functionality, therefore this CL creates a healthier boundary between render threads and child threads. At the same time, it simplifies a nasty code path present in both RenderFrameImpl/RenderFrameProxy::GetRemoteAssociatedInterfaces() that separates a "production" path vs a "test" path. We do this by introducing the GetRemoteRouteProvider() method on the RenderThread public API, and providing two implementations: - RenderThreadImpl - Responsible for returning a legitimate mojom::RouteProvider* that will be hooked up to a real cross-process implementation - ChildThreadImpl - Responsible for providing a dummy mojom::RouteProvider* bound to nothing, so that the messages sent over it are simply drained This is a reasonable tradeoff over the alternative solution of introducing a MockAgentSchedulingGroup to handle cases where its RenderThread is a MockRenderThread. If things regarding RenderThread should be mocked, then it makes sense for RenderThread implementations to mock them, as opposed to have mocks appear in both MockRenderThread *and* MockAgentSchedulingGroup, which is slightly more awkward and cumbersome. Bug: 1111231, 1132901 Change-Id: I903553a67f14d22d654556c4398d169196763a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433793 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#811451}
-
Xida Chen authored
In this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2293427 When we make the DroppedFrameCounter ignore frames during loading, we change the behavior of the FPS meter too, so that the FPS meter ignores the loading frames. This is undesired, because there is no explanation to the users why these frames are not included. Excluding these frames in the smoothness metrics should be internal implementation details for UMA. This CL makes changes such that the FPS meter still takes the loading frames into account. Bug: 1129049 Change-Id: Ief2b8878c7342c945de74a7af97f41ec5a17b71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418537Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811450}
-
Siyu An authored
AutofillEnableStickyBubbleAndUpdatedLogging. For more details about the feature please refer to go/sticky-payments-bubble-dd. This feature is currently running 50% in Canary/Dev. So added this to fieldtrial_testing_config and get ready for Beta. Also fixed some tests that will be obsolete when this feature is launched. Bug: 1070799 Change-Id: I3061a5de8c94e5a7e453e84615d9807fc0baa6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424078Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#811449}
-
Xida Chen authored
Blink's animation doesn't use Timing::Nullvalue anymore, and this CL removes the IsNUll. Bug: 791086 Change-Id: I488f077b96ec6477176876f224f7f5e5d71c07ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430484 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#811448}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib541131caa821909b891725058ee47e1b67f764f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436352Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811447}
-
Noel Gordon authored
After CL:2432150 piex_loader.js no longer depends on files app types (external types). It only depends on DOM platform types. js_library("piex_loader"): Remove deps=[]. Replace with a note about not adding any more deps so that piex_loader.js can be used standalone. js_library("image_loader_util"): image_loader_util does not depend on piex_loader; remove that dep. Bug: 1132695 Change-Id: I8df346343c86d68d610c72b2f77164153a800074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435031Reviewed-by:Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811446}
-
- 28 Sep, 2020 20 commits
-
-
Jamie Madill authored
This allows the runner to capture the contents of this directory from the device. The directory is used by ANGLE tests to produce images for Skia Gold. Bug: angleproject:4090 Bug: b/168049670 Change-Id: I10a669c21357366a2535d13d5f578771b52e8612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434088 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Piotr Pawliczek authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/77b1345ec0eb..1342b20cf245 $ git log 77b1345ec..1342b20cf --date=short --no-merges --format='%ad %ae %s' 2020-09-19 pawliczek system_api: New error codes in debugd/CupsResult 2020-08-13 wvk vm_tools: Add SetVmId method to concierge BUG=chromium:1069844,chromium:1123268 TEST=tested on atlas as a part of larger patch Change-Id: I848a8c6edc7da9fba8a9f10a5e138d5df4550f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436550 Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811444}
-
Andrew Grieve authored
This reverts commit 9d395e1d. Reason for revert: Finished collecting data. Original change's description: > Optimize for speed Android performance sensitive functions. > > Set optimize_max compiler options to build some hot blink render > components and improve size-vs-speed balance on Android. > > Pixel4 Aarch32/64: > +628Kb/+884Kb libchrome size > +6.9%/+5.7% speedometer2 speed > > Bug: 1125115 > > Binary-Size: Will revert this after perf graphs show impact of it. > Change-Id: I45e176ae1cbc2e513eda986b667ce65640ec9a2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390778 > Commit-Queue: Pavel Iliin <Pavel.Iliin@arm.com> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804555} TBR=agrieve@chromium.org,Pavel.Iliin@arm.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1125115 Change-Id: I66387878027a71a59a65b269b6e95b3b31c5d90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436271Reviewed-by:
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /content/renderer/pepper This CL was uploaded by git cl split. R=raymes@chromium.org Change-Id: I7a8be6603564a805c85b254fee8dcf24fee6b30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434630 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#811442}
-
Liviu Tinta authored
We are running a Finch trial and we would like to know how many times the browser process fails to verify User Activation. Bug: 1098466, 1098467 Change-Id: I28572dd8bf5eb600efa13732bd8f64a316f2d3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418974 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811441}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b94db86cf9b3..44be0942f9a8 2020-09-28 bclayton@google.com Pipeline: Fix return type of SIMD::Pointer::limit() 2020-09-28 bclayton@google.com Pipeline: Assign to SpirvRoutine::pointCoord If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id55cb1a4e2534fb0ee87726bfb299b7454a12021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435911Reviewed-by:
-
Moe Ahmadi authored
Modules do not need names in addition to titles. Bug: 1130799 Change-Id: I6475d1b1b72b5e94e7417dbf533b7684c051fd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436374Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811439}
-
Yulun Wu authored
chromium/src/ash/app_list/views/app_list_folder_view.cc:260: Add #include <utility> for move [build/include_what_you_use] [4] chromium/src/ash/app_list/views/folder_header_view.cc:46: Add #include <memory> for make_unique<> [build/include_what_you_use] [4] Bug: 1130129 Change-Id: I0f9351349ae983d45e12591f74b97c3d5c5ceff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419756Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811438}
-
Reilly Grant authored
Based on a stable 1% experimental launch in M-85 new backend appears to be stable. Enabling it by default so that it rolls out to all users as part of M-87. Bug: 637404 Change-Id: I57d996c1cef5c5c097561c9c23b9ae713825e4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436292 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811437}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/08ae7cea30d2..e39b378d4a92 2020-09-28 mbonadei@webrtc.org Remove tests associated to WebRTC-LibvpxVp{8,9}TrustedRateController. 2020-09-28 danilchap@webrtc.org Delete RtpRtcp::BitrateSent as no longer used 2020-09-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0957d98f..3274067a (810507:811217) 2020-09-28 guidou@webrtc.org Add API to allow legacy TLS protocols. 2020-09-28 hta@webrtc.org Refactor webrtc::PeerConnection to split out offer/answer 2020-09-28 tommi@webrtc.org Delete dead signal code in pc/channel.* 2020-09-28 mbonadei@webrtc.org Compile screen capturer mac test only when is_mac=true. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131805 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id129c3c36831d735d142996385e07a96c931bfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436447Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1fbf9326. With Chromium commits locally applied on WPT: 6bdcd688 "[COOP] access reporting: split property.https.html test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I3be97c0bbe568962b2b62fcb2a2b30cef9f6b32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436651Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811435}
-
Siyu An authored
We don't need this field in the MVP scope, and we are not 100% sure what format of the text will be. So remove it for now. Will add it back when we really use this. Bug: 1112095 Change-Id: I919c5520cf14da24d9474fff0b3f95716fd31935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432322Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#811434}
-
Matt Swartwout authored
A basic true/false does not encapsulate the full error reasons. Some clients may want to behave different on a ConnectionPending error vs a real connection failure. Bug: None Test: None Change-Id: Ic38eaad6dd0d27046e9c9d8d6fe45847756046e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431408 Commit-Queue: Matt Swartwout <mwswartwout@google.com> Auto-Submit: Matt Swartwout <mwswartwout@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#811433}
-
Emily Stark authored
We are not planning to run the stable experiment with this enabled. Bug: 1090393 Change-Id: I2763b67032564580806f0053b1507e5d7a4334c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431460Reviewed-by:
-
Dylan Cutler authored
Bug: 973801 Change-Id: Ice5e4cf1583502d47cf4350274c9b58fc5ebc142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434737Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#811431}
-
Sophey Dong authored
AndroidX's DialogFragment does not have the issue where onAttach(Context) is not called for API < 23. Bug: 1131851 Change-Id: I116785d34f59dde51ed3204c12867aad486237e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430325Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#811430}
-
Andrew Grieve authored
This reverts commit 0ce26a3b. Reason for reland: Leaving in a suppression that broke tests. Original change's description: > Revert "Android: Remove StrictMode usage from //chrome" > > This reverts commit 1de470a5. > > Reason for revert: Likely caused a lot of test failure due to StrictMode. > An example build is https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/27067 > > Original change's description: > > Android: Remove StrictMode usage from //chrome > > > > Removes direct usage (StrictModeContext left for follow-up) > > > > These suppressions are safe to remove now that StrictMode handling in > > chrome has been switched to a filter-based approach. > > > > Bug: 1038384 > > Change-Id: I59ee33bd1e34249c6be7973e5d759007ec0b2533 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410537 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#809402} > > TBR=agrieve@chromium.org,pkotwicz@chromium.org > > Change-Id: I6277029a7154c53d2ea1bc0f4d7cc6b9aacb0e62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1038384 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424989 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#809584} Bug: 1038384 Change-Id: Ibb41fc756f9e1aa76d738cdc08436d1013562cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426465 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7930477fba50..19e9df68a7bb 2020-09-28 jmadill@chromium.org Re-land "Add a small unit test that dumps system info." 2020-09-28 jmadill@chromium.org D3D11: Enable renderable mipmap generation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1130678 Tbr: jonahr@google.com Change-Id: Ia345f8a6812e2b493820da438bd51f1fa82e9688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436438Reviewed-by:
-
Dave Tapuska authored
Accessiblity can use gfx::RectF directly instead of using the deprecated WebFloatRect. Change-Id: I9ae67e219900bb4df7857a6d935280cc41966a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431794 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811427}
-
David Black authored
Pinned files container should show a prompt to the user when empty, otherwise the pinned files. This CL also: - Updates a few styles. - Fixes a bug in which downloads were not restored due to the time of first enabling holding space not being stored to prefs. Bug: 1131253 Change-Id: Ife26c626e633c4263fea80610b4948c7971ba09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434465 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811426}
-
