- 17 Jul, 2020 40 commits
-
-
Sebastien Lalancette authored
TBR=robertma@chromium.org Bug: 1106861 Change-Id: Idd91371a1d9e6bb4013e3d7b147ecdbe4b6461d2 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304103 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789678}
-
Reilly Grant authored
This change enhances the cancel() method on SerialPort.readable so that is requests a flush of the serial port's receive buffer as required by the draft specification[1]. [1]: https://reillyeon.github.io/serial/#dfn-serialportsourcecancelalgorithm Bug: 989653 Change-Id: I8f6550ea6ac7093a04ca814b1f1b6b8d5d08ee76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250366 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#789677}
-
Sonny Sasaka authored
This CL adds BluetoothBatteryClient which is a proxy to BlueZ's org.bluez.Battery1 interface. Future CLs will interact with this new interface to get battery level of Bluetooth devices and store the value to BluetoothDevice object. Battery API Doc: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/refs/heads/chromeos-5.54/doc/battery-api.txt Bug: b:160905767 Change-Id: I2bee100b25518b48a296b87657026769058384d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296266 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#789676}
-
Scott Violet authored
This is in preparation for using favicons in WebLayer, which won't use history. BUG=1076463 TEST=covered by tests Change-Id: I4adc5bd015cfdda16e3189f30df5a854dc0a4a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305038Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9109ad22..c80db6e1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8853506baf40fdbbca7b3df04929b4a3ae5f0d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303704Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789674}
-
Ben Joyce authored
Jacoco is not generating .exec files for junit targets. I traced the root of the issue to the out/Debug/lib.java/base/base_java.jar (and other host jars) not being run through jacoco. Less redundant code would be to set the _previous_output_jar to the results of the host_filter jar, but then that'd get run through desugar, which was the reason for the changes in the first place (see https://chromium-review.googlesource.com/c/chromium/src/+/2241865) We were running on-the-fly code coverage with a javaagent sent as an arg to the jvm, but that did not generate the desired coverage data so we're going to use all offline. Bug: 1097815 Change-Id: I0d9b4a48f921b743ee5179345fd6a81fa9437cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291835 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789673}
-
Gabriel Charette authored
Currently being used for MessagePump jank investigations R=chromium-metrics-reviews@google.com, fdoray@chromium.org Bug: 1104928 Change-Id: I97cd90523dad2fc561155b0e45d4fcc9be855be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305033 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789672}
-
Dean Michael Berris authored
In the ReportSender API, the callbacks are semantically called once and therefore should be base::OnceCallback instances instead of base::Callback (an alias to base::RepeatingCallback). Bug: chromium:1007815 Change-Id: I2a2f1d79f2c6c6dba1282174e71108b2c8e66c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291307 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Dean Berris <dberris@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789671}
-
George Steel authored
The vscode clangd extension now uses this directory. Change-Id: I0232a3ac556ddbe2b867e8db508e1a86380fd6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297814Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789670}
-
Ian Kilpatrick authored
Previously we used slightly different logic for storing ink-overflow in the compressed "outsets" format, and the "NGSingleInkOverflow" object format. This resulted in differences in when running a 64bit binary (typical) vs. a 32bit binary with large ink-overflows (which are relative uncommon). This patch changes the "NGSingleInkOverflow" to have the same outset logic. Change-Id: If9d5146ec3fad1de27cfda2c13980312886b1e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304143Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789669}
-
James Cook authored
set_sources_assignment_filter() causes files to be magically excluded from sources lists based on path (e.g. *_win*). It is considered a misfeature of gn, see bug or docs/no_sources_assignment_filter.md Convert BUILD.gn to use conditionals to include source files only on the platform where they are used. Bug: 1018739, 1096762 Test: compiles Change-Id: Ic5563a3558d9bdc8b9bc22bb6275d869a0985c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303463 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789668}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaca01acfdb0fab350ca38a6d96e042e3d33f7356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789667}
-
Alexander Cooper authored
Converts the OpenLoginTabCallback from Callback to RepeatingCallback. Converts base::Bind calls that were being passed to methods that take RepeatingCallback's to BindRepeating. Converts a few Callbacks being used as OpenLoginTabCallback in chrome/browser as well, since that is how the initial need for changes was discovered. Bug: 1007635,714018 Change-Id: I3a514a2eff2d821e2a34d9537440407eab1619e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297565 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#789666}
-
Haiyang Pan authored
For the following OSes: android, chromiumos, fuchsia, linux, and win. And remove the change in luci.chromium.try Bug: 1098927 Change-Id: I6a547e24c645128e3bef5368cf8117269dd0de47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286191Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#789665}
-
Quinten Yearsley authored
Change-Id: I5c2d041663d700b1b2860b20e73f6017c374e663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304965Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#789664}
-
David Schinazi authored
This CL fixes a linker issue where apps were failing to link CronetStatic due to missing symbol base::mac::CxxPersonalityRoutine. The fix explicitly adds the file containing that symbol. Thanks to mef@chromium.org and justincohen@chromium.org for finding this fix. R=zhongyi@chromium.org Bug: 1106056 Change-Id: Ifa2095f9c24de456b27eb1dd49c78ba94dd0900b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304966Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789663}
-
Noah Rose Ledesma authored
Regardless of how the UI is laid out, media playback controls should be laid out in a left-to-right manner, as suggested by the material.io bidirectionality guide. Additionally, the images for playback control buttons will no longer be mirrored about their horizontal axes in an RTL layout. This includes the play button and the PiP button. The PiP button is not mirrored because the PiP display is always in the bottom right corner regardless of UI layout. Finally, after having worked with l10n and talking to UX engineers in Israel, we have determined that the appropriate focus order for this dialog should traverse the playback controls left-to-right first and then focus the picture-in-picture button. This CL implements this order. Bug: 1040021 Change-Id: I0a57ec7d879ab312ec1ce7bb592d8f79edceaa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253134 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789662}
-
Andre Le authored
1. Fix padding and layout. 2. Make it a button that takes user to management setting page. Change-Id: Iddc81f1b6b3762249e6046484cce96128e3651c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303050 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#789661}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d7afd4824c6..d0c9d0cb7ffa 2020-07-17 nifong@google.com Replace arcTo with three functions for it's overloads. 2020-07-17 csmartdalton@google.com Bind deferred vertex buffers during GrGLOpsRenderPass::onDrawIndirect 2020-07-17 fmalita@chromium.org [skottie] Fix analytical mask fill type 2020-07-17 johnstiles@google.com Add an input FP to the GrProcessorTestData. 2020-07-17 robertphillips@google.com Clean up some GrContext uses in the GMs 2020-07-17 adlai@google.com Remove two unused deprecated SkImage functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Id1e85a51798d15f77faa00b38719ed792ef0e25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305052Reviewed-by:
-
Jimmy Gong authored
- Removes extra indent of print job entries. Screenshot: https://screenshot.googleplex.com/4T27OJb9MT9 Bug: 1106167 Change-Id: I75ff3989e94b88766989d22be2e2ac1757bbc412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303872Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#789659}
-
Etienne Pierre-doray authored
Log actual values of max_concurrency, expected_max_concurrency and should yield. Change-Id: I4151e8812d58c30311111d07d06844d2f4ce60e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303986 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#789658}
-
Maksim Ivanov authored
Log the error details, including the key, when crashing in base::PathService::CheckedGet(). Bug: none Change-Id: I69386d92cc335c82012a247c9cef255d8fefea57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291150Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789657}
-
Koji Ishii authored
|PostLayout| was limited to |LayoutBlockFlow| because crbug.com/965639 could happen only to|LayoutBlockFlow|, but following conditions have changed: * Only |LayoutBlockFlow| could be relayout boundary, until r772560 <crrev.com/c/2219312>. * Only |LayoutBlockFlow| was laid out by LayoutNG, until |LayoutNGFlexibleBox| inherits from |LayoutBlock|. This patch changes |PostLayout| to work for |LayoutBox|. In doing so, two changes were made: 1. |CurrentFragment| is replaced with |GetPhysicalFragment| because the former is not available for |LayoutBox|. 2. Stopped checking |IsRelayoutBoundary|. Though it is the only case crbug.com/965639 can happen as far as we're aware of, checking |NGPhysicalFragment| is more essential and sufficient. The change 1 also helps <crbug.com/1061423>, but we may need different approach to support block fragmentation. Bug: 1102151, 965639 Change-Id: Id83be614066392a4c58c8b03bd16ee57ad82e145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302984Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789656}
-
Michael Spang authored
This should work like other platforms, and give a Viz process that doesn't require a hardware GPU, e.g. for running tests on infra. This fixes an infinite loop when --disable-gpu is passed in such builds, where we try to start a GPU process but this is rejected by GpuProcessStartAllowed() == false. This started happening (or at least became severe enough to break our tests) after 966e62f6 ("[scheduler] Enable prioritize until begin main frame by default."). Change-Id: I67c4f819e0383950d1c876bc34b799fb794bd5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304154Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789655}
-
Chris Hamilton authored
This is similar to util::IdType<...>, except it adapts StrongAlias wrappers of base::UnguessableTokens, for code that wants to use a token as an identifier. This will be used in upcoming work to migrate much of current base::UnguessableToken usage to be strongly-typed. BUG=1096617 Change-Id: Icba4d6ace622dc7cc55cf731fc85d15aa12443b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302727Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#789654}
-
Alex Newcomer authored
They are working on the project and I would like to have them review CLs in this directory. Change-Id: Ic9230e3b966279b3ed112802c0c15052f28abd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305015Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789653}
-
K. Moon authored
Removes support from pdf/BUILD.gn for building with PDF engines other than PDFium. We do not intend to support other PDF engines going forward. Bug: 1076554 Change-Id: Id85f685001cc338bc8839f6f168a738ba4ed338d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302910 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4181.3-1594633354-benchmark-86.0.4203.0-r1 to 86-4181.3-1594633354-benchmark-86.0.4204.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifc34640d34e36bbbe27203672f4fc4a54a7a968e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305094Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie490f0bfa01dc59445c839f63a8b7eada872a69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305057Reviewed-by:
-
chrome://downloadsDaniel Rubery authored
This CL makes the presence of the "Open Now" button during deep scanning dependent on whether policy has allowed pending scans to be opened. Fixed: 1068649 Change-Id: I5d640f45d0c8d5275fd75f135312de4667d61061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297979 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789649}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4181.3-1594633791-benchmark-86.0.4203.0-r1 to 86-4181.3-1594633791-benchmark-86.0.4204.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8af74f232280ad65ecfcb88658af1b4bdc853408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305093Reviewed-by:
-
Daniel Libby authored
Scrollbar scrolling in general had a number of problems when pinch-zoom (a.k.a. page scale factor) is set. On the compositor side, input points need to be transformed to the scrollbar relative coordinate space in order to appropriately calculate deltas, since the calculations are all done in layer relative coordinates. Additionally the scroll deltas themselves must be scaled by the page scale factor, since the code that handles GSUs expects this to be encoded in the deltas sent to LayerTreeHostImpl. Clamping logic also needs to account for the distribution of deltas across the inner (visual) viewport and the outer (layout) viewport. On the main thread, the injected scroll deltas suffer from the same issue as the compositor thread - they need to apply the input scale as well. I've also added the ability to hit test the root viewport scrollbars, since the hit testing code otherwise will hit elements that are visually under the scrollbar (the positioning of the scrollbar is done specially via the OverscrollElasticityTransformNode). Code in Scrollbar also needs to become aware that it should use the widget-relative coordinates instead of root frame-relative coordinates (the latter have been transformed based on scale and offset of the visual viewport), when operating on the root frame layout viewport. Bug: 531603 Change-Id: I6eb2ecd135a88228d3f4a11bed29ebb9d788b4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290966Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789647}
-
Sebastien Lalancette authored
TBR=nasko@chromium.org Bug: 1106893 Change-Id: Ice1d35cd252d4efdd9bc65822d64cfbacfa924cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304973Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie76925e89f5379714545b3568413e21157529d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304934Reviewed-by:
-
Ben Pastene authored
This reverts commit 3d879e70. Reason for reland: - All hand-rolled DEPS-consuming apps have been updated. - No changes in this CL between original & reland. Original change's description: > Revert "Simplify Simple Chrome's gclient and GN conditionals." > > This reverts commit 072cfd65. > > Reason for revert: Needed to fix merge conflicts for revert in https://crrev.com/c/2289991. > > Original change's description: > > Simplify Simple Chrome's gclient and GN conditionals. > > > > Now uses the new gclient var 'cros_boards_with_qemu_images' for DEPS > > hooks as well as for building the data_deps for CrOS tests in GN. > > > > Bug: 937821 > > Change-Id: Ifdd05f09a4200328a06028be86aeb22c8486c65c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285361 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#786312} > > TBR=thakis@chromium.org,dpranke@google.com,bpastene@chromium.org > > Change-Id: If0b181d298f6a9368af88eaf658f0226e2161c68 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 937821 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289401 > Reviewed-by: Michael Moss <mmoss@chromium.org> > Commit-Queue: Michael Moss <mmoss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786762} TBR=thakis@chromium.org,mmoss@chromium.org,dpranke@google.com,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937821 Change-Id: Ia9759be4fcdf7dc510fefd9c020440478da5b8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303031Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#789644}
-
Katie D authored
When a node in the current group is removed we should check that the current group is valid, and re-calculate its children. This change also has some other bugfixes to improve stability around edgecases. AX-Relnotes: N/A Bug: 1105196, 1106575 Change-Id: I0461150aadc42d5bd01099d96bf69d8d1f71119a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303056Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#789643}
-
Stefan Zager authored
BUG=1072349 Change-Id: I2618941d60bb81c2a4e255cf7ffb9a8d434ffe45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304133Reviewed-by:
-
Jesse McKenna authored
Reland "Limit Windows-shell-based launches to one argument" and "Replace --single-argument= with --single-argument" This reverts commit 2538167d. Reason for revert: This relands the two reverted CLs. The original change to the command-line syntax (landed in two separate CLs) caused the following issues: * Temporary breakage after background update from `chrome.exe %1` syntax to `chrome.exe --single-argument=%1` (crbug.com/1092913), when a file is opened via the shell: * Registry contains `--single-argument=%1`, running browser sees no argument (only an unrecognized switch), opens new tab page * Crashes after attempted fix that replaced `--single-argument=%1` with `--single-argument %1` due to a CHECK in the first change enforcing the presence of the `=` character: * After background update, registry contains `--single-argument %1`, running browser CHECKs for `=` and crashes (crbug.com/1096004) * Windows 7 Dev channel (expecting `=`) default-browser check parses Canary's registry command line (containing ` `) to get the default browser path (crbug.com/1096964), triggering CHECK * Crash when unregistering PWA file handlers on local Chromium build (crbug.com/1096004#c3), presumed to be caused by parsing the shell/open command written by file-handler registration on an older version (as local Chromium builds don't background update) What all the above issues have in common is that they are caused by incompatibility between new and old versions. With this in mind, this reland assumes that the old and new syntax can and will be mixed in potentially unexpected ways. This change replaces `chrome.exe %1` with `chrome.exe --single-argument %1`, which is flexible enough to handle the following cases: * If registry contains old syntax and running browser expects new syntax: * Due to the absence of the `--single-argument` switch, the command line will be parsed normally (potentially as multiple arguments) * If registry contains new syntax and running browser expects old syntax: * The browser will ignore the unrecognized `--single-argument` switch and parse the command line normally (as the argument still appears after a space like in the current syntax) * If browser parses command line from another channel with different syntax: * Covered by either the first or second case above This reland also replaces the single remaining CHECK with a DCHECK. Original change's description: > Revert "Limit Windows-shell-based launches to one argument" and "Replace --single-argument= with --single-argument" > > This reverts commits 452f8315 > and 74ae85ac. > > Reason for revert: this CL and crrev.com/c/2238270, which introduced > the --single-argument flag to the Windows command line, have caused > issues (crbug.com/1092913, crbug.com/1096004, and crbug.com/1096964) > related to incompatibility between the Chrome command line in the > registry and that expected by the running browser. crrev.com/c/2238270 > was an attempt to fix those issues, but outstanding bug > crbug.com/1096964 is still not well-understood and has made it to the > Dev channel. This change reverts both CLs to prevent further issues > and to enable a future reland that incorporates lessons learned. > Reverting both CLs simultaneously is necessary to prevent trybot > failures due to the same registry-browser command-line incompatibility > issues (i.e., browser-test trybots having the current command-line > syntax "chrome.exe --single-argument %1" in their registry, and > failing to recognize the argument in the between-changes syntax > "chrome.exe --single-argument=%1"). > > Original change's description: > > Limit Windows-shell-based launches to one argument > > > > This change adds "--single-argument" to launches done via the Windows > > shell, which makes Chrome treat all text after "--single-argument=" as > > Chrome's one and only argument. This limits shell-based launches to > > passing only one argument to Chrome. > > > > Previously, Chrome's command line as registered with the Windows shell > > was `chrome.exe "%1"`, %1 being Windows' filename placeholder. The > > shell replaces this placeholder with the file/URL that Chrome has been > > invoked on (e.g., if the link "https://www.chromium.org" were clicked, > > Chrome would be run with command line > > `chrome.exe "https://www.chromium.org"`. > > > > With this change, Chrome's command line is > > `chrome.exe --single-argument=%1`, and the contents of %1 are treated > > as a single argument regardless of quotes or spacing. > > > > Code that creates the command line string for the Windows shell (e.g. > > code writing Chrome's command line to the registry) must use the new > > format by calling GetCommandLineStringForShell(), which appends > > "--single-argument=%1" to the returned string. > > > > Bug: 937179 > > Change-Id: I6c0d6f0abce7a8c9f65ca8b90d15438310db7c92 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116596 > > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#773398} > > TBR=thestig@chromium.org,grt@chromium.org,jessemckenna@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 937179 > Change-Id: I014cd0b1acb5080b16b68268ea8d20eb18f9b431 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255138 > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > Reviewed-by: Jesse McKenna <jessemckenna@google.com> > Cr-Commit-Position: refs/heads/master@{#780559} TBR=thestig@chromium.org,grt@chromium.org,jessemckenna@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937179 Change-Id: I3d83b82bddaf1a40235273bce94541c63322cc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273598Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#789641}
-
Tommy Steimel authored
This CL fixes most of the gn check issues in chrome/credential_provider by adding necessary deps and removing some unused includes. This CL enables gn check for the directories that are completely fixed. The last issue will be fixed in a followup CL since it's more complex. Bug: 1106758 Change-Id: Ib382eb7b3af808db00d806ffd46d8d9c76ecb280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304172 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789640}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I425fbb626966938f14cafb2d97405d6ea4061995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305030Reviewed-by:
-
