GitLab

Print preview UI expects the initial settings key to be in camelCase,
like |previewIsPdf|.

Bug: 989978
Change-Id: Ifcfee6f71e3dcdb4902054b7f9407c814898a481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825897
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700001}

Renaming OpenXR location related variables/functions so their meanning
is more clear

Change-Id: I760b143b9f4d4a498741278b507b9608bca51b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820022Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700000}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d1d142297302..3ef6d975b402

git log d1d142297302..3ef6d975b402 --date=short --no-merges --format='%ad %ae %s'
2019-09-25 vapier@chromium.org pylint: enable docstyle checker
2019-09-25 vapier@chromium.org pylint: re-enable bad-builtins

Created with:
  gclient setdep -r src/third_party/chromite@3ef6d975b402

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Iae9eb96a01e85226f3c9b331bc15ca99c0832d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825783Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699999}

Declare them as extern in .h files and have a single implementation
in .mm file. Nothing bad happened fortunately because this variable is
a const, but it's wrong.

Bug: None
Change-Id: Ia9bcb4121594fae9dd6c95679cdcdf6b67f411ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825170Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699998}

This CL restructures PAK inclusion for DevUI pages to be hierarchical:
* Each DevUI page has its own "atomic" PAK files (currently only done
  for chrome://bluetooth-internals).
* On *all* architectures, pages intended for the DevUI DFM are repacked
  into dev_ui_page_resources.pak.
* For non-Android, or if DevUI DFM is off, dev_ui_page_resources.pak is
  simply repacked with other resources to form resources.pak. This
  produces the same result as before.
* For Android with DevUI DFM on (APK and bundles):
  * dev_ui_page_resources.pak and DevUI support resources are repacked
    into dev_ui_resources.pak.
  * Remaining resources go into resources.pak.

This CL also centralizes atomic PAK files targets and deps into a single
target (dev_ui_paks) in chrome/browser/resources/BUILD.gn, making it
easier to edit dev_ui_page_resources.pak contents.

Change-Id: Ieeaa18a322b46ed5102b2cbec20fab44a2b4ab82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785007Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699997}

ChromeSerializedNavigationDriver::Sanitize may rewrite some session
restore entries stored in sessions::SerializedNavigationEntry.
Such rewrite needs to leave the data in a self-consistent state.
This becomes more important now, because r698995 introduced extra
DCHECKs that enforce the self-consistency.

Before this CL, ChromeSerializedNavigationDriver::Sanitize
would modify PageState (which contains the URL, Referrer and other
pieces of data), but would not modify the referrer stored in
the SerializedNavigationEntry.  This CL fixes this.

Bug: 1007532
Change-Id: I0e8722914f1d7a7283a1d87b26b645e058b1c18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825461
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699996}

These are simple files to move so doing both in the same CL.

Bug: 995916
Change-Id: I67b61f9d3ffea0f66bd493f350f069affea708e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812117
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699995}

This re-lands:

https://chromium-review.googlesource.com/c/chromium/src/+/1699138

which was reverted by:

https://chromium-review.googlesource.com/c/chromium/src/+/1824081

due to asan failures.

The failures were test-only.  It used a base::Unretained in a mock
that, due to a posted callback, was being destroyed during test
teardown before the callback had a chance to run.  When it did run,
asan got mad.

This CL replaces the unretained with a weak ptr.  Changes are in
mock_shared_image_video_provider.* .

TBR=sandersd,vikassoni,mpearson

Change-Id: I85e6f85a6f81964a6c4b286d2b8219d0b4840958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825900
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699994}

Adds:

1. "enable_typescript_bindings" gn arg, which must be set to true
   to test Typescript bindings.
2. "use_typescript_sources" gn variable that can be set to opt-in a
   target into generating Typescript bindings.
3. Test interfaces folder where interfaces will be added as features
   are implemented.
4. A mojom gn target that includes the tests interfaces. This target is
   included as part of mojo_unittests
5. Basic template and generator implementation.
6. Script to compile generated Typescript bindings into JS bindings.

Bug: 1002798
Change-Id: Id8424d707ad4b2ec9a773b291fd4a41332623274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817860Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699993}

The following icons should be colored according to the current theme:
- search loupe
- globe

I've changed the functionality from setting properties in the model to
setting the resource values intermediate variables (icon/tint) and
settings those in the model at the end of the branch. This simplifies
the code a bit and makes it easier to read. To allow for this change,
I've altered the favicon fetching logic to post a task back to the
ui thread for the callback. This way the callback isn't invoked
immediately, which avoids crbug.com/997343 from resurfacing due to
this change.

Bug: 1004903
Change-Id: I6e8102f47e81d0037761d9b111b98d4f1999a225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818604
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#699992}

No change to logic, only docs. This adds navbar.md (supported by gitiles
markdown) to the mojo docs. This makes http://go/mojo-docs/ slightly
easier to navigate, as the top bar will link to some of the high-level
documents. This does not link to every mojo doc, to avoid
over-cluttering the navbar.

Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I2cad169397ae8a0d12b23da735fb9d641a1eff64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824062
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699991}

This CL is proposing to lift the call to FcInit to ensures the
font-config is initialized.

Currently, the FcInit(...) is lazily called on first use. On windows,
the DWrite is early initialized to avoid the lazy initialisation. We
proposed to do the same on Linux.

The behavior should be the same on Windows. On Linux, FcInit should
be called on startup, as we need fonts for any rendering.


The main goal of this change is to help collapsing the bugs / crashes
stack to point to a single culprit. Currently, they are spread over
multiple stackframes in incorrectly reporter.

  Memory leak with FcInit(...) - crbug/1000881, crbug/977249
  Iterator corrupt, initialisation - crbug/1004254

More signatures are available here:
  https://bugs.chromium.org/p/chromium/issues/detail?id=1004254#c11

Change-Id: I1f6d80c790829b1d9416b773d5c9cdba16f90eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808447Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699990}

Quick cleanup for ScreenCaptureNotificationUIViews in preparation for
Layout changes in http://crbug.com/1005568.

BUG=
TBR=pkasting@chromium.org
Trivial changes.

Change-Id: Ic2934537d91e05467429e11976fba5b0ef96604c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825728
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699989}

https://chromium.googlesource.com/angle/angle.git/+log/d4c75347e4d3..29f7916fd56e

git log d4c75347e4d3..29f7916fd56e --date=short --no-merges --format='%ad %ae %s'
2019-09-25 jmadill@chromium.org Vulkan: Store current Serial in RendererVk.
2019-09-25 ynovikov@chromium.org Temporarily disable SwiftShader everywhere.
2019-09-25 jonahr@google.com GLX: Forward XExposeEvents to parent window

Created with:
  gclient setdep -r src/third_party/angle@29f7916fd56e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:1008100,chromium:991577
Change-Id: Ib83f0b48defba45f982a0e9ab4e9af5a35c8b795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825627Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699988}

For https://bugs.chromium.org/p/chromium/issues/detail?id=1007570, I
can't reproduce the issue, but my best guess is that somehow we're
relying on DiscardPendingEntry getting called when we don't have a
pending entry to clear the failed_pending_entry_id_. This makes sure
that we don't skip calls to DiscardPendingEntry when we've set a
failed_pending_entry_id_.

Bug: 1007570
Change-Id: I3e1f46515247b99a0adbd68b3fea82aa719e474a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825592
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699987}

For a <section> element with an accessible name, change the
ControlType from Pane to Group and the LocalizedControlType
from "region" to "section".  <section> elements  with no accessible
name are not changed.

Spec reference: https://w3c.github.io/html-aam/#el-section

This change required the introduction of ax::mojom::Role::kSection.
kRegion had previously been used for <section>, but this no longer
works because we need to distinguish between these two cases:
<section aria-label='section'></section>
<div role='region' aria-label='region'></div>
Where only the former has LocalizedControlType == "section".

Introduction of the new kSection role also allows us to eliminate
dependencies on the kHtmlTag StringAttribute in a few places.

The UIA ControlType of the Region role is also updated to Group per
https://www.w3.org/TR/core-aam-1.1/#role-map-region

Bug: 999730
Change-Id: I1008d27b5744fe22b5fa5fefc58bb9d16dedcef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779430
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#699986}

The code in ui/accessibility is designed to be used outside
of the browser process, it works with generic cross-platform
accessibility data structures.

The code in ui/accessibility/platform contains the implementation
of platform-specific accessibility APIs and the internal
abstractions of these. It doesn't make sense to include anything
from this directory from a renderer process, or on platforms
that don't have a native accessibility API.

AXTreeManager (in ui/accessibility) had two functions that
returned an AXPlatformNodeDelegate, which violates this
layering and  makes it impossible to use AXTreeManager
in places where we don't want to depend on
ui/accessibility/platform.

The underlying reason that these functions were added to
AXTreeManager were because there was no way to retrieve
an AXPlatformNode given a (tree id, node id) pair. So
instead, this change adds that interface to
AXPlatformNodeDelegate, which is a better place for this
than AXTreeManager.

That fix required two changes as a consequence:

First, AXRange was using AXTreeManager's hook into
AXPlatformNodeDelegate to call platform bounds rect code.
I fixed that by having GetScreenRects() take a helper class
as a parameter, so that the caller can provide an
implementation of the platform-specific logic that AXRange
needs. This enables the current usage of AXRange to work
without precluding using AXRange from elsewhere in the codebase
in the future.

Second, the autofill code was using AXTreeManager's APIs
to find the focused text field given its [AXTreeID, node id].
This change just required getting an AXPlatformNode from
WebContents, and then calling the new AXPlatformNodeDelegate
API.

Bug: 1006402

Change-Id: I640ecebf00baded00ae968197a8ecd7bffad0cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815221
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699985}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01c20b755102..95d5e25ad030


Created with:
  gclient setdep -r src-internal@95d5e25ad030

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Ib36b15ec68e60e87947f924291092199d704be95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825626Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699984}

This adds a timer histogram for all PalmDetectionFilter->Filter
executions. We'll keep the timer whenever we change the underlying
filter implementation.

Adds a unit test that ensures the timer is populated.

Bug: 982118
Change-Id: I410ca0348bca9c556f4dff05ab5e228a1f09516d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824796Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@google.com>
Cr-Commit-Position: refs/heads/master@{#699983}

base::Version::GetString() returned a `const std::string`; there's no
reason to do this, since it's a new string (and not a reference to a
member). Additionally, this could potentially result in invocations of
Version::GetString() creating a copy, if the caller did something like:

std::string version_string = version.GetString();

Since the result would be a `const std::string`, a copy might be made to
fit into the non-const std::string required by the caller. Hopefully,
the compiler is smart enough to optimize this out, but it's better to
just un-const the result altogether.

Bug: None

Change-Id: I5afb69b5e1e04dab03eb8629ea7e2d124e91f755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825460Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699982}

This reverts commit 25a9b3bd.

Reason for revert: Memory snapshots work again

Original change's description:
> Revert "[DevTools]: Moves common to ES modules"
>
> This reverts commit e0645533.
>
> Reason for revert: Memory tool fails to take heap snapshots with this
> error: https://imgur.com/hzR9Eqw
>
> Original change's description:
> > [DevTools]: Moves common to ES modules
> >
> > This CL converts the contents of the common/ folder over to ES modules
> > from the current custom module system. It includes statements in each
> > file that will pollute the global namespace, allowing the non-ESM code
> > to continue working as before.
> >
> > Bug: 1006759
> > Change-Id: Ib591e49155000381f85999a5da6c467ad0160996
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816563
> > Reviewed-by: Yang Guo <yangguo@chromium.org>
> > Commit-Queue: Paul Lewis <aerotwist@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#699728}
>
>
> Change-Id: Ic0d526780451e8bb4de538f11c85859a3badfb0f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1006759
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825463
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#699835}

Bug: 1006759
Change-Id: I48c7e84262bb295e5830cac8a79a274226df046c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825420
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699981}

Code does not use these experiment enums anymore. Only kSmoothScrollingDefault
is used to determine how to adjust the viewport insets.

Bug: 914042
Change-Id: I71c4112d7f2f820a4793d74d0c5a0726513f300a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812121Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699980}

Remove a suppression on oboslete AMD Radeon 6450.

TBR=kbr

Bug: 1008125, 479975
Change-Id: Id683c79e37be6fb99e8cc05796e3ed9c08b96023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825475Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699979}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a5cb2517a2c..69b63c9f97d0

git log 6a5cb2517a2c..69b63c9f97d0 --date=short --no-merges --format='%ad %ae %s'
2019-09-25 pwnall@chromium.org Fix sys.platform mapping in download_from_google_storage.py.

Created with:
  gclient setdep -r src/third_party/depot_tools@69b63c9f97d0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1007872
Change-Id: I44a40fad86d62e9822a640bf394a2e20c63c7578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825625Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699978}

If app list view state transition is started during app list page
transition, the initial search box position should be calculated as a
position for the current app list page, otherwise the search box
will initially be misplaced.

BUG=999273

Change-Id: I053ab7f962b7c0a00914be97a0532f9ea445af42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824363Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699977}

This test verifies that prerender request reaches the server
before the use taps on omnibox suggestion and that there are no
further requests.

Bug: 995641, 834116
Change-Id: I06cdc323ccd2eafc500fad6e6849a2a5223e7238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815712
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699976}

There are a number of externs files for closure compiler that  are
autogenerated from files in chrome/common/extensions/api/ or
extensions/common/api/ that do not have PRESUBMIT checks. Add checks
for these files.

Bug: None
Change-Id: I9df36c4ef819244287c13538d28c765f9aba78cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815986
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699975}

Autogenerate the resources_private.js externs file, and update
pdf_viewer.js to use an enum from the new autogenerated file.

Bug: 721073
Change-Id: I177d3b229f27555bf811abc7087321606f412fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811499
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699974}

GPU.GPUChannelHostWaitTime.MicroSeconds records the amount of time the
browser main thread spends blocked on sync IPCs to the GPU. This is
measuring the same value as GPU.GPUChannelHostWaitTime but with
different bucketing. GPU.GPUChannelHostWaitTime only cared about large
values and we do not wish the change the existing bucketing for it.

Bug: 1006924
Change-Id: I55447d3bd54cb7b24c84a6a4f5613880683cf571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816960
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699973}

This reverts commit 9747ecdd.

Reason for revert: This is potentially crashing vulkan_blink_web_tests on Intel. 

A failure of one test in the following run, lead to a crash of the entire test suite: https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20%28Intel%20HD%20630%29/1639

Original change's description:
> linux: Enable Crashpad for content shell
> 
> Bug: 942279
> Change-Id: I221431e352f11b40c3bc39bbcd8297b431dd8f0c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763346
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#699880}

TBR=jperaza@chromium.org

Change-Id: I117aa67f345510a5eb9ae77ec60ea5122ac12b16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 942279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825920Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699972}

According to the Mozilla Developer Network, the value attribute of an email field, or the
value attribute of any other field that includes user-specified validation logic,
doesn't always contain what the user has typed into that field.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/email#Validation
The value attribute always contains the sanitized text. For example, if there are spaces
at the start of an email address, they will be removed.

Both the DOM and the AX selection logic in Blink work on the inner
text contents of the field and not the sanitized value, so we have to switch to exposing
the inner text contents of all input and textarea fields in the accessibility tree.
Otherwise, caret and selection offsets between the inner text and the value attribute
will not match.

R=dmazzoni@chromium.org, dtseng@chromium.org

Bug: 1007454
Change-Id: I0ae2125ddd716a84a9ae06557c0f9431a4007b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825166Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699971}

This reverts commit a2c0ced3.

Reason for revert: Fuchsia doesn't provide enough protected memory. https://fuchsia-review.googlesource.com/c/fuchsia/+/322346 was reverted.

Original change's description:
> [Fuchsia] Reenable protected mode in WebEngine
> 
> Bug: 982922, fuchsia:24570
> Change-Id: If9fb495249488c43f97e4451a14f0193911d600f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#697683}

TBR=sergeyu@chromium.org,emircan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 982922, fuchsia:24570
Change-Id: I7f52d2fbfdabc14de398df68409dfd6d07f1fc9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825725Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699970}

https://pdfium.googlesource.com/pdfium.git/+log/693460a3a7b7..f57843cb20ee

git log 693460a3a7b7..f57843cb20ee --date=short --no-merges --format='%ad %ae %s'
2019-09-25 thestig@chromium.org Reformat radial shading pixel tests.
2019-09-25 thestig@chromium.org Add an axial shading pixel test.
2019-09-25 thestig@chromium.org Fix nits in CPDF_RenderStatus.
2019-09-25 thestig@chromium.org Fix crashes in FPDFClipPath_CountPaths() and friends.

Created with:
  gclient setdep -r src/third_party/pdfium@f57843cb20ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: I95d4aab1e7a46e86c56b6451a38a70134691a699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825590Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699969}

Kudos to Neiko Rivera for raising the issue.

BUG=1006763

Change-Id: I38f0d96aba171c2f4bf6d84c958b224920857065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825622Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699968}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b88dac708caf..d1d142297302

git log b88dac708caf..d1d142297302 --date=short --no-merges --format='%ad %ae %s'
2019-09-25 lamontjones@chromium.org cros-signing migration.
2019-09-25 xianuowang@chromium.org chromeos_config: disable hwtest for beaglebone_servo-release builder.

Created with:
  gclient setdep -r src/third_party/chromite@d1d142297302

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I995cb7bba56a16f4d70bb4de47440eadc4cee70f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825589Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699967}

close(socket_fd_) is sometimes hanging in this test. While that doesn't
necessarily mean this is a Fuchsia bug, it seems likely, given that this
test passes on all other platforms, and the underlying code hasn't
changed since this test was enabled on Fuchsia.

Bug: 1005042
Change-Id: I71babfc0472658b662a3c9232f05ad4abe5b1e21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825323
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699966}

As the code is all related to media, use the /media OWNERS for changes
rather than relying on chrome/common/ OWNERS.

Bug: none
Change-Id: I44b225b35bb409e38eaa8fe8423e6752ba96dd32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823799Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699965}

While disposing a worker script context on worker thread, its corresponding
extension might have already vanished from RendererExtensionRegistry because
of ExtensionMsg_Unload IPC. This means that detecting whether the
script context had extension API bindings installed through
ExtensionAPIEnabledForServiceWorkerScript() won't return correct state.

This CL changes worker disposal to inspect ServiceWorkerData instead,
which should be non null if extension bindings were installed in the
worker script context.

Bug: 1005541
Test: Update{un,}packedExtension flakiness reduces locally, see crbug.com/984522
Change-Id: Ib33148a81ebcc720cf26b754c26a520bb4e22b92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815226
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699964}

Web tests set page zoom on every RenderView's main frame, but some may
be holding a remote main frame. Don't try to set page zoom on those ones
and let the page zoom propagate from the main frame down to those
RenderViews and their child frames.

R=avi@chromium.org

Bug: 1006580
Change-Id: I411b9cd8d21f16e03649c9c716a3e6d1e7fc271e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823317Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699963}

Change-Id: I2323455f22ecee9795b8b25eb0f95c5fd4c85f87
Bug: 875768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823844
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699962}