- 03 Jul, 2018 40 commits
-
-
Qiyu Hu authored
- Ensure that CCCD is added such that we can report the value change in CCCD to Android in OnNotificationStart/Stop() - Implement SendIndication() such that Android can call it Bug: b:78593133 Test: Pass Android CtsVerifier test on server sending indication/notification Change-Id: I8b1a4be6596555003d6d447b4518f37632a45370 Reviewed-on: https://chromium-review.googlesource.com/1119079 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572291}
-
Lei Zhang authored
Fix includes in chrome_signin_client.cc. Change-Id: I22bdfd9a625ed7e57cab49f61004d2334dea066a Reviewed-on: https://chromium-review.googlesource.com/1124108Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572290}
-
Simeon Anfinrud authored
reactive_java.md documents the expectation that the Observable produced by map() is not activated when its source is activated and the Function that transforms the activation data returns null, but this expectation was not properly tested. Bug: None Test: cast_base_junit_tests Change-Id: If8ff1764efe6790a9eeabcfeadf28b052ce924f5 Reviewed-on: https://chromium-review.googlesource.com/1120643Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572289}
-
Quan Nguyen authored
Also includes a run of "git cl format --js" on display_manager.js, and a fix for splash screens not stretching to the full screen. Bug: 836861 Change-Id: Icfe750f9d743b9608e120fc02f8cf16228be5c8f Reviewed-on: https://chromium-review.googlesource.com/1115977 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572288}
-
yiyix authored
Remove the following metrics: Renderer4.CompositorThreadImplDrawDelay (99th percentile by size) Renderer4.LanguageDetection (95th percentile by size) Renderer4.SoftwareCompositorThreadImplDrawDelay (85th percentile by size) Bug: 851784 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I99947370afa55bea137f99a317983db11292e33e Reviewed-on: https://chromium-review.googlesource.com/1112203Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#572287}
-
Simeon Anfinrud authored
Now it's possible to e.g. create a Function<Both<ADerived, BDerived>, CBase> from a BiFunction<ABase, BBase, CDerived> if: * ADerived extends ABase * BDerived extends BBase * CDerived extends CBase This will help with some refactors. Bug: None Test: cast_base_junit_tests Change-Id: I7cfa3b3cfb559510e318ac8a597a138c0e4b3e0e Reviewed-on: https://chromium-review.googlesource.com/1119056Reviewed-by:
-
Lei Zhang authored
Change-Id: I8a8c0ba1da296572c5c661a82faa15c776200671 Reviewed-on: https://chromium-review.googlesource.com/1123895Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572285}
-
Bill Orr authored
The proper fix requires some design work. The current behavior does suffer from potential raciness, but shouldn't cause real-world issues for users. BUG=859666 Change-Id: I8d502a7db25949d2508675e1d153dbf56f69e1ed Reviewed-on: https://chromium-review.googlesource.com/1124948Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572284}
-
Kevin Strohbehn authored
Bug: none Change-Id: I564a8acb297811c9dee27d2c6d91077774e1bba7 Reviewed-on: https://chromium-review.googlesource.com/1123372Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#572283}
-
Toni Barzic authored
Adds OFFLINE_DEMO_ACCOUNT to ChromeAccountType in auth.mojom, which will be set for offline enrolled demo sessions, so ARC++ can use offline demo mode provisioning flow for this account. Currently, there is no real change in prod, given that ARC still handles demo sessions the same (as arc_kiosk), and logic to determine whether the device is in demo mode is not yet hooked up. This cl additionally updates chromeos::DemoSession to indicate whether the device is offline enrolled while in demo mode - this is hardcoded to false for now (except in tests). BUG=b:110276688 BUG=846934 TEST=None Change-Id: Ib1c49401020838e566e07f765aff3e4f4dd9aad9 Reviewed-on: https://chromium-review.googlesource.com/1105599Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#572282}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/45a546a30885..da20e836abca git log 45a546a30885..da20e836abca --date=short --no-merges --format='%ad %ae %s' 2018-07-03 dgarrett@google.com chromeos_config: Move all chrome-pfq builders to swarming. 2018-07-03 dgarrett@google.com chromeos_config: Move all android-pfq builders to swarming. Created with: gclient setdep -r src/third_party/chromite@da20e836abca The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853969,chromium:853969 TBR=chrome-os-gardeners@chromium.org Change-Id: Ic6cfa31337c5a29b332625f48f0521cd8e5b6e7b Reviewed-on: https://chromium-review.googlesource.com/1124646Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572281}
-
Robbie McElrath authored
This migrates IntranetRedirectDetector from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 859131 Change-Id: Iec4c2f7907066d030d8de11d13ac955a558a2415 Reviewed-on: https://chromium-review.googlesource.com/1123332Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#572280}
-
Theresa authored
Add tests for: * Opening EoC using the toolbar button and tapping a suggestion * Button visibility when entering and exiting the tab switcher * Button visibility when switching tabs BUG=859567 Change-Id: Ib786454fc0f23ead9d6c446e05877e9fb92638e7 Reviewed-on: https://chromium-review.googlesource.com/1123273Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#572279}
-
Dominic Battre authored
Disable LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden when run in servicified network stack but not otherwise. Flakes are caused due to a bug in the servicified network stack, the test seems to work well on other platforms. Bug: 853118 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I02bf111449dd88c24c788d630e8e53f364e03265 Reviewed-on: https://chromium-review.googlesource.com/1123822Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#572278}
-
Brian Sheedy authored
This reverts commit 65c38f54. Reason for revert: Causing DCHECK failures in VR instrumentation tests Original change's description: > GPU: Grow and shrink transfer buffer > > Automatically grow the transfer buffer when it is full and shrink it > when the full capacity is not being used. Allow choosing larger and > smaller sizes than before. > > Before we would only grow it when a single transfer request was larger > than the whole buffer; requests smaller than the whole buffer would just > block if the buffer was full. Also we would not ever shrink the buffer > until someone called Free() manually. > > Bug: 850271, 835353, 828363, 856347 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: If2f2235a1d5297c63663398b37e1e30791347a3e > Reviewed-on: https://chromium-review.googlesource.com/1105505 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572135} TBR=jdarpinian@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I031b30234cdcfbd8a4e48c7ebb6fd23312ec10ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850271, 835353, 828363, 856347, 859952 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1124822Reviewed-by:
-
Egor Pasko authored
Coding against this API has been a 2-day debugging challenge :) I also considered "moving network controller options out of browser_options into finder_options: [1]. Then quickly I was chasing the ideals of unbundling StorySet from WprArchiveInfo in order to make _possible_browser.{SetUp,CleanUp}Environment() to start/stop the WPR server and forwarding. This would have been a better API IMO. On the other hand the refactoring associated with it looked a bit involved. So here it is - re-elly partial solution, to say mildly, which injects a few more tightly-coupled classes into each other to solve one specific problem. Sorry. [1] Mention of http://crbug.com/404771 in shared_page_state.py. The catapult side of it (https://github.com/catapult-project/catapult/issues/1977) was closed, but seems not done yet. Bug: 760498 Change-Id: I44e03179f9f2ed16f8fc1934c9786ef342f83609 Reviewed-on: https://chromium-review.googlesource.com/1122862 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#572276}
-
Theresa authored
BUG=859564 Change-Id: I928bffc0ca099121134c5df8cb2355f7b39738cd Reviewed-on: https://chromium-review.googlesource.com/1124933Reviewed-by:
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I4129f2fa7e0a9162077e6aeb6ded3c1857113638 Reviewed-on: https://chromium-review.googlesource.com/1124666Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572274}
-
Tarun Bansal authored
The WPT tests check the Accept-CH-Lifetime (ACL) header functionality. Add tests for: (i) When ACL header is sent by a same-origin iframe. (ii) When ACL header is sent by a cross-origin iframe. (iii) When ACL header is sent by a subresource. (iv) When ACL header is sent on the main frame. Also, change the ACL persistence time-duration from 20 seconds to 5 seconds to make it easier to run multiple tests quickly and without waiting too long. Change-Id: I31047598bbb1e7c64cadf3e6845bf850c29aca8b Bug: 856700 Reviewed-on: https://chromium-review.googlesource.com/1119848 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#572273}
-
kylechar authored
There is a lot of complexity in InProcessCommandBuffer and the internal Service class makes things more complex. This CL attempts to clean this up a bit. 1. Move InProcessCommandBuffer::Service into it's own file and rename to GpuCommandService. Improve comments and modernize code slightly. 2. Make GpuCommandService a subclass of RefCountedThreadSafe, rather than all of the subclasses of GpuCommandService and then manually forwarding calls to AddRef() and Release(). This was originally done because GpuCommandService was a pure interface, however that is no longer the case. 3. Remove passing around const refs to scoped_refptrs. We can just pass the scoped_refptr by value in these cases. Bug: 832243 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib6dc5212ba71e3645e2649b5db43f2c06fbb14e2 Reviewed-on: https://chromium-review.googlesource.com/1118618 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572272}
-
Aldo Culquicondor authored
When entering presentation mode from 2D browsing, the content's buffer size is not set, and thus VrShellGl uses the wrong buffer size for the dialogs. Bug: 856727 Change-Id: Idf740285739e026a818b44c85fd05b34edfbd17f Reviewed-on: https://chromium-review.googlesource.com/1124864Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#572271}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a8662be. With Chromium commits locally applied on WPT: 98d4a440 "[LayoutNG] Fix hit test clipping by fragmented border with round corner" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20698 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, ksakamoto@chromium.org: external/wpt/css/css-font-loading TBR=markdittmer No-Export: true Change-Id: Ifc94884ef14e91e48af233c7a69a4babd4d3a071 Reviewed-on: https://chromium-review.googlesource.com/1124599 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#572270}
-
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true Change-Id: I889a03d6149f4ea3a90be461f4a97620ae957228 Reviewed-on: https://chromium-review.googlesource.com/1124947Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#572269}
-
Emily Hanley authored
Cleanup of perf_data_generator will be in a follow on CL NOTRY=true Bug: 757933 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I93f2f3f1cbc52e0ef97d578a7b689d7f9201b733 Reviewed-on: https://chromium-review.googlesource.com/1124662 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c56c2429b0f6..24b373394918 git log c56c2429b0f6..24b373394918 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 lalitm@google.com trace_processor: fix BestIndex/Filter calls when using OR constraints Created with: gclient setdep -r src/third_party/perfetto@24b373394918 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I7995b1ad8f88de53e2b5ba13224db5378ef01eb0 Reviewed-on: https://chromium-review.googlesource.com/1124648 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572267}
-
Ned Nguyen authored
This reverts commit 3c6537d8. Reason for revert: block other CL from landing with PRESUBMIT error: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942003279127111280%2F%2B%2Fsteps%2Fpresubmit%2F0%2Fstdout ** Presubmit ERRORS ** Pylint (261 files using ['--disable=cyclic-import'] on 8 cores) (8.11s) failed ************* Module contrib.orderfile.orderfile E:109,20: story_class is not callable (not-callable) W:113,19: Access to a protected member _IterAllSystemHealthStoryClasses of a client class (protected-access) R:144, 0: Too many ancestors (8/7) (too-many-ancestors) R:155, 0: Too many ancestors (8/7) (too-many-ancestors) R:189, 0: Too many ancestors (8/7) (too-many-ancestors) R:194, 0: Too many ancestors (8/7) (too-many-ancestors) R:200, 0: Too many ancestors (8/7) (too-many-ancestors) R:206, 0: Too many ancestors (8/7) (too-many-ancestors) R:212, 0: Too many ancestors (8/7) (too-many-ancestors) R:218, 0: Too many ancestors (8/7) (too-many-ancestors) Presubmit checks took 15.4s to calculate. Original change's description: > Orderfile: training and testing benchmarks. > > These benchmarks will be used to train the new production android orderfile. > > Bug: 843561 > Change-Id: Iea097d784773c98ec3076f297aac16558c2a8104 > Reviewed-on: https://chromium-review.googlesource.com/1124561 > Reviewed-by: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572219} TBR=pasko@chromium.org,lizeb@chromium.org,mattcary@chromium.org Change-Id: I0f22ff64f7532aaa913bb4dbd844be6cfdb7b5ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843561 Reviewed-on: https://chromium-review.googlesource.com/1124702Reviewed-by:
-
Alexei Filippov authored
The test was flaky because of the rounding errors. BUG=856955 Change-Id: I089ff4efa05935433c6f1cd3a89f8cbad26879d5 Reviewed-on: https://chromium-review.googlesource.com/1123768Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#572265}
-
Emily Hanley authored
Bug:855063 NOTRY=true TBR=nednguyen@google.com Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ica527284a240bf2251e2a57c26729c541577aa44 Reviewed-on: https://chromium-review.googlesource.com/1124943Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#572264}
-
Sandra Sun authored
This patch implements snapping for gesture fling on main thread. The ScrollManager would implement SnapFlingClient to collect snap information, schedule animation, and execute the scroll as instructed by SnapFlingController. This patch also updates the interface of SnapCoordinator::GetPositionForPoint() for it to return an Optional FloatPoint, clearly indicating whether there exists a snap point for the current scroll. Bug: 778259 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I196e8c58c238cfad2a96e3f6a1c218f2c4f77a3c Reviewed-on: https://chromium-review.googlesource.com/1083144Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#572263}
-
Michael Spang authored
Implement sync_file export for fences so we can submit fences with planes to DRM atomic. This does not work unless you have a fairly recent kernel (requires syncobj support, I915_EXEC_FENCE_ARRAY). Bug: 851997 Test: ozone_demo on eve with USE=vulkan and kernel 4.14 Change-Id: I5859b64690e9b45ccb95698a9ca096f0847ec51b Reviewed-on: https://chromium-review.googlesource.com/1115570Reviewed-by:
-
Ryan Sleevi authored
SingleTreeTracker currently implements CTVerifier::Observer and STHObserver, exposing OnSCTVerified and OnSTHObserved. However, it's not accessed through either interface - the only interaction with these methods is through the TreeStateTracker, which dispatches calls via a direct pointer to the SingleTreeTracker. Remove the inheritence to make it easier to track the concrete interface implementations. BUG=none Change-Id: I372c803984a8c808914e254e69ec6527c6ec772b Reviewed-on: https://chromium-review.googlesource.com/1123921Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572261}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1448cc11b9be..d77e0ed72f73 git log 1448cc11b9be..d77e0ed72f73 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 tsepez@chromium.org Use more UnownedPtr<> in cfxa_ffpageview 2018-07-03 tsepez@chromium.org Remove XFA_LAYOUT_INVALIDNODE Created with: gclient setdep -r src/third_party/pdfium@d77e0ed72f73 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia1596111eb427a42364528bd3b4dcb6ce1d4e28f Reviewed-on: https://chromium-review.googlesource.com/1124647Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572260}
-
Ken Rockot authored
This CHECK was added to diagnose the leaks covered by https://crbug.com/813045 which are now well understood. No longer needed. TBR=jam@chromium.org Bug: 826432,813045 Change-Id: I691f4c9a4c4cd9bc5b8823cfae2d9c8bc3cfeabe Reviewed-on: https://chromium-review.googlesource.com/1124663Reviewed-by:
-
Yusuf Ozuysal authored
This reverts commit d4fc9d34. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove LayoutTab#mInsetBorderVertical and related logic > > TabLayer::SetProperties() currently has a param, inset_border, that changes the > geometry logic for showing tabs in the tab switcher. Currently, we're always > setting the param to true. We then use it to set another variable: > > const bool inset_toolbar = !inset_border; > > which is always false. This is immediately followed by this check, which always > passes: > > if (!inset_toolbar) {...} > > > In addition to being unnecessary, this param is also extremely > confusing/misleading. We do actually start out with the toolbar inset on top of > the tab thumbnail (before we fade it into the tab title), and we only inset the > top and bottom borders, not the ones on the left and right. > > This CL removes this unnecessary logic. > > Bug: 849401 > Change-Id: I5ccfa35f766baf477837be1d886a2974d0009a54 > Reviewed-on: https://chromium-review.googlesource.com/1114330 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570971} TBR=dtrainor@chromium.org,rlanday@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 849401 Change-Id: I124cce58f105b75164acc05ce6b6cb6831db8a91 Reviewed-on: https://chromium-review.googlesource.com/1124820Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#572258}
-
François Beaufort authored
Updated spec says IDL for requestPictureInPicture and exitPictureInPicture should specify that a new object is returned. https://github.com/WICG/picture-in-picture/pull/76 Bug: 806249 Change-Id: Iba50455ef30c97d87c3e22b9ac95bc4bc41d546d Reviewed-on: https://chromium-review.googlesource.com/1122226Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#572257}
-
Qiyu Hu authored
We don't have to SendCachedPairedDevices() whenever the adapter is up. Android knows how to get all paired devices from adapter properties. SendCachedPairedDevices() will create bogus pair state change to Android. Bug: 78593133 Test: Reboot and confirm that paired devices are still there Change-Id: Ibcb29f3f3abb3ea30c5e9cdd1d13c72e119a1085 Reviewed-on: https://chromium-review.googlesource.com/1120695Reviewed-by:
-
Marc Treib authored
In the past, there was a bug where some themes incorrectly got synced into the EXTENSIONS data type, so we added cleanup code to remove the bad data. That was long ago and all bad data should be long gone now, so let's get rid of the cleanup code. Bug: none Change-Id: I53fcc8ecb208e9fce6565cda70ec57cc960f9b6c Reviewed-on: https://chromium-review.googlesource.com/1124680Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#572255}
-
Sylvain Defresne authored
Add a default member initialization for client_pin_availability_ to prevent use of un-initialized memory (found by MSan). Bug: 859816 Change-Id: I5ab81ee60a6aed657f44a8bee7d094dc14f030b9 Reviewed-on: https://chromium-review.googlesource.com/1123828Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572254}
-
Peter Kvitek authored
Change-Id: I956ea3523eb42b6d7f0cf851a126c6a11578912e Reviewed-on: https://chromium-review.googlesource.com/1121378 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572253}
-
bsheedy authored
Makes several changes to VR tests related to the VR controller: 1. Switches VrShellWebInputEditingTest to use the Chrome-side controller input mocking rather than VrCore controller emulation since the latter was slightly flaky. 2. Adds a null check to VrShellWebInputEditingTest to prevent a rare flake. 3. Remove @Manual from all VrShellDialogTest cases. These are mainly intended for screen diff tests, but do have some value as functional tests. 4. Fix hitting a DCHECK when using Chrome-side input mocking that was caused by some recent controller changes. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic3ccda408f7f531e1b8a78a46bae55858f46dc82 Reviewed-on: https://chromium-review.googlesource.com/1123400Reviewed-by:
-
