- 30 Oct, 2020 40 commits
-
-
James Hollyer authored
Pointer Lock should fail without user gesture. However, the logic which checks that is overridden in in web tests. This adds logic to mimic those checks in the overriding class in order to test that the proper error is routed out. A follow up CL is planned to move the actual logic up in the flow so that the real logic is tested. Bug: 1142136 Change-Id: I9d62ad2df0bde3666fe987ea70131378a605ffba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496191Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#822778}
-
Henrique Nakashima authored
We've been tracking the size of chrome_java_sources.gni, this makes the process automatic and more accurate. Change-Id: Ide6a912cb5a137349885c84bd45c0894ffd41b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508556Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#822777}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/25eb373eede4..5a1d786754ad 2020-10-30 kainino@chromium.org Check for deprecation warnings in ValidationTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I53012496582006b316df190fafcd70cce68c3501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822776}
-
Collin Baker authored
Fixed: 1143461 Change-Id: Ifc5df8a84188e403af6986bf7e5a7d30c4d066ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508909Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822775}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Ie97e2092b0b60d28e00c31e0f7c5c32b92d8de28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510357Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#822774}
-
Andrew Grieve authored
And move checking for embedded configs to after expectations code so that it only runs when actually optimizing (took 300ms on my machine). Bug: None Change-Id: I692a7b54f355783565bca58669829008b3820fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510378Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822773}
-
Alex Moshchuk authored
Previously, the KilledWhileVisible and KilledWhileHiddenThenShown tests relied on sad frame metrics being logged synchronously after a process kill or after a WebContents visibility. Make these tests more robust by explicitly waiting for all sad frames to be shown before checking metrics. This is an attempt to deflake these tests. Additionally, add some explicit expectations around subframe visibility on a shown/hidden a WebContents, to aid debugging in case these tests are still flaky. Bug: 1097060 Change-Id: I05567e9c76f94f32c0f2bbabf47fc2cfa2b013e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509003 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#822772}
-
Kevin Ellis authored
The computation of quaternions during matrix decomposition appeared to be based off of the matrix transpose. Indexing in the quaternion calculation is consistent with row-major ordering; however, the "rows" variable is actually column major order (goes back to the original implementation of unmatrix in Graphics Gems II). The rotation matrix constructed from the quaternions also appeared to be assuming row-major ordering. These discrepancies were mostly corrected for by flipping the direction of the quaternion when extracting from the matrix. This patch cleans up the implementation to avoid implicit coordinate transformations and making the calculations consistent for column-major ordering in the rotation matrix. Additional comments in the code should help prevent similar errors in the future. Combining rotations without a common axis or rotation was needlessly complex, requiring a conversion to matrices, followed by matrix blending and rotation extraction from the resulting matrix. In addition to being computationally expensive, the extra steps reduce numerical stability and introduce orientation artifacts (the quaternions (x,y,z,w) and (-x,-y,-z,-w) are effectively equivalent transformations). The SLERP algorithm in blink::TransformationMatrix and blink::Rotation now directly call gfx::Quaternion::Slerp. The SLERP algorithm contained an error in that it always returned the counterclockwise rotation even if clockwise rotation was shorter. This problem was fixed by flipping the orientation of the first quaternion if the half angle is greater than 90 degrees. This ensures that we take the shortest path. Test expectation were updated for the rotation-composition test. These tests recorded expectations based on Blink's evaluations which where not consistent with the spec. In particular, Blink short-circuits the interpolation process at progress 0 and 1. This leads to boundaries begin left in a non-canonical form (e.g. "1 1 0 45deg" should be normalized to "0.707 0.707 0 45deg"). Furthermore, transforms to and from "none" should be converted to a neutral operator based on its counterpart (e.g none -> rotate 45deg at 0 should be rotate 0deg). One of the tests contained a degenerate case of a 180 degree rotation which is ill defined. This test was updated to avoid the problem. We have unit tests for edge cases to ensure no division-by-zero errors. One non-WPT test was affected. Manually confirmed that the SLERP algorithm was computing a negative value for the scalar component of the quaternion product. This component in fact is the cos of the half angle. Since the value was negative, it implies that the rotation angle was exceeding 180 degrees. We were rotating in the wrong direction. Design doc: https://docs.google.com/document/d/1RUd5Nt-ZUnKt-P6OZEDurx9g60TjfD0gx_iYAMbkAfE/edit?usp=sharing Access via chromium credentials Bug: 998175, 929841 Change-Id: Iaf057eb576aacfd2029342246ac314d783022997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489727Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#822771}
-
Sasidhar Sanapala authored
This code is feature protected. Bug: 170790680 Change-Id: I573b6813d4af1897d323a6599eeab845e1c06ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490671 Commit-Queue: Sasidhar Sanapala <ssanapala@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#822770}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf5f19d0ea8a..6903f467cb0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC thomasanderson@google.com,pmonette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142775,chromium:1143787,chromium:1144005 Tbr: thomasanderson@google.com,pmonette@google.com Change-Id: Ia7124644c2bfa736dee74a74e57321b9269d70ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510090Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822769}
-
Jan Wilken Dörrie authored
This change adds the HAS_CPP_ATTRIBUTE and NO_UNIQUE_ADDRESS macros to base/compiler_specific.h. This allows using the C++20 no_unique_address attribute in prior dialects if the compiler supports it. Bug: None Change-Id: I6aff82e7b195f5eaf93551049c9dfa6a3fd1fbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510396Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#822768}
-
Salvador Guerrero authored
This CL disables the following tests: * org.chromium.weblayer.test.NavigationTest ** testWebResponseCachedWithSniffedMimeType ** testWebResponseCached Because they are flaky on builder: * "Marshmallow 64 bit Tester" TBR=estade@chromium.org Bug: 1144246 Change-Id: I7bd528e78cdab0ee898892d2c3c9f5600749d206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510910 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#822767}
-
Sergey Silkin authored
Bug: 1143697 Change-Id: I2d0bca89575b5fdc2a859538bf9005a22bf5fc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507817 Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#822766}
-
Henrique Nakashima authored
Bug: 1115268 Change-Id: I700c54adf07c1388dc9a4d9b589dc937bec8165e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506121 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#822765}
-
Adam Langley authored
Rather than passing a separate callback into each of the methods that create a Transaction, have the completed signal be a method on the |Platform|. BUG=1002262 Change-Id: Ie63e5ace91177127efa9f84ef49c4412139f13ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500276 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#822764}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/0fabd6dc4222..f9e6f257d1a0 2020-10-30 dpranke@google.com Fix Python3-compat issue in run_mig.py. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112471 Tbr: mseaborn@chromium.org Change-Id: I71fac0d7534b6548bc2ed5e961c7911b058d59b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510433Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1603705354-benchmark-88.0.4306.0-r1 to 88-4296.0-1603705354-benchmark-88.0.4307.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I540ff67b1422641ae5ea37819b39e3571b1f2b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511010Reviewed-by:
-
Leonid Baraz authored
It will now receive public key id from caller (server in prod mode) rather than calculating it locally. This was we avoid any discrepancy between the way it is calculated on the server and on the client. Bug: b:153651358 Change-Id: If1d43e7c86c142ed8be753b14b49976f9f5659ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510609Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#822761}
-
Sam Maier authored
Bug: 1143257 Change-Id: I88d02690152aa3dabeece3d6cd937d1e3f61a1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508329Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Yi Gu authored
Previously there was a race condition between executing Javascript via |ExecJS| and the UKM run loop. This patch moves ExecJS to be after the run loop setup to avoid such race. Bug: 1141862 Change-Id: Ie1c550fde2e84c21676f73a9623c9846081f0165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502749Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822759}
-
Yann Dago authored
Bug: 1143699 Change-Id: Ie55777e4bfc7a77d7160ef8362f291c2f4e2c598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507380 Auto-Submit: Yann Dago <ydago@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#822758}
-
Wei Li authored
Bug: none Change-Id: I5f98be89e8a0735ae5eaeb1295430b3d23b4bbb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508875Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822757}
-
Olivier Yiptong authored
Minor refactor that shortens and clarifies the callback queuing mechanism. Change-Id: Ibebb44009ad7a4091d7df2c25fdcba2f174d0489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506362 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#822756}
-
Hans Wennborg authored
MOZ_Z_deflate: This doesn't exist anymore. Chromium uses Cr_z_ as prefix for zlib functions with external linkage. longest_match: If there is an uninitialized use, we should fix zlib instead of suppressing it. See the last bug below for a similar issue. I'm hoping that if there is indeed an uninitialized use in longest_match, and we have an existing test or fuzzer that hits it, then we can extract a test case from that which also works upstream (I wasn't able to repro based on what's in that referenced bug). Bug: 116277,418383,1137613 Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: Ica7c0356cefcf6beb48d4a956cf9c839d310c880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510332 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#822755}
-
Thomas Lukaszewicz authored
This CL adds the following classes to c/b/ui/views: - WebUIBubbleView A WebView subclass that supports the ShowUI() call from its hosting WebUI. - WebUIBubbleManager Takes a WebUI and GURL and manages the showing / closing of the WebUIBubbleDIalogView and caching of the hosted WebUIBubbleView. Example included in this CL is management of read later's WebUI. - WebUIBubbleDialogView Responsible for hosting the WebView in an anchored Views bubble. Follow up will cleanup existing WebUI bubble code from ui/views/controls/webview and switch Tab Search to use the WebUIBubbleManager. Bug: 1099917 Change-Id: I8a70394fe1718f31727c9a9d2478ea860890bcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501075 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#822754}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4296.0-1603709458-benchmark-88.0.4306.0-r1 to 88-4296.0-1603709458-benchmark-88.0.4307.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I67ed938c9e0e1c871fd6728bd596ac4a4769ef30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510739Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c1ca9469d705..ce4726c3a32b 2020-10-30 tvanderlippe@chromium.org Typecheck media/PlayerPropertiesView.js with TypeScript 2020-10-30 tvanderlippe@chromium.org Typecheck layers/LayersPanel.js with TypeScript 2020-10-30 pfaffe@chromium.org TypeScriptify GutterDiffPlugin 2020-10-30 bmeurer@chromium.org De-duplicate file entries in QuickOpen window. 2020-10-30 tvanderlippe@chromium.org Typecheck lighthouse/LighthouseReportSelector.js with TypeScript 2020-10-30 patrick.brosset@microsoft.com Migrate 3 web_tests to the corresponding unit and e2e tests in frontend 2020-10-30 alexrudenko@chromium.org Emulate unsupported image types 2020-10-30 andoli@chromium.org [ts] Typecheck sources/SourceMapNamesResolver.js with TypeScript 2020-10-30 andoli@chromium.org [ts] Typecheck source_frame/XMLView.js with TypeScript 2020-10-30 andoli@chromium.org Migrate Map.proto.inverse into MapUtilities. 2020-10-30 alexrudenko@chromium.org Roll deps and update protocol definitions 2020-10-30 sigurds@chromium.org [ts] Type-check resources/DatabaseTableView.js with TypeScript 2020-10-30 tvanderlippe@chromium.org Extract Lighthouse ReportRender types into proper exports If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1130556,chromium:1137438 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0b80baaa8fe59a041b8ca305397bc7990edec08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510589Reviewed-by:
-
Sergey Poromov authored
According to the latest UX mocks, another Chrome OS notifications should be shown in the case of screenshots and screen capture that are blocked due to DLP (Data Leak Prevention) restricted content being captured. Also it changes the existed notification that is shown when screenshots are disabled via policy, per new UX guidance. See mocks: https://docs.google.com/presentation/d/1v0GM-lwHCznFJ6hnZlUH37eBOuAkJMw5Q6UnSkcKOgA/edit?hl=en#slide=id.ga41d6e7481_4_0 Bug: 1133324, 1109723 Change-Id: Ie210c107df98dd70ce11d4041e73c18e387a182c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502470Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822751}
-
Jonah Ryan-Davis authored
The Metal backend is mostly GLES3 conformant. We should enable testing on the bots. Bug: angleproject:2634 Bug: angleproject:4235 Change-Id: Ibb251ebc2545edd405de0d4a7641bbfdad010ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508293Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#822750}
-
Salvador Guerrero authored
This CL disables the following tests: * WebViewLayoutTest#testWebViewIncludedStableInterfaces * WebViewLayoutTest#testGlobalInterfaceNoFail * WebViewLayoutTest#testWebViewExcludedInterfaces Because they are flaky on builder: * android-pie-x86-rel TBR=timvolodine@chromium.org Bug: 1144241 Change-Id: I15402e2a0169488c9b7500e3bf938ccb66af9ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510909Reviewed-by:
-
Salvador Guerrero authored
This CL disables the following flaky test: * org.chromium.weblayer.test.MediaRouterTest#testFailStartCancelled Because it's flaky on builder: * android-pie-x86-rel TBR=estade@chromium.org Bug: 1144233 Change-Id: Ic5cb140064e4dc5c31798e93dc9e1d762cf18267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510709Reviewed-by:
-
Matthias Körber authored
Change-Id: I1b90d3ec7dc4a8d7856d661b6f0aa9ef0e454cc3 Bug: 1100231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505760 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#822747}
-
Andrey Zaytsev authored
Privacy elevated on Android: cleaned up the flag and the codepath since this the feature fully launched Bug: 1099233 Change-Id: Iaefe554d4d72536b78d83a6337fe2861978e0c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507650Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#822746}
-
Bartek Nowierski authored
Bug: 1069567 Change-Id: I4491ab3dd122295167dbff7007e865bdd5fa9637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509831 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
I think I have enough context here, and can delegate to others whenever appropriate (and in most cases I'd do so too). (I have ownership in core, modules, platform, common, and public, but in some cases it could help reviewing bigger CLs when they have minor changes in other directories) Feel free to other owners too. R=mkwst@chromium.org,yoavweiss@chromium.org,chrishtr@chromium.org,rbyers@chromium.org Change-Id: I56e1822c5eab4239059c942f013ca18ac38cb9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505332Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822744}
-
Saurabh Nijhara authored
When an update is required as per policy but the device has reached end-of-life or auto update expiration, the policy behaviour is to block user sign after warning time in the policy has expired by showing the update required screen on the login page over the user pods. In such a case, the users of the device cannot delete their data which is a privacy concern. This CL adds UI on the update required screen which can be used to delete all users data on the device. Screenshot of UI - https://screenshot.googleplex.com/5QNGETeyHRSUgVc Bug: 1120090 Change-Id: Ia990457b3befd10f4a34ee2b5f51a9973d85503e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504289 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#822743}
-
Dominique Fauteux-Chapleau authored
This doesn't break tests in other classes since references to legacy protos had already been removed, so this is just a cleanup for code that never runs. Bug: 1103390 Change-Id: I72ae6028002592a1b9981174334c47454b961a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506263Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#822742}
-
Prashant Nevase authored
For few url schemes, the light color scheme is forced as they don't have dark mode theme yet. This was done by calling UpdatePreferredColorSchemesBasedOnURLIfNeeded(). This function gets called from OverrideWebkitPrefs() and OverrideWebPreferencesAfterNavigation(). The prior function sets the prefs preferred color scheme based on IsNightModeEnabled() for Android or native theme scheme for other platforms, but the later function does not set it. This patch now sets preferred color scheme for all platforms at one place in UpdatePreferredColorScheme(). As --force-dark-mode switch works only for preferred color scheme, until dark scheme is detected in page, default background is white which causes flicker once dark content is rendered. However this is a separate issue. Bug: 1137213 Change-Id: I5567149a5644a6d3d30ceabd65fb1f25e1971ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494296Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#822741}
-
Sven Zheng authored
svenzheng@ and bsheedy@ works on the project. It should be easier for them to be able to approve changes for these files. Change-Id: Ie50a5ec2337801b2cb518d0e5d850d5a07f8aa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508251Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822740}
-
Samuel Huang authored
In daignose_bloat.py, class ResourceSizesDiff takes an |apk_name| param at construction, but the value sits around and never gets used. This CL removes the param, and simplifies callers. Bug: 1040645 Change-Id: I8843018e400c3a12ce15178490c03a0a4b415963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510532Reviewed-by:
-
