GitLab

Befort this CL, we would just ignore a VR intent if the VR services were out of
date. In this CL, we show the DOFF, and show the update infobar in 2D.

For DLAs some reason, intenting out to the play store sometimes results in
Android dropping the intent, so we keep the CCT alive if the DON flow is
successful and show the infobar.

Bug: 824524
Change-Id: I2387b270a2e9c18f941e4a433309749f6ef25f87
Reviewed-on: https://chromium-review.googlesource.com/997018Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548798}

As we have all approvals and the feature will fully launch with 66,
enable it by default.

Bug: 794108
Change-Id: I2cc5badc77391ff8bfe56b8653381c3648fd06a7
Reviewed-on: https://chromium-review.googlesource.com/999516Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548797}

This is a reland of 8ce1863f

The last one was reverted for making some tests flaky. That should
be fixed by 661500f0

Original change's description:
> Turn on native notifications by default for Chrome OS.
>
> They're already on by default for Mash. This makes Chrome use the mojo
> ("native") interface for notifications even in non-Mash.
>
> Bug: 578868
> Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b
> Reviewed-on: https://chromium-review.googlesource.com/963518
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544395}

Bug: 578868
Change-Id: I33f5ec5a614e2cd7f0c745944413ea49965b82bf
Reviewed-on: https://chromium-review.googlesource.com/999333Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548796}

It's not used.

Change-Id: I741e8fe3285a43c12e3e1cad1cb1591647c3dc17
Reviewed-on: https://chromium-review.googlesource.com/998753Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548795}

BUG=828979

Change-Id: Ic65fcc0d1928dd07da37666b068e67daa683890c
Reviewed-on: https://chromium-review.googlesource.com/999029Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548794}

Use the domain matching algorithm to determine which content setting
rule could have influenced the creation of a cookie to correctly decide
whether it should be deleted on exit.
This fixes cases where cookies are visible to subdomains or
domains with non-default ports and directly looking up the origin of a
cookie in HostContentSettingsMap doesn't return the right result.

Bug: 775080
Change-Id: If460537cf7a3de0a4a483d58ac1504637d9612be
Reviewed-on: https://chromium-review.googlesource.com/975861Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548793}

These were left in error after moving mhtml_page_notifier.mojom out
of chrome/common/offline_pages.

Bug: 826362

Change-Id: I07204272d67f33858c6113936a3ba88164f24bc0
Reviewed-on: https://chromium-review.googlesource.com/998684Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548792}

This change removes the HTTP auth nib (already unused in these builds) and
all the extension bubble nibs, as well as all the plumbing leading to them.
After this change, mac_views_browser builds always use Views versions of
these dialogs and !mac_views_browser builds always use Cocoa versions.

TBR=rdevlin.cronin@chromium.org

Bug: 825610
Change-Id: I93fd0098826a65b6de453864bfa1243bbfab5ee0
Reviewed-on: https://chromium-review.googlesource.com/997992Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548791}

Bug: 786559
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I463de96ebe15cff88295ab503f9e88840fd23348
Reviewed-on: https://chromium-review.googlesource.com/998542
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548790}

Moving the replaying of redirects and response started notifications for
frames from WebURLLoaderImpl to the ResourceDispatcher. This allows to
provide the actual ResourceResponseHead to
URLLoaderClientImpl::OnReceiveResponse and fixes the bug where IP
address and MIME type would not be reported in ResourceLoadComplete
notifications for frames.

Bug: 826082
Change-Id: I02c90300e0399045e646764cf6a266dd58c0b0b7
Reviewed-on: https://chromium-review.googlesource.com/982733Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548789}

Merge internal change: 191592257

R=rch@chromium.org

Change-Id: I6b18da8eb73506819c8be3853e33715ab3cf62b7
Reviewed-on: https://chromium-review.googlesource.com/999327Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548788}

https://chromium.googlesource.com/angle/angle.git/+log/c3755fc56611..b8e396609624

$ git log c3755fc56..b8e396609 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 jmadill Vulkan: Remove Observer from LineLoopHandler.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Iba6ac177fe134d548f3d23118a785a9e85ff532e
Reviewed-on: https://chromium-review.googlesource.com/998400Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548787}

This is another run of base_bind_rewriter to //content and //storage
that covers the users of newly migrated services, new rewriters that
remove unneeded base::Passed and fix misused BindRepeating.

Change-Id: I1e745d606de85a2843255e30ce7e0352a782aea9
Reviewed-on: https://chromium-review.googlesource.com/999077
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548786}

Using wpt-import in Chromium d2ab45ba.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15385

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org:
  external/wpt/compat
jsbell@chromium.org:
  external/wpt/resources

TBR=lukebjerring

No-Export: true
Change-Id: I4e69a43d8172c38fabb0cf400d31aa592638b15b
Reviewed-on: https://chromium-review.googlesource.com/998543
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548785}

Update Blink's implementation of ReadableStream to
https://streams.spec.whatwg.org/commit-snapshots/37ace3d5f16cbea7aec4a0c80532c95059994d51/

This also updates TransformStream to use CreateReadableStream() instead
of calling the ReadableStream constructor.

Several common operations have become unused and have been removed.

The EXTERNALLY_CONTROLLED flag has been renamed to the slightly more
specific name "BLINK_LOCK_NOTIFICATIONS".

All external/wpt/streams/readable-streams tests now pass, and failing
expectations have been removed.

Most changes were already covered by the web-platform-tests. A new
readable-streams/patched-global.js test verifies that
ReadableStreamTee() does not use the global ReadableStream constructor
or otherwise touch the global object.

BUG=710728

Change-Id: I2b799045f47376adef305f5f88ad106161425b46
Reviewed-on: https://chromium-review.googlesource.com/992077
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548784}

This CL adds a function to generate FormData based on a given
DataAccessor. The CL further uses this function to add a fuzzer for the
code parsing FormData into PasswordForms (on iOS, for now).

Bug: 827945
Change-Id: I910a19b8e54b6383f91476c5c0fd698521d11eb2
Reviewed-on: https://chromium-review.googlesource.com/992496
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548783}

It should be impossible for this toast to show up while in VR as we
intentionally never send long presses for exactly this reason.
However, the toast is still showing up whenever the icon is clicked or
scrolled over, but only on Android N. I've gone through the support
library code, and overridden the long-press handler that shows the toast
and the toast still shows up. I have no idea what's creating the toast
or how to even find that out.

The simplest solution seems to be just clearing the title when we're in
VR, as the toast will never show up then.

Bug: 829151
Change-Id: I9353ffa41ee44e488cc79d44ad6869961e11561f
Reviewed-on: https://chromium-review.googlesource.com/998658Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548782}

Origin must be extracted from the URL before it is passed to
GetPermissionStatusForFrame().

Bug: 750018
Change-Id: Iffffbf4ec516cb1a798c3604333a71d3bdac5e9e
Reviewed-on: https://chromium-review.googlesource.com/998160Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#548781}

The video hole doesn't make practical use of the overlay API. Rather
than pretend to show anything via overlays, just replace the video quad
with a transparent quad.

This also allows the video hole to work with Ozone platforms other than
Cast since the Ozone platform is no longer expected to lie about
supporting the video hole overlay.

Bug: b/74998539
Test: Played video on device
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia9b63f718d16ab8d933221a3ce551dbbf06b5748
Reviewed-on: https://chromium-review.googlesource.com/970910Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548780}

This patch begins using the new AXPosition and AXRange classes in a relatively simple part of the codebase in order to avoid regressions.
It also takes the opportunity to rename AXObject::AXRange to AXSelection in preparation of the use of the new AXSelection class in a subsequent patch.
The C++ Style Guide allows the use of initializer lists {...} when returning from or when calling functions, hence this patch switches to the new style in all the selection related functions. This will make the switch to the new AXSelection class in a subsequent patch easier since a rename at the point of construction will not be needed.
The patch makes some functions that are using the AXRange class not inline because the Style Guide dictates that virtual functions should not be inlined.

R=dmazzoni@chromium.org

Bug: 639340
Change-Id: I8e19986b0937fd6a954dfe1f5631064c5a9c42a2
Reviewed-on: https://chromium-review.googlesource.com/995976Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548779}

In jumbo experiments (jumbo is not yet supported in
chrome/browser/ui) several GetBubbleAnchorView and
GetBubbleAnchorRect functions clashed. They were more or less
identical but there is no obvious place to share them, and even
though they are small, the code gets messier if you inline them.

This patch gives the functions unique names as a preparation
for jumbo support in chrome/browser/ui

Bug: 803406
Change-Id: I104ae7cc961dd867e89e06fe8f18b401b39af549
Reviewed-on: https://chromium-review.googlesource.com/998158Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#548778}

The aria labels for the 'More Actions' buttons will now also give context,
mentioning whether the apply to all passwords or the specific user and
domain.

Bug: 828312
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If94daaa5b6a903b3e0887caea13a2446eef52bfd
Reviewed-on: https://chromium-review.googlesource.com/964330Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548777}

This change puts the toast over content, near the bottom, in a position
just above where a downloading snackbar appears.  It also removes the
linear layout that previously held more than one toast.

BUG=828515

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iab15c457261e9887940c69140c9af607eb18f1cd
Reviewed-on: https://chromium-review.googlesource.com/998404Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548776}

Instead of the proper value that may have many digits and make no sense
to a human.

Bug: 829627
Change-Id: I467354edc416af46de0f1c625e6b890414f8ae6f
Reviewed-on: https://chromium-review.googlesource.com/998915
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548775}

Change the implementation of ArcBackupRestoreEnabled and
ArcLocationServiceEnabled to disallow policy changes after the initial
setup of ARC.

BUG=b:74220823
TEST=Opt in to ARC, ensure settings still applied.

Change-Id: I695cfaf0335faa6eefe96f63e5a5ce41ed9880a2
Reviewed-on: https://chromium-review.googlesource.com/959503
Commit-Queue: Josh Horwich <jhorwich@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548774}

Previously, the |name| of a PerformanceNavigationTiming entry was the initial
URL (the request URL). After this CL, it is the response URL, so for example
a url of the form 'redirect?location=newLoc' will have 'newLoc' as the |name|.

Bug: 797465
Change-Id: Icab53ad8027d066422562c82bcf0354c264fea40
Reviewed-on: https://chromium-review.googlesource.com/996579Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548773}

This is part of the effort to introduce a fuzzer for code parsing
FormData into PasswordForms.

As described in the design linked from https://crbug.com/827945#c2, in
order to create FormData from an arbitrary input string supplied by the
fuzzer framework, a DataAccessor class should be created to wrap turning
the input string into bits, numbers and strings.

This CL adds DataAccessor, including tests (because the contained logic
is not straightforward).

Bug: 827945
Change-Id: Ib7b2fe54d74bc096afa7e8bc8ff72ab68a8c5977
Reviewed-on: https://chromium-review.googlesource.com/992312
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548772}

This reverts commit 8fa7eced.

Reason for revert: HistogramManager.HistogramBucketFields crashes consistently on Win7 Tests (dbg):

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=cronet_unittests&tests=HistogramManager.HistogramBucketFields

First failing run:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68309

Original change's description:
> Enable Cronet tests on desktop platforms.
> 
> - Only initialize global state (e.g. AtExitManager) in non-Debug builds, so that our component-
>   build Debug bots can run cronet_tests.
> - Fix memory leaks in a number of unit-tests.
> - Disable some StaleHostResolver tests under ASAN, since they have leaks
>   that need resolving.
> 
> Bug: 812268, 816705, 829097
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I5084dd578682b2a8c128487c62de12e437e646f3
> Reviewed-on: https://chromium-review.googlesource.com/981787
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Misha Efimov <mef@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548672}

TBR=wez@chromium.org,mef@chromium.org,jbudorick@chromium.org

Change-Id: Ic30729594ae2b1264702c7bb77c971d55e5e9ae9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 812268, 816705, 829097
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/999334Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548771}

This is a reland of f5bbb138

Original change's description:
> Add SubmitFrameMissing mojo call for WebVR/WebXR
> 
> Goal is that we get a clean lifecycle for a functioning WebVR/WebXR
> presentation render loop. It's started by a presenting SendVSync, calls
> GetVSync to schedule the next frame, and is ended by a SubmitFrame
> call. If there was nothing drawn, it uses SubmitFrameMissing instead of the
> usual SubmitFrame/SubmitFrameWithTextureHandle.
> 
> In WebVR 1.1, submitFrame is a JS call, and the app can exit its animation
> loop without calling it. WebXR had an analogous feature where SubmitFrame
> was skipped if the framebuffer wasn't touched by drawing calls. This
> made it hard to tell for the device side if a frame is done or not.
> 
> WebVR 1.1 worked around this by deferring a GetVSync call until after
> SubmitFrame, but this was complex:
> 
> -  // The logic here is a bit subtle. We get called from one of the following
> -  // four contexts:
> -  //
> -  // (a) from requestAnimationFrame if outside an animating context (i.e. the
> -  //     first rAF call from inside a getVRDisplays() promise)
> -  //
> -  // (b) from requestAnimationFrame in an animating context if the JS code
> -  //     calls rAF after submitFrame.
> -  //
> -  // (c) from submitFrame if that is called after rAF.
> -  //
> -  // (d) from ProcessScheduledAnimations if a rAF callback finishes without
> -  //     submitting a frame.
> -  //
> -  // These cases are mutually exclusive which prevents duplicate GetVSync
> -  // calls. Case (a) only applies outside an animating context
> -  // (in_animation_frame_ is false), and (b,c,d) all require an animating
> -  // context. While in an animating context, submitFrame is called either
> -  // before rAF (b), after rAF (c), or not at all (d). If rAF isn't called at
> -  // all, there won't be future frames.
> 
> This CL removes those special cases and just always calls RequestVSync from
> requestAnimationFrame, collapsing cases (a) and (b) into an unconditional call.
> Cases (c) and (d) are now no longer needed and removed.
> 
> The layout tests now check the SubmitFrameMissing call count.
> 
> Also added a check for a WebXR exclusive session ending in the middle of a
> frame. (The layout tests revealed this since OnEndFrame no longer exits early
> on a clean framebuffer.)
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I5722097d421ca9448760e696ea379895a1320199
> Reviewed-on: https://chromium-review.googlesource.com/996614
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Martin Barbella <mbarbella@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Commit-Queue: Klaus Weidner <klausw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548518}

Change-Id: I14b7ac8fc661cfb91a8be2b959d27091007602ee
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/998079Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548770}

This matches NSTextView's behavior by creating a CFString and asking
what Cocoa thinks should happen. This also handles UTF-16 surrogate
pairs, so this change splits that check to the non-Mac code path.

Bug: 826794
Change-Id: I8fce5510e3cd483533699edd1ba33118ce55b44e
Reviewed-on: https://chromium-review.googlesource.com/986475
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548769}

The specs for both WebBlueTooth & WebUSB only require a user
activation during a requestDevice call.  So consuming the activation
(vs just checking) is not a strong requirement.  There was a concern
that "not consuming" could possibly mean multiple choosers for a single
user activation but our browser code already handles the situation
gracefully.  Multiple requests to browser is possible from different
tabs anyway, even with (isolated) consumptions in individual tabs.

Therefore it makes sense to remove the consumption behavior here,
which is not spec-ed anyway.  This would fit our goal of a simple
user activation model ("UserActivationV2" project) which should be
simple enough for cross-browser implementation and for a complete spec.

Bug: 786407
Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b
Reviewed-on: https://chromium-review.googlesource.com/775866Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548768}

Previously, all user events were deleted when Sync was disabled. After
this CL, user consent events are preserved in persistent store. This CL
does *not* include their garbage collection and attempting to send them again.


Bug: 781765
Change-Id: I6fdb7488da81324d782f28745299301b551a712c
Reviewed-on: https://chromium-review.googlesource.com/986514
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548767}

The AutofillAgent can be null in some cases.

BUG=821502

Change-Id: Iada92ce5889643a3eda1d02cb499a16699e73015
Reviewed-on: https://chromium-review.googlesource.com/997797
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548766}

This reverts commit 5e4c7d7b.

Reason for revert: 
Speculative revert for failing base_unittests on Android,
CFIBacktraceAndroidTest.TestUnwinding.

See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579

Original change's description:
> Fix conditions for can_unwind_with_cfi_table with frame pointers
> 
> CFI table unwinder is not appilcable for builds with frame pointer
> enabled. Make sure can_unwind_with_cfi_table is set to false.
> No need to check for use_thin_lto.
> 
> BUG=469376
> 
> Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6
> Reviewed-on: https://chromium-review.googlesource.com/992890
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548634}

TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org

Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 469376,826718
Reviewed-on: https://chromium-review.googlesource.com/999635Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548765}

https://swiftshader.googlesource.com/SwiftShader.git/+log/f8cdc74..1119ce6

BUG=chromium:823096

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I7606c5a8f2ade19639098c752e7f35e6b7f68330
Reviewed-on: https://chromium-review.googlesource.com/999128
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548764}

This CL adds a metrics for the time elapsed between the time the user
taps on a button and the popup menu is presented.

Bug: 829343
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id978bd57ffa93adc0827a7810ca546c8272aded7
Reviewed-on: https://chromium-review.googlesource.com/999476
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548763}

Creation time is no longer unique (not that it ever was);
(domain,path,key) is (as it's long been).

Bug: 826322
Change-Id: I433fe3ceffd2b2cfeb5c27c7af0033d69e76301c
Reviewed-on: https://chromium-review.googlesource.com/984514Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548762}

This makes the testapp rendering code more closely match vr_shell_gl,
alleviating the annoying hover issue (a button may stay hovered even
when the reticle had moved away).

BUG=
R=ymalik

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6b1bd7006c9ff319c177d721a309d82906a69153
Reviewed-on: https://chromium-review.googlesource.com/998740Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548761}

Currently, _CheckUniquePtr is run both on upload and on commit. This
check emits errors, which means commit is blocked if it fires. At the
same time, it has a history of false positives (one mentioned in
https://crrev.com/c/933547, another in https://crbug.com/827961).

Therefore this CL makes _CheckUniquePtr an upload-only check.

Bug: 827961
Change-Id: I6d5a7f3dda33432ae1375359c2ae573e5ad3df34
Reviewed-on: https://chromium-review.googlesource.com/990133Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548760}

The test is timing out on Mac. Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Flayout_ng_experimental%2Fprinting%2Fwebgl-oversized-printing.html&showFlaky=true

TBR=junov@chromium.org
NOTRY=true

Bug: 829804
Change-Id: I0ee14c1e9235222e9690daed12cc489dd81e6a6e
Reviewed-on: https://chromium-review.googlesource.com/999602Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548759}