- 18 Sep, 2020 40 commits
-
-
Ian Kilpatrick authored
Original change description: > This patch ensures that we always have a "consistent" fragment-tree (or > rather a portion of a fragment-tree if we have legacy nodes). > Previously it was possible for a fragment-tree to become inconsistent > whenever we performed layout from a subtree root. Now when we layout > from a node like this, we rebuild the "spine" of the tree. > After this change we'll be able to remove most "PostLayout" calls, > except where they are used for building this "consistent" tree. The first change had two issues. 1) Cloning a part of the fragment tree which had its layout-objects removed from the tree. The fix for this specific issue is to stop re-building the spine of the tree when we encounter an object which needs layout. 2) AbstractInlineTextBox holding a stale pointer to an NGFragmentItem. The fix for this specific issue is to call: DetachAbstractInlineTextBoxesIfNeeded on any NGFragmentItem(s) which have an associated LayoutText. Bug: 1066616 Change-Id: Iade8d4c2e7ae9129863d3b295271da944ffec81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418978Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#808453}
-
Kent Tamura authored
This CL applies LayoutObjectFactory to RangeInputType::CreateLayoutObject() and SliderTrackElement::CreateLayoutObject(). This CL adds LayoutObjectFactory::CreateSliderTrack() for SliderTrackElement. - The function returns LayoutNGBlockFlow for LayoutNG - The constructor of LayoutSliderTrack should take Element*. CreateObject<> requires it. This CL has no behavior changes because RangeInputType::TypeShouldForceLegacyLayout() still returns |true|. Bug: 1040826 Change-Id: Id4ba89f09e5ff16f6b5f1f7d5c477162395beaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419091 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808452}
-
Andrew Grieve authored
This reverts commit f43f03fe. Reason for reland: Added missing "await" Original change's description: > Revert "SuperSize: Fix missing access token for diffs" > > This reverts commit a26b32ce. > > Reason for revert: Missed an "await" > > Original change's description: > > SuperSize: Fix missing access token for diffs > > > > Also: > > * Throws a more explicit exception for failed fetch. > > * Stops setting Cache-Control: no-cache > > > > Bug: None > > Change-Id: I380207b32497f1cb5467ff62bcd3c857dc03ff58 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418799 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#808406} > > TBR=agrieve@chromium.org,mheikal@chromium.org > > Change-Id: I0a264d02d6066034e9eb23c854520c0e1c55672f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: None > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419122 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808441} TBR=agrieve@chromium.org,mheikal@chromium.org # Not skipping CQ checks because this is a reland. Bug: None Change-Id: Ie4ea9ffdaab2cd7c0e23b516fba016e57e3ae6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419123Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808451}
-
Connie Wan authored
Buggy behavior: When moving >=3 tabs in bulk, tabs would get moved farther and farther apart due to this: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/extensions/api/tabs/tabs_api.cc;l=1477;drc=9eb09ede880e6cb9f4d58ff003dcd52815b4a45c (The new_index was already being updated to the actual inserted index at each move). This change is dependent on crrev.com/c/2414994 due to this: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/extensions/api/tabs/tabs_api.cc;l=1471;drc=9eb09ede880e6cb9f4d58ff003dcd52815b4a45c Change-Id: Ib2b61daf56d1b7e4f054cc57b332c4d150e272aa Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414778Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#808450}
-
Michael Hansen authored
This updates the title on the button that opens the device name dialog and removes the label above the text field in the dialog. These changes are to match updated specs in the Nearby Share strings spec. Bug: b:161297140 Change-Id: If77ed7f29cd2ce9f2ae37c810baebfe38688c251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417057Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#808449}
-
Natalie Chouinard authored
This resource override on API 26 does not appear to be necessary anymore. Tested on Android O emulator. More background on b/67327250. Bug: 1129668 Change-Id: I234e42b580f95bcc430353cfec29243c3f69b819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417536Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#808448}
-
Sammie Quon authored
This will help prevent regressions like the one caused by crrev.com/c/2189575. See [1] for more details on the regression. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1125403 Test: merged crrev.com/c/2189575 and test failed Bug: 1129000 Change-Id: Ia2a79fda1553ad0298a064b957e122f2a0e2b962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416734 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#808447}
-
Tom Sepez authored
Replace a boolean enabling javascript with a tri-state enum and plumb through to the appropriate code. No functional change yet introduced. Building with PDF_ENABLE_XFA will still result in a chromium with XFA support fully enabled. We do not yet ship chrome built with this option. Bug: chromium:62400 Change-Id: Idbbc8de6033cf3ed90d3eb3ecbb9a2ef0a32b623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417091 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808446}
-
Daniel Rubery authored
This launch has been rolled out to all Canary/Dev users for a few days, and we don't see any stability impact. Since this code only triggers on a small proportion of downloads from Advanced Protection users (~50,000 users), we don't expect our code paths have actually been executed much in the wild. We can be reasonably confident we aren't causing problems for non-APP users, however. Change-Id: I9a3cf16459d839623ac8417a032dce031cbed798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402134 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#808445}
-
Yulun Wu authored
Bug: 1110766 Change-Id: I9a77bfbdc6c19679d82ea01bfaf25fc70e7483ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416763Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808444}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70026f9d14f0..03fd7930c651 2020-09-18 terelius@webrtc.org Allow more than 2 encoders in RtcEventLogEncoderTest 2020-09-18 yinwa@webrtc.org Minor fixes to avoid crash on some traces that have unexpected data. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id6451d5aa107ccc8cab127d537999b26d7f0dd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418844Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808443}
-
Fabrice de Gans-Riberi authored
This reverts commit bbfe2800. Reason for revert: Broke linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8602 Original change's description: > Roll src-internal from e1e4781e5ec2 to 882abc4519b6 (12 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1e4781e5ec2..882abc4519b6 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC yutak@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1077274,chromium:1099982,chromium:1105693,chromium:1128770,chromium:1129342,chromium:1129402,chromium:1129540 > Tbr: yutak@google.com > Change-Id: Iedb2614fa2100e62b39a54dd82ed657f633955c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417751 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#808211} TBR=yutak@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: Ia170cadaf951bef8e1441ae96456a303552fc367 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1077274 Bug: chromium:1099982 Bug: chromium:1105693 Bug: chromium:1128770 Bug: chromium:1129342 Bug: chromium:1129402 Bug: chromium:1129540 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419004Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808442}
-
Andrew Grieve authored
This reverts commit a26b32ce. Reason for revert: Missed an "await" Original change's description: > SuperSize: Fix missing access token for diffs > > Also: > * Throws a more explicit exception for failed fetch. > * Stops setting Cache-Control: no-cache > > Bug: None > Change-Id: I380207b32497f1cb5467ff62bcd3c857dc03ff58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418799 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808406} TBR=agrieve@chromium.org,mheikal@chromium.org Change-Id: I0a264d02d6066034e9eb23c854520c0e1c55672f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419122Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808441}
-
Fabrice de Gans-Riberi authored
This reverts commit 7fc5d2f9. Reason for revert: Broke win-archive-rel https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17696 Original change's description: > Make expand_owners use dirmd/metadata if available > > Fix tests that were pre-broken > > Bug: 1102997 > Change-Id: Ice303cf2ab3f382ad6e0345b355aaa3e214d209a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388950 > Commit-Queue: Anthony Polito <apolito@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808432} TBR=asvitkine@chromium.org,caitlinfischer@google.com,apolito@google.com Change-Id: Ie2f203e72377545c179d0713fd604f5ffb67af7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419137Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808440}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009180800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/RzU2bbtCMDN7rttn_IQQP4tZXDULinq6V7viaVaFnQwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159892033,b/159901790 Tbr: media-app@grotations.appspotmail.com Change-Id: I0977a1bad62daf42eb2ff904d2e02349a0384f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418840Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808439}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/913c13b2757b..eed20333dd52 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingPresets.js with TypeScript 2020-09-18 andoli@chromium.org [ts] Typecheck cookie_table/CookiesTable.js with TypeScript 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingManager.js with TypeScript 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/NetworkThrottlingSelector.js with TypeScript 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/NetworkPanelIndicator.js with TypeScript 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/MobileThrottlingSelector.js with TypeScript 2020-09-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I32e0425beb7548342011553f3171eb35e3debd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418834Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808438}
-
Benoit Lize authored
There can be only one thread cache enabled at a time. Enable it for the FastMalloc() partition when DCHECK_IS_ON() and PartitionAlloc is not malloc(). This is DCHECK_IS_ON() only, as the lack of thread cache purge can increase overall memory usage. It is not used for PartitionAlloc-Everywhere builds, as there can only be a single thread cache partition, which is already claimed for PA-E builds. Bug: 998048 Change-Id: Iaff0164d0e14ec290b19e050c7911aecbf678448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416292 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#808437}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/236701a9c910..9bc5783e698d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gujen@google.com,fdegans@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1109276 Tbr: gujen@google.com,fdegans@google.com Change-Id: Iac6053afc3663baa1630c24619cc9d2a6cd42187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418846Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808436}
-
Bryan Bernhart authored
Fixes the mismatch by adding a helper DXGIFormatToVizFormat to ensure the format matches transferable resource and also adjusts the size based off sub-sampling factors. This reverts commit 90cc64e6. Original change's description: > Use shared images with DX11 video decoder > > This change enables support for SkiaRenderer. In a future change, > GLRenderer will also be supported. > > Change-Id: I760013fdd163dcec3e3fe5d888541f07849749c7 > Bug: 1011555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250890 > Auto-Submit: Bryan Bernhart <bryan.bernhart@intel.com> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794763} Fixed: 1119666 Change-Id: I24556ab91d6037245bc5f1dad73678dc7ab71bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369578 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#808435}
-
Zhaoliang Ma authored
This CL move the ContextGL to a member function of VideoResourceUpdater. Bug: None Change-Id: I0032cd5c766d6c0f3d798b8ca60259bf66d3057e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415671 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808434}
-
Benoit Lize authored
Also fix `git cl lint` warnings. Change-Id: Ibdd0d2337b576efe8b255e39efd3d78ce070d191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410483Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808433}
-
Anthony Polito authored
Fix tests that were pre-broken Bug: 1102997 Change-Id: Ice303cf2ab3f382ad6e0345b355aaa3e214d209a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388950 Commit-Queue: Anthony Polito <apolito@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#808432}
-
Maria Kazinova authored
Stopped ignoring forms that do not have a <form> tag in provisional password save infrastructure. This allows submission detection on navigating the main frame and iframe detachment to work for such forms. Change-Id: I0ddf885532045ce52d05c0d2c508bafa96b55ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414235 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808431}
-
Martin Kreichgauer authored
This reverts commit 5640f6c5. Reason for revert: breaks PIN entry in some cases (crbug.com/1129713) Original change's description: > device/fido: add a cache for authenticator ECDH keys. > > While, at the moment, I don't believe we will end up asking for the > authenticator's ECDH key twice, when we support the PRF extension we > could. Thus add a cache and skip asking an authenticator for it twice. > > Change-Id: I73ecaa38447cbbe04f34c12d83f9c79bca553c90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255208 > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: Adam Langley <agl@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#781110} Change-Id: Ief5dd139f1221b8bfbe58a6edf2390a022971538 Bug: 1129713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418852Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#808430}
-
Haiyang Pan authored
Most of test suites will be run in MM-x86-rel-non-cq MM-x86-rel will run only chrome_public_test_apk since it fails very often. And have it run on 4-cores to evaluate capacity Bug: 997376, 1127110 Change-Id: I57cd561600a28fcf21e440b167729a02ccd13909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415141 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808429}
-
Azhara Assanova authored
Adds a log to see how users interact with hide crash button. Bug: 1059944 Test: Manual - locally add Log.i() calls and verify this works correctly Change-Id: I6d3631ceeea2c46e7db771a961522bf70236b959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414274Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Azhara Assanova <azharaa@google.com> Auto-Submit: Azhara Assanova <azharaa@google.com> Cr-Commit-Position: refs/heads/master@{#808428}
-
Geoff Lang authored
The block size requirement for each mip level meant that all DXT textures had to be POT sized. Relax these restrictions for non-zero mip levels to allow NPOT DXT textures. Bug: angleproject:4841 Change-Id: I6d5cde0c9eec220d9d82a73fc069743d3a934746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416748Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808427}
-
Abigail Klein authored
loaded. AX-Relnotes: Give feedback when the accessibility tree has loaded on the chrome:accessibility page. Bug: 1082502 Change-Id: I4acacca12ed56b7e50af31c789aac300d939b845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418973Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#808426}
-
Alice Wang authored
This CL adds and records the metric StartedGuestSession when user opens incognito tab in the web sign-in flow. Bug: 1127841 Change-Id: I58b01077089f6cbf949719ba699c06d65bb7cb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418095 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808425}
-
Claude van der Merwe authored
Add wifi sync and phonehub multidevice features to proximity-auth webui for logging. Bug: 1117619, 1106937 Change-Id: Ibabda5a2d53642ece09fa070f49059cfb5f628b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418565Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#808424}
-
Olivier Robin authored
This CL adds a breakdown of the connection type as 2G/3G/4G. Previously, only 3G was reported. Change-Id: I4e80eb6d568e2ff56450ebd979e5461f5f4a035c Bug: 1128867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412310 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808423}
-
Victor-Gabriel Savu authored
It was replaced by Cryptohome.FreeDiskSpaceTotalTime2 since crrev.com/c/1955412 . Bug: None Change-Id: I7e567c4e204e77b6e36a80315b853bbc0d2480f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416277Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#808422}
-
Fredrik Söderqvist authored
* fO with composited descendant under other fO. * gBCR on fO and fO descendant. Bug: 738022, 848693, 976224, 1066421, 1111779 Change-Id: I0ea5e23ec4466fc206acdc60e04ae8582c587bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419011 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#808421}
-
Muyao Xu authored
AudioDeviceEntryView is changed to be a sub-class of HoverButton. Changed button colors and added ink drop effects in Cast/AudioDeviceEntryView. Bug: b/161610050, 1107162 Change-Id: If91d5041cbf81954bd2a3c9a8b5fd79fe3fdf22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387204 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#808420}
-
rbpotter authored
These statements are no longer needed since Print Preview uses preprocess_grit to generate rollup input. Bug: 1128583 Change-Id: I9a513f6bdcc972bbfd823c39117634766b650b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414703Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808419}
-
Ioana Pandele authored
This reverts commit 1f9b9db0. Reason for revert: The test failure was caused by the new button pushing list items off screen. The fix for this and other related test cases is at: crrev.com/c/2418672 Original change's description: > Revert "Add field trial testing config for password and safety check" > > This reverts commit 2346288a. > > Reason for revert: Suspected cause of failures of password related tests (testSelectedStoredPasswordIndexIsSameAsInShowPasswordEntryEditingView) on android-marshmallow-x86-rel and others: > > https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1349 > > Original change's description: > > Add field trial testing config for password and safety check > > > > Make sure that tests which were not meant for Safety Check explicitly > > disable the feature. > > > > Bug: 1070620, 1092444 > > Change-Id: I83ba782b73cff33f6b4b6f5afa0df9d9e4db2fd6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410866 > > Auto-Submit: Ioana Pandele <ioanap@chromium.org> > > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > > Reviewed-by: Mark Pearson <mpearson@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#807803} > > TBR=mpearson@chromium.org,ioanap@chromium.org,chouinard@chromium.org > > Change-Id: Ia51936bc2889d9fc9a8423f8d3c3186358fb045d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1070620 > Bug: 1092444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416930 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807928} TBR=mpearson@chromium.org,mdjones@chromium.org,ioanap@chromium.org,chouinard@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1070620 Bug: 1092444 Change-Id: I8ffe45012305e47bbc36c1972e17e28c54e0c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418405Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#808418}
-
Xing Liu authored
Add the file size metric when the user select to download later. Add the download later choice metric with data reduction proxy turned on or off. Bug: 1128007 Change-Id: Ia31314fa5642f3fbc90f8e218e6549a69ca32b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416765Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808417}
-
Chris Hamilton authored
Currently the existence of an RTCPeerConnection in a LocalDOMWindow prevents that context from being throttled. RTCPeerConnection objects are used in fingerprinting libraries (typically for the IP information that the ICE exploration yields), but not subsequently actually used to send any data. This prevents these contexts from being throttled. It has been observed that these same fingerprinting libraries add RTCDataChannels to the RTCPeerConnection, and these channels stay forever in the 'connecting' state and never transition to 'open'. To allow the context to be throttled this CL modifies the logic to only notify the scheduler once the RTCPeerConnection is supplemented with an 'open' RTCDataChannel or a 'live' MediaStreamTrack, which indicates with much higher likelihood that actual data will be sent. The feature handle is removed when RTCDataChannel or MediaStreamTrack transition to readyState == 'closed'. BUG=1127481,1075553,1101731 Change-Id: I9d07992da717a9e36eb004a7af27c4b72f9ea08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406685Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#808416}
-
Tom Sepez authored
No functional change to shipping chrome, but avoid linking in some dead code should some third-party build chromium with the GN arg pdf_enable_v8 = false. Change-Id: Ib96547b7632bafc3aca992d903b24d4d1a348608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416850 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808415}
-
Wenyu Fu authored
Currently shadow is only listening to scrolling behavior for ScrollingView, but didn't handled the view changes. This fix will update the shadow view visibility #onGlobalLayout. Bug: 1127816 Change-Id: I3a0b04bfb077d543fa0b41a9ece7890e5198d77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416565 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#808414}
-