- 14 Sep, 2020 40 commits
-
-
arthursonzogni authored
render_frame_host->is_mhtml_document() became false after a same-document navigation, which is wrong. This is fixed by here. R=acolwell@chromium.org,nasko@chromium.org TBR=nasko@chromium.org Bug: 1126391 Change-Id: Ie473c396ea9769356c39d8eee1d1915c0a136807 Fixed: 1126391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404340Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806665}
-
Anthony Cui authored
Revert "Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu" This reverts commit 24c91f76. Reason for revert: Resulting browser process crashes Original change's description: > Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu > > Consolidated logic by having RenderViewContextMenu::ExecTranslate call > TranslateManager::InitiateManualTranslation, and RenderViewContextMenu::AppendPageItems call > TranslateManager:CanManuallyTranslate. > > Bug: 898168 > Change-Id: If91cf98626f73d0c357522f8fdca840695185bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385636 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Megan Jablonski <megjablon@chromium.org> > Commit-Queue: Anthony Cui <cuianthony@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806161} TBR=avi@chromium.org,sclittle@chromium.org,megjablon@chromium.org,cuianthony@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 898168 Change-Id: I23e202b72625365eedcd124af000c972ced3f816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409140Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#806664}
-
dpapad authored
Bug: 1123202 Change-Id: I0c766d95e62059f815cbec907d8703c522963150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409218 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806663}
-
Lijin Shen authored
Remove an used dep of the tests of DefaultBrowserPromo. Bug: 1090103 Change-Id: I49c9cdc88bd773cd47a48b877227c307354c39a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408875 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Auto-Submit: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#806662}
-
Liquan (Max) Gu authored
Change: * Inline onMinimalUiDismissed() and onMinimalUiErroredAndClosed() as they are just one-liners, Bug: 1108099 Change-Id: I77097396926519566dd4e2ac778818f4d6ba990d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404752 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#806661}
-
Philip Rogers authored
This metric is still useful and I track it on a weekly basis. Bug: 1125785 Change-Id: I328f51b59b907135f7d56fadd44cc4c0ff3634b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408732Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#806660}
-
jongdeok.kim authored
In this CL, all effect node that is affected by backdrop filter is marked. So that the layer can find the LCD text disallowed reason for the backdrop filter. Bug: 1115564 Change-Id: Iad23ca619d21d7436786fe9d6e112a198ca638d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404908 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806659}
-
Avi Drissman authored
This reverts commit 249ce21a. Reason for revert: Suspicion of breaking 30-odd accessibility tests (DumpAccessibilityEventsTest.*, DumpAccessibilityTreeTest.*) starting with https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15793 https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25463 Original change's description: > [Ash] Simplify accessibility tray view > > After refactoring of AccessibilityControllerImpl, we can finally > leverage that modularity by removing tons of identical calls. > > Bug: 2390184 > Change-Id: I1c42bff577a844af80584ba6acd8da81e7b9b704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398687 > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806594} TBR=xiyuan@chromium.org,apotapchuk@chromium.org Change-Id: Iaee9d02267fd87eabc94930da410ff870079282c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 2390184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410341Reviewed-by:
-
Elly Fong-Jones authored
This dialog is shown on the winlogon desktop to prompt for Google credentials to use for Windows login. It appears in testing to still work properly when window-modal. Bug: 1121132 Change-Id: Ibb611ef58fafb14948f79173211e29eddf678584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405701Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#806657}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71d7c8e3cdd6..8452ea86c5cb 2020-09-14 mirtad@webrtc.org Synchronize modifications to frame_extra_info_ in jni::VideoEncoderWrapper. 2020-09-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1b3e75b8..ff96bd07 (806461:806570) 2020-09-14 philipel@webrtc.org Removed old OnDecodedFrame callback. 2020-09-14 nisse@webrtc.org Fix standard GetStats to not modify NetEq state. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I711888b2bae340570af11f86b8c9d9607edacf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806656}
-
Filip Gorski authored
This reverts commit d4e7ee66. Reason for revert: Broke Lollipop Phone Tester tests. See below link for details. https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/26949 Original change's description: > Reland "base/allocator: Add a thread cache to PartitionAlloc." > > Changes: disabled the thread cache on Windows. > > Original change's description: > > base/allocator: Add a thread cache to PartitionAlloc. > > > > This CL adds a thread cache to PartitionAlloc. It is optional, only > > applies to thread-safe partitions, and uses the same freelist encoding > > and bucketing as the main allocator. > > > > The thread cache is added "in the middle" of the main allocator, that is: > > - After all the cookie/tag management > > - Before the "raw" allocator. > > > > That is, the general allocation flow is: > > 1. Adjustment of requested size to make room for tags / cookies > > 2. Allocation: > > a. Call to the thread cache, if it succeeds, return. > > b. Otherwise, call the "raw" allocator <-- Locking > > 3. Handle cookies/tags, zero allocation if required > > > > On the deallocation side, the process is reversed: > > 1. Check cookies / tags, adjust the pointer > > 2. Deallocation > > a. Return to the thread cache of possible. If it succeeds, return. > > b. Otherwise, call the "raw" allocator <-- Locking > > > > The thread cache maintains an array of buckets, the same as the parent > > allocator. A single thread cache instance is only used by a single > > partition. Each bucket is a linked list of allocations, capped to a set > > maximum size. Elements in this "freelist" are encoded the same way they > > are for the main allocator. > > Only the smallest buckets are eligible for caching, to reduce the > > memory impact. > > > > There are several limitations: > > - Only a single partition is allowed to have a thread cache > > - No periodic purging of thread caches is done > > - No statistics are collected > > > > The last two limitations will be addressed in subsequent CLs. Regarding > > the first one, it is not possible to use Chrome's native thread local > > storage support, as it allocates. It is also desirable to use > > thread_local to improve performance. > > > > Bug: 998048 > > Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805697} > > Bug: 998048 > Change-Id: I23b70f6964bb297502921d1a08bf128d9093d577 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404849 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806597} TBR=haraken@chromium.org,lizeb@chromium.org Change-Id: Iedf9f99609ccd57e1a0754c8dfd8cda3a5f85539 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410422Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#806655}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc7fafa8. With Chromium commits locally applied on WPT: efd3138b "[mathml] Make math display values on non-MathML elements compute to flow" 077d63da "[blink] Fix top-level-await error reporting" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I55de6132fd06476528335fa74a44914cdf55cc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409918Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806654}
-
Xi Han authored
Bug: 1091507 Change-Id: I29a291ee7a9db36a665bf0663c27f08b876486ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406684Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806653}
-
Ehimare Okoyomon authored
Screenshots: https://crbug.com/1077766#c38 Bug: 1077766 Change-Id: I15d2d7c6ccf229f69e5ab7ed30e50d229dac786a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396075 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#806652}
-
Rohit Agarwal authored
LocationBarModel. This CL returns a non primary OTR profile when mTab is null for LocationBarModel#getProfile. This CL also adds tests. Bug: 1127695 Change-Id: I2aa2e63229826e50e1602630d6fef2e6197395a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409298Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#806651}
-
Friedrich Horschig authored
By using paddings instead of margins (and adding a symmetric bottom padding), the touch target size increases as demanded by mocks). Screenshot in the bug. Bug: 1109727 Change-Id: I0cab8af44002fe2c9978ed770e7678d73d87e6e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409959Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#806650}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9edd1a906f57..bef393a5a340 2020-09-14 lalitm@google.com Merge "tools: replace \ with _ in include guard as well" 2020-09-14 treehugger-gerrit@google.com Merge "Displaying Flow Events in the UI" 2020-09-14 lalitm@google.com Merge "gn: make generate_descriptor consistent between chrome and standalone" 2020-09-11 treehugger-gerrit@google.com Merge "chrome_config: Add client priority setting" 2020-09-11 fmayer@google.com Merge "Check whether all allocations are sampled for accurate test." 2020-09-11 hjd@google.com Merge "ui: Fix build dependencies" 2020-09-11 lalitm@google.com Merge "tp: add missing array header" 2020-09-11 lalitm@google.com Merge "as_pandas() -> as_pandas_dataframe(); add __str__ representation" 2020-09-11 lalitm@google.com Merge "tp: move metrics descriptor generation to build time" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1287524252c58e915bf0b4233eaa683a38c33bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408970Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I504a5b2aa41ee1db66b84162e0938552544cce62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410024Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806648}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: Id1340e7ec64d65905152a1588fbda307fa38f884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410237Reviewed-by:
-
Glen Robertson authored
These targets fail to build or link if depended upon without `enable_rlz_support`. It is a stronger and more relevant condition than `!is_android`, see: rlz/buildflags/buildflags.gni Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: Ie675921f61c626eb9a8808df335bc88f309ea31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409073 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
Chris Lu authored
Updates the illustration image. The modal will now be a form sheet presentation, making it smaller. The bottom button will not be padded on the bottom with the layoutMargin's bottom value so that the button is slightly closer to the edge. This will give the buttons and content more space. Popovers width will be capped at 300pt so that they will fit a more square shape for iPads. Bug: 1107489 Change-Id: I0d8f400ef8e249f9c5ea3d6b0c4ab939282a3a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405540 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#806645}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600062449-eb397872f2f81f98b45c4ec794b206b9a087897d.profdata to chrome-mac-master-1600084447-6a3b264d40de14a9dcaaf57db5d6240ab2f7fff3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I76a585b661f5347dc81d20149072dc707142409a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410197Reviewed-by:
-
Steven Bingler authored
These tests fail when Schemeful Same-Site is active due to them using an HTTP top-level with HTTPS subresources. Because none of the tests appear to require an insecure top-level site to test their assumptions, change them to use HTTPS instead which avoids the issue. Bug: 1127348 Change-Id: Ic3d7f7c87b683ab4506203e679a6bb6ba3d0e1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404805Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#806643}
-
Stepan Khapugin authored
Adds a per-scene incognito blocker. Removes the old blocker. The new blocker is implemented as a scene agent that monitors the scene for state changes and checks a new SceneState flag |incognitoContentVisible| that was previously owned by SceneController. Removes old tests and adds new ones. Uses window ordering by windowLevel instead of keyWindow, which is actually possible even before scene startup. especially with full-screen video in an incognito tab. Fixed: 1125969 Test: on iOS 12, 13, 14 devices test that the incognito blocker works, Change-Id: I3192908c61fecc7d548383dab4d068a05f4c3ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404855 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
This reverts commit 8668ae66. Reason for revert: Fixing build error on Android builder starting on https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/221587. !!!! Skipping CQ because Android build on perf waterfall has been failing for 2 days. Original change's description: > Revert "Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision)" > > This reverts commit 608a0e43. > > Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that. > > Original change's description: > > Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision) > > > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bb03bb4b22d..44c9ca6a2c0e > > > > If this roll has caused a breakage, revert this CL and stop the roller > > using the controls here: > > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > > Please CC orphis@google.com on the revert to ensure that a human > > is aware of the problem. > > > > To report a problem with the AutoRoller itself, please file a bug: > > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > > > Documentation for the AutoRoller is here: > > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > > Bug: chromium:1040645 > > Tbr: orphis@google.com > > Change-Id: I586d0a124bb943405b379d527767540d5730141e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405975 > > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#806112} > > TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com > > Change-Id: I55721462acc6cdeb5da2584ae493d1e119072c3c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1040645 > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406521 > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> > Cr-Commit-Position: refs/heads/master@{#806329} TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1040645 Change-Id: I00393b7a94df4eae2c5e31ee5f74979785deaf41 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410438Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#806641}
-
Tamir Duberstein authored
This test still fails on Fuchsia, but this should produce better errors. Bug: 1127298 Change-Id: I9c6d18ad1ce863814628d052031b932c53fb9ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408399Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#806640}
-
Wenbin Zhang authored
This reverts commit 407e6843. Reason for revert: Fixing build error on Android builder starting on https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/221587. Original change's description: > Revert "Roll src-internal from 7214110d995d to 4bb03bb4b22d (2 revisions)" > > This reverts commit c8b2d7b0. > > Reason for revert: Android builders on perf waterfall started failing from this CL. > > Original change's description: > > Roll src-internal from 7214110d995d to 4bb03bb4b22d (2 revisions) > > > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7214110d995d..4bb03bb4b22d > > > > If this roll has caused a breakage, revert this CL and stop the roller > > using the controls here: > > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > > Please CC rakina@google.com on the revert to ensure that a human > > is aware of the problem. > > > > To report a problem with the AutoRoller itself, please file a bug: > > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > > > Documentation for the AutoRoller is here: > > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > > Bug: chromium:816629 > > Tbr: rakina@google.com > > Change-Id: I39fc271d42e249d7084a884043433b66ee355278 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404674 > > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#806087} > > TBR=rakina@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com > > Change-Id: Icb635758b167278d7bf04255d693f1de619d3f84 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:816629 > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405946 > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> > Cr-Commit-Position: refs/heads/master@{#806332} TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:816629 Change-Id: Ia641881803779597e9a66721e0182901a206a1c6 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410418Reviewed-by:
-
Liquan (Max) Gu authored
Change: * For close() and closeUIAndDestroyNativeObjects() called together, remove closeUIAndDestroyNativeObjects() because close() already has it. * Move PR UI (non-minimal UI)'s complete handling (#onComplete in particular) out of closeUIAndDestroyNativeObjects(), because #onComplete is supposed to be called only in response to PR#complete(). Bug: 1102522 Change-Id: I68c1e7027219790f105fe5c46deee2168a2a674a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404397 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806638}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Icfd2199eddc1966d0cd88cdfb129e62686521e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408886Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#806637}
-
Sylvain Defresne authored
https://crrev.com/c/2315695 added `is_apple` variable defined as `is_ios || is_mac` and converted usages of this pattern, but the conversion missed the negative form. Convert `!is_ios && !is_mac` to `!is_apple` as a followup. Bug: 1105907 Change-Id: Iae063a2cbb89a7d545958b5bbeebac48bac9ec0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410021 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#806636}
-
Jan Wilken Dörrie authored
This change replaces existing usages of std::{all,any,none}_of in password manager and autofill code with their base::ranges equivalents. Change-Id: If2ff0b71f00bdced18d0354baa5bafdf49eb2452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404347Reviewed-by:Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#806635}
-
Alexander Surkov authored
Change-Id: I6a9c8debc188d8bdde097cc2515a25eef6992dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405415 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806634}
-
Colin Blundell authored
This CL adds the ability to override the target language used by the translate feature on a per-Tab basis. This is analogous to the functionality of CCT's TRANSLATE_LANGUAGE intent extra. Once the override is set, all translate infobars in the given Tab will appear with the specified language as the target language. Calling Tab#setTranslateTargetLanguage() with an empty string clears the override and causes behavior to revert to normal. Note that even with the override set the translate infobar will not appear for pages that are in the user's locale. This is internal behavior of Chromium's translate component and is common to CCT and WebLayer. I marked the added method as since 86 as this CL will be targeted for cherrypicking to 86. Bug: 1116394 Change-Id: Ic4f08c16a64a3f0ceebed5feab7cdc9401001279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397716Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806633}
-
Etienne Pierre-doray authored
Now that it's deprecated in v8. Bug: 1114823 Change-Id: Id184f3c100a1b5d02e9ce31e3164de71eefd94d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405569Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#806632}
-
Clovis PJ authored
Change-Id: I0f72337a6007260044e443ef2b4e4a90a0947b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395737Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Clovis PJ <clovispj@google.com> Cr-Commit-Position: refs/heads/master@{#806631}
-
Bo Liu authored
Weblayer resize may be caused by client in which case keeping the page interactive is more important than showing gutters. This CL adds a heuristic to detect surface resize due to a rotation. Then add plumbing for a surface resize to supply a deadline override, and override the deadline to 0 for non-rotation resizes. There are two resize heuristics: If activity is recreated, we already have code to detect this case in BrowserImpl, and just pass it into ContentViewRenderView when it's recreated. If activity handles rotation, it's detected by the DisplayAndroidObserver which appears to always happens before the resize. This CL does not change non-weblayer products. Bug: 1126706 Change-Id: Iac6cd90f159765fc8a56a9a766130851bd6177b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402289 Auto-Submit: Bo <boliu@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Robert Flack authored
Bug: None Change-Id: Id47626c66cd4f1f2ac37cea3c273eebb303b5bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403880Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#806629}
-
Scott Violet authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/2225548 I removed an override of onScrollOffsetOrExtentChanged. It turns out the code was relying on this to be called when the scale factor changed so that the zoom-controls could be updated. The fix is to update the zoom-controls when the scale factor changes. BUG=1116921 TEST=see bug Change-Id: Iea87c23e9ea0e6b5934ee568f668388dde489ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405645Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#806628}
-
Arthur Sonzogni authored
This reverts commit 0f8373b2. Reason for revert: The cause of the regression is: https://chromium-review.googlesource.com/c/chromium/src/+/2385929 The test was working correctly, it detected regressions. Original change's description: > sheriff: Disable AwContentsTest#testCreateLoadDestroyManyAtOnce > > The test causes webview to crash. It has to be disable until the cause > off the crash is found. > > TBR=timvolodine@chromium.org > > Bug: 1073077 > Change-Id: I66fb484ad23d33754b5ab841abd4826d3a289b07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409977 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806609} TBR=timvolodine@chromium.org,arthursonzogni@chromium.org Change-Id: If94228d7e8cd44da735a16385a83f78659590ef4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409961Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600062449-3179a4da9bad3e513a066b6120519028fcbec2a4.profdata to chrome-linux-master-1600084447-654ce493c2d2b8d13e6243ff3cb852a603e3ef72.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I975e40916af0ccad4f64920ba824ccb679437907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410013Reviewed-by:
-
