- 28 Jan, 2019 40 commits
-
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 925652 Change-Id: I93fc68a67fcc5df2c1547465fe5bed33eeb2868e Reviewed-on: https://chromium-review.googlesource.com/c/1437826 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626477}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 925652 Change-Id: Ic9d36d670eb64d6e13c89f2d9b785715752b6428 Reviewed-on: https://chromium-review.googlesource.com/c/1437350 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#626476}
-
Marc Treib authored
TBRing trivial test call site updates TBR=sebsg,vasilii Bug: none Change-Id: I555fb199aa9fd7391dcd557659e19f7cd1edc1a1 Reviewed-on: https://chromium-review.googlesource.com/c/1436237 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#626475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d1214aeb988..834c3ddbba12 Created with: gclient setdep -r src-internal@834c3ddbba12 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If1d60b6c44326b0f36f8750a96ab5959b0b59233 Reviewed-on: https://chromium-review.googlesource.com/c/1438878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626474}
-
Gauthier Ambard authored
This CL reorganizes the Settings directory, moving the Clear Browsing Data files to their own directory as the directory has too many files. Bug: 925357 Change-Id: I29533c3ea27c98b59ac95e6064eff6a55de173de Reviewed-on: https://chromium-review.googlesource.com/c/1437178 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#626473}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/media/webrtc/webrtc_event_log_manager_common_unittest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 925652 Change-Id: I9e896043df954dc48b883eb78b1f0bbe6ab97558 Reviewed-on: https://chromium-review.googlesource.com/c/1437832 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL splits EmbeddedSharedWorkerStub::WorkerScriptLoaded() into WorkerScriptLoaded() and WorkerScriptEvaluated(), and make them called in appropriate places. Before this CL, WorkerScriptLoaded() is called after EvaluateClassicScript(). This is strange. Literally WorkerScriptLoaded() should be called immediately after script fetch, not after script evaluation. This stems from that the function does 2 things: 1) notifying the completion of script fetch, and 2) dispatching connection requests on SharedWorkerGlobalScope. 2) is required to be called after script evaluation on the worker thread, so the call timing of the function is delayed until that. Bug: 924041 Change-Id: I09aa947696e5b0d77373f7feee9fbb3768b28a73 Reviewed-on: https://chromium-review.googlesource.com/c/1438755Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#626471}
-
Mathias Carlen authored
Before this patch we initialized AA and its UI via the webContents from the currently active tab. A current tab is not immediately set and we were using a null webContents object. This patch uses the existing tab instead of a "current" tab instead. AA no longer crashes when a payment request UI is shown. Bug: 806868 Issue: b/123338819 Change-Id: Ibf14792b43dcd317f99236bc5368215de8f9f4c1 Reviewed-on: https://chromium-review.googlesource.com/c/1437077Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626470}
-
Darren Shen authored
We currently have several tast integration tests that test the VK under real devices. However, in rare cases, the VK doesn't show up and it's not clear why. One route of investigaiton is to first determine whether the issue is due to C++ or JavaScript. We put an error log when there's a lingering state. If we linger in LOADING_EXTENSION, that probably means it's a C++ issue, as the extension should load in under 5s (if the extension has a runtime error, it also counts as "loaded"). If we don't linger, then it means the extension is not resizing the keyboard window. Bug: 879073 Change-Id: I60945fd1f5c2dd8284c0ea416b4127e12a9d394c Reviewed-on: https://chromium-review.googlesource.com/c/1436277 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#626469}
-
Sara Kato authored
Android side change ag/5900087 Bug: b/121359095 Change-Id: I2a1e95909429556fa47dcfbc123b1b9ec73a5147 Reviewed-on: https://chromium-review.googlesource.com/c/1391651Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#626468}
-
Takashi Toyoshima authored
In HandleResponseHeader(), we checked net::HttpResponseHeader's existence, but we should do the same check even in CreatePreflightResult(). Bug: 925380 Change-Id: I9b93d52b595dd066ac325a4b41139fe04abaa8b7 Reviewed-on: https://chromium-review.googlesource.com/c/1438856Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#626467}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/webrtc_logging_private. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=grunell@chromium.org Bug: 925652 Change-Id: I02e600e50b04228866f1b2cc050d57158779bc95 Reviewed-on: https://chromium-review.googlesource.com/c/1438379 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626466}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 925652 Change-Id: I4aa39e130acd1831ebceded91180c15cd41ca15b Reviewed-on: https://chromium-review.googlesource.com/c/1438374 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#626465}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9df9418e..cb59b3a2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. NOTRY because of broken infra. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com NOTRY=true Change-Id: I590fcae19a37945540b8d51e64b613c962782ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1437326 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626464}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=hidehiko@chromium.org Bug: 925652 Change-Id: I0f9f03c8e34187cf5d84d5076726fd469e8605e0 Reviewed-on: https://chromium-review.googlesource.com/c/1438367 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626463}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55f3043c8b90..1d1214aeb988 Created with: gclient setdep -r src-internal@1d1214aeb988 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I96ee5857b6f2b4d9983e311981ce9f8890ac9ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1437803Reviewed-by:
-
Eugene But authored
chrome_web_view_factory.mm no longer exists, so the exception was removed. Bug: 620134 Change-Id: I606ef534913f269b0471aadb4a77f7ca020bb017 Reviewed-on: https://chromium-review.googlesource.com/c/1437941 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#626461}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=olka@chromium.org Bug: 925652 Change-Id: I67adb332a439aedcb063363b1d6f53c9e06656b7 Reviewed-on: https://chromium-review.googlesource.com/c/1438324 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#626460}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I8722879e0490a11b0db17d49a8c77bbf06ee5304 Reviewed-on: https://chromium-review.googlesource.com/c/1438877Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626459}
-
Xiaocheng Hu authored
The function was separated out from NGInlineNode::SegmentBidiRuns to support legacy layout. Now that we've remove legacy layout support from bidi caret affinity, the function can be merged back. Bug: 925192 Change-Id: I38dfde1278b604e7839e431a7aff64a68f815280 Reviewed-on: https://chromium-review.googlesource.com/c/1437271 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#626458}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbbf7a4393ac..55f3043c8b90 Created with: gclient setdep -r src-internal@55f3043c8b90 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I796ed624d786110ddcbb5d73defd9394f215adf6 Reviewed-on: https://chromium-review.googlesource.com/c/1437993Reviewed-by:
-
chkuo authored
[chromecast] Refactor URLRequestContextFactory to set up the common settings for creating URLRequestContext Most of the settings for creating URLRequestContext are same and we use same code in different functions. To reduce the redundant code, we add a helper function called 'ConfigureURLRequestContext' to setup all configs of URLRequestContext object. Bug: 921430 Test: NONE Change-Id: Ifcc1aa197e36ca466f1377db25e233c892cbb764 Reviewed-on: https://chromium-review.googlesource.com/c/1385693 Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626456}
-
Yuta Kitamura authored
Bug: 925600 Change-Id: I2a5f9fbc8695f9205d7cdaf58b5eca3e4f168ab0 Tbr: msramek@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1438795Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#626455}
-
Yuta Kitamura authored
Bug: 793133 Change-Id: If31637bf3cf2496eeb641c352f383e17c4729557 Tbr: dominickn@chromium.org Tbr: hanxi@chromium.org Tbr: changwan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1436600Reviewed-by:
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=ricea@chromium.org Bug: 925652 Change-Id: I59e6a4fdc1295b778c9e33e35d57cf019617695d Reviewed-on: https://chromium-review.googlesource.com/c/1437831 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#626453}
-
Hayato Ito authored
Add UMA for any HTMLTemplateElement usage. We might want to add other UMA for different usages, as https://crbug.com/922719#c1 requested, later. Bug: 922719 Change-Id: Ib5f3c1a1bc573fb290d52a73ecbca38a5b86b8fa Reviewed-on: https://chromium-review.googlesource.com/c/1436728Reviewed-by:
-
Yuta Kitamura authored
This reverts commit 8e470e32. Reason for revert: Suspected cause of flaky timeout of the following test (see issue 925599): org.chromium.base.task.SingleThreadTaskRunnerImplTest#testPreNativePostTask Original change's description: > Rerouting all Java tasks through TaskRunner API > > Pre-native Java tasks are now having their priority set when started. > Also switches dynamicmodule's ModuleLoader to use the TaskTrait's > priority setting instead of manually setting the thread priority. > > Bug: 863457 > Change-Id: Iee601ca1e18e2637f8e930c6d212c8115e682fc3 > Reviewed-on: https://chromium-review.googlesource.com/c/1407374 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626095} TBR=yfriedman@chromium.org,skyostil@chromium.org,agrieve@chromium.org,lizeb@chromium.org,smaier@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863457 Change-Id: I55487d7e6373a1b1d8d346432e3ac59cdde08e41 Reviewed-on: https://chromium-review.googlesource.com/c/1436657Reviewed-by:
-
edchin authored
The goal of this CL is to reduce SadTabCoordinator code in BVC so that SadTabCoordinator can eventually be moved to BrowserCoordinator. NamedGuides decouple placement of views from BVC. This CL moves SadTab view placement out of BVC and next to the presentation code so that presentation and placement are adjacent to one another. This helps to reduce the SadTabCoordinator footprint in BVC. Bug: 905524 Change-Id: Ib6744e145380441b3b43c783a12162a9bc0f7f1b Reviewed-on: https://chromium-review.googlesource.com/c/1426176 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#626450}
-
Hiroki Nakagawa authored
Before this CL, kOffMainThreadWorkerScriptFetch has been used as the flag for off-the-main-thread dedicated worker script fetch. This will be confusing after a new runtime flag for off-the-main-thread shared worker script fetch is added by the subsequent CL [1]. To avoid that, this CL renames the flag to kOffMainThreadDedicatedWorkerScriptFetch. Also, this moves it from blink's features to base's features to make it aligned with the shared worker's flag that is also used in content/. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1428624 Bug: 835717 Change-Id: I2981619a4d6f1b1bdd5c4c192db917d1de59db9d Reviewed-on: https://chromium-review.googlesource.com/c/1438677Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47a5a2d44bec..fbbf7a4393ac Created with: gclient setdep -r src-internal@fbbf7a4393ac The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6b0320b00174366c35fea510966df58202dd4388 Reviewed-on: https://chromium-review.googlesource.com/c/1437991Reviewed-by:
-
Kent Tamura authored
Restarting Chrome application, duplicate a tab, and back/forward navigation call 'restoreValueCallback' of form-associated custom elements to restore their state. Implementation: * element_internals.{h,cc}: Hook some methods to support the state restore feature. ElementInternals::RestoreFormControlState() posts a microtask to call 'restoreValueCallback'. * form_controller.{h,cc}: - ControlType() supports ElementInternals. We store custom element name as a type. - SavedFormState::Deserialize(): Accept custom element names. - FormController::RestoreControlStateOnUpgrade(): Added for upgraded custom elements. * html_element.{h,cc}: FinishParsingChildren() Hook it to restore the state of form-associated custom elements which are not owned by a <form>. * file.{h,cc}, file_input_type.cc: Move logic to save/restore File state to blink::File in order to share it with ElementInternals. Change-Id: Idb8ea5d333afbd566ae838334800cbf0b8128af5 Reviewed-on: https://chromium-review.googlesource.com/c/1436416Reviewed-by:Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#626447}
-
Donna Wu authored
This CL introduced a new class extensions::UsbDeviceManager and merged it with existing extensions::UsbEventRouter. This new class will proxy all USB mojo requests in chrome.usb extension implementation. Bug: 716628 Change-Id: Ie296e6682dedd938e59432dd3b35f2a92fc9a69a Reviewed-on: https://chromium-review.googlesource.com/c/1424739 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#626446}
-
Leon Han authored
After crrev.com/c/1433854, this CL moves content/public/common/renderer_preference_watcher.mojom -> third_party/blink/public/mojom/renderer_preference_watcher.mojom BUG=869748 TBR=thestig@chromium.org for trivial changes in chrome/ Change-Id: I7d2c1ce4d9b353bf3020f9cdcc4f354909bba3fc Reviewed-on: https://chromium-review.googlesource.com/c/1436879 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626445}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=yhirano@chromium.org Bug: 925652 Change-Id: Id5d334e4d4baa89dac5aa5a5e64d558c8bef14e2 Reviewed-on: https://chromium-review.googlesource.com/c/1438320 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: Ic8ff151b1980b55a31106f93a1ad5b174fdfeae2 Reviewed-on: https://chromium-review.googlesource.com/c/1438676 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/381f6a7d336b..47a5a2d44bec Created with: gclient setdep -r src-internal@47a5a2d44bec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idb39b0f745cea87d582214cefae3aa3d736d1916 Reviewed-on: https://chromium-review.googlesource.com/c/1437636Reviewed-by:
-
Leon Han authored
crrev.com/c/1426522 enables us to move renderer_preferences.mojom out of //content, this CL does so. content/public/common/renderer_preferences.mojom -> third_party/blink/public/mojom/renderer_preferences.mojom BUG=869748 TBR=skyostil@chromium.org, boliu@chromium.org, rockot@google.com for trivial changes in headless/, android_webview/, and extensions/. Change-Id: I08b0a975b5b2760dde0abbe0ed664c3ddf680312 Reviewed-on: https://chromium-review.googlesource.com/c/1433854Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#626441}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Icb70b334ef0da71d912b416f6e27bae3eb66fd34 Reviewed-on: https://chromium-review.googlesource.com/c/1438464Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#626440}
-
Dmitry Gozman authored
We are not using loader for main resources anymore. Bug: 855189 Change-Id: I56c5d04e0088f1ae2c1ce6fe2cee9cbfe3ac90d2 Reviewed-on: https://chromium-review.googlesource.com/c/1424166 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This is a followup of crrev.com/c/1436464. With the previous patch, callers of NGOffsetMapping::GetMappingUnitsForDOMRange() no longer need to clamp out-of-range portions of the units by themselves. As a followup, this patch removes the code handling partially out of range units. Change-Id: I5a7452d995365939509ba7a763de20ee2acf47a4 Reviewed-on: https://chromium-review.googlesource.com/c/1437193Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626438}
-
