- 22 Jun, 2018 40 commits
-
-
Niklas Hambüchen authored
Before 0.5, render strings looked like this: Gallium 0.4 on llvmpipe (LLVM 4.0, 256 bits) now they look like this: llvmpipe (LLVM 5.0, 256 bits) Change the regex accordingly to avoid accidentally not matching the llvmpipe renderer string. Bug: 854437 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I14a7a7631880b2dcfcd3af5eeb6c01d5be32edb6 Reviewed-on: https://chromium-review.googlesource.com/1108216 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569747}
-
Eric Stevenson authored
Change-Id: I5fb983c8f31a1b548b4776588e46f49bf5d0aa80 Reviewed-on: https://chromium-review.googlesource.com/1112062Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569746}
-
Ran Ji authored
Bug: 831863 Change-Id: I7ac3dfbc5656b0aa71984571fa7c4791f0bacce2 TBR=yfriedman@chromium.org Change-Id: I7ac3dfbc5656b0aa71984571fa7c4791f0bacce2 Reviewed-on: https://chromium-review.googlesource.com/1110478 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#569745}
-
Eric Stevenson authored
This CL fixes a regression where gclient sync failures were causing the build step to be skipped. Also fixed a problem where the script would fail because of missing llvm bin tools. Now these tools are copied to the temporary dir we use for supersize. Bug: 855124 Change-Id: Iabc82938aec54f853a2631d107d7d1f8c57c3696 Reviewed-on: https://chromium-review.googlesource.com/1112487Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569744}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5a26a769e69..c48318a35b17 git log c5a26a769e69..c48318a35b17 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 ehmaldonado@chromium.org bot_update: Don't force solutions to be unmanaged. Created with: gclient setdep -r src/third_party/depot_tools@c48318a35b17 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812,chromium:853032 TBR=agable@chromium.org Change-Id: I854ba50b5081e06e1c192132a80c19db2a107e26 Reviewed-on: https://chromium-review.googlesource.com/1112222Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569743}
-
Daniel Murphy authored
Session was assuming that InitiateConnection() would always complete asynchronously. In tests, this doesn't happen. This fixes one case where a callback was registered after the call to InitiateConnection() Bug: 716490 Change-Id: I606446ba5e5ba5907c9c37ab440cc38bef2838d8 Reviewed-on: https://chromium-review.googlesource.com/1112486Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#569742}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic03d0c70bedfa019a587178bbe833890989b400f Reviewed-on: https://chromium-review.googlesource.com/1112490 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569741}
-
Ken Buchanan authored
The current behavior to allow mouse input in the browser process to be locked to a given RenderWidgetHost is to send all mouse input between a MouseDown and a MouseUp to the same target. This is not in accordance with spec, and causes some site breakage. Whether a MouseDown should cause capture depends on the node that the event hits. Drag-highlighting text or clicking the thumb part of a scrollbar require capture, for instance, while most elements do not. This change removes the implicit capture currently done in the browser, and replaces it in the case of scrollbars with an explicit signal from Blink to start capturing. Other cases requiring capture still need to be implemented. Bug: 647378, 849862 Change-Id: Ifc4b690c36927ed48edd2604d40742e130295dcf Reviewed-on: https://chromium-review.googlesource.com/1099183 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569740}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/694c8ff073d5..6ec076ceabc3 git log 694c8ff073d5..6ec076ceabc3 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 nya@chromium.org gs: Use Stainless log browser everywhere in chromite. Created with: gclient setdep -r src/third_party/chromite@6ec076ceabc3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1801a8453204639bf0683f2b2c61c779b886340b Reviewed-on: https://chromium-review.googlesource.com/1112221Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569739}
-
David 'Digit' Turner authored
Chrome currently crashes on startup on Android if the system locale is set to something that it doesn't support. For example, set the system locale to 'Furlan': regular Android applications will fallback to display English strings as a fallback, but Chrome crashes on startup immediately. This CL fixes the issue, by detecting which locale the Android framework uses to display strings effectively, then using this value to extract the corresponding .pak file, instead of trying to find one that matches the current system setting. + Move compressed locale file detection to background thread. Since this now requires I/O access when accessing the resources, this operation can no longer be performed on the UI thread. For more details, see associated bug entry. BUG=846633 R=agrieve@chromium.org,astevenson@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org Change-Id: If2db6136367081ad50b2b80c85b4cc0e1c2c276f Reviewed-on: https://chromium-review.googlesource.com/1088708 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#569738}
-
Mike Dougherty authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib34a317f87110d54572003bb1c1beca31b1cf9f1 Reviewed-on: https://chromium-review.googlesource.com/1108394 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569737}
-
Min Qin authored
This CL stops DownloadDBCache to immediately updating the DB. Instead, it caches the change and only update the DB when timer fires. Some of the updates are considered high priority and will thus flush to DB immediately. Bug: 850990 Change-Id: I124ac1c69e5c7e6bd609d656be3ac1a938f78c63 Reviewed-on: https://chromium-review.googlesource.com/1102084Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569736}
-
Xiaocheng Hu authored
When hit testing a list marker, we should hit the corresponding list item element. This patch implements the same behavior in LayoutNG. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d191098a444cf276b917451ae1f9ab4a0df2d88 Reviewed-on: https://chromium-review.googlesource.com/1111270Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
cathie chen <cathiechen@tencent.com> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#569735}
-
Kim Paulhamus authored
Removes the NOT_IMPLEMENTED placeholder. Bug: 678885 Change-Id: I4572dc2e6aad8019b383b93173b7962cc97ad60d Reviewed-on: https://chromium-review.googlesource.com/1109498 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569734}
-
Manuel Rego Casasnovas authored
In r543079 we added support for calc() in grid gutters. In that patch we modified LayoutGrid::GridGap() but we forgot to do the same in LayoutGrid::AvailableSpaceForGutters(). This patch just changes the IsPercent() call by IsPercentOrCalc() that way calc() gutters are considered too when looking for the available space. BUG=816300 TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002.html TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html Change-Id: I3237d5dc73f508cea6d904b9f1fd3822bb9efe55 Reviewed-on: https://chromium-review.googlesource.com/1112237Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#569733}
-
Sebastien Marchand authored
Bug: 773382 Change-Id: Ibaf68d29185611ffbd3563330ab7c3d23ca4f7e8 Reviewed-on: https://chromium-review.googlesource.com/1106053 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569732}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e3b12b3e7d98..fa74d9840634 git log e3b12b3e7d98..fa74d9840634 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 perezju@chromium.org [Telemetry] Should not "warn" when computing TBM 2018-06-22 perezju@chromium.org [Telemetry] Do not raise on missing devtools clients for clock sync Created with: gclient setdep -r src/third_party/catapult@fa74d9840634 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854212 TBR=sullivan@chromium.org Change-Id: I228ac2a4d7ae2ad4ae535d3dd69fe390b0c73c44 Reviewed-on: https://chromium-review.googlesource.com/1112119Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569731}
-
Ryan Tseng authored
Going to switch this to a larger bot and turn off Goma for the time being. Change-Id: Ia09d67b6acdb03ba1228ea3a73bc41da959d1dba Reviewed-on: https://chromium-review.googlesource.com/1112477Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569730}
-
John Delaney authored
Top level header was missing a space causing the markdown to be parsed incorrectly. Bug: 854334 Change-Id: Ia721d8adb009877ba1d3bf536091387bedade23f Reviewed-on: https://chromium-review.googlesource.com/1106671 Commit-Queue: John Delaney <johnidel@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#569729}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5e0909776e81..96b1ecc25d00 git log 5e0909776e81..96b1ecc25d00 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 brucewang@google.com Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig. 2018-06-22 benjaminwagner@google.com Upgrade MacOS on Skolo bots. 2018-06-22 herb@google.com Use the correct paint from the looper 2018-06-22 bungeman@google.com Remove include/ports/SkFontMgr.h 2018-06-22 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader bf8fd5b5fb68..a9969b2ab8c3 (1 commits) 2018-06-22 senorblanco@chromium.org GrTessellator: avoid split with zero primary and out-of-range secondary. 2018-06-22 herb@google.com Add SkGlyphRunList - v2 2018-06-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@96b1ecc25d00 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851914 TBR=kjlubick@chromium.org Change-Id: I579cb3684298fb742231c47cdb7f995b0797f49c Reviewed-on: https://chromium-review.googlesource.com/1112219Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569728}
-
Nicolas Pena authored
This CL introduces a bool |first_input_detected_| to make sure that we do not create more than one PerformanceEventTiming entry of type 'firstInput'. Before, there could be many entries of this type dispatched to PerformanceObservers when the first input occurred after onload and |first_input_timing_| would never be set. Bug: 841224, 851484 Change-Id: I293d3de1ac052eaab9297d725ce0211f242aaf5a Reviewed-on: https://chromium-review.googlesource.com/1111914Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#569727}
-
Scott Chen authored
Suspected reason for flakiness is that the timing of cr-input shifting focus onto the internal input sets it as the activeElement too late. Bug: 855637 Change-Id: Ifdc3fa26c357ca6aa1e92180ec309cca4e455e07 Reviewed-on: https://chromium-review.googlesource.com/1112350 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569726}
-
Nico Weber authored
The motivation is to remove chromium_memory_chromiumos_asan_gtests in favor of linux_chromeos_rel_gtests, but when I tried doing that directly [1], I got many asan/lsan and msan reports for these tests. Some of them pass however, so I'd like to lock in the working ones while I work on fixing the broken ones. 1: https://chromium-review.googlesource.com/c/chromium/src/+/1110703 Adds to "Linux ChromiumOS MSan Tests" and "Linux Chromium OS ASan LSan Tests (1)" these tests: - chromevox_tests - gl_unittests_ozone (to asan/lsan only) - ozone_gl_unittests - ozone_x11_unittests - select_to_speak_extension_tests - views_mus_interactive_ui_tests Bug: 843511 Bug: 855573,855580,855588 Bug: 855584,855585,855583 Change-Id: I9402cd43d1d0ef95432eba8231ae79c936b4848b Reviewed-on: https://chromium-review.googlesource.com/1112037Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569725}
-
Jacob Dufault authored
If pin length must be set then the error messages for - [0,3] digits: "PIN must be at least 4 digits" - [5..] digits: "PIN must be less than 4 digits" The 5.. digit case should be "PIN must be less than 5 digits" Bug: 855635 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I840772182b292f150626aa670594221bd1096904 Reviewed-on: https://chromium-review.googlesource.com/1112210Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#569724}
-
Jared Saul authored
Bug: 812710 Change-Id: I38b1e3f647c857ac1c6d8cbcfbd8eaafe61e4407 Reviewed-on: https://chromium-review.googlesource.com/1112208Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#569723}
-
Rayan Kanso authored
Now that CacheStorage can have multiple clients/owners, some of them will need access to the CacheStorageManager after shutdown to wrap up their tasks. This CL changes the CacheStorageManager member in CacheStorageContextImpl to a scoped_refptr, so that if there are any references after the shutdown was initiated, systems that hold a reference can finish their tasks without crashing. Bug: 851164, 851229 Change-Id: I3226e79325adce62594de2135ab4450f463b5eac Reviewed-on: https://chromium-review.googlesource.com/1095261Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569722}
-
Dominic Farolino authored
Before this CL we have some Request constructor logic in our implementation of RequestInit. Once we generate RequestInit with the IDL compiler, that logic will have to be inlined back into the Request constructor. This CL moves that logic, revolving around the referrer property, back to the Request constructor to minimize the size of the CL that removes our implementation of RequestInit. R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 836873 Change-Id: Id351d9503ead1ef4e377fa0bd1cc5eaac70cfbed Reviewed-on: https://chromium-review.googlesource.com/1103786 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#569721}
-
George Burgess IV authored
Some of these tests caused blink to recurse to stacks > 4,000 frames deep. This caused crashes for Android on ARM64, which has a standard stack limit of 1MB. Since it appears that these benchmarks' depths are somewhat arbitrary (e.g. the crashes that we're seeing when running these benchmarks aren't indicative of a problem in the real world), turning down the recursion seems reasonable here. New limits were chosen arbitrarily. Bug: 851539 Test: Ran blink_perf.parser on ARM64 Android; no crashes observed. Change-Id: I310b5e92fcb32524ec6e1c8a1c67226d68f4e5aa Reviewed-on: https://chromium-review.googlesource.com/1111685 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569720}
-
Lei Zhang authored
Change-Id: Icc99c8dc75960314b1bc0b2c8b6f959fcc497630 Reviewed-on: https://chromium-review.googlesource.com/1110549Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#569719}
-
Ramya Nagarajan authored
Change-Id: Iafb44e629fc0089c575b741c79c91c34b67959d4 Reviewed-on: https://chromium-review.googlesource.com/1112352Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569718}
-
Aleks Totic authored
Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1d0d9d290805e0de27d17d3f2cb26e9ecc9cb5b9 Reviewed-on: https://chromium-review.googlesource.com/1112204Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#569717}
-
Kenneth Russell authored
Allow direct use of base/numerics/safe_conversions.h in Blink. Bug: 854710 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I43c664317beca77525fe65445a25da528c7747d5 Reviewed-on: https://chromium-review.googlesource.com/1109267 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#569716}
-
Ken Rockot authored
mojo/edk/embedder -> mojo/edk/system TBR=jcivelli@chromium.org Bug: 753541 Change-Id: I4b73748986c4b728e42c5a19fe8b7a6a685238b5 Reviewed-on: https://chromium-review.googlesource.com/1109034 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569715}
-
Andrew Grieve authored
Bug: 702625 Change-Id: I68ff5c0b3e81da58ca85cd2a6b26ebe7ec80456e Reviewed-on: https://chromium-review.googlesource.com/1112351Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#569714}
-
Fan Yang authored
R=rch@chromium.org Change-Id: I95fdbe700abfb4a028037e27dded55c12bf9633d Reviewed-on: https://chromium-review.googlesource.com/1112050 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569713}
-
Lindsay Pasricha authored
Also delete UIRefrefresh-simulator.json. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I261230199df6da2669d0ac186571e19df67fa42b Reviewed-on: https://chromium-review.googlesource.com/1107279 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569712}
-
Xiaohan Wang authored
This describes the capability (supported features) of a CDM. Add a new struct for it to simplify a lot of code. Bug: 848532 Change-Id: Iaf83bad1ebe4882e8fbc0a1786b2d9898ef9a52b Reviewed-on: https://chromium-review.googlesource.com/1110602Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569711}
-
Ryan Hansberry authored
SecureChannelClientImplTest.TestMultipleConnections can intermittently fail: it was only caught by the test waterfall after this unrelated change: https://chromium-review.googlesource.com/c/chromium/src/+/1111937. The test was failing on release builds, not debug builds, because TestConnectionAttemptDelegate::last_client_channel() was returning a unique_ptr which was being immediately thrown away; in a release build, the memory allocation is optimized such that when a second ClientChannel was created, it was assigned to the exact same address that the old one was addressed to, causing the check 'EXPECT_NE(client_channel_1, client_channel_2)' to fail. Bug: 824568, 752273 Change-Id: I2571f63c7dd0bfbbadef3fca17f001f740d64ab3 Reviewed-on: https://chromium-review.googlesource.com/1112422Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#569710}
-
Ramya Nagarajan authored
Adds a service request and callback to get Google Photos for the user. An access token for the signed-in user with requisite scope is obtained and used in the request. Bug: 839152 Change-Id: I5e6bbb3d3329e5fe9158e815fe91f717d8652256 Reviewed-on: https://chromium-review.googlesource.com/1109258 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569709}
-
Jialiu Lin authored
For Android settings: Change to third-person singular verb, i.e. "Protect you and ...." to "Protects ....." String doc for mobile: go/unity-mobile-strings For desktop SB settings: title: "Safe Browsing" Check box label: "Protects you and your device from dangerous sites" String doc for desktop: go/unity-strings Bug: 837857 Change-Id: I25a8c93bacded9163614edfbe92b4bd5f3d17149 Reviewed-on: https://chromium-review.googlesource.com/1110453Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#569708}
-