- 19 Apr, 2019 40 commits
-
-
Klaus Weidner authored
This change is needed to match the API change in https://chromium-review.googlesource.com/c/chromium/src/+/1570217 but was missing in that CL. TBR=bajones@chromium.org Change-Id: Ic49436558c3cde7e42b9b8a4bd26c416f0b80f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574457 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#652689}
-
John Budorick authored
This should make resource_sizes output files in a format and structure amenable to process_perf_results. Bug: 807273,861983 Change-Id: I5d359b35ad4ba836cd1282f804daf996fbbec7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574455 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652688}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Id7fcc09482854f18a722bc0e8e951fb96846b4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574447 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#652687}
-
Eric Roman authored
Change-Id: I7d9ca04bc1c82a0a7341bd76dd265653cb0fba55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575162Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652686}
-
David Benjamin authored
We can just tell //base to act case-insensitively. Change-Id: I5d4a9ecfa09cd7fada0b0af792d0f414de888904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575172 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652685}
-
Misha Efimov authored
Bug: 954372 Change-Id: Id148ead661409576491fec9b37226e975098ef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575115Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Auto-Submit: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#652684}
-
Dana Fried authored
This is distinct from opening a bookmark from bookmarks bar, manager, app/wrench menu, etc. Bug: 951909 Change-Id: I8ba878a126d21696e74f821535929a59db3c120e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574424 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652683}
-
Rakina Zata Amni authored
[Display Locking]: Highlight highest locked ancestor instead of highlighting nodes in locked subtree Previously DevTools might call getBoundingClientRect on nodes in a locked subtree from within paint, which might trigger style/layout because we skipped the locked subtree in those phases (so they might be still dirty), leading to crashes. For nodes in a locked subtree, when we want to highlight it, we should instead highlight the highest locked ancestor instead, because it will always have up-to-date style & layout values. The tooltip for the overlay will indicate that we're highlighting the locked ancestor in that case. See https://bugs.chromium.org/p/chromium/issues/detail?id=934458#c12 for a screenshot of the UI. Bug: 934458 Change-Id: I20d85104cbeed36af6ac98b157ab6da31ed73dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528123Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#652682}
-
Johannes Henkel authored
This is the minimal change. I'll simplify the code in a separate change, and remove the test suites in a separate change. The update to dom-getBoxModel-expected.txt is because the flag won't have an effect any more. Bug: 954618 Change-Id: Ib017e78c56fa19178b2d914bfcad96f9a2187596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575999Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc0161223605..f777fd10f59a git log cc0161223605..f777fd10f59a --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate SessionIdRequest, SessionStateRequest, SheriffsRequest to es6 modules 2019-04-19 benjhayden@chromium.org Migrate expand-button to es6 module Created with: gclient setdep -r src/third_party/catapult@f777fd10f59a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011 TBR=charliea@chromium.org Change-Id: I33a86be494cc73fb8c3a1fb8c9d341106ad4dd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576058Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652680}
-
Aran Gilman authored
This is a clean-up CL in preparation for adding an image-specific filter. Bug: 954318 Change-Id: I002e09c2ebd384c0f0d667dcb00eebc7550aee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574629 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#652679}
-
Xiyuan Xia authored
- FocusActivationStore uses ActivateWindow(nullptr) for deactivating to avoid an arbitrary window covering the active window before Restore(). - RootWindowController puts the moved windows under existing ones on display change. Bug: 945754 Change-Id: I3cacfd3427b8c98c9ce9dd2da05977120c1c1d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574824Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652678}
-
Jacob Dufault authored
- DeviceDisabledScreenView - EnableDebuggingScreenView - EncryptionMigrationScreenView - FingerprintSetupScreenView - KioskAutoluanchScreenView Also eliminate unnecessary Delegate classes on the views. Bug: 928555 Change-Id: Ifd45f381f2fb9aaae60dbe3ec6ea1287424980bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572521 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#652677}
-
Shakti Sahu authored
For completed videos 1 - We should show the play icon for completed videos 2 - We should not show the circle/square animation for completed videos 3 - Paused state should show a download icon rather than play button Bug: 951839 Change-Id: I3cd1aa07777f212824fe7a110ae834fdfe4d118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575400 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652676}
-
Mitsuru Oshima authored
This measures the presentation time of following actions: * gesture-drag to show the launcher from shelf to fullscreen state. * gesture-drag to hide the fullscreen launcher. I also moved the perf test utility classes into separate file so that they can be used in other tests. Bug: 948324 Change-Id: Iac4d5ca7a39ab44c0404ab927df12608cb7529de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565235Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652675}
-
Johannes Henkel authored
We're removing the --disable-internal-devtools-binary-protocol flag so these virtual tests are no longer useful. See also: https://chromium-review.googlesource.com/c/chromium/src/+/1575999 Bug: 954618 Change-Id: Ia084f42b19ea11c92de9c3dc37d43249ca67d7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576002Reviewed-by:
-
Donn Denman authored
Adds a test to exercise the UI when a dictionary definition is returned by the server. BUG=936695 Change-Id: I1b18ab395a402948377d541e828e14f51f170fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573862 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#652673}
-
Jeremy Roman authored
All valid inputs are ASCII, and ASCII case conversion is currently done on both the key and value after the Unicode case conversion. While here, use StringView to just access into the ASCII-lowered buffer without copying out substrings for each key and value, since they're only read. Bug: 627682 Change-Id: Ibe11bd111205c286efb12273e006837f57254e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575125Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652672}
-
Yuwei Huang authored
This CL provides an FtlDeviceIdProvider implementation for the iOS client, which generates the device ID from identifierForVendor: https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor?language=objc Bug: 954594 Change-Id: Ieb5c373d66d17751294754c1674e86b8c7cb4ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575116 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#652671}
-
David Bienvenu authored
This is a reland of crrev.com/c/1559168, with a fix for the issue restoring windows after minimize (crbug.com/952142). Bug: 873414,952142 Change-Id: I421c1334396c9525dc121d2e98864b7bf1b691a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570246Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652670}
-
Jeremy Roman authored
All valid color strings are ASCII. Bug: 627682 Change-Id: Ib169ff7c1014557ac50286435b443dc1e3104533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574210Reviewed-by:
-
David Black authored
I was unable to reproduce the crash, but based on the stack trace in crbug/952996, my understanding of the cause is: (1) User attempts to close Assistant UI via caption bar while animation is in progress. (2) This triggers an animation abort to occur which fires an animation ended callback in UiElementContainerView. (3) UiElementContainerView currently only handles the case where an animation end occurs due to a new Assistant response being queued for display. (4) We attempt to access the queued Assistant response and crash. Since (1) will ultimately result in the entire Assistant view hierarchy being destroyed, the cleanest way to handle this is to just prevent (3) - (4) from accessing invalid state. Bug: 952996 Change-Id: I056df562a21f18ae032beaeb46fc637ecef21c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574743Reviewed-by:Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#652668}
-
Erik Luo authored
A) SSP used to manually set height, 'contain: strict' during edits for performance. This CL removes them, since there is no noticeable gain. See crbug.com/684341 B) Removes unnecessary 'editing state tracking', once used to manually focus sections before ShadowDOM-delegatesFocus. See also crbug.com/791494 Pre-keyboard navigation) SSP has tabIndex 0. On editingCommitted, we ensure focus goes back to the pane. After-keynav) Individual sections have tabIndex -1. On stopEditing, parent pane has focus, but we manually move focus to the section. After ShadowDOM V1) parent pane no longer has tabIndex, but uses 'delegatesFocus'. This makes moving focus around unnecessary. However, it also introduces 'blue flickering' when users 'Tab' navigate through properties, since focus is first delegated to the section. This bug is not addressed in this CL. Bug: 931145 Change-Id: If24177344ec975478fd91937daea58630b396069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574366 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#652667}
-
rbpotter authored
Also create a new print_preview_vars_css.html file, to store all CSS variables separately from common styles. Bug: 952960, 941369 Change-Id: I24bcc3cca781d7acfe7ff075e5b954827b009745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573163 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652666}
-
Charlene Yan authored
Updated a few known cases that should be draggable. Bug: 930782 Change-Id: I09ba7e0a71097317d241042e16a89f28dd27f4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570126 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#652665}
-
Ken Rockot authored
Adds associated analogs for Remote, Receiver, ReceiverSet, PendingRemote, and PendingReceiver. Basic smoke test coverage for compile and basic operation, since implementation is in terms of types with extensive coverage already. Bug: 875030 Change-Id: Ib441f15da94e1c481e9f7f88d3012ceda886bbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574365 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#652664}
-
dpapad authored
Also: - Added an .eslintrc.js file to enforce these changes. - Added exception for content/browser/resources/media/ which is fairly large and should be updated separately. Bug: 792774 Change-Id: I80b6079220cea112016e5a25c79f01f52a353890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572935 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#652663}
-
Sinan Sahin authored
Bug: 951103, 951111 Change-Id: Iab209ea609e4de0db4dce6b29843ec6e2860d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574593Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#652662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7be19dbfabac..990de7c7fcb5 Created with: gclient setdep -r src-internal@990de7c7fcb5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ie858b74bd619629b906ab4dd426f41af72b121ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575876Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652661}
-
Lily Chen authored
This CL adds "Extended" and "None" as possible values of SameSite for display in DevTools, to reflect the addition of new values to the enum net::CookieSameSite. Bug: 953306, 953995 Change-Id: Ic04eec726cfea0d9fcdbfcb26ff268bb532e85ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575109Reviewed-by:
-
Jeffrey Kardatzke authored
This was due to a coding error in another recent CL: crrev.com/c/1560516 Bug: 954563 Test: Generated feedback report is uploaded to server Change-Id: I2747760b1c41ec44476f2361148a351675719b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575174 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Chris Morin <cmtm@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652659}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7ef31b3e5b93..5609aa373c8e git log 7ef31b3e5b93..5609aa373c8e --date=short --no-merges --format='%ad %ae %s' 2019-04-19 dhanyaganesh@chromium.org history-aware: Extend the lookback period to a week Created with: gclient setdep -r src/third_party/chromite@5609aa373c8e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Idbc6b7135fa6ecfb8700cdd191daafed70bc3a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575875Reviewed-by:
-
Yue Li authored
Bug: b/129505256 Test: Manual Test Change-Id: I0d4fbe6c6a2b0280e6bff4ce9340db13291d40a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571026 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Sinan Sahin authored
Bug: 802284 Change-Id: I674255c3d1aa577206f677f13ad5bd30efc085ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572901Reviewed-by:
-
Oystein Eftevaag authored
Also queue up any tasks posted to the Perfetto task-runner-wrapper until the Chrome taskscheduler has been created. R=eseckler@chromium.org TBR=yusukes@chromium.org Change-Id: Ie9a2dd26ee529add9ce86709eef5876edbd7de27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553670 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#652655}
-
Jeremy Roman authored
Per spec, this should use ASCII, not Unicode, case folding: https://html.spec.whatwg.org/#enumerated-attribute Bug: 627682 Change-Id: I2e11153c3c391fd2a8e720b28d2412da59795c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575085Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652654}
-
Jeremy Roman authored
Unicode case conversion is slower and incorrect. Besides, all strings passed here today are ASCII. Bug: 627682 Change-Id: Ie2f5777599c62879e3e3460e7cbd516010c56792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574790Reviewed-by:
-
rbpotter authored
- Add a "clear search" button to the print preview search box element. - Remove unnecessary timeout, since a timeout has subsequently been added to CrSearchFieldBehavior. Bug: 954278 Change-Id: I073a991227b71213968ac8dac2994a2a3b3a2873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574609 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
Attempting to deflake Windows 10 bot. These tests are now failing instead of crashing: http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html virtual/outofblink-cors/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html These tests are now passing consistently: http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https.html virtual/outofblink-cors/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https.html The expectations are updated accordingly. TBR=csharrison@chromium.org Bug: 686118, 954586 Change-Id: Ia11e2a602908f0f647d879203f660263739bfc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574596 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Chris Lu authored
Thegreenfrog has been responsible for creating all file contents in this directory, landing 10+ CLs in the process. Michaeldo has reviewed a majority of those CLs. Bug: 919685 Change-Id: I4da69fbbeee987381c632a174528f1ce606a1b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574461 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#652650}
-
