- 25 Feb, 2020 15 commits
-
-
Darin Fisher authored
Bug: 1050143 Change-Id: I7b5ac5d5aba763e644f372120578532ba79da7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070822Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744137}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e723c6de. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" ea6dba31 "Align <pattern> and <*Gradient> attribute collection" 7d52b1d5 "[v8][wasm] Fix WebAssembly streaming tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8f859fac76aadf3ccc67eb3e37bbd90da677dcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071075Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744136}
-
François Degros authored
Bug: 996549 Change-Id: I6c45c32116b2f7982f31837c9268253a69c7dd39 Cq-Depend: chromium:2061628, chromium:2059037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063512Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#744135}
-
Ella Ge authored
This CL removes badge icon from webapk&shortcut install, including a2hs and app banner. For splash icon, we want to fetch it for building the webapk proto, but don't want to do it together with primary icon, because it'll increase latency, and we only need the splash icon data after the user has initiated the install. For webapks, we are downloading all useful image data when computing the murmur2 hash, so we can use the the image data from webapk_icon_hasher, similar to crrev.com/c/2047166 did for the best shortcut icon. Bug: 1043271 Change-Id: Ibbe5b80796794b3f1c4b75cd81cdfc32cc61dfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032723Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#744134}
-
Yutaka Hirano authored
This reverts commit 9a31f5ab. Reason for revert: Speculative revert for LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable failures https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3477 Original change's description: > Reland "Add support for loading predictor to use hints from optimization guide" > > This is a reland of eed7024d > TBR=tbansal@chromium.org for chrome/browser/predictors/... > > Original change's description: > > Add support for loading predictor to use hints from optimization guide > > > > Will add metrics in a subsequent CL. This shouldn't affect any current > > metrics since the support is all behind a feature flag. > > > > Bug: 1050101 > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#743767} > > Bug: 1050101 > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744088} TBR=tbansal@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org Change-Id: If2d29382d644733504141aed662fe7c570cd8db8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071178Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#744133}
-
Jared Saul authored
Although the code was cleaned up, since the flags were left in flag-metadata.json, we got alert emails that the flags were going to be expiring. To prevent these alarming emails, just remove the cleaned-up flags. Also updates some other Autofill-related flags, incl. owners and expiry. Change-Id: Id8185a2b7c1dd62ae9822188194e9723705f26d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070965 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#744132}
-
Rakesh Soma authored
Bug: 1055120 Change-Id: Ie3b6832a4f4aca0e7c3ac688488fae0494b9dc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069500Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#744131}
-
Piotr Bialecki authored
Bug: 1054952 Change-Id: Ic03ce2e03fc8c6e55e5cc46faf49057f32593404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070966 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#744130}
-
Quinten Yearsley authored
When cpplint was enabled, there was discussion about its usefulness since clang-format is already enforced via presubmit checks. It was decided that cpplint could be somewhat useful until a clang-tidy analyzer was enabled, and at that point clang-tidy may cover any use-cases that were covered by cpplint (and many more). Now, clang-tidy is here and enabled, and cpplint should be disabled as it sometimes produces false positives. Bug: 1048144 Change-Id: I79be2b1660b186e16925be791f26b14c4e63f0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071358Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#744129}
-
Noel Gordon authored
CSS rgba color expressed as percentages using % is our preferred style these days. No change in visual behavior. Bug: 992824 Change-Id: I69d67b0d3eb135b8d909c3954c0a9010df9e6f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068229Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744128}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/def23d3c..9b2c573d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib73b8f11652b53c9bdfb779508e3a059e4159eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071295Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744127}
-
Eric Willigers authored
Tests using kAppDotComManifest now all call SetupAppWithURL This is in preparation for adding a configuration for web app tests. Bug: 1052722 Change-Id: I7b97eea18fb37a2373142ec41e2673d4acc9e198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069964 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#744126}
-
Michael Ludwig authored
Bug: 1044032 Change-Id: I4f577ce9f2cf2d45fdf1abcb5cf36973a5285495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068034Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#744125}
-
Kyle Milka authored
Reorder the first party share options to match the spec. Bug: 1009124 Change-Id: I0f90f6c2cc7edad008b2d49f67943fc49c366804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062574 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744124}
-
Brandon Wylie authored
The ColorStateList needs to be different between the mic button and the delete button. Bug: 1054300 Change-Id: I97e88144c359e5c27cecfd7b99509051520a7808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067461 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744123}
-
- 24 Feb, 2020 25 commits
-
-
Kevin Babbitt authored
We were using AriaRole as the node name, but AriaRole is intended as an informational property. ControlType is a better match for the notion of "role" in UIA and is better suited for this purpose in UIA specific tree dumps. Bug: 1039347 Change-Id: I16ce8a67b7a981a106ce6877b47b0fde0c585f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068653 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744122}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I45fbe737c714780a3c15044fca04c3ec58cfa882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744121}
-
Katie D authored
Reader mode view page title now says "Loading..." instead of "Simplified view" on Desktop before the article title is populated. The article title is followed by "- Reader mode" to provide an indication to screen reader users that they are in a distilled page tab. Bug: 1016461 Change-Id: Ie7ab1ab1e89090e182c4c556bd22878ee876b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052487 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744120}
-
Caroline Rising authored
Make popped out extensions stay popped out if they have a context menu shown in the new extensions toolbar container. Previously we would only check if a context menu was running when trying to hide a popped out extension. In the case where the context menu was not yet running when this happened then the popped out extension would be hidden when it shouldn't be. This change lets the ExtensionsToolbarContainer keep track of an extension with an open context menu and adjust visibility accordingly. Bug: 943702 Change-Id: I547b16eb324852c9559238c646d189c39892fb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065009 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744119}
-
Esmael El-Moslimany authored
Bug: 1054741 Change-Id: Iae1362c77859c122c7100886788c64682aa569b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070735Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#744118}
-
Tom McKee authored
Before this change, running javascript like `performance.mark(...)` would result in a callstack like MakeGarbageCollected<PerformanceMark>(...) PerformanceMark::Create(<overload-1>) UserTiming::CreatePerformanceMark(...) Performance::mark() <v8-bindings-layer> `performance.mark(...)` while running script like `new PerformanceMark(...)` would result in a callstack like MakeGarbageCollected<PerformanceMark>(...) PerformanceMark::Create(<overload-1>) UserTiming::CreatePerformanceMark(...) PerformanceMark::Create(<overload-2>) `new PerformanceMark(...)` Note that, since the bindings layer calls into PerformanceMark::Create directly, PerformanceMark had to call UserTiming which had to call back to PerformanceMark. Apart from being a cyclic dependency, this also lead to confusion around which constraints needed to be checked at which points. This CL breaks the cyclic dependency between UserTiming and PerformanceMark by pushing all the validation into a single PerformanceMark::Create function. Along with this change comes better UseCount tracking for UserTimingL3 in the case where script runs `new PerformanceMark(...)`. Bug: 805566 Change-Id: Ic648b097734655b2c0e55db95e738b48bc8826c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003552 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#744117}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bfe5a68c1e31..19304d88c8be git log bfe5a68c1e31..19304d88c8be --date=short --first-parent --format='%ad %ae %s' 2020-02-24 nifong@google.com Move all canvaskit example resources to CDN 2020-02-24 herb@google.com Remove SkExclusiveStrikePtr. Replace it with sk_sp<SkStrike> Created with: gclient setdep -r src/third_party/skia@19304d88c8be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ieb238fd608000b4cede306771a41e47acf13c4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744116}
-
David Black authored
In response processing v1, UI elements are immediately added to the response and are processed in unison. In response processing v2, UI elements are pended while they each are processed individually. Only then are they added to the response as being ready for rendering, being careful to maintain the correct order of insertion. Bug: b:2063264 Change-Id: Ia487b0f7b99850314a6c83493e9f72af1b8b7b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065410Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#744115}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c7f63a01d344..e3aee0b42a11 git log c7f63a01d344..e3aee0b42a11 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 aleino@nvidia.com Remove skip dEQP-GLES31 test now passing on NVIDIA 2020-02-24 julien.isorce@chromium.org Reland "Provide default implementation of rx::DisplayEGL" Created with: gclient setdep -r src/third_party/angle@e3aee0b42a11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ie2239025241f848b292d26f5e45454d2bec0081d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744114}
-
Xing Liu authored
We use auto generated Java enum based on a c++ enum. However the Java API RecordHistogram.recordEnumeratedHistogram() need to pass a maximum value +1 to the auto generated value. TBR=dtrainor@chromium.org,isherman@chromium.org Bug: 1054957 Change-Id: Ib6a8d9695fceab7bffaef4b765277a6a4f5d69f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068754Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744113}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4028.0-1581935713-benchmark-82.0.4065.0-r1 to 82-4044.15-1582543985-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1ccf82c2152010c0af12446d9245043da0ec5b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071276Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744112}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.15-1581938780-benchmark-82.0.4065.0-r1 to 82-4044.25-1582542147-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifce8fdfc8923b5ff83e1e33f3f3665111aa427fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744111}
-
Eric Willigers authored
The test BookmarkAppWindowAshCrash in ExtensionUninstallDialogViewBrowserTest was using extensions functions to install a bookmark app. We now use web_app:: functions so the test will continue to pass when we enable the DesktopPWAsWithoutExtensions flag. Bug: 1052722 Change-Id: I2745e434d12f6386f69509308bab3076efa7ad44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067785Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#744110}
-
Alex Newcomer authored
Check whether the overview animation has finished showing or hiding. To be used in CrOS tast tests. Bug: 1052211 Change-Id: Ib8063d61302a66412ee0f55b49ae0a5fc5df945a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055694 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#744109}
-
Matthew Mourgos authored
TBR=oshima@chromium.org Bug: 1052441, 1022544 Change-Id: Ifc0399af5c8d4f32322b685161d8fea2aa6867fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067797Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744108}
-
Adrienne Walker authored
This is just preparation for making moving this code easier. Bug: 1015214 Change-Id: I379b6d1c8be4f61f9e13329c6ddae590fd8c80a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068929 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#744107}
-
Joel Hockey authored
For Autogenerated, and extension-based themes, use frame color for COLOR_STATUS_BUBBLE rather than toolbar. When PWAs set a theme-color, status bubble bg will match frame. crbug.com/1053823#c16 Bug: 1053823 Change-Id: I3a159a5c25a038ab78594c98b7208b3066a82181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067763 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744106}
-
Saman Sami authored
We are seeing invalid frame tokens in the wild. Add some crash keys before taking a dump to help investigate this issue. Bug: 1045372 Change-Id: I3e8546ff214c2ee2f6d2bda3cf4b64d277cce920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042290 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#744105}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.5-1581936665-benchmark-82.0.4065.0-r1 to 82-4044.25-1582540590-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I608cd8043babc2c20590505a074645239339d3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744104}
-
Toby Huang authored
Attempting to show HaTS for supervised users will cause ChromeOS to crash because incognito mode is disabled. Disable HaTS until it is ready for supervised users. Bug: 1055022 Change-Id: I1b7286410a6c2b9c08145862d45944c320ee44c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070111 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744103}
-
Collin Baker authored
Currently, events that would be dispatched to a disabled view are discarded instead. This seems to be a holdover from old event handling code and not necessary anymore. To allow pre-target handlers to still see these events, this CL changes these methods to dispatch the events to the closest enabled ancestor view. Bug: 1043374, 1011082 Change-Id: I82bca238e98b9b820c0c7619a5880fbf3497d886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029087 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744102}
-
Manu Cornet authored
It is unused and retrieving the login status from the session controller is easy enough anyway. Bug: 1042918, 1047012 Change-Id: I06afc5a4f724a45814e76b3bd7af79eab42489a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070815Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#744101}
-
inglorion authored
This uses the new debug info size reduction feature introduced in https://github.com/llvm/llvm-project/commit/651128f5). This was previously enabled for other platforms (crrev.com/c/2040441). For ChromeOS, we needed to upgrade the compiler to get the new feature. Now that that is done, we can enable the feature for ChromeOS, too. Bug: 1050118 Change-Id: Ide359fcb8d1e748bb321927055802bf6ebd7fad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067741 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744100}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1cb4a3a99d23..05a90eab354e git log 1cb4a3a99d23..05a90eab354e --date=short --first-parent --format='%ad %ae %s' 2020-02-24 primiano@google.com Merge "Revert "UI: Add CSP policy"" Created with: gclient setdep -r src/third_party/perfetto@05a90eab354e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6118d0ec4c0ed8105b1c3a6eed3862380fec5327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744099}
-
Ahmed Fakhry authored
- On sign in of the primary user, desks count and their names will be restored to their most recent state for this user. - Desks addition/removal/renaming triggers updates to the desks restore prefs. - The data structure selected for storing and restoring desks was chosen to be very simple: * A list of desk names. * The size of the list indicates the number of desks that needs to be created on restore. * An empty desk name is treated as a placeholder for a desk that wasn't renamed by the user and should be default-named. * Non empty desks names are the user-modified desks names. - In a multi user session, changes to the desks made by secondary users will be persisted in the prefs of the primary user only. It will never affect the prefs for those secondary users. BUG=1040980 TEST=Manually, added new tests. Change-Id: I85000f9bba32419ef907f26a03c34f25ff67686f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067358 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#744098}
-