- 30 Oct, 2020 40 commits
-
-
Kinuko Yasuda authored
I think I have enough context here, and can delegate to others whenever appropriate (and in most cases I'd do so too). (I have ownership in core, modules, platform, common, and public, but in some cases it could help reviewing bigger CLs when they have minor changes in other directories) Feel free to other owners too. R=mkwst@chromium.org,yoavweiss@chromium.org,chrishtr@chromium.org,rbyers@chromium.org Change-Id: I56e1822c5eab4239059c942f013ca18ac38cb9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505332Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822744}
-
Saurabh Nijhara authored
When an update is required as per policy but the device has reached end-of-life or auto update expiration, the policy behaviour is to block user sign after warning time in the policy has expired by showing the update required screen on the login page over the user pods. In such a case, the users of the device cannot delete their data which is a privacy concern. This CL adds UI on the update required screen which can be used to delete all users data on the device. Screenshot of UI - https://screenshot.googleplex.com/5QNGETeyHRSUgVc Bug: 1120090 Change-Id: Ia990457b3befd10f4a34ee2b5f51a9973d85503e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504289 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#822743}
-
Dominique Fauteux-Chapleau authored
This doesn't break tests in other classes since references to legacy protos had already been removed, so this is just a cleanup for code that never runs. Bug: 1103390 Change-Id: I72ae6028002592a1b9981174334c47454b961a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506263Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#822742}
-
Prashant Nevase authored
For few url schemes, the light color scheme is forced as they don't have dark mode theme yet. This was done by calling UpdatePreferredColorSchemesBasedOnURLIfNeeded(). This function gets called from OverrideWebkitPrefs() and OverrideWebPreferencesAfterNavigation(). The prior function sets the prefs preferred color scheme based on IsNightModeEnabled() for Android or native theme scheme for other platforms, but the later function does not set it. This patch now sets preferred color scheme for all platforms at one place in UpdatePreferredColorScheme(). As --force-dark-mode switch works only for preferred color scheme, until dark scheme is detected in page, default background is white which causes flicker once dark content is rendered. However this is a separate issue. Bug: 1137213 Change-Id: I5567149a5644a6d3d30ceabd65fb1f25e1971ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494296Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#822741}
-
Sven Zheng authored
svenzheng@ and bsheedy@ works on the project. It should be easier for them to be able to approve changes for these files. Change-Id: Ie50a5ec2337801b2cb518d0e5d850d5a07f8aa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508251Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822740}
-
Samuel Huang authored
In daignose_bloat.py, class ResourceSizesDiff takes an |apk_name| param at construction, but the value sits around and never gets used. This CL removes the param, and simplifies callers. Bug: 1040645 Change-Id: I8843018e400c3a12ce15178490c03a0a4b415963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510532Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#822739}
-
Mariia Shvedchenko authored
This CL synchronized the hardcoded regex with JSON, reorganize matching patterns by ServerFieldTypes if possible and fixes some wrong matching_attributes and matching_field_input_types. Bug: 1140775 Change-Id: Id3bbf5c9cb12e959ef5e43627569f6820eaeccc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510135Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mariia Shvedchenko <mariiash@google.com> Cr-Commit-Position: refs/heads/master@{#822738}
-
behdad authored
The begin-frames do not always terminate in the same order as they start. For example, a frame that does not have any updates can terminate earlier than a previous frame that had an update and is awaiting presentation. This can make it tricky to measure dropped-frames in a sliding window. To make this easier, introduce a FrameSorter, that makes sure the sliding-window can process the frames in order, regardless of when they are terminated. BUG=1138552 Change-Id: I2ae0e2413d64d0242aa3ba57f9d1b3d2c1f4354e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441202Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Ben Joyce authored
This will be read by the test runner when sharding junit tests. Bug: 1138506, 1141757 Change-Id: I050064f4b0c4ef766246b60469f59ee69a3893ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506172Reviewed-by:
-
Xing Liu authored
The check in main setting page doesn't apply any more, there are more preferences in the download setting now. Bug: NONE Change-Id: Iaa63198dea780d4cf379e1d8f8375ffe9c13ca38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505799Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822735}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a08cc488. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ic49fbfedbb33ea46355bcd630d3afd15670c811b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510509Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822734}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ffc771df..9d02bd39 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id647e03de537e430364992f8f3a1d3b8f9d4aef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510489Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822733}
-
Emircan Uysaler authored
This CL adds acquire and release fences to fuchsia overlays, so they can be obtained from the Image backing and sent to Scenic. - Adds a SharedImageRepresentationOverlay instance for ExternalVkImage, so that the common overlay processing code in SkiaOutputDeviceBufferQueue can use this representation for synchronization. - Changes NativePixmap and SharedImageRepresentationOverlay interfaces to handle vectors of acquire and release fences as fuchsia API requires. - Adds fuchsia specific fields to GpuFenceHandle for transport. - Sends these synchronization parameters to the overlay's ImagePipe::PresentImage() sequence. Bug: 1127984, 1137991 Change-Id: Ie7f73aafbd34925a83263de9cf6624179e4797bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490492Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822732}
-
Adam Langley authored
The MakeCredential and GetAssertion calls take a large number of arguments. This change makes them structs instead. This will be useful in the next change when these arguments need to be held pending a notification on Android. BUG=1002262 Change-Id: Ia03c2f786e36243902749183e6d3307a45c0717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500275 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#822731}
-
Elly Fong-Jones authored
Bug: 1134730 Change-Id: Ibe825add4319fa3c821b7c5780812a920e1a573f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510237Reviewed-by:
Milica Selakovic <selakovic@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#822730}
-
Brandon Wylie authored
Eliminate #onNativeLibraryReady from the LocationBar interface. Prevent Toolbar classes from poking at LocationBar to do native initialization. Change-Id: I8c3439f8021309a23fe48eec8d7647015d2570dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473344 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#822729}
-
Salvador Guerrero authored
This CL disables the following test: * org.chromium.chrome.browser.sync.SyncTest#testSignInAndOut Because it's flaky on builder: * android-arm-beta-tests TBR=yfriedman@chromium.org Bug: 1144221 Change-Id: I18fb396a0f54a5f2e351245a66b6c592b7b9e820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510611Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#822728}
-
Matt Menke authored
It was using the SpawnedTestServer, which is slow to start, and has been a never ending source of flake. HeadlessBrowserTest.ServerWantsClientCertificate will continue to use the SpawnedTestServer, since the EmbeddedTestServer does not support client cert requests. Bug: 492672 Change-Id: I03a511abf63ee149704c908e838275f07b4e9903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508652 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#822727}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7fc7a467710..eed4cbab5e8c 2020-10-30 egdaniel@google.com Guard use of GrVkGpu in GrAHardwareBufferUtils 2020-10-30 johnstiles@google.com Fix prefix/postfix mixup discovered by fuzzer. 2020-10-30 tdenniston@google.com Handle cubic segments in variable-width stroker 2020-10-30 johnstiles@google.com Reland "Moved SkSL data back into node classes" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I93111893801913b1062f1cd591c61313daeda43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510328Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822726}
-
Kevin McNee authored
This portals behaviour change was guarded by a flag as we did not want to change behaviour in the middle of an origin trial. The portals origin trial lasted from M85 to M86, so we can now un-gate the change. Bug: 1102081 Change-Id: I9202363c56bb2801874ccb84c16e1e6527a40e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510373Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822725}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=szager@chromium.org Bug: 1142671 Change-Id: I38de99a1ea146247a0a9e7a6f75eb4826a2cdf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500217 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#822724}
-
Etienne Bergeron authored
This CL fix a startup regression due to loading the voices DLLs early after startup. On startup, there a call to TtsControllerImpl::VoicesChanged(...). The call check whether or not the TTS platform is loaded (TtsPlatformLoading(...)). Unfortunately, this is accessing the singleton and creating it. The creation triggers the DLL loading. Bug: 869399 Change-Id: I639cec62ee176c36aee888413a1a91d893d165b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505575Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#822723}
-
James Cook authored
The lacros browser version, and release channel, can be different from the underlying OS release channel. Record a metric for the OS release channel (stable, beta, etc.) as part of lacros browser startup metrics. This will help us make rollout decisions and decide what OS channels to use for QA. For background on lacros, see //docs/lacros.md or go/lacros Bug: 1142646 Change-Id: I7e8f39f1e9b88241dbabf35fdf903f19c57c4a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508401 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#822722}
-
Ben Mason authored
Bug: 1131716 Change-Id: I7d8d9ae2104d6a88bbe1e3f7568dc04748a2a47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508230 Commit-Queue: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Auto-Submit: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#822721}
-
Elly Fong-Jones authored
Bug: None Change-Id: I43f3af3003d12d218140db9415df13b230e1e2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508324 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822720}
-
Salvador Guerrero authored
This CL disables the following test: * AppBannerManagerTest.testBlockedModalNativeAppBannerResolveUserChoice Because it crashes on builder: * test-o-phone TBR=dominickn@chromium.org Bug: 1144199 Change-Id: I31cd1c0f718f559d67587b7d9a62ac9c7622ab15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510358Reviewed-by:
-
Lijin Shen authored
Add a detector for message banner view. To detect swipe gestures, set a swipe handler by MessageBannerView#setSwipeHandler. Bug: 1123947 Change-Id: Ie8e1405e4bf4c31b37707a2d5e7f33b582283ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473801Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#822718}
-
Anders Hartvoll Ruud authored
Ideally we would change :host() and :host-context() to take a single compound selector instead of a list, per CSSWG resolution (see bug). Or, failing that, we should simplify the specificity calculation such that it takes place statically. Hence I'm adding use-counters for both of these scenarios. Bug: 1143404 Change-Id: I9b37641a4b95acc25502d66094a7db2147cda753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505981 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5ae623f592fc..93f7621b08d3 2020-10-30 edcourtney@google.com Change ExtractTarball to use existing compression helpers. 2020-10-30 jomag@google.com packages: use chroot-relative path for DriveFS 2020-10-30 edcourtney@google.com Move ExtractTarball to cros_build_lib. 2020-10-30 ahassani@chromium.org xbuddy: Do not rename update payloads to update.gz anymore 2020-10-29 davidriley@chromium.org chromeos_config: Enable Notifications for borealis release builds. 2020-10-29 cjmcdonald@chromium.org uprev_lib: Remove stale package cleanup from chrome uprev manager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I9f86fd819c0970c8b0b6964e5e64d8dc57887477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510319Reviewed-by:
-
Antonio Sartori authored
This CL stores the document's Referrer Policy inside the Policy Container and uses it for inheritance in case of local scheme URLs. The behaviour is hidden behind a feature flag, disabled by default. Change-Id: I5397f55afad0634f485cb5f79134db48b094b3a3 Bug: 1130587, 1075738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424345 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#822715}
-
Jeffrey Young authored
Used for automating ambient mode tast tests. Add prefs for configuring lock screen inactivity timeout and background lock screen timeout after ambient mode starts. BUG=b:169579102 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I2040ea5a0519b985ad246132925815d87754f7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485754 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#822714}
-
Eugene Zemtsov authored
VideoEncoder might be used for live video or something else that a user is waiting for. This priority is suggested by Gabriel Charette. Bug: 1132057 Change-Id: I893b6a17df0cfeee368b8ee5a87afe12912a1ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508516 Auto-Submit: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#822713}
-
chinsenj authored
Currently the desk rename textfield does not account for its padding when eliding its text. This results in the first couple of letters not being visible when a long desk name is typed. This CL fixes this bug by making the desk rename textfield account for its padding. Test: manual Bug: 1142104 Change-Id: I515e9822bd8d1321d62bb976bdfa59ad5fcb48ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505678Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#822712}
-
Andrew Grieve authored
Change-Id: I7151ec2d5161c5ba7b424486f88156a7c6c669f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510091 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822711}
-
Dave Tapuska authored
We can remove the WebWidgetClient callback to get the FrameSinkId and replace it with a parameter passed into the ctor. BUG=1097816 Change-Id: I4369df664776262e9331df8dcc49ff1c97a68325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504748Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#822710}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I4e06a7a480bd6a1f6743fbd035edd52f051f5eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510377Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822709}
-
Igor Britsky authored
For GCC 8.4.0 is important to get all the first initializer in designated init-list in case of implicit construction. Correct compile if use explicit construction. Error example (GCC 8.4.0): In file included from ../../ui/gfx/x/event.h:14, from ../../ui/events/platform/x11/x11_event_source.h:19, from ../../ui/events/platform/x11/x11_event_source.cc:5: gen/ui/gfx/x/xproto.h:2744:16: note: candidate: 'x11::Future<void> x11::XProto::CreateWindow(const x11::CreateWindowRequest&)' gen/ui/gfx/x/xproto.h:2744:16: note: no known conversion for argument 1 from '<brace-enclosed initializer list>' to 'const x11:: CreateWindowRequest&' ../../ui/events/platform/x11/x11_event_source.cc:201:4: error: no matching function for call to 'x11::Connection::ChangeProperty(<brace- enclosed initializer list>)' Bug: 819294 Change-Id: I604af19e3c441bbb788d0b6094c52f12df49269e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506431Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#822708}
-
Yann Dago authored
This is a reland of e977adb7 Original change's description: > PolicyService: Notify when policies from all providers are loaded > > Add a new PolicyService::Observer::OnFirstPoliciesLoaded function to > listen to first policies loaded on a policy domain. This allows > observers to be notified when all policies are loaded. This allows > services that rely on policies to wait for eventual cloud policies > before starting. This can take sometime if the cloud policies do not > have a local cache and need to fetch their policies over the network. > > Bug: 1129065 > Change-Id: I5b50b0b6a1737c818ea2277d905a64151f45c95e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409132 > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Yann Dago <ydago@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822342} Bug: 1129065 Change-Id: Ia10604c2332f616bbed45fc117d005334dacbf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509971Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This flag has been expired since M76 and controls a disabled-by-default feature, so the code controlled by it has been dead for a long time. Bug: 1110712 Change-Id: I6ffd0bf8050fe6cdc5d0dd9f9bcfdef0c93a0323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507396Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#822706}
-
Hidehiko Abe authored
So, the utilities can be used in ui/ozone/platform/wayland in following CLs. Also, along with the move, this CL introduces more error checks and adds unittests. Bug: 1140536 Test: Ran ui_base_unittests, exo_unittests. Quick manual tests with Lacros. Change-Id: I5de661528f328fd0e79154f8011056d1816e0f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489107 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#822705}
-
