- 05 Dec, 2019 40 commits
-
-
Ken Rockot authored
There is really no reason to expect the pre-test browser shutdown not to race with storage commits. This changes the pre-test to effectively wait for a commit before exiting (by queueing a usage request and waiting for the reply), ensuring that the database is opened and pending operations are scheduled before the browser terminates and the actual test goes on to verify the persistence of data. Fixed: 1027940 Change-Id: I58eac4ec5fc9d547f8e10f5f2d12cbf41c6d12ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951765 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#721800}
-
Aidan Wolter authored
This allows other programs to utilize the FeatureListCreator without pulling in all of chromecast:browser. Bug: None Test: CQ Change-Id: Ibab85c394f17d21a53ce1b682e85a5620b17c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945086Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#721799}
-
Julian Pastarmov authored
Currently only the Windows implementation is fully viable. Mac and Linux work but will generate a new secret at every invocation. Bug: 996077 Test: unit_tests Change-Id: Idfa789fa68913f373e3bd2ac02d1194ab249df94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939889 Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721798}
-
Chase Phillips authored
This CL renames ScopeMatches() to IsUrlWithinScope and makes it more general so a later change can use it for scope validity checks. Bug: 999001 Change-Id: I69c504753cb6be09aa2ed6f359372b27198083e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935043 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#721797}
-
Jonah Chin authored
This is a prerequisite for out of process rasterization of canvas. Patch 1: Remove disabling deferral in Canvas2DLayerBridge::WritePixels The idea here is to flush the recording (to execute all queued commands) then call SkCanvas::WritePixels. This is already its behaviour. First patch is essentially a revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1754228 Patch 2: Remove kCanvasAlwaysDeferral flag and any usages of is_deferral_enabled_. Removing the flags since deferral is now always enabled. Patch 3/4: Remove test suite that turns off CanvasAlwaysDeferral Removed all references to disable-deferred-rendering virtual test suite. Also removed any test disablements for this suite. Should likely merge the bugs for those disabled tests into crbug.com/1023273 Bug: 1023273 Change-Id: Ifb16f20e63c058990a91e4975fdf86a4dfc79ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915284 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721796}
-
nancy authored
BUG=1011235 Change-Id: I8de563d0dccff8db1b1a6229c2bdd68c8bb77e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939991 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721795}
-
Yuki Shiino authored
Re-implements SymbolScopeNode._insert_symbol_definition to cover more general combinations of SequenceNode and SymbolScopeNode. Bug: 839389 Change-Id: I3a9163e2a47795e5e5035edf7021ef1d1d715432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948685Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#721794}
-
Toni Barzic authored
DragWindowFromShelfController now notifies home screen controller that the home is about to show when the app window animation to shelf starts. The goal is to start shelf and hotseat transition to home screen state sooner, as the window scale animation starts, instead of when the window animation completes. Additionally, updates ShelfLayoutManager::CalculateHotseatState to return accurate state for home screen and overview when handling shewlf drag completion. BUG=1026902 Change-Id: Ie6a8ae797bdafd3cdcb6f3296a1dae1a08f803d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951565 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#721793}
-
Julie Jeongeun Kim authored
This CL cleans up URLLoaderPtr, one of old Mojo types, from URLLoaderTest with replacing it with PendingRemote<URLLoader>. Bug: 955171 Change-Id: Ib875590e46a7c5ec1f186c53cf3914016fd51b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949806Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#721792}
-
Julie Jeongeun Kim authored
This CL updates struct members from mojom files with pending_remote. These members have been converted to new Mojo types already from C++ code. The reason that it worked with old Mojo types from mojom files is that new Mojo types support compatibility. So, this CL updates mojom files to generate new Mojo types. Bug: 955171 Change-Id: Ic2bf1aeec232cf376862b97cbcdf06500f2ed0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950049Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Move it out of RendererFactorySelector and rename it to RendererFactoryType which is shorter. Also does some misc cleanup: - Make it an enum class - Use kCamelCase style - Use kMaxValue which is recommended - Use std::map for |factories_| Bug: 1018372 Change-Id: I87c4b2a56eae1b00c885aa43379f96896736d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951418 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#721790}
-
chrome://media-appTrent Apted authored
The file handler spec changed in r720766. Update the chrome://media-app manifest.json to the new spec and add a regression test. Bug: 1023742 Change-Id: I54cce5105c5193ea4e847e7ebab5a8f590f16201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949829 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#721789}
-
Kai Ninomiya authored
Bug: chromium:985142 Change-Id: Ifa9b692c47def3cbe1f3b030467a0bb122a2cfd9 TBR: cwallez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951895Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#721788}
-
Roberto Carrillo authored
This should avoid the issue where code coverage instrumentation gets confused about which of the two copies of the compiled code (dav1d_8bit vs dav1d_10bit) is executed, and results in counter overflows. R=mmoroz,dalecurtis@chromium.org,sajjadm,liaoyuke Bug: 1030350 Change-Id: I8b1c93e27017622022e0562957f1f72cf85eecdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951976 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721787}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/391d4f3130da..270946946c93 git log 391d4f3130da..270946946c93 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 thestig@chromium.org Fix wrong integer type CPDF_SecurityHandler::GetUserPassword(). Created with: gclient setdep -r src/third_party/pdfium@270946946c93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030583 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I089bf4bf8a06008f4f0d5e1c1f32b17d0ae49cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721786}
-
Yngve N. Pettersen authored
This allows embedders to customize this kind of startup operations without editing chromium Change-Id: Ic020b13a87b4e59d7156385da37555683d2418a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944392 Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#721785}
-
Natalie Chouinard authored
Remove feature-specific autofill code from PreferencesLauncher to AutofillProfileBridge. This is a prerequisite to modularizing PreferencesLauncher as described in go/clank-preferences-refactor. Bug: 1029194 Change-Id: I50bb9579d3733084b0de83045c0df8a7092ae514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941275Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#721784}
-
Taylor Bergquist authored
This animation is not to spec - this is partial progress towards that animation which I'm landing because it's convenient to do so. Bug: 1024009 Change-Id: I96e0233c1b755dc8f8b9cb33aac59e8bcf16efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949678 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721783}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c4a669a1bfc2..989b6154e4ff git log c4a669a1bfc2..989b6154e4ff --date=short --first-parent --format='%ad %ae %s' 2019-12-04 ajwong@chromium.org Reduce LogcatMonitor timeout to 10ms. Created with: gclient setdep -r src/third_party/catapult@989b6154e4ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1021686 Tbr: sadrul@google.com Change-Id: Ic4aa069bd8dc6c224315aa76dc79b4c356ab0b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951409Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f3456e3314b..e3c25715ec2b git log 5f3456e3314b..e3c25715ec2b --date=short --first-parent --format='%ad %ae %s' 2019-12-04 jmadill@chromium.org gn: Minor improvements. 2019-12-04 syoussefi@chromium.org Vulkan: Optimize unused uniform cleanup in glslang wrapper 2019-12-04 syoussefi@chromium.org Re-enable atomic counter tests on !windows 2019-12-04 jmadill@chromium.org Vulkan: Fold read access into write flags on buffer writes 2019-12-04 shrekshao@google.com Turn on fboRenderMipmap for D3D11 2019-12-04 courtneygo@google.com Split out core.compute_shader expectations 2019-12-04 courtneygo@google.com Add Compute Shared Memory Size Validation Created with: gclient setdep -r src/third_party/angle@e3c25715ec2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1023747,chromium:4173 Tbr: geofflang@google.com Change-Id: I7473328956aa65bbc3a71c145c9428686f2e34f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951411Reviewed-by:
-
Daniel Murphy authored
During a refactor, the filename used for memory dumps was dropped. This fixes that. R=rockot@chromium.org Bug: 1028623 Change-Id: I439eff20e0ddd19329a100a84be33dcd5f482073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951779 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Eric Willigers authored
The Mac icons for minimal-ui are not implemented yet. Desktop minimal-ui will initially ship on Chrome OS, Windows and Linux. Bug: 1028393 Change-Id: If3fc14a7829ce3a9fe866eceb92b09ce6b2b8a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952043 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#721779}
-
Takumi Fujimoto authored
Disable tests that were determined by Findit to be flaky. TBR=bsazonov,szermatt Bug: 1030217, 1030559, 1030561, 1030683, 1030903, 1030562, 1030558, 1030218 Change-Id: If58bf930e3963dadac6682cab38674f30fee1efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951894Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721778}
-
Varun Khaneja authored
I haven't removed the pref entirely since that can be used as-is later. Fixed: 1030815 Change-Id: Ie93427232fbb5f3a8086b0faa66f7a14dedb3a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951658Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#721777}
-
Albert Chaulk authored
Resources still get produced frequently, but because no TextureDrawQuads are produced the associated mailboxes don't get cleaned up Fix this by also including the resource, so that the compositor will trigger the usual cleanup path Bug: b/145355036 Test: manual test on device Change-Id: Ia364aef10fba5b5af67eb440b30a30bdb6a12361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949345 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#721776}
-
Jinsuk Kim authored
The top shadow drawable for bottom sheet consists of 3 parts vertically - round-cornered view, shadow, and an empty space at the top. In order to remove the gap between bottom sheet and infobar (or any other view bottom container), the infobar needs to be lowered down by the height of shadow plus that of the empty space. This CL defines a new constant |bottom_sheet_shadow_top_offset| for the space, and applies it to bottom container. Bug: 1025098, 1030251 Change-Id: Ic145e861fcc5f1639196f6b96d3bfe3208fc0581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948367 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#721775}
-
mark a. foltz authored
Adds a TODO to the issue to fix dependencies. TBR=takumif@chromium.org Change-Id: I7b75ae3d4925e3f99cc62335a353cabd8bd89c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951488Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#721774}
-
Abhijeet Singh authored
Bug: b:143715504 Change-Id: I8f362488e8d79a90a2c294c3978e3c56e8ca5391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948810Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#721773}
-
Jonathan Backer authored
Presentation helper only picks up changes to the use of EGL timestamps when we make current (GLSurfacePresentationHelper::OnMakeCurrent). With virtual contexts we very rarely call MakeCurrent. This CL adds a MakeCurrent on initialization to pick it up. Change-Id: I2cc5429004e6f2d84782091464d0a90aa5d25ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951581 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721772}
-
David Van Cleve authored
The DNS fuzzer dictionaries contain some preconstructed record fields for A, AAAA, and CNAME records. This patch adds corresponding values for ESNI (draft 4) records to hopefully increase the fuzzer's coverage of the ESNI parsing code. R=ericorth Bug: 1003494 Change-Id: Id3ef0f0cb77bf3eb5721e4aacf55d87b6ae6707d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924548 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#721771}
-
John Lee authored
This CL sets up the scroll container to the the TabListElement itself, allowing the TabListElement to directly control its own scroll position without having to modify anything outside of itself. This also allows for various optimizations so that layout does not need to be re-calculated multiple times. Other optimizations include using a cache of CSS variables to determine the relatively static dimensions of tabs and viewport. Bug: 1023492 Change-Id: I00874f36ab022aed15477c98652f8014b6098ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948059Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#721770}
-
Caleb Rouleau authored
TBR=alexclarke@chromium.org Bug: 1030735 Change-Id: Ica41739148816215876d6da58bef0acaa548fada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951776Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#721769}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=lpy@chromium.org Bug: 1023677 Change-Id: Ib862853982d5623ee977d4ae21104b10937a4f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926827 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721768}
-
Simeon Anfinrud authored
If a source file in a target #includes, transitively, a header generated by e.g. a buildflag_header, mojom, or grit target, the compiler may attempt to compile that translation unit before the header is generated unless gn properly declares the dependency on the action that generates the header. This patch adds some missing deps that at least allows the test_support target to be compiled from scratch without first compiling some other target, which was blocking some builds in the chromecast internal project. Bug: 800764 Test: build the following target in a clean out directory: third_party/blink/renderer/modules/peerconnection:test_support Change-Id: I1c469a37585f142df5c97e6a0ba21c76a889759f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947558Reviewed-by: -
Chase Phillips authored
This is the first in a series of changes that introduce a manifest scope in AppCache. Prior to these changes, a manifest can specify CHROMIUM-INTERCEPT and FALLBACK sections with resources that exist outside of the scope of the manifest's URL. After these changes, a manifest by default will have a scope that is the URL of the manifest stripped to the right-most forward-slash. Any resources specified in the CHROMIUM-INTERCEPT or FALLBACK sections will need to reside within this scope. This CL adds a manifest_parser_version which is currently 0 and plumbs that through AppCache, AppCacheUpdateJob, and AppCacheManifestParser. manifest_parser_version is kept in 2 members: cached_manifest_parser_version_ (a const) and fetched_manifest_parser_version_. The manifest parser currently gets cached_manifest_parser_version_ from the group which initializes to 0 and always results in a fetched_manifest_parser_version_ of 0, so this change is effectively a no-op. This CL also adds a manifest_scope which is currently set to the manifest URL's root path. The manifest_scope is retrieved in 3 stages, and there's a member for each stage: cached_manifest_scope_ and fetched_manifest_scope_. Initially, all of these are set to the manifest URL's empty path to make this a no-op change. Eventually, this will be tightened down to a stricter default of the manifest URL without a filename. Bug: 999001 Change-Id: I723c594e9e5abec6608c4a9eb0cd77c8434fd46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934316Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Jiawei Shao authored
This patch adds the check to ensure that in WebGPU command buffer decoder deviceTick() is called only when wgpu_device_ is not nullptr. In current implementation wgpu_device_ will not be created until RequestAdapter() is called, so wgpu_device_ may not be always valid after the creation of WebGPU command buffer. BUG=chromium:996713, chromium:1028241 Change-Id: I868e178dbad69ece0618d3d7b72112b1a129827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949774Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#721765}
-
Chisoon Jeong authored
Change-Id: I1ab3e2c1b18dbd3614e4bf0cc9f29a3b91d632f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946056 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Ayu Ishii authored
This change add a check to ensure frame is available, and to return and error if not before proceeding with the call. Bug: 1027394 Change-Id: Ib839321b7a9eef193b4285523ac60344d4a3a049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947192 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Follow-up to commit 470bf888 ("heap: Resolve data race in addition to HashTable"), which started using std::atomic outside the DUMP_HASHTABLE_STATS ifdef. This fixes the build with libstdc++ (it looks like <atomic> was being implicitly included by libc++): ../../third_party/blink/renderer/platform/wtf/hash_table.h:1796:31: error: implicit instantiation of undefined template 'std::atomic<std::pair<blink::OffererState, blink::OffererState> *>' AsAtomic<ValueType*>(table_).store(new_table, std::memory_order_relaxed); ^ ../../third_party/blink/renderer/platform/wtf/hash_table.h:1863:22: note: in instantiation of member function 'WTF::HashTable<std::pair<blink::OffererState, blink::OffererState>, std::pair<blink::OffererState, blink::OffererState>, WTF::IdentityExtractor, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState , blink::OffererState> >, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::RehashTo' requested here Value* new_entry = RehashTo(new_table, new_table_size, entry); ^ ../../third_party/blink/renderer/platform/wtf/hash_table.h:1068:5: note: in instantiation of member function 'WTF::HashTable<std::pair<blink::OffererState, blink::OffererState>, std::pair<blink::OffererState, blink::OffererState>, WTF::IdentityExtractor, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::Rehash' requested here Rehash(new_capacity, nullptr); ^ ../../third_party/blink/renderer/platform/wtf/hash_set.h:180:11: note: in instantiation of member function 'WTF::HashTable<std::pair<blink::OffererState, blink::OffererState>, std::pair<blink::OffererState, blink::OffererState>, WTF::IdentityExtractor, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState, b link::OffererState> >, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::ReserveCapacityForSize' requested here impl_.ReserveCapacityForSize(SafeCast<wtf_size_t>(elements.size())); ^ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker.cc:26:7: note: in instantiation of member function 'WTF::HashSet<std::pair<blink::OffererState, blink::OffererState>, WTF::PairHash<blink::OffererState, blink::OffererState>, WTF::HashTraits<std::pair<blink::OffererState, blink::OffererState> >, WTF::PartitionAllocator>::HashS et' requested here : valid_offerer_transitions_( ^ /usr/lib/gcc/x86_64-redhat-linux/9/../../../../include/c++/9/bits/atomic_base.h:148:12: note: template is declared here struct atomic<_Tp*>; ^ Bug: 957519 Change-Id: I0694785f6f5191b82773ea5144dfba20b113afb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951024 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Stephen Martinis authored
This reverts commit 7fb4c506. Reason for revert: Won't remove chromium.webkit.json Original change's description: > Revert "Remove exparchive from testing configs" > > This reverts commit 23dd050b. > > Reason for revert: Broke rebaseline-cl, https://crbug.com/1018936 > > Original change's description: > > Remove exparchive from testing configs > > > > Bug: 840252 > > Change-Id: I7181f1adde1d2b11b4ca5da6535210112f031317 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877229 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#709666} > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > # Skipping CQ because the failure is unrelated, other tests pass, and > # this is breaking rebaseline-cl. > > No-Try: true > Bug: 840252 > Change-Id: If30dac52b2e23aff12dd8144d517e7a504a9c1bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885251 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710102} Bug: 840252 Change-Id: I23d620370b1dad7f6eee777ad9aaa7b751923775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949455 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721761}
-
