- 19 Feb, 2020 40 commits
-
-
Hirokazu Honda authored
This is a reland of 139567ba Original change's description: > content/renderer/media: Query GPU process HW encoder capabilities > > Originally GpuVideoAcceleratorFactoriesImpl get HW encoder > capabilities by referencing values stored GpuInfo instance. > However, the values are not updated after GPU process boots up. > Even if a new hw encoder is available after GPU process is > initialized, the hw encoder is not detected. > > This fixes the problem by querying GPU process the hw encoder > capabilities when a render process is created. e.g. open the > page. > > Bug: b:147404923 > Test: HW encoder is used at appr.tc > Test: tast run webrtc.* on krane > Change-Id: Ibca82b6e54e9b5d585037c8e63f4c663d085db0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994849 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735339} Bug: b:147404923 Change-Id: Ia5535e0d316c0418f15e1139d475af67f226ed14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035481 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742563}
-
Fredrik Söderquist authored
Change the structure of these pair of functions such that the former handles the cache lookup and calls the latter to mint a new PatternData. Remove the redundant check for an empty 'viewBox'. LayoutSVGResourcePattern::PatternForClient is removed, because the issue mentioned in the FIXME should no longer be present. Bug: 109212 Change-Id: I5514dce39c20e07adbf45ea46c2dd472a4c71303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061752 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742562}
-
Sergey Poromov authored
This reverts commit b51be283. Reason for revert: Breaks builds. Original change's description: > Revert "Allow mixed-security content in promoted PWA windows" > > This reverts commit ef364481. > > Reason for revert: [sheriff]: > Consistent failures on linux-chromeos-chrome > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome > First failed run: > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 > > Original change's description: > > Allow mixed-security content in promoted PWA windows > > > > Prior to this CL, mixed-security content was blocked entirely in > > standalone PWA windows with scopes. This CL allows those PWAs to display > > mixed-security content, but when this happens, the window will show the > > CustomTabBarView with the URL and a "Not Secure" indicator to indicate > > the presence of mixed content. > > > > Screenshot: > > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 > > > > This removes a behavioural difference between promoted PWAs and "create > > shortcut" apps without manifest scopes. > > > > > > Bug: 910016 > > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#742515} > > TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org > > Change-Id: Ibb71d71f13f3fea753b5cb80a4a98c733a093c12 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 910016 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063015 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742557} TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,poromov@chromium.org,dominickn@chromium.org,glenrob@chromium.org Change-Id: Ifef5a3c6a34563999506f4c5946273533ad0063d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063016Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742561}
-
Sergey Poromov authored
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31990 TBR=alcooper@chromium.org Bug: 1053903 Change-Id: Idbd00ecfe63d58649969714912fffa8d083fefe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062275 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742560}
-
Greg Thompson authored
- Push expiration of some cleanup histograms out by a few milestones since the related cleanup code is still being used. - Remove the legacy multi-install Chrome Frame cleanup and its related histogram since it is now very rarely used. - Remove the legacy app_host.exe cleanup and its related histogram since it is nearly never used. - Mark Setup.Install.StrandedChromeIsUsed as obsolete since it was removed from the codebase years ago (oops). - Mark Setup.Install.Result as never expiring since it is a fundamental metric. BUG=1053134,1053138 R=bcwhite@chromium.org Change-Id: Icc89877e442abc5953ba3a2deb9788487da60569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060951 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742559}
-
Clemens Arbesser authored
I only recently realized that the generic ui framework is actually much more simple if we remove this requirement. Now, callbacks have to be fully specified in proto, which is easier to read and understand (and also less code). This is a refactoring and does not contain user-facing changes. Bug: b/145043394 Change-Id: I96b66af316a4b4c205c0d0234f841075e96f8be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038653 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#742558}
-
Sergey Poromov authored
This reverts commit ef364481. Reason for revert: [sheriff]: Consistent failures on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failed run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315 Original change's description: > Allow mixed-security content in promoted PWA windows > > Prior to this CL, mixed-security content was blocked entirely in > standalone PWA windows with scopes. This CL allows those PWAs to display > mixed-security content, but when this happens, the window will show the > CustomTabBarView with the URL and a "Not Secure" indicator to indicate > the presence of mixed content. > > Screenshot: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 > > This removes a behavioural difference between promoted PWAs and "create > shortcut" apps without manifest scopes. > > > Bug: 910016 > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742515} TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org Change-Id: Ibb71d71f13f3fea753b5cb80a4a98c733a093c12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063015Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742557}
-
Jan Wilken Dörrie authored
This change modifies chrome.passwordsPrivate.requestPlaintextPassword to take an extra PlaintextReason parameter. This parameter will be used for logging, as well as performing different actions, such as copying the password to the clipboard in the browser process. Furthermore, it modifies the existing implementation to use chrome.runtime.lastError to signal errors and renames a few methods for consistency. Bug: 1047726 Change-Id: I962081a22f0947e64523289ca4e4933fa02b0137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050489 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#742556}
-
Colin Blundell authored
This CL injects dependencies into ChromeSSLHostStateDelegate directly rather than getting these dependencies internally from the Profile. The motivation is to componentize this class for sharing with WebLayer, replacing WebLayer's custom implementation of content::SSLHostStateDelegate. Bug: 1030692 Change-Id: I6ecd95e76ffa01a57a3f3a9fcb8fb827ac960364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060669Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#742555}
-
Keishi Hattori authored
Some observers call their regular shutdown methods from ContextDisposed(), and they end up calling RemoveObserver while HeapObserverList is being iterated over. To support this natively this CL adds removal while iteration support by sacrificing stable iteration order. Bug: 1052319 Change-Id: I83ece3b5596550b9016c911e433f6f9e1a5fdc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060348Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742554}
-
Robbie Gibson authored
This flag already exists and is used for this purpose on Android and Desktop. This adds the flag to iOS. Bug: 1048193 Change-Id: Ia50dbcc3994cc74592f821a3fbc6c3f74ff785a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056776Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#742553}
-
Guido Urdaneta authored
This reverts commit 9be2d95a. Reason for revert: Does not fix the issue. The actual timeout detection should be elsewhere. Original change's description: > [getUserMedia] Introduce timeout for video format queries. > > This CL causes getUserMedia() to fail if requesting video formats > exceeds a timeout. > This is suspect of causing getUserMedia() hangs in some environments > such as virtual machines. > > Drive-by: Add some comments, a thread check, and some extra WebRTC > logging. > > Bug: 1044974 > Change-Id: I87f7687c491b4a502f4dba57d2c57bc53cb81390 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015249 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734493} TBR=guidou@chromium.org,armax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044974 Change-Id: I21c0ba8ab734b2e4b132f7f6409631e81660d375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062969Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#742552}
-
Sergey Poromov authored
This reverts commit a4abe593. Reason for revert: [sheriff]: Consistent failures on linux-chromeos-chrome: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome First failed run: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3306 Original change's description: > Reland "Enable passive mixed content warning by default" > > This reverts commit 562af1be. > > Reason for revert: Failing test was disabled since it should run with autoupgrades disabled, will investigate and fix why InitAndDisableFeatures is not doing that separately > > Original change's description: > > Revert "Enable passive mixed content warning by default" > > > > This reverts commit 0a37869a. > > > > Reason for revert: Causing failure of DidChangeVisibleSecurityStateTestWithAutoupgradesDisabled.DidChangeVisibleSecurityStateObserver in browser_tests on linux-chromeos-chrome > > Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3194 > > > > Original change's description: > > > Enable passive mixed content warning by default > > > > > > Sets the feature to enabled by default and removes the config from > > > fieldtrial_testing_config.json in preparation for launch. > > > > > > Bug: 1025276 > > > Change-Id: Iffcdd2153491de25b7038a609776255bbdacf2ac > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053024 > > > Commit-Queue: Carlos IL <carlosil@chromium.org> > > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > > Reviewed-by: Emily Stark <estark@chromium.org> > > > Auto-Submit: Carlos IL <carlosil@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#741506} > > > > TBR=rkaplow@chromium.org,estark@chromium.org,carlosil@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1025276 > > Change-Id: I20e9dc38d83036c7b17d91de24c23ebae3049de9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058970 > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741860} > > TBR=rkaplow@chromium.org,estark@chromium.org,bsep@chromium.org,carlosil@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1025276 > Change-Id: I9e2043fc150b9225bc32537b0cee669f1836802a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062671 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742366} TBR=rkaplow@chromium.org,estark@chromium.org,bsep@chromium.org,carlosil@chromium.org Change-Id: I554708d53c87488e8f199c52b32dd2d62471bb1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062416Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742551}
-
Sergey Poromov authored
This reverts commit 653f075d. Reason for revert: Consistent failures on Linux: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests The first failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/87279 Original change's description: > Clear the subresource redirect hints when navigation is started > > RenderFrames could be reused for same-origin navigations. This causes > the hints from previous navigations to be used in next navigation > until the new hints fetch finishes and updates the hints. This CL clears > the hints. > > Unfortunately this causes race conditions between the image fetch and > the hints update, which causes images to not redirected to compressed > versions. So the image fetches are delayed a bit to circumvent this. > > Bug: 1051283 > Change-Id: Ie9e5351e68c0081ab9dbfe23faed2c3c5e8e4d42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056207 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742326} TBR=tbansal@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org Change-Id: I74441c0600ab5fe5de3016c813590a5d3d21e447 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1051283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063170Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742550}
-
Sergey Poromov authored
This reverts commit e490a00a. Reason for revert: Sheriff here: Consistent failure of Linux MSan Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests First failed run: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22357 Original change's description: > Reland "Make PWA titlebar and icons flex and animate properly." > > This reverts commit de7cd485. > > Reason for revert: Fixing issue with Mac tests. > > Original change's description: > > Revert "Make PWA titlebar and icons flex and animate properly." > > > > This reverts commit 8f2f4243. > > > > Reason for revert: speculative revert for test failures on Mac > > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g. > > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700 > > > > Original change's description: > > > Make PWA titlebar and icons flex and animate properly. > > > > > > Nested layouts now allocate available space properly to their > > > descendents. Also, we consistently use flex layout in the PWA titlebar. > > > > > > Removed a couple of invalid assumptions that were encoded as DCHECKs. > > > > > > There are still some inkdrop issues but they are purely cosmetic, see > > > crbug.com/1006162 for more detail. > > > > > > Bug: 1048061 > > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264 > > > Commit-Queue: Dana Fried <dfried@chromium.org> > > > Reviewed-by: Peter Boström <pbos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#738874} > > > > TBR=pbos@chromium.org,dfried@chromium.org > > > > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1048061 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615 > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738907} > > TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org > > Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742203} TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org Change-Id: If65099915ea0efa01de8cc9b0df0a7e9bf03a60b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062996Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742549}
-
bttk authored
Bug: 1046181 Change-Id: I371ad290e454e55c0f8133b4397b26a9b902e3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024176 Auto-Submit: bttk <bttk@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#742548}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c.2043181, and remove IconType by directly using mojom::blink::FaviconIconType in Blink. Bug: 1040099 Change-Id: If2d589ca5579f5fbba45f13e4fb9cda450ccf121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053908 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742547}
-
Manuel Rego Casasnovas authored
The methods to check and set the visual overflow recalc flags were both doing similar checks, so we were duplicating those calls. In this change we somehow inline the code of that methods so we avoid repeating those operations. This is intended to improve performance in perf_tests/shadow_dom/v1-small-deep-distribution.html. BUG=1051342,941180 Change-Id: Ica18dd6d07b9f8bca9c35c9db438fbc09bb4a53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062430 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742546}
-
Nikita Podguzov authored
Bug: 996785 Change-Id: Icfce332a4cc763bdabed6a235224a6cea014c203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015040Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742545}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/333b29e11603..53bc9c82f33f Created with: gclient setdep -r src-internal@53bc9c82f33f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic040b66cffb1b667df8dd46c12f7147619df3c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742544}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4af84fff. With Chromium commits locally applied on WPT: ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I96fef74d2fd31792ad7a61a6d2917d69654a284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063451Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742543}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fefe765c06..79f8caf9154a git log 77fefe765c06..79f8caf9154a --date=short --first-parent --format='%ad %ae %s' 2020-02-18 bclayton@google.com vscode: Add missing fields to schema.Opcode (#3169) 2020-02-18 siglesias@igalia.com spirv-val: Add support for SPV_AMD_shader_image_load_store_lod (#3186) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@79f8caf9154a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I93668639b207123df68ca91e88586e7db4eee031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742542}
-
Morten Stenshorne authored
fragmentation/auto-overflow.html now starts to fail, but that test is invalid, so removing it. A block with overflow:auto is potentially scrollable, and treating it as monolithic therefore makes sense. All other browsers do this as well. Note that we did actually "always" treat it as monolithic, as far as LayoutBox::GetPaginationBreakability() was concerned, but since our legacy engine doesn't really understand fragmentation, we ended up slicing it, making the test pass. LayoutNG will now let such tall objects overflow the column instead, which wouldn't match the expectation. Bug: 829028 Change-Id: Id2ca5488049ef8e768a363e4dbe8767c7bc4d645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062351Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#742541}
-
anina koehler authored
Deprecate the policy schema SCHEMA_ALLOW_INVALID since it only has a different value from SCHEMA_ALLOW_UNKNOWN on Mac OS and Android and in a low percentage of its use cases. Bug: 969706 Change-Id: Ie5251e1ceaa6a4bc8472e6bb1477b7a6de45fc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018946 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#742540}
-
Marc Treib authored
Bug: 1053171 Change-Id: I197a7fda2e2f2521fe2cafc556749bf4fd1a424c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751786Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#742539}
-
Hitoshi Yoshida authored
- adds more native_value_traits_impl.h includes - adds include for a union type Bug: 839389 Change-Id: I454f2e5a2e9d757439ee3def1edafa53c18bb860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060443Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#742538}
-
Side Yilmaz authored
incognito. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL changes behavior to use always off-the-record profile for HelpAndFeedback activity, because it is "incognito learn more" button and it is always called in incognito mode. Bug: 1041781 Change-Id: I4438919d6afcd0efbec1dc5198fb94729c981707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060073Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742537}
-
Julie Jeongeun Kim authored
This CL converts FrameMsg_ChildFrameProcessGone to RenderFrameProxy and removes FrameMsg_ChildFrameProcessGone message. Bug: 1051137 Change-Id: I55e24ee59d2c15273988f7d1636edfe2f0198f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062010Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#742536}
-
Alan Cutter authored
This CL moves BookmarkAppRegistrarBrowserTest into being a HostedAppBrowserTest. Additionally it renames the existing HostedAppBrowserTests to HostedOrBookmarkAppBrowserTests to more accurately reflect the params its instantiated. Now HostedAppBrowserTest is only for hosted apps. Branch: +hosted-app-not-web-app Change-Id: Ic7dbe52669cf10895006d584a1d08ed8f7f8e8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059698 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#742535}
-
Side Yilmaz authored
incognito. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL changes behavior to use always off-the-record profile for incognitoLearnMoreClickListener. Bug: 1041781 Change-Id: I39911b87ada97db6187aa4fb540c382c061a203d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054963Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742534}
-
Alan Cutter authored
This CL updates AppRegistrar::FindAppWithUrlInScope() to ignore the IsShortcutApp() status of a web app and just use the default scope the same as a specified scope. This makes web apps with default scopes will be treated the same as web apps with scopes specified in their manifest reducing the behavioural differences between promoted installs and "create shortcut" installs. Bug: 910016 Change-Id: Ifa2c94132fa806a013a6d210dff0d7505df4c3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051464 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#742533}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: Icaecfbdc9596cf7fb8eaf12b99b3e3ae8839de94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062348Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742532}
-
Vasilii Sukhanov authored
They are - oauthaccountmanager.googleapis.com - passwordsleakcheck-pa.googleapis.com Bug: 1049177 Change-Id: I256a5530209f7601c8587d64e4789c2c46ff22b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062408Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742531}
-
Tarun Bansal authored
Change-Id: Ie27b6fe8ed3f9b2e769baf4111c2229f0f3a6803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063894 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742530}
-
Kunihiko Sakamoto authored
It's been a long time since these features got enabled by default (SignedHTTPExchange in M73 and SignedExchangeReportingForDistributors in M74). There's no reason to associate them with the Experimental Web Platform Features flag anymore. This will eliminate the confusion that the combination of --disable-features=SignedHTTPExchange and --enable-experimental-web-platform-features does not disable SignedExchange. Bug: 1052251 Change-Id: I9e70b850d86473df0ac40ef43a43c5b123d50ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063195Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742529}
-
Kuo Jen Wei authored
Bug: None Test: Manually check GA event is (not) emitted from network panel for tast and manual run. Change-Id: Ia42e8b18378a8a5bf53a31209a34dc7c642ed6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060217 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#742528}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates HelpAndFeedback activity initialization at settings classes. Since settings is considered as always running on regular mode, it is safe to use regular profile even called in incognito mode. For this reason, there is no need to make change on code behavior to act differently for each profile. Therefore, it is safe to leave behavior as-is today. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Ic3bc99d747d28aa6269b7243d7f9feb7337ed75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058817Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742527}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580123479-benchmark-81.0.4044.0-r1 to 82-4044.5-1581936665-benchmark-82.0.4058.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0938ff21d18fa36bce4aa014a34225a496f57338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742526}
-
Hwanseung Lee authored
Use enum class instead of enum for InkDropHighlight::AnimationType. enum class is more type safety. Bug: 940736 Change-Id: I4fb353a460efd4387f7caa16aed4ee968c426728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062017 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742525}
-
Lei Zhang authored
- Use early returns to avoid 5 levels of indentations. - Call base::File::GetInfo() earlier to retrieve the file size, and avoid making a separate GetLength() call. - Use std::vector and avoid a memory allocation with "new". Change-Id: I8a036047df1b09ac0871ec6b264935c91c9b57c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055996 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#742524}
-