GitLab

This CL moves the call to Init Previews into ProfileManager alongside
similar calls.

Bug: 896001
Change-Id: If1bcecd73b9b5cab9f4ec101bd1e0e09867dba28
Reviewed-on: https://chromium-review.googlesource.com/c/1308990Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604757}

https://chromium-review.googlesource.com/c/chromium/src/+/1278226
attempted to fix these, but there was still an issue because
last_upload_finish_time_ was being set to TimeTicks() instead of
Now().

Bug: 894909
Change-Id: Ibacc8755e53ed6a67fa0ba5a52cea1f281f32c36
Reviewed-on: https://chromium-review.googlesource.com/c/1310639Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604756}

conformance/rendering/gl-scissor-fbo-test.html
Flaky also in Release (Vulkan Win Nvidia passthrough)
deqp/data/gles2/shaders/swizzles.html
Fail (Vulkan Win Nvidia passthrough debug)

conformance2/textures/image_bitmap_from_video/*
Flaky on Linux Nvidia GL passthrough

TBR=kbr@chromium.org

Bug: 766918, angleproject:2939, angleproject:2940
Change-Id: I608b5a25275db953d8d2e0d2ac2fc5343caa64f0
Reviewed-on: https://chromium-review.googlesource.com/c/1313287Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604755}

Bug: 896865
Change-Id: Ide1f9ae86533d5f2c6296da8b77e35c08d8a264e
Reviewed-on: https://chromium-review.googlesource.com/c/1289675
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604754}

- Fixes issue where switching wifi networks while starting Mdns
  HostLocator would crash chrome.

Bug: chromium:900779
Test: end to end
Change-Id: Ide5e1bb53961dcd654aedadbffc6cf2a83c5d998
Reviewed-on: https://chromium-review.googlesource.com/c/1313331Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604753}

Bug: b/116166191
Test: Manual Test
Change-Id: Ia9270ce57d2fd4c2b1f563612c892877ee08e251
Reviewed-on: https://chromium-review.googlesource.com/c/1310913
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604752}

Bug=internal 117626741

Test=locally disable widevine and build on atv.

Change-Id: Ic30c773b8c37d6f2ef500dea0bb3ed2a3e94714b
Reviewed-on: https://chromium-review.googlesource.com/c/1308763Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604751}

The page had gotten badly out of date. This CL rewrites most
of it to reflect current policy and practice and stops pointing
to viewvc for other links ;)

Change-Id: I62cc952a6f56954af723f4d57b2fadfd84227bda
Reviewed-on: https://chromium-review.googlesource.com/c/1298650
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604750}

Changed DevTools SystemInfo.GetProcessInfo() process type from enum to string.

Change-Id: I7831d6b3fd9a4d2a1feb8aa4c4541d3f86c91a85
Reviewed-on: https://chromium-review.googlesource.com/c/1312117Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604749}

In this CL, four FeatureParams were added.

These 2 are added for "os_win && google_chrome_build" when
kNuxOnboardingFeature is enabled:

kNuxOnboardingNewUserModules
kNuxOnboardingReturningUserModules

And 2 more are added for when the feature is force-enabled with
kNuxOnboardingForceEnabled on other platforms/non-branded build:

kNuxOnboardingForceEnabledNewUserModules
kNuxOnboardingForceEnabledReturningUserModules

Sample command line to test the changes:

./out/gn/chrome --user-data-dir=/tmp/debug_chrome_1 \
    --enable-features="NuxOnboardingForceEnabled<study" \
    --force-fieldtrials=study/g1 \
    --force-fieldtrial-params=study.g1:new-user-modules/nux-google-apps/returning-user-modules/nux-email

TBR=mpearson@chromium.org

Bug: 874153
Change-Id: I495e6492ee66ce20ec8bfad8743d20c9c55acf53
Reviewed-on: https://chromium-review.googlesource.com/c/1311659
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604748}

This reverts commit 19b1b85c.

Reason for revert: breaks mac-dbg build

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-dbg/1574

In file included from ../../remoting/host/remoting_me2me_host.cc:15:
In file included from ../../base/bind.h:10:
In file included from ../../base/bind_internal.h:13:
In file included from ../../base/callback_internal.h:14:
In file included from ../../base/memory/ref_counted.h:16:
../../base/logging.h:786:26: error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
DEFINE_CHECK_OP_IMPL(NE, !=)
~~~~~~~~~~~~~~~~~~~~~~~~~^~~
../../base/logging.h:774:33: note: expanded from macro 'DEFINE_CHECK_OP_IMPL'
    if (ANALYZER_ASSUME_TRUE(v1 op v2))                                      \
                             ~~ ^  ~~
../../base/logging.h:338:36: note: expanded from macro 'ANALYZER_ASSUME_TRUE'
#define ANALYZER_ASSUME_TRUE(arg) (arg)
                                   ^~~
../../remoting/host/remoting_me2me_host.cc:1576:3: note: in instantiation of function template specialization 'logging::CheckNEImpl<unsigned int, int>' requested here
  DCHECK_NE(getuid(), 0);
  ^
../../base/logging.h:960:31: note: expanded from macro 'DCHECK_NE'
#define DCHECK_NE(val1, val2) DCHECK_OP(NE, !=, val1, val2)
                              ^
../../base/logging.h:913:18: note: expanded from macro 'DCHECK_OP'
      ::logging::Check##name##Impl((val1), (val2),                     \
                 ^
<scratch space>:21:1: note: expanded from here
CheckNEImpl
^
1 error generated.


Original change's description:
> [MacOs Host] Provide user with a prompt to enable input injection on Mojave
> 
> This change is required due to new security restrictions in Mojave.  We can no longer
> inject input w/o being added as an accessibility app in the security applet.
> 
> While this sounds like a usefulk speedbump, it causes remote access applications quite
> a bit of trouble:
> 1.) We don't use the restricted API until a user connects so they cannot approve remotely
> 2.) The dialog appears to only show up once (regardless of approve/deny status)
> 3.) Users connecting to a locked machine will never see the dialog
> 
> This is affecting quite a few CRD users, basically everyone who upgrades to Mojave
> will experience this one way or another.  This is the simplest fix (and easiest to merge)
> that I could think of to unblock users.  The prompt will only be shown on 10.14+ platforms
> and the request is only shown if the app has not been approved.  I'd like to look at the
> user feedback after releasing this change to see if more work is needed.
> 
> One problem I anticipate is that the dialog shown doesn't have a lot of context and it
> refers to the wrapper script (org.chromium.chromoting.me2me.sh) instead of Chrome Remote
> Desktop.  If this is confusing, we can wrap the prompt request in a dialog where we control
> the text.  My concern with checking in the feature first is that the new strings won't be
> available for merging.
> 
> Another behavior to call about this impl is that the prompt will be displayed in two instances:
> 1.) When the host is first started (choosing enable via app/website)
> 2.) When the user signs in and the host service is started
> 
> Scenario #2 will have less context but that is the only way to ask for permission for
> users who upgraded and had CRD installed previously.  The dialog is not displayed at the login
> screen (i.e. when no one is signed in).
> 
> One last note, there is no way that I can see to specify this permission in the manifest or
> set up via a script / at install time.  It requires a user action to complete.
> 
> Bug: 901021
> Change-Id: I9dd1b24b6d4d083e7e019af32a0da816f6060a86
> Reviewed-on: https://chromium-review.googlesource.com/c/1313170
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604723}

TBR=jamiewalch@chromium.org,joedow@chromium.org

Change-Id: I7c948b26c00f6c6fc7c4e0a3ec4175dcae17e459
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 901021
Reviewed-on: https://chromium-review.googlesource.com/c/1313747Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604747}

Bug: None
Change-Id: Id27ad0db8e6749efe25aca72d74e023cf9267ac1
Reviewed-on: https://chromium-review.googlesource.com/c/1308083Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604746}

EventGenerator::PressTouch would set |is_touch_down_| of aura::Env to
be true. And aura::Env is singleton and shared by test cases. So in CL,
AshTestBase::SetUp is modified to reset aura::Env's properties.

Bug: 586514
Change-Id: Iea96d7fcfc2fba1db857e0d8fe7a1931300cf0cd
Reviewed-on: https://chromium-review.googlesource.com/c/1293174Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604745}

The map to ContentRule is exclusively owned by
ChromeContentRulesRegistry, and it doesn't seem like there
is any necessity of ref-counting it via linked_ptr.

Make the map own these through unique_ptrs.

Bug: None
Change-Id: Ie55c9cce94b34c18bdad089c78f50c49d6df0658
Reviewed-on: https://chromium-review.googlesource.com/c/1306792Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604744}

This CL adds an ellipsis(...) before each of the subsequent tail
suggestions in the Omnibox tail suggestion list.

Bug: 726769
Change-Id: Ifba11bb5aca8474ee4a37dca652c9f9c676980c5
Reviewed-on: https://chromium-review.googlesource.com/c/1297726
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604743}

Bug: none
Change-Id: I3c9d49ca54ab9520b3779ce42f702a2d127343b9
Reviewed-on: https://chromium-review.googlesource.com/c/1303047Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604742}

Bug: 752372
Change-Id: I4a9b4565dd70c85295268fb8d67b4cf84b1a00ee
Reviewed-on: https://chromium-review.googlesource.com/c/1313268Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604741}

Change setupAndWaitUntilReady function to wait until Files app is fully
loaded. This intend to fix flaky tests where tests expect to have Files
app loaded in Downloads folder, however EntryList |updateSubDirectories|
method is being refactored to be asynchronous, which makes Downloads
folder to delay its appearance. This change has had 4 successful runs in
a row in crrev.com/c/1312185 (patchset 2 and 3).

Re-enable test that was flaky on MSAN.

Bug: 899664
Change-Id: Iedff85699c56f6cf8ac82d5ea27ef0ca54b7a641
Reviewed-on: https://chromium-review.googlesource.com/c/1313709Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604740}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24bca4e741a9..5ee6b6e6e335


git log 24bca4e741a9..5ee6b6e6e335 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 tikuta@chromium.org Add brucedawson to OWNERS of autoninja file


Created with:
  gclient setdep -r src/third_party/depot_tools@5ee6b6e6e335

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I5b83d8b4add7fd358dd012104754588d58b003d2
Reviewed-on: https://chromium-review.googlesource.com/c/1313273Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604739}

At OnLoad event, the renderer notifies browser process of the
anchor elements in the viewport. The browser uses this information
to predict the navigation probability of each of these anchor
elements.

This CL changes the logic in the render side to skip reporting
of elements that are part of ad frames since we expect these
to be clicked less often.

Change-Id: Ia131ac301acda317e7618ac206f4bda60c39e5cf
Bug: 899339
Reviewed-on: https://chromium-review.googlesource.com/c/1300682Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604738}

Also took the opportunity to:
Add a test for managing virtual focus,
and a test for the "focusable" and "enabled" accessibility attributes
R=dmazzoni@chromium.org, ellyjones@chromium.org, aleventhal@chromium.org

Bug: 811277
Change-Id: I6061ddae14bc1fd83ab4e38222fe57d6025380e5
Reviewed-on: https://chromium-review.googlesource.com/c/1302576
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604737}

Bug: 887646
Test: manual
Change-Id: I51652f21684fb7f1bb9dbae07420b687d9cf2dec
Reviewed-on: https://chromium-review.googlesource.com/c/1237146Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604736}

This CL hides ripple effect on "Backspace" button when it is disabled.

Bug: 898830
Change-Id: Ie77e0f0846a707be4d288c1762d4775403ad32d5
Reviewed-on: https://chromium-review.googlesource.com/c/1312309Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604735}

Bug: 870460
Change-Id: I24fa99baa9e390df94be3e6f01bf2a3127bfc37c
Reviewed-on: https://chromium-review.googlesource.com/c/1311773
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604734}

This CL lands server change 215811820 by diannahu.

BUG=488484

Change-Id: Ide173348373e7ad4f32eaf3226009fafbc18ae7f
Reviewed-on: https://chromium-review.googlesource.com/c/1292437Reviewed-by: Yang Song <yasong@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604733}

Bug: 870460
Change-Id: I5a579b584f9fb13a0c1010109b3990ddd4306a0b
Reviewed-on: https://chromium-review.googlesource.com/c/1308601Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604732}

This reverts commit 756ebd67.

Reason for revert: Missing file on chromeos side to support this change.

Original change's description:
> Start arc data removal directly from Chrome
> 
> Chrome had to proxy through session_manager to start the arc-remove-data
> Upstart job, but now it calls it directly.
> 
> BUG=b:115779632
> TEST=Disable ARC++ and ensure arc data removal occurs
> 
> Change-Id: I0f30570c665efc85538b9de4bcd63bb158b37417
> Reviewed-on: https://chromium-review.googlesource.com/c/1311124
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
> Commit-Queue: Christopher Morin <cmtm@google.com>
> Cr-Commit-Position: refs/heads/master@{#604724}

TBR=hashimoto@chromium.org,yusukes@chromium.org,alemate@chromium.org,hidehiko@chromium.org,cmtm@google.com,ereth@chromium.org

Change-Id: I46bc58d45f3749363a0f4e72948d13293832b186
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:115779632
Reviewed-on: https://chromium-review.googlesource.com/c/1313755Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Christopher Morin <cmtm@google.com>
Cr-Commit-Position: refs/heads/master@{#604731}

Biggie device has post processing configuration for 4 channels. If
ResetPostProcessorsForTest() is called channels number should be set by
SetNumOutputChannelsForTest() as well.

Bug: internal b/118631518
Test: Unittests.
Change-Id: Ia04f890bbcca18df702496db49432e36b2bd9b65
Reviewed-on: https://chromium-review.googlesource.com/c/1312987Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Sergei Istomin <sistomin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604730}

Currently we have a single root accessibility tree (the "desktop"
tree) containing all aura Windows and views in the browser process,
and all WebContents accessibility trees are direct children of that
tree.

Under multi-process mash, we're going to want it to be possible for a
remote app to host a WebContents, so we need to remove the assumption
that the parent accessibility tree of a WebContents must be the root
accessibility tree.

To do this, modify AutomationInternalCustomBindings::GetParent
so that it checks for any tree that lists the current tree as
its child tree, rather than only trying the desktop tree.
To make this efficient, have AutomationAXTreeWrapper keep track
of a map from child tree ID to its host.

This is reasonably well-covered by existing tests - if GetParent
doesn't work correctly, nearly all automation tests break.

Bug: 888147
Change-Id: Ib7350d51dffed345dd03ec11e6cc0b7591bb243c
Reviewed-on: https://chromium-review.googlesource.com/c/1286903
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604729}

BUG=900464

Change-Id: Iabdce98f4f3a362d1376860277fc9d1c31757c12
Reviewed-on: https://chromium-review.googlesource.com/c/1309296
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604728}

Add quic tag kEPID and set it in the public reset packets sent from GFE. GFE side change protected by --quic_reloadable_flag_quic_enable_server_epid_in_public_reset.

The intention is to use this tag in Chrome to differentiate public resets received from Google servers vs. Non-google servers.

Merge internal change: 219217158

R=rch@chromium.org

Change-Id: I81977087ece589c5081f644d330e92c4e5038cf8
Reviewed-on: https://chromium-review.googlesource.com/c/1309116Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bin Wu <wub@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604727}

Bug: 814675
Change-Id: I522890e1252535832aed187e7add7034f46fb30c
Reviewed-on: https://chromium-review.googlesource.com/c/1311800
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604726}

R=benmason@chromium.org

Change-Id: Iddf657f4f14b9ba4d273d2a4973dd763c28dcc51
Reviewed-on: https://chromium-review.googlesource.com/c/1313562Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604725}

Chrome had to proxy through session_manager to start the arc-remove-data
Upstart job, but now it calls it directly.

BUG=b:115779632
TEST=Disable ARC++ and ensure arc data removal occurs

Change-Id: I0f30570c665efc85538b9de4bcd63bb158b37417
Reviewed-on: https://chromium-review.googlesource.com/c/1311124Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Christopher Morin <cmtm@google.com>
Cr-Commit-Position: refs/heads/master@{#604724}

This change is required due to new security restrictions in Mojave.  We can no longer
inject input w/o being added as an accessibility app in the security applet.

While this sounds like a usefulk speedbump, it causes remote access applications quite
a bit of trouble:
1.) We don't use the restricted API until a user connects so they cannot approve remotely
2.) The dialog appears to only show up once (regardless of approve/deny status)
3.) Users connecting to a locked machine will never see the dialog

This is affecting quite a few CRD users, basically everyone who upgrades to Mojave
will experience this one way or another.  This is the simplest fix (and easiest to merge)
that I could think of to unblock users.  The prompt will only be shown on 10.14+ platforms
and the request is only shown if the app has not been approved.  I'd like to look at the
user feedback after releasing this change to see if more work is needed.

One problem I anticipate is that the dialog shown doesn't have a lot of context and it
refers to the wrapper script (org.chromium.chromoting.me2me.sh) instead of Chrome Remote
Desktop.  If this is confusing, we can wrap the prompt request in a dialog where we control
the text.  My concern with checking in the feature first is that the new strings won't be
available for merging.

Another behavior to call about this impl is that the prompt will be displayed in two instances:
1.) When the host is first started (choosing enable via app/website)
2.) When the user signs in and the host service is started

Scenario #2 will have less context but that is the only way to ask for permission for
users who upgraded and had CRD installed previously.  The dialog is not displayed at the login
screen (i.e. when no one is signed in).

One last note, there is no way that I can see to specify this permission in the manifest or
set up via a script / at install time.  It requires a user action to complete.

Bug: 901021
Change-Id: I9dd1b24b6d4d083e7e019af32a0da816f6060a86
Reviewed-on: https://chromium-review.googlesource.com/c/1313170
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604723}

R=wittman@chromium.org

Change-Id: I171d11f25c2903894feb015adff53d6280a88be7
Reviewed-on: https://chromium-review.googlesource.com/c/1306496
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604722}

Now all the model building no longer needs the view to
build the properites, so we can just pass in the Model
instead of the View.  We should now be able to pull out
the model building to a mediator and out of the adapter.

BUG=898522

Change-Id: I5b0bff0778975bce0e5b27f9dd95c9f9385396c2
Reviewed-on: https://chromium-review.googlesource.com/c/1312560Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604721}

Recently the SwiftShaderTest.h file was moved. Chromium shouldn't directly
depend on any header or source files within SwiftShader. The class defined
in this header is practically empty anyway, so just move it to the Chromium
side test setup.

TBR=kbr@chromium.org

Change-Id: Iea7cb482457a1a1aa935868489757e97994b1dff
Reviewed-on: https://chromium-review.googlesource.com/c/1311084Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Nicolas Capens <capn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604720}

Bug: 899137
Bug: 845079
Change-Id: Id196b62707f7f5d66fc7f011b8cd4bc8bdc2f743
Reviewed-on: https://chromium-review.googlesource.com/c/1308237Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604719}

Bug: 884075
Change-Id: I08094816c99b1ba0c0b8519318a57c957c7648e2
Reviewed-on: https://chromium-review.googlesource.com/c/1308669Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604718}