- 22 Jun, 2018 40 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e3b12b3e7d98..fa74d9840634 git log e3b12b3e7d98..fa74d9840634 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 perezju@chromium.org [Telemetry] Should not "warn" when computing TBM 2018-06-22 perezju@chromium.org [Telemetry] Do not raise on missing devtools clients for clock sync Created with: gclient setdep -r src/third_party/catapult@fa74d9840634 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854212 TBR=sullivan@chromium.org Change-Id: I228ac2a4d7ae2ad4ae535d3dd69fe390b0c73c44 Reviewed-on: https://chromium-review.googlesource.com/1112119Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569731}
-
Ryan Tseng authored
Going to switch this to a larger bot and turn off Goma for the time being. Change-Id: Ia09d67b6acdb03ba1228ea3a73bc41da959d1dba Reviewed-on: https://chromium-review.googlesource.com/1112477Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569730}
-
John Delaney authored
Top level header was missing a space causing the markdown to be parsed incorrectly. Bug: 854334 Change-Id: Ia721d8adb009877ba1d3bf536091387bedade23f Reviewed-on: https://chromium-review.googlesource.com/1106671 Commit-Queue: John Delaney <johnidel@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#569729}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5e0909776e81..96b1ecc25d00 git log 5e0909776e81..96b1ecc25d00 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 brucewang@google.com Implement onMakeClone(const SkFontArguments& args) in class SkTypeface_fontconfig. 2018-06-22 benjaminwagner@google.com Upgrade MacOS on Skolo bots. 2018-06-22 herb@google.com Use the correct paint from the looper 2018-06-22 bungeman@google.com Remove include/ports/SkFontMgr.h 2018-06-22 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader bf8fd5b5fb68..a9969b2ab8c3 (1 commits) 2018-06-22 senorblanco@chromium.org GrTessellator: avoid split with zero primary and out-of-range secondary. 2018-06-22 herb@google.com Add SkGlyphRunList - v2 2018-06-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@96b1ecc25d00 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851914 TBR=kjlubick@chromium.org Change-Id: I579cb3684298fb742231c47cdb7f995b0797f49c Reviewed-on: https://chromium-review.googlesource.com/1112219Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569728}
-
Nicolas Pena authored
This CL introduces a bool |first_input_detected_| to make sure that we do not create more than one PerformanceEventTiming entry of type 'firstInput'. Before, there could be many entries of this type dispatched to PerformanceObservers when the first input occurred after onload and |first_input_timing_| would never be set. Bug: 841224, 851484 Change-Id: I293d3de1ac052eaab9297d725ce0211f242aaf5a Reviewed-on: https://chromium-review.googlesource.com/1111914Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#569727}
-
Scott Chen authored
Suspected reason for flakiness is that the timing of cr-input shifting focus onto the internal input sets it as the activeElement too late. Bug: 855637 Change-Id: Ifdc3fa26c357ca6aa1e92180ec309cca4e455e07 Reviewed-on: https://chromium-review.googlesource.com/1112350 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569726}
-
Nico Weber authored
The motivation is to remove chromium_memory_chromiumos_asan_gtests in favor of linux_chromeos_rel_gtests, but when I tried doing that directly [1], I got many asan/lsan and msan reports for these tests. Some of them pass however, so I'd like to lock in the working ones while I work on fixing the broken ones. 1: https://chromium-review.googlesource.com/c/chromium/src/+/1110703 Adds to "Linux ChromiumOS MSan Tests" and "Linux Chromium OS ASan LSan Tests (1)" these tests: - chromevox_tests - gl_unittests_ozone (to asan/lsan only) - ozone_gl_unittests - ozone_x11_unittests - select_to_speak_extension_tests - views_mus_interactive_ui_tests Bug: 843511 Bug: 855573,855580,855588 Bug: 855584,855585,855583 Change-Id: I9402cd43d1d0ef95432eba8231ae79c936b4848b Reviewed-on: https://chromium-review.googlesource.com/1112037Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569725}
-
Jacob Dufault authored
If pin length must be set then the error messages for - [0,3] digits: "PIN must be at least 4 digits" - [5..] digits: "PIN must be less than 4 digits" The 5.. digit case should be "PIN must be less than 5 digits" Bug: 855635 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I840772182b292f150626aa670594221bd1096904 Reviewed-on: https://chromium-review.googlesource.com/1112210Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#569724}
-
Jared Saul authored
Bug: 812710 Change-Id: I38b1e3f647c857ac1c6d8cbcfbd8eaafe61e4407 Reviewed-on: https://chromium-review.googlesource.com/1112208Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#569723}
-
Rayan Kanso authored
Now that CacheStorage can have multiple clients/owners, some of them will need access to the CacheStorageManager after shutdown to wrap up their tasks. This CL changes the CacheStorageManager member in CacheStorageContextImpl to a scoped_refptr, so that if there are any references after the shutdown was initiated, systems that hold a reference can finish their tasks without crashing. Bug: 851164, 851229 Change-Id: I3226e79325adce62594de2135ab4450f463b5eac Reviewed-on: https://chromium-review.googlesource.com/1095261Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569722}
-
Dominic Farolino authored
Before this CL we have some Request constructor logic in our implementation of RequestInit. Once we generate RequestInit with the IDL compiler, that logic will have to be inlined back into the Request constructor. This CL moves that logic, revolving around the referrer property, back to the Request constructor to minimize the size of the CL that removes our implementation of RequestInit. R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 836873 Change-Id: Id351d9503ead1ef4e377fa0bd1cc5eaac70cfbed Reviewed-on: https://chromium-review.googlesource.com/1103786 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#569721}
-
George Burgess IV authored
Some of these tests caused blink to recurse to stacks > 4,000 frames deep. This caused crashes for Android on ARM64, which has a standard stack limit of 1MB. Since it appears that these benchmarks' depths are somewhat arbitrary (e.g. the crashes that we're seeing when running these benchmarks aren't indicative of a problem in the real world), turning down the recursion seems reasonable here. New limits were chosen arbitrarily. Bug: 851539 Test: Ran blink_perf.parser on ARM64 Android; no crashes observed. Change-Id: I310b5e92fcb32524ec6e1c8a1c67226d68f4e5aa Reviewed-on: https://chromium-review.googlesource.com/1111685 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569720}
-
Lei Zhang authored
Change-Id: Icc99c8dc75960314b1bc0b2c8b6f959fcc497630 Reviewed-on: https://chromium-review.googlesource.com/1110549Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#569719}
-
Ramya Nagarajan authored
Change-Id: Iafb44e629fc0089c575b741c79c91c34b67959d4 Reviewed-on: https://chromium-review.googlesource.com/1112352Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569718}
-
Aleks Totic authored
Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1d0d9d290805e0de27d17d3f2cb26e9ecc9cb5b9 Reviewed-on: https://chromium-review.googlesource.com/1112204Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#569717}
-
Kenneth Russell authored
Allow direct use of base/numerics/safe_conversions.h in Blink. Bug: 854710 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I43c664317beca77525fe65445a25da528c7747d5 Reviewed-on: https://chromium-review.googlesource.com/1109267 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#569716}
-
Ken Rockot authored
mojo/edk/embedder -> mojo/edk/system TBR=jcivelli@chromium.org Bug: 753541 Change-Id: I4b73748986c4b728e42c5a19fe8b7a6a685238b5 Reviewed-on: https://chromium-review.googlesource.com/1109034 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569715}
-
Andrew Grieve authored
Bug: 702625 Change-Id: I68ff5c0b3e81da58ca85cd2a6b26ebe7ec80456e Reviewed-on: https://chromium-review.googlesource.com/1112351Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#569714}
-
Fan Yang authored
R=rch@chromium.org Change-Id: I95fdbe700abfb4a028037e27dded55c12bf9633d Reviewed-on: https://chromium-review.googlesource.com/1112050 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569713}
-
Lindsay Pasricha authored
Also delete UIRefrefresh-simulator.json. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I261230199df6da2669d0ac186571e19df67fa42b Reviewed-on: https://chromium-review.googlesource.com/1107279 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569712}
-
Xiaohan Wang authored
This describes the capability (supported features) of a CDM. Add a new struct for it to simplify a lot of code. Bug: 848532 Change-Id: Iaf83bad1ebe4882e8fbc0a1786b2d9898ef9a52b Reviewed-on: https://chromium-review.googlesource.com/1110602Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569711}
-
Ryan Hansberry authored
SecureChannelClientImplTest.TestMultipleConnections can intermittently fail: it was only caught by the test waterfall after this unrelated change: https://chromium-review.googlesource.com/c/chromium/src/+/1111937. The test was failing on release builds, not debug builds, because TestConnectionAttemptDelegate::last_client_channel() was returning a unique_ptr which was being immediately thrown away; in a release build, the memory allocation is optimized such that when a second ClientChannel was created, it was assigned to the exact same address that the old one was addressed to, causing the check 'EXPECT_NE(client_channel_1, client_channel_2)' to fail. Bug: 824568, 752273 Change-Id: I2571f63c7dd0bfbbadef3fca17f001f740d64ab3 Reviewed-on: https://chromium-review.googlesource.com/1112422Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#569710}
-
Ramya Nagarajan authored
Adds a service request and callback to get Google Photos for the user. An access token for the signed-in user with requisite scope is obtained and used in the request. Bug: 839152 Change-Id: I5e6bbb3d3329e5fe9158e815fe91f717d8652256 Reviewed-on: https://chromium-review.googlesource.com/1109258 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569709}
-
Jialiu Lin authored
For Android settings: Change to third-person singular verb, i.e. "Protect you and ...." to "Protects ....." String doc for mobile: go/unity-mobile-strings For desktop SB settings: title: "Safe Browsing" Check box label: "Protects you and your device from dangerous sites" String doc for desktop: go/unity-strings Bug: 837857 Change-Id: I25a8c93bacded9163614edfbe92b4bd5f3d17149 Reviewed-on: https://chromium-review.googlesource.com/1110453Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#569708}
-
Ken Rockot authored
Deletes PlatformChannelPair, NamedPlatformChannelPair, and NamedPlatformHandle types from the EDK. These are superceded by equivalent types in the public platform support API. TBR=jcivelli@chromium.org Bug: 753541 Change-Id: Ic1982aac93f0b6a78730497fc04dc44bb128cef0 Reviewed-on: https://chromium-review.googlesource.com/1109259 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569707}
-
Sergey Ulanov authored
Scenic Ozone platform requires view_owner_request field to be set in PlatformWindowInitProperties when creating a window. Previously there was no mechanism for upper layers to discover that the current Ozone platform expects that field. To solve this problem this CL adds GetPlatformProperties() method in OzonePlatform. The returned PlatformProperties struct contains just one field, but in future it can be extended as needed for other platforms. Bug: 829980 Change-Id: Idcd8c1b645cdeca36975c7feb5a1cf720fd592dd Reviewed-on: https://chromium-review.googlesource.com/1110877 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#569706}
-
Stefan Zager authored
Introduce the method HyoptheticalScrollbarThickness, which avoids constructing a scrollbar. This might be useful in figuring out overflow:auto scrollbars as well (left for a future CL). R=skobes@chromium.org BUG=823365 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7d3a1be44f7146bfbb2d650e9fa0d647db54f3f Reviewed-on: https://chromium-review.googlesource.com/1110892 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569705}
-
Evan Stade authored
Mostly copied from ws::UserActivityMonitor. Nothing actually connects to it yet. Bug: 854700 Change-Id: I478942c4f5462e9632454bf7385aa827f015e05d Reviewed-on: https://chromium-review.googlesource.com/1108974 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569704}
-
Dirk Pranke authored
This reverts commit 53235652. Reason for revert: Build is no longer reporting failures correctly. Original change's description: > Update json test results for webkit_layout_tests. > > This brings the test results more into compliance with the > current test result standard in bit.ly/chromium-json-test-results-format. > > Notable changes: > - If a test is run multiple times, we explicitly return every > `actual` result. Previously, if the test produced the same result every > time, we'd only return a single value for `actual` > - If a test is skipped unexpectedly, that will be considered a regression > and an unexpected result. > - The test results will contain `is_unexpected`, `is_flaky`, and > `is_regression` fields for the matching conditions. > > Bug: 837047, 822078 > Change-Id: I4896e61469d3b576ea9e7dbbe16fac709f74b6b9 > Reviewed-on: https://chromium-review.googlesource.com/1103611 > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569466} TBR=qyearsley@chromium.org,dpranke@chromium.org,seanmccullough@chromium.org,robertma@chromium.org Change-Id: Icf1882e8eea328b115a458afa6378b35bb11a638 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837047, 822078 Reviewed-on: https://chromium-review.googlesource.com/1112178Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569703}
-
Michael Spang authored
The OverlayPlane struct uses the ScanoutBuffer class, which was originally a DRM platform implementation detail. This struct was moved into common code with the intent to share it with other linux platforms. However, exposing ScanoutBuffer is probably not what we want to do - it contains several methods that are specific to DRM. Instead, a public ui::OverlayPlane should be using the gfx::NativePixmap interface, which is already public. Move ui::OverlayPlane back into DRM, and rename it to DrmOverlayPlane. A followup CL will add a new version of ui::OverlayPlane that uses gfx::NativePixmap instead. Bug: 851997 Test: compile Change-Id: I1f4dbc11419aaacabb2a63eb692eb6a3892a3be3 Reviewed-on: https://chromium-review.googlesource.com/1097208 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#569702}
-
Daniele Castagna authored
For Night Light we tried to always apply the color transform matrix in linear color space when using the display controller for the transformation. On Rockchip we'd get the BT.709 degamma/gamma automatically. On Intel we used the split gamma pipeline and we set degamma/gamma manually. Unfortunately intel split gamma doesn't do interpolation of values and introduced banding. This patch exposes to the browser if a display color correction matrix will be applied in linear color space or in a gamma compressed one. In this way we'll be able to change the night light matrix and avoid setting gamma/degamma on intel. Bug: 851156 Test: display_unittests Change-Id: Ia0d385697747afb42c5dbb1b939be661c4fdd559 Reviewed-on: https://chromium-review.googlesource.com/1108362Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#569701}
-
chrome://discardsFrancois Doray authored
There was an invalid access when the site engagement score of a WebContents that was never navigated was obtained in chrome://discards. With this CL, we return 0 as the engagement score of never-navigated WebContents, instead of doing an invalid access. Creating a new tab or opening a link in a new tab are actions that create a WebContents a briefly keep it in a non-navigated state. Bug: 854497 Change-Id: I204509b7c41445ac4b524f9a652f006189e4fcd9 Reviewed-on: https://chromium-review.googlesource.com/1111908Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569700}
-
Kevin Schoedel authored
This reverts commit 05654b06. Reason for revert: Name error causes conflict. Original change's description: > Add definition of window.speechSynthesis for cast > > This is used by Chromevox. > > Bug: b/110195060 > Test: manual > Change-Id: I9e22aacf0c3335d70eb92ea9b66f6e11a7ef2f7c > Reviewed-on: https://chromium-review.googlesource.com/1105028 > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568493} TBR=alexst@chromium.org,kpschoedel@chromium.org,rmrossi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/110195060 Change-Id: I35230adbfdb5042f622900335c96f62bff17a3c8 Reviewed-on: https://chromium-review.googlesource.com/1112161Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569699}
-
David Grogan authored
wpt.fyi showed Safari passing these recently-added tests because the scrollbars don't show in either the tests or their refs. https://wpt.fyi/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html Aside: Edge matches Safari's current and Chrome's previous behavior. But they've confirmed it's a bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17505131/ Firefox has a mostly-unrelated incompatibility that doesn't allow us to check it. Bug: 837408,838144 Change-Id: I82058d3c22d7668711e9a9a1c977047033d64b46 Reviewed-on: https://chromium-review.googlesource.com/1054770 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#569698}
-
rajendrant authored
Bug: 782233 Change-Id: I4e0e8d06dd8d2be5613fd221a541fec67a9857c2 Reviewed-on: https://chromium-review.googlesource.com/1111471Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#569697}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/20eea3c..a9969b2 BUG=chromium:854817 TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I13d0fab6a29ba96f13f0e74c07b011db36abbeed Reviewed-on: https://chromium-review.googlesource.com/1112047Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#569696}
-
Jacob Dufault authored
Bug: 855650 Change-Id: Ib9abc4447eb81365439611953e641d30f97cc58d Reviewed-on: https://chromium-review.googlesource.com/1112344Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#569695}
-
Xi Han authored
In this CL, we refactor the ServiceManagerContext to make sure all of the services can be registered without any dependency of BrowserMainLoop. It includes the following changes: 1) Add API StartBrowserConnection() in ServiceManagerContext to start the browser connection to the ServiceManager. This API must be called after the BrowserMainLoop starts. 2) Make OutOfProcessServiceInfo takes a RepeatingCallbacks to get the process name. 3) ServiceMangerContext owns the DeferredSequencedTaskRunner for audio service. It was owned by BrowserMainloop before this CL. BUG=846846,729596 Change-Id: I29725a383e2662fccd8a2fba5fedddc52a8c565c Reviewed-on: https://chromium-review.googlesource.com/1093021 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569694}
-
Max Moroz authored
When ICF (Identical Code Folding) is enabled, the linker has hard time figuring out all identical code patterns inserted by compiler's instrumentation. That is why this option is disabled when we use sanitizers. It also should be disabled for code coverage instrumented build, as it has even more instrumentation code. This change allows code coverage bots to use use_sanitizer_coverage=false which would result in much faster and much smaller builds. Performance improvements: - builds 2x faster - binaries 2x smaller - run time 2x smaller (or even more on some targets, up to 6x) Bug: 851337 Change-Id: I20d4ad1e55730daf813e0f26060dd5830351dbcf Reviewed-on: https://chromium-review.googlesource.com/1112199 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569693}
-
edchin authored
The completion handler was not properly being run in history coordinator when the coordinator was previously stopped. Bug: 854597 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3a317f8776ea10452889c39a69cb257d4a8e7073 Reviewed-on: https://chromium-review.googlesource.com/1111619Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569692}
-