- 18 Aug, 2020 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: Idde01476544d3ec2227a4fb82ba9db558b7f20b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360949Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798971}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2549f174b533..88816e373d30 2020-08-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2ecce21d..a0c9fe7f (798579:798709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifcf02cf75a1b4e06d1d9327c31a19cfac4158655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798970}
-
Mark Schillaci authored
This is a reland of 82d92693 Speculative revert was incorrect Original change's description: > Add accessibility support for multiselectable aria-activedescendants on Android > > This CL adds support for multiselectable aria-activedescendants > > For nodes that are multiselectable (e.g. listbox of items with an > aria-activedescendant role), we add more descriptive labels. For > Android R we use the new stateDescription on AccessibilityNodeInfo > object for the given node. To support pre-Android R, we append the > labels to the text for the node. > > For a multiselectable node that has no items selected, we add the > text: > > "multiselectable, none selected." > > For a multiselectable node with n children selected of k total, we > add the text: > > "multiselectable, n of k selected." > > > > multiselectable aria activedescendants > > AX-Relnotes: Added more descriptive accessibility labels for > Change-Id: I9fe04714c5800939b73b11c3339e628ae7760939 > Bug: 1101660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341826 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Cr-Commit-Position: refs/heads/master@{#798926} TBR=dmazzoni@chromium.org,sky@chromium.org,pinkerton@chromium.org,mschillaci@google.com Bug: 1101660 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I8ee35f5a04cb09c9b462a08fcf92c611bdb2f2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360064Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798969}
-
Miguel Casas authored
This is a reland of 02aec841 Speculative revert was incorrect Original change's description: > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > The relanded CL was reverted due to crashes when used from ARC++: > Video Frames coming from this path are not GpuMemoryBuffers, so there's > a DCHECK not verified, and then a crash. This CL addresses that > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > see crrev.com/c/2359734/1..3. > > Bug: b:163920993 > > Original RELAND description ------------------------------------------- > > The original CL was reverted due to crashes in betty initialization: > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > TBR=andrescj@chromium.org > > Original CL description ----------------------------------------------- > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > error in the tracking of the VASurfaces lifetime in the driver: every > time we get a new resource from the pool to decode onto, this is > imported into libva as a VASurface: this works fine almost everywhere > but doesn't play well in these old platforms (see CreateSurface() body). > > This CL adds a map that keeps the ref-counted VASurfaces alive and > indexed by the unique GpuMemoryBufferId until the VA Context is > destroyed. In so doing, we're basically observing the "contract" of > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > contexts using these surfaces have been destroyed". > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > Bug: b:142019786 b:143323596 > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#795026} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Auto-Submit: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798931} TBR=mcasas@chromium.org,andrescj@chromium.org Bug: b:163920993 Bug: b:142019786 b:143323596 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I6124e960d93f6985dbf9a546bc9d34372815e002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359975Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798968}
-
Fergus Dall authored
This reverts commit 02aec841. Reason for revert: Speculative revert, may have broken Network Service Linux: https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/10157 Original change's description: > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > The relanded CL was reverted due to crashes when used from ARC++: > Video Frames coming from this path are not GpuMemoryBuffers, so there's > a DCHECK not verified, and then a crash. This CL addresses that > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > see crrev.com/c/2359734/1..3. > > Bug: b:163920993 > > Original RELAND description ------------------------------------------- > > The original CL was reverted due to crashes in betty initialization: > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > TBR=andrescj@chromium.org > > Original CL description ----------------------------------------------- > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > error in the tracking of the VASurfaces lifetime in the driver: every > time we get a new resource from the pool to decode onto, this is > imported into libva as a VASurface: this works fine almost everywhere > but doesn't play well in these old platforms (see CreateSurface() body). > > This CL adds a map that keeps the ref-counted VASurfaces alive and > indexed by the unique GpuMemoryBufferId until the VA Context is > destroyed. In so doing, we're basically observing the "contract" of > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > contexts using these surfaces have been destroyed". > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > Bug: b:142019786 b:143323596 > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#795026} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Auto-Submit: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798931} TBR=mcasas@chromium.org,andrescj@chromium.org Change-Id: I4e2d835e7551210298fa150442250bc5dce6475a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:163920993 Bug: b:142019786 b:143323596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359974Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798967}
-
Fergus Dall authored
This reverts commit 82d92693. Reason for revert: Speculative revert, may have broken Network Service Linux: https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/10157 Original change's description: > Add accessibility support for multiselectable aria-activedescendants on Android > > This CL adds support for multiselectable aria-activedescendants > > For nodes that are multiselectable (e.g. listbox of items with an > aria-activedescendant role), we add more descriptive labels. For > Android R we use the new stateDescription on AccessibilityNodeInfo > object for the given node. To support pre-Android R, we append the > labels to the text for the node. > > For a multiselectable node that has no items selected, we add the > text: > > "multiselectable, none selected." > > For a multiselectable node with n children selected of k total, we > add the text: > > "multiselectable, n of k selected." > > > > multiselectable aria activedescendants > > AX-Relnotes: Added more descriptive accessibility labels for > Change-Id: I9fe04714c5800939b73b11c3339e628ae7760939 > Bug: 1101660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341826 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Cr-Commit-Position: refs/heads/master@{#798926} TBR=dmazzoni@chromium.org,sky@chromium.org,pinkerton@chromium.org,mschillaci@google.com Change-Id: I6ef8ea0fb314eda1f8cb962cea0bd0f089dc7713 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361222Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798966}
-
Evan Stade authored
since it's now available in the SDK. Bug: 1057100 Change-Id: I10c867cdc40ab0a5d7eb41b6892d1220e1ee23dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354561 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#798965}
-
Daniel Classon authored
Combine the OS Sync Controls "turn on sync" and "turn off sync" buttons. This is better for a11y as the button doesn't lose focus when clicked. This is related to settings deep linking as its easier to deep link to a single element rather than two elements sharing one setting. Bug: 1084154 Change-Id: I545498954934368f47c8f6af168830014e41947d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359164 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798964}
-
Yuke Liao authored
This CL refactors the skipped tests for unit_tests so that it applies to both linux-lacros-tester-rel and linux-lacros-rel. Bug: 1116180 Change-Id: Ia7657ff8eb00d49fd1108dda4ffd76bbc1be4d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360679Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798963}
-
Kent Tamura authored
We do something like: shadow_root.lastChild.textContent = 'foo.txt'; when input[type=file] receives the result from a file chooser dialog. If a file input requests to open a file chooser and the input type is changed before receiving the result, we remove shadow elements by the textContent setter in some cases. This CL fixes it by - Introduce InputTypeView::will_be_destroyed_, which becomes true when a InputTypeView is disconnected from the owner HTMLInputElement. - Check will_be_destroyed_ in functions which receive asynchronous results from pickers. Bug: 1116378 Change-Id: I76fb166a0e5221441fcabeea34ab8a5bbd7d4af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358718 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798962}
-
Dominic Mazzoni authored
When caret browsing is enabled it should cause the cursor to start blinking if it wasn't already. To do this, it's sufficient to just invalidate style. This results in calling FrameCaret::UpdateStyleAndLayoutIfNeeded() which starts the caret timer if needed. Bug: 1116658 Change-Id: I55a249878a1646a358a584e6ffccd501bfdd8189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357963 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798961}
-
Orin Jaworski authored
This CL adds `en-GB, es, es-419, et, fa, fi, fil, gu, he, hi, hr, id, it` to the set of languages supported by Pedals. Bug: 893183 Change-Id: I6740e0074fbd6eeaf3a668973cf6423ae2ce8df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360219 Auto-Submit: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798960}
-
Tommy Li authored
This reverts commit e8ecbf8b. Reason for revert: This flag is too broadly scoped. When it's disabled, it also turns off MostVisited on Android and iOS, which is not intended. Original change's description: > [omnibox] Add kFocusGestureTriggersContextualWebZeroSuggest flag > > This CL adds an enabled-by-default flag that causes on-focus gestures > to trigger ZeroSuggest on the Contextual Web page classification > (OTHER). > > We add this flag so we can disable it in some experiments, where we > want to use on-clobber instead. > > It also adds a test to make sure this flag doesn't affect other page > classifications such as the NTP. > > Bug: 1106096 > Change-Id: I32d4b9fc396874f836c60ae347ac3894818cf1d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350309 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797491} TBR=tommycli@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106096 Change-Id: Icfef70ed62561fcfc2f9f14af6a5234e2fd65f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358907Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798959}
-
Evan Liu authored
This CL updates the speech recognition recognizer to be compatible with Windows. Chromium uses std::wstring for file paths; however, wide characters should not be passed across API boundaries, so they must be converted to plain C-style characters before being passed into the SODA DLL. Bug: 1116563 Change-Id: I920a994706fe9212b8ed50ecd5c6371090509e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357609Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#798958}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597687171-f7ac758bbaa5d412cea42dd6434f8391401d2bbb.profdata to chrome-mac-master-1597708766-1039a8f039b278bc6845dae261350aff5bb3b369.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibd92847b99b80fc3abc366f021abb5fafe4cc577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798957}
-
Sergey Ulanov authored
Fixed the capturer to increment frame counter, so it reports frame rate. Updated tests to verify that frame rate is set for all frames. Also removed redundant line that was setting pixel format to the same value that's sent one line avove. Bug: 1116536 Change-Id: I74bc000a2bc9172768bb3153f01cdded7a3e911b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357611 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#798956}
-
Dana Fried authored
Follow-up CL to remove logic added to make it possible to host the caption buttons on browser elements. See upstream CL: https://chromium-review.googlesource.com/c/chromium/src/+/2358249 Do not check in until upstream CL has been *verified* as what we want for tablet mode on Windows. Bug: 1116651 Change-Id: Ia5670d40e0565711041835d0641231396612730a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359019 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#798955}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 113e774e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ie7a357a9ed2e2e5d905f64379ef35de283b0bf90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360698Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798954}
-
bttk authored
Bug: 1109369 Change-Id: I7f80348e388471783104dc46b06d299cfaf7ec0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352521Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#798953}
-
Ted Meyer authored
This new image type can hook an X11 pixmap up to an egl pixmap surface, which lets VaapiPictureNativePixmapAngle create xlib pixmaps and bind them as surfaces. With this cl, the flag --enable-accelerated-video-decode will be functional on a modern intel graphics linux system while using ANGLE. Bug: 1103510 Change-Id: I9c2bce16729be1e8f007b47da5a5160074f78483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288633 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798952}
-
Fergus Dall authored
TBR=mnissler@chromium.org TBR=hidehiko@chromium.org Bug: 1117324 Change-Id: Iec44ae22a5c0452f9b6489c9e0c567e957c68b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359877Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798951}
-
Patrick To authored
The GPU process may have been restarted and initialized on a different GPU than the default if the VR headset is not plugged into the default GPU. Staying on this XR compatible GPU can drain battery a lot quicker. When there are no longer any renderers using WebXR, this change reverts reverts the GPU process back to the default GPU. Bug: 1090951 Change-Id: Ibc5e7f709d2c82d5a6e8cbda08766d1d654951a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321771 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#798950}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f926b0866fe4..d2a9f6661597 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie02fa5e98b96b461b2e86875f46b9c79cd497f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798949}
-
Changwan Ryu authored
Design doc: http://go/webview-display-cutout (Google internal) This is the core logic for display cutout support in WebView. We cannot get the onApplyWindowInsets() for P, Q, R, and sometimes view signals should update safe area insets, so we are currently triggering window inset updates on certain view callbacks. https://crrev.com/c/chromium/src/+/2299461 is the next CL that has more information on how this can be integrated into AwContents. Once the controller sets the insets and pass it to WebContents#setDisplayCutoutSafeArea(insets), then the webpages can use these values as safe-area-inset-* CSS properties. Note that these CSS values will be automatically updated when we set the values again, and set to zero on navigation away from the current page. Tested: AwDisplayCutoutControllerTest, also tested manually. Bug: 1094366 Change-Id: I53461689ca065651d382ad2bb5c4cd1d09591df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298728Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798948}
-
Fergus Dall authored
This reverts commit ebc935dc. Reason for revert: Introduced non-determinism in to build of libblink_common.so on Linux. See first failing build here: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/18293 Original change's description: > [tools/perf] Add app and device usage to WebView power metric > > Since webview_power_usage.sql now calculates app power usage and total > device power usage, this change updates the corresponding tbmv3 metric > to output these values. > > Bug: b/159154163 > Change-Id: Ia0f788e357837e056ed04b1bd252f9a26d2d07de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354834 > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798739} TBR=oksamyt@chromium.org,khokhlov@google.com Change-Id: Iecd85d90ef0fcc71d2091bebe35aeeabed57a10d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/159154163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360100Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#798947}
-
Tomasz Wiszkowski authored
This is done so that the search-ready omnibox (SRO) will be shown even in cases where there are currently no matches. Specifically, in Incognito mode tabs. SRO will be shown whenever the User focuses the Omnibox, or clears the Omnibox content while visiting a Website, regardless of the session type. Bug: 1114125 Change-Id: I4446d10b341d55e9492fc128a4bf61a4edf6d0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350762Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798946}
-
Rakina Zata Amni authored
Add "subtree" to the name, add comments, remove unnecessary part. See https://chromium-review.googlesource.com/c/chromium/src/+/2348245/9#message-00feb65b1599a87535c7ddf414093ac195c137cb Bug: 977562 Change-Id: I9d03ba65fc801daf4f6992fa586221ac20cc88b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359654 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#798945}
-
Haiyang Pan authored
This reverts commit 8c9ffba0. Reason for revert: suspected cause of the test failure as observed in android CQ builds: depth_capture_tests, webgl_conformance_tests in * https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/635915 * https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/635916 * https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/635919 and webkit_unit_tests in * https://ci.chromium.org/p/chromium/builders/try/android-lollipop-arm-rel/96663 * https://ci.chromium.org/p/chromium/builders/try/android-lollipop-arm-rel/96670 Original change's description: > Update callsites of PaintImage::GetSkImage > > With OOPR Canvas we need to be explicit about how SkImages will be used > in the renderer process. In OOPR mode, SkImages must be software backed > because we can no longer use GrContext in the renderer. This change > updates callsites of PaintImage::GetSkImage to specify what kind of > SkImage is required with the new GetSwSkImage and GetAcceleratedSkImage > APIs. > > Follow up CLs will cleanup remaining callsites of GetSkImage until > we can completely remove the function. > > Bug: 1018894 > Change-Id: I69f7247e36c7cbb5d30f444f1255dd84af968df0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350027 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798894} TBR=dcheng@chromium.org,khushalsagar@chromium.org,nazabris@microsoft.com Change-Id: I051d4fdbc346e66d08c72fa366ef61dc0eeaa77e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360557Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#798944}
-
Ken Rockot authored
These features were originally separated with the intent to experiment and independently compare unsandboxed vs sandboxed vs in-process storage. Since we're no interested in pursuing an unsandboxed service to fulfill short-term needs, this drops the StorageServiceSandbox feature flag and change StorageServiceOutOfProcess to imply sandboxing by default. Bug: 1052045 Change-Id: I0f63f44adddeac5994b6fb3c3cd2e5a62ef9fe92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341401 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798943}
-
sczs authored
This will be used in future CL's to prevent certain behaviours for some time after CBD has been triggered. Bug: 1085419 Change-Id: I24d9a4878d05339911ec7bd95df6773ebc28f2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359549 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#798942}
-
alanlxl authored
SmartDimNewMlAgent is ready to roll out to 100% stable, this CL turns the feature kSmartDimNewMlAgent on by default, and removes SmartDimNewMlAgent from fieldtrial_testing_config.json. Bug: 1067048 Test: Test on DUT and it downloads the default version model. Change-Id: I72014365a32d19870401cebe59879872b4c4ab4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355355Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#798941}
-
Vignesh Venkatasubramanian authored
Update the thread counts to match the number of tiles. This configuration has better performance than the existing configuration. Bug: 1102227, 1047051 Change-Id: I5c9723da97ec814bcb3417609a603a4e54610c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359578 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#798940}
-
Xianzhu Wang authored
Previously once a layer became not LCD-text capable, it would never use LCD-text again. I think this was to avoid re-raterization during animation. As we don't allow LCD text with will-change:transform and during animation, and we skip re-rasterization on LCD text status change during animation, there is no reason to keep that logic. Bug: 1111195 Change-Id: Ib544be76c114e520572c0ccf5d88dd96bf7db151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344810Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798939}
-
Pete Williamson authored
Headlines, 3packs, and Covid news all don't have a base URL. Allow sending feedback anyway. Bug: 1117268 Change-Id: Iad366bc79b042dc51c1df5938db32c6f5f7cada0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360484Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#798938}
-
Yuke Liao authored
The CQ linux-lacros-rel couldn't find certain targets, for example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8871947371480314656/+/steps/analyze/0/stdout This CL fixes the issue by using gn_all instead. Bug: 1116180 Change-Id: I5b9f3a8f595790d8ff2628d132599f6347df7e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360571 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798937}
-
Brandon Wylie authored
Bug: 1116167 Change-Id: I4187c9a7fe3434bd3de5177913a0d5f34291a81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358817Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798936}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8111309b7f06e13a31904997edcc0a1171e03796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798935}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d63bca58a085..693d0e0bb673 2020-08-17 jmadill@chromium.org Vulkan: Minor cleanup to vk_helpers. 2020-08-17 cnorthrop@google.com Capture/Replay: Don't capture unused default uniforms in MEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: MEC capture of COD:Mobile Change-Id: I67668785a88f96de2f7e7c0a96820fd6167bfff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360268Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798934}
-
Carlos IL authored
The parameter was accidentally removed when solving merge conflicts in crrev.com/c/2350022 Also adds a test to prevent a similar regression in the future. Change-Id: Ib0646c69fc1881f8a82fc122fc4d2fce23f41a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356935 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798933}
-
Merissa Tan authored
This reverts commit d5524bc1. Reason for revert: Fixed bug that was making arc.Gamepad fail. Manually tested to ensure arc.Gamepad is passing. Original change's description: > Revert "Add gamepad rumble support in Exo and Wayland." > > This reverts commit 047950bb. > > Reason for revert: failing arc.Gamepad > > Original change's description: > > Add gamepad rumble support in Exo and Wayland. > > > > - Add exo::Gamepad interface. > > - Add exo::GamepadObserver interface. > > - Add WaylandGamepadVibratorImpl to handle vibration and cancel > > vibration requests from the client. > > - Refactor WaylandGamingSeatDelegate so that WaylandGamepadDelegate > > handles all gamepad-specific events. > > - Add Wayland protocol to support gamepad rumble. The zcr_gamepad_vibrator_v2 interface is created when the server calls > > the vibrator_added event. The client can then trigger/disable vibration > > events on a gamepad vibrator through the interface. > > > > BUG=b:158686809 > > TEST=Add unit tests in gamepad_unittest. All tests pass in > > exo_unittests. > > > > Change-Id: Ie4b1b3b5f9748f31846c54c97cb4f7c315d09a05 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313976 > > Commit-Queue: Merissa Tan <liyingtan@google.com> > > Auto-Submit: Merissa Tan <liyingtan@google.com> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798253} > > TBR=oshima@chromium.org,xutan@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,liyingtan@google.com > > Change-Id: I39d80057e7bcfda6bbfab5d2ea99d0d94a743aaf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:158686809 > Bug: 1116682 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358690 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798400} Bug=b:158686809 Test=Add unit tests in gamepad_unittest. All tests pass in exo_unittests. Manually tested arc.Gamepad Tast test. Change-Id: I094007035f7eb28e3130e3a1de207e4a85f6845d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359580Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Merissa Tan <liyingtan@google.com> Auto-Submit: Merissa Tan <liyingtan@google.com> Cr-Commit-Position: refs/heads/master@{#798932}
-