GitLab

Add run_gtest_benchmark.py that has a similar role of run_benchmark;
- Runs gtest with "--trace-dir=TRACE_DIR" in result processor's
  intermediate dir;
- Scans luci test result generated by gtest and run_metric on
  trace files (to be replaced by result processor later);

Example usage:
For developer,

  tools/perf/run_gtest_benchmark.py out/Debug/interactive_ui_tests
      --gtest_filter=OverviewAnimationsTest.EnterExit/7
      --output-dir=/tmp/perf_output
      --output-format=histograms

For perf bot,

  testing/scripts/run_performance_tests.py
      --isolated-script-test-output=/tmp/perf_output/output.json
      --non-telemetry=true
      --use-gtest-benchmark-script
      --gtest-benchmark-name=interactive_ui_tests
      tools/perf/run_gtest_benchmark.py
          --output-format=histograms
              out/Debug/interactive_ui_tests
              --gtest_filter=OverviewAnimationsTest.EnterExit/7

Bug: 945711
Change-Id: I977c1a81b53cd7cd78de4aa0bc17a2de7b8c7b1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762872
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710806}

This separates cases out from connection migration on path degrading
and helps collect data on how often a new network is connected after
path degrading is detected.

Change-Id: I36dc7306d6b94c84a85ffceb61a91645b312650f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888952
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710805}

This is a precursor to a follow-up change that will allow captive portal
probes to bypass DoH.

Bug: 10161646
Change-Id: I302111db7a1f3f9de7d5fc164775eea57b561547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870491Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#710804}

This temporary change disables eval(TT), so all related WPTs are disabled as well. It is necessary to change the v8 callback signature and support throwing exceptions when CSP blocks execution.

Bug: 940927
Change-Id: I9b16f9e9611034111859683eb6b6a31d958fe6eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872221Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710803}

NoBlockedExternalUserProviders is now flaky because it used to use
MessageLoopRunner (which uses a deferred Quit) and was refactored
to use RunLoop.QuitClosure (which doesn't use a deferred Quit).
This fix keeps RunLoop but uses QuitWhenIdleClosure instead of
QuitClosure.

Bug: 1019160
Change-Id: I9061165ac4e6f959cef1b8a4cb7565dd52f35974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887051Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710802}

Bug: 1014702
Change-Id: I295dfea0ad5a628e74559f44090eadc6a1eafae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883649Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#710801}

The DCHECK is triggered whenever Report an Issue is tapped and an
Infobar Message banner is currently being presented.

This DCHECK makes an assumption about another VC, and its misleading
since baseViewController might not even be the VC that ends up presenting
report an issue. Which means that this doesn't give us certainty that
the presenterVC is not presenting another VC.


This works as expected since BVC will dismiss the InfobarBanner and
then present report an issue.

Bug: 1016962
Change-Id: I516a6513422fe8817b291e00f0944d602b98357b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887754Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710800}

This CL results in some warts (double is_win sections and the like)
that I'll clean up in a followup CL.

Bug: 1018739
Change-Id: I912161a34b293a47e179c0b983c162d4ac96af06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885654Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710799}

InvalidatorRegistrarWithMemory was a subclass of InvalidatorRegistrar,
but the base InvalidatorRegistrar was never actually used itself. So no
reason to have two separate classes and split the implementation between
two places.

Bug: none
Change-Id: I6892ccf7d01293a357665a588e433716208dd042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890313
Commit-Queue: Marc Treib <treib@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710798}

policy_browsertest.cc contains too many policy tests today. Write a file
comment to ask developers to stop adding more into it. Also give a simple
hint about how to test policy outside policy directory.

Bug: 1002483
Change-Id: I06c660c9b8df00a719e39280f112d029622d5a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872806Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710797}

Reuse the PWA intent picker for the UI.

(This is a rebase and re-land of https://crrev.com/c/1703487.)

BUG=981337

Change-Id: Icc2528db9250dc148a1b537ad2f27a3f062288b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880530Reviewed-by: Maggie Cai <mxcai@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710796}

This CL adds support for reading the new NDEFRecord encoding and lang
attributes as specified in https://github.com/w3c/web-nfc/pull/381

An upcoming CL will add support for writing.

Bug: 520391
Change-Id: I6292975ef0399b5ededbdc8e13aeb1b482391e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871702Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#710795}

https://skia.googlesource.com/skia.git/+log/ebdae1144978..7da048b5e8f1

git log ebdae1144978..7da048b5e8f1 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 jvanverth@google.com Use texture for shadow falloff

Created with:
  gclient setdep -r src/third_party/skia@7da048b5e8f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: chromium:b/142333639
Change-Id: Ic7d91f7789ef0bad47ba7cf10a2ddf04aad06c38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890624Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710794}

base::ProtectedMemory is being deprecated because it's not widely used
enough to make a security impact and justify its maintenance burden.
Replace use of base::ProtectedMemory with raw function pointers and add
an attribute to disable CFI-icall checking.

Bug: 1018834
Change-Id: I2ff1a9ad5415b8244b5b488fcf115b7481022c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888775Reviewed-by: Martin Robinson <mrobinson@igalia.com>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710793}

Bug: 1014959
Change-Id: I3504b83034008c12bd66a02b01154395484e919d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888100
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710792}

This reverts commit 5bb59abc.

Reason for revert: CL passed webview_instrumentation_test_apk

Original change's description:
> Revert "printing: Mojofy PrintMsg_* in PrintViewManagerBase"
> 
> This reverts commit 10d377be.
> 
> Reason for revert: Speculative revert for webview_instrumentation_test_apk failing on https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/6755?blamelist=1#blamelist-tab
> 
> Original change's description:
> > printing: Mojofy PrintMsg_* in PrintViewManagerBase
> > 
> > Replace PrintMsg_PrintingDone, PrintMsg_PrintPages, and
> > PrintMsg_SetPrintingEnabled IPC messages with new Mojo methods. Update
> > AwPrintManager and HeadlessPrintManager to also use these new methods.
> > 
> > Bug: 1008939
> > Test: Print a webpage and PDF
> > Change-Id: I3a403dd47ffc9c4debe819d26b00eccbd24b1180
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876473
> > Commit-Queue: Jesse Schettler <jschettler@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Changwan Ryu <changwan@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710576}
> 
> TBR=sky@chromium.org,dcheng@chromium.org,thestig@chromium.org,changwan@chromium.org,jschettler@chromium.org
> 
> Change-Id: Id6c6676aafab9e6abeb8d99bc18613a6ba5a2c60
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1008939
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890070
> Reviewed-by: Kamila Hasanbega <hkamila@google.com>
> Commit-Queue: Kamila Hasanbega <hkamila@google.com>
> Cr-Commit-Position: refs/heads/master@{#710719}

TBR=sky@chromium.org,dcheng@chromium.org,thestig@chromium.org,changwan@chromium.org,hkamila@google.com,jschettler@chromium.org

Change-Id: I31a05cdcda5790cb925205d95da48ade2bd41e64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1008939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890712Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710791}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c47ee16c44c1..fda994c63075

git log c47ee16c44c1..fda994c63075 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 digit@google.com [vulkan] Implement external semaphore support for Fuchsia

Created with:
  gclient setdep -r src/third_party/swiftshader@fda994c63075

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/140421726
Change-Id: I508f42eda5f31a7750f726ea462ec512f6c9d461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890617Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710790}

This revert:
https://chromium-review.googlesource.com/c/chromium/src/+/1877250
https://chromium-review.googlesource.com/c/chromium/src/+/1881814

Reason for revert: https://crbug.com/1019623
Causing build failure for clank official.

Original change's description:
> Add lib placeholders when packaging modules to make bundle multi ABI
>
> This fixes a bug where modules can miss an ABI and fail the bundle
> packaging step. This is due to two factors:
>
> 1. crrev.com/c/1876975 added an allotment step to each bundle that
>    determined in which module native libs are packaged into. If a module
>    only depends on libs that are also depended on by other modules this
>    module will package no libs even though libs are specified when
>    instantiating the module target.
>
> 2. Bundletool requires that all modules support the same set of ABIs.
>    To make modules appear to support the WebView ABI for Monochrome and
>    Trichrome we add placeholder libs for the WebView ABI. We do this in
>    the chrome_feature_module template if we specify real libs for the
>    browser ABI.
>
> Given 1. and 2. it can happen that a module is only left with the
> placeholder lib and appear single ABI, failing packaging. This CL fixes
> that by telling the packaging step that the module should be multi ABI
> and the packaging step will add a placeholder lib if necessary. This
> makes placeholder logic in chrome_feature_module obsolete and therefore
> it is removed.
>
> This new multi ABI logic can likely be reused for other APKs that use
> lib placeholders simply to make the APK multi ABI.
>
> Bug: 870055
> Change-Id: I25cf4edd56bf253cff2aef54d1857cbe9167cae3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881814
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710204}

TBR=cjgrant@chromium.org,estevenson@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870055, 1019623
Change-Id: I3e3acdbfe062c3b360c284811506dfd11900b4b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888656
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710789}

Both WebView's and Chrome's cache clearing APIs do the following:
1) Clear the GL shader cache, which corresponds to DATA_TYPE_CACHE in
the language of browser_data_remover.h.
2) Clear the Blink cache of the renderers.

This CL implements the first part in WebLayer.

Change-Id: Ib29edf65bf36bd85c912f02b2e2bce918d7084ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883655
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710788}

Bug: 1019662,1019663
Change-Id: Ib9af219a8e386954260d10db852da1761b2366ac
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890074Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710787}

This CL populates the network isolation key for custom tabs detached
resource requests. It is computed using the |site_for_cookies_| since
that represents the origin of the app. The origin is verified using
digital asset links verification and so should be fine to use here.
The existing tests impacted by this change are:
org.chromium.chrome.browser.customtabs.DetachedResourceRequestTest
#testSafeBrowsingMainResource
and
org.chromium.chrome.browser.customtabs.DetachedResourceRequestTest
#testSafeBrowsingMainResourceBeforeNative

Change-Id: Ia05916f1da39ec4628c51dd4de5eeb42da78d820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854685
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710786}

Bug: 949069
Change-Id: I3d7dcddbbcfeeafee5ac7e89c45fccb2e3b86c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889974
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710785}

This CL fixes the bookmark signin promo tests when the promo is
dismissed in different scenarios.

Bug: 789531
Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Auto-Submit: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710784}

This CL increases the blob DataPipe cap from 512kb to 2MB to improve
performance.

Trials show a 12% progression at P95 when reading the body from a
cache_storage response provided to a subresource service worker
FetchEvent.  A partner site showed a 5% progression at P95 in core
css stylesheet load times.

Bug: 1010199
Change-Id: I040cadc1d6d7c081b242f72ad286a2f942b0a53f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859839Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710783}

The ScopedTempDir must outlive anything that holds file(s) open within
it; otherwise, it is unable to delete itself.

BUG=546640
R=joenotcharles@chromium.org

Change-Id: I40a4febf2585e0f445790ca99f45f2ef2f3e4b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889975
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710782}

Bug: 1019663
TBR: fbeaufort@chromium.org
Change-Id: If58fd2c071cab7e77db76c96b78d6a25c46a7ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890532Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Auto-Submit: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710781}

Tbr: eugenebut
Bug: 987646
Change-Id: I5856f970fac3af18be19761d09cf649d953a05b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883717
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710780}

The test was disabled (crrev.com/c/1849426) because it instantiates
FeatureLists after the browser threads have been created.

The test enables custom passphrase with scrypt key derivation on one
client and expects another client to be able to setup decryption
without scrypt being enabled. Solution is just setting up encryption
in the pre-test.

Bug: 1013073
Change-Id: I7c6edf5d2ab7be432835c8fd3a3820bf60fd3ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890416Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#710779}

https://webrtc.googlesource.com/src.git/+log/4778f6ce7a0b..4e19670d3a93

git log 4778f6ce7a0b..4e19670d3a93 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 hbos@webrtc.org [PeerConnection] Implement parameterless SetLocalDescription().
2019-10-30 sakal@webrtc.org Disable rendering statistics while video is paused.

Created with:
  gclient setdep -r src/third_party/webrtc@4e19670d3a93

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:980885,chromium:b/142685093
Change-Id: I82db2bdbddeeed75ae3b57c392e71b2eefd1f4e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890616Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710778}

This reverts commit 03e8e9c1.

Reason for revert: Not useful revert. 

Original change's description:
> Revert "[ios] Disables CookiesTestCase on iOS 12 under EG2."
> 
> This reverts commit 7c87047e.
> 
> Reason for revert: tree failure.
> 
> Original change's description:
> > [ios] Disables CookiesTestCase on iOS 12 under EG2.
> > 
> > BUG=1019670
> > 
> > Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630
> > Commit-Queue: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710769}
> 
> TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com
> 
> Change-Id: Iee07c30e9f08de1ad2457a300e809b173c03df56
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1019670
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890058
> Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710774}

TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com,hkamila@chromium.org

Change-Id: I18af80235e3078a1ea5f4bbd7895a64108f53b0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890434Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710777}

https://chromium.googlesource.com/angle/angle.git/+log/07be79e14506..924dad3b22c2

git log 07be79e14506..924dad3b22c2 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 42f885238114..7e2cba6a5241 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@924dad3b22c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:None
Change-Id: I2344d14e024f24e3cd62ceaa54909df43bb64ecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710776}

Up until now, heap snapshot could not handle ephemerons. Since heap snapshot
is always called after a GC, we can treat ephemerons as strong hash tables.
The visitor interface is extended with a method that get a KeyValuePair. This
is needed so that heap snapshot can determine the correct parent for the
value. The default visitor implementation ignores the key and only traces the
value. The DevTools visitor sets the key as the parent and then traces the
value. Since DOM worlds are ephemeron-based since r705062 this allows users to
debug those using DevTools as well.

Drive-by: remove redundant trace in Node::Trace.

Bug: 986235, 993415
Change-Id: Ifaf453b2d7c2883a929577825991a11fbb0cf835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834229
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710775}

This reverts commit 7c87047e.

Reason for revert: tree failure.

Original change's description:
> [ios] Disables CookiesTestCase on iOS 12 under EG2.
> 
> BUG=1019670
> 
> Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630
> Commit-Queue: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710769}

TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com

Change-Id: Iee07c30e9f08de1ad2457a300e809b173c03df56
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890058Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710774}

Bug: 1019211
Change-Id: I2df1ed99e225bbd6b7e480388828632b7d6ef13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890412
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710773}

On the first click on the profile menu we show the local avatar instead
of GAIA avatar for signed in accounts. To fix that, we load the GAIA
image from disk on startup if needed.

Bug: 1017445
Change-Id: I43739a4da1f3dd2729c5aa6082fa23be0512038c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888030Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710772}

This reverts commit fa7708ed.

Reason for revert: Breaks this bot: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/12814

Original change's description:
> Move sharing messages to sync protocol directory.
> 
> Bug: 1018129
> Change-Id: I1aa4d71364fd9324770807ec5c0edb11a5939e0e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890410
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Richard Knoll <knollr@chromium.org>
> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710768}

TBR=mvanouwerkerk@chromium.org,mastiz@chromium.org,knollr@chromium.org

Change-Id: Ic9cc83a44b50f18af9e806bd7a74a318761a385b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1018129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890533Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710771}

The three last tests time out because handleEvent exceptions are not
passed on.

Bug: 1014421
Change-Id: I2349cb92968e375e5af2befaeea49abd1ec584d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889972Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710770}

BUG=1019670

Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710769}

Bug: 1018129
Change-Id: I1aa4d71364fd9324770807ec5c0edb11a5939e0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890410Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710768}

This was added in r422176 as a bug fix, but the original author doesn't
recall specifically what it fixed, speculating that it might be related to
a bug that caused searches not to terminate in some cases.

This interacts poorly with last year's refactor to use idle tasks for find,
causing a great deal of "final" updates per frame. I think it's likely that
the original bug was addressed by the same refactor, but if not, removing this
code will smoke it out so we can document *why* we need it.

Bug: 1015818
Change-Id: I8234aa3788b24ce54ae75120c8d1e00c6ed31d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888090Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710767}