- 06 Apr, 2018 39 commits
-
-
Devlin Cronin authored
The histogram values for an extension function are used to report API call activity and related metrics for extension functions. Each extension function should have a unique histogram value, but some of them were erroneously copy-pasted. This leads to incorrect metrics, both with not reporting one function and over-reporting another. Fix the instances where the histogram values were duplicated, and add a browser test that ensures each function has a unique histogram value. Bug: 827601 Change-Id: Ic44519ca83fe0cf4b3a1896a16232f6400b6c79d Reviewed-on: https://chromium-review.googlesource.com/988227 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548654}
-
Xianzhu Wang authored
I found the reason that SPv175 has 10% less paint_op_count but about 1% more paint_op_memory_usage: we didn't count ops in sub-records. Add cc::DisplayItemList::TotalOpCount() to count all ops. Bug: 803867 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0526ace84cc16775d5691e87b502544e64f5932e Reviewed-on: https://chromium-review.googlesource.com/996316Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548653}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I10ab13cc1eba5f515d163fe10ea24e3bcbc88416 Reviewed-on: https://chromium-review.googlesource.com/999314Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#548652}
-
Johann authored
BUG=aomedia:1672 R=dalecurtis@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I36df0607d647ba7cc4d9c46e70f1a34aaedcc54c Reviewed-on: https://chromium-review.googlesource.com/999007Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#548651}
-
Tarun Bansal authored
getSSID on Android may return a special pre-defined string if the app does not have permissions to get the SSID. In that case, the method returns an empty string. Change-Id: I58c99301b4d611124c8434e93fd787edbec32da3 Bug: 827212 Reviewed-on: https://chromium-review.googlesource.com/987306Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#548650}
-
Becca Hughes authored
The scrubbing message has lots of child DOM elements. This creates/prunes them when the visiblity of the scrubbing message changes. BUG=821961,821414 Change-Id: I4f0b2dc2c276387be1867ff6459d594dc97d3545 Reviewed-on: https://chromium-review.googlesource.com/990480 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#548649}
-
Xiaocheng Hu authored
This patch unifies the duplicate code in the function for better code health. Bug: 828719 Change-Id: I5c75a6345b345633bebd37c556b780cfaad24d1d Reviewed-on: https://chromium-review.googlesource.com/996569Reviewed-by:
Ryan Landay <rlanday@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#548648}
-
Chandan Padhi authored
MediaStreamTrack's clone should have same constraints. This CL ensures that MediaStreamTrack.clone().getConstraints() returns the same value as MediaStreamTrack.getConstraints(). Bug: 669212 Change-Id: I305a3e3e831d8355576201dada5f1ef81072bab5 Reviewed-on: https://chromium-review.googlesource.com/997319Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#548647}
-
Xi Cheng authored
This dependence is unnecessary so remove it. Bug: 734095 Change-Id: Ibadaab346553f3d842ecc371328bf624583f25ec Reviewed-on: https://chromium-review.googlesource.com/999039 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#548646}
-
Nick Carter authored
make SiteIsolationPolicy public. The problem was that --site-per-process disabled extension process sharing, but the site-per-process base::Feature (which we've been field trialing) did not. This was due to the extensions code checking only for the flag, and not considering the field trial state as well. components/printing actually got the logic right, but only by reproducing a lot of business logic. Thus, it seems appropriate to move SiteIsolationPolicy to content/public, so that we can centralize the "what kind of oopifs are there" logic. For printing, this change adds a new getter function specific to oopif compositor, since that's basically a derived policy of the process model. For extensions, we've decided to disable LockToOrigin in --site-per-process (rather than to enable it in the feature), since origin-locking extensions doesn't help with the spectre threat, and --site-per-process is about spectre these days. [Charlie suggests we develop some kind of "extension isolation v2" proposal, maybe reviving the --isolate-extension flag for that purpose!] Bug: 824966, 766267 Change-Id: Ibf7592c9d522fd0c99057358bcc34b5881780db8 Reviewed-on: https://chromium-review.googlesource.com/949966 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#548645}
-
Tommy C. Li authored
When Steady State elisions is on, and the user focuses the Omnibox, and then presses the Home key, we should unelide and place the caret at the very beginning of the full URL. Also, when the user gesture taps the Omnibox twice to place a cursor, we should also unelide and display the full URL. This CL adds a unit test for each of the above two behaviors. It also updates the TextField class to add a missing nullptr check for GetInputMethod(). This method returns nullptr in tests, and is checked in the other places it's used in the file. Bug: 797354 Change-Id: I9537028b8cb0abfdb5316efd5bae5518055f5ecf Reviewed-on: https://chromium-review.googlesource.com/998835 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#548644}
-
Oksana Zhuravlova authored
This change updates CloudPrintProxyService methods to take base::Value instead of base::DictionaryValue pointers/references and call base::BindOnce() instead of base::Bind(). ServiceProcessControl implementation was updated to use base::OnceClosure accordingly. Bug: 646113 Change-Id: Id4ff1b0ffd96ec27969bd489ab64503d85c7d6c6 Reviewed-on: https://chromium-review.googlesource.com/998522Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#548643}
-
Tim Zheng authored
BUG=chromium:800120 TEST=comment only change. Change-Id: Ie3a5d99186419c6a11d3efac4e7b50ec459cf772 Reviewed-on: https://chromium-review.googlesource.com/999118Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#548642}
-
Peng Huang authored
Add {Lock,Unlock}ForExternalUse to replace GetResourceMetadataForExternalUse. It is because the sync_token for GetResourceMetadataForExternalUse should be considered as unverified sync token due to the task (which will release the token) is not scheduled when calling GetResourceMetadataForExternalUse. It will cause problems, if the we return resources with the token to child before calling the SwapBuffers(which will schedule a GPU task to SwapBuffers and release the sync token). This case will not happen right now, but it is better to not assume it will not happen in future. Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59de9191d3405ca64704b00bedd71564812394a4 Reviewed-on: https://chromium-review.googlesource.com/986505Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#548641}
-
Kent Tamura authored
_basename_re and _checked_in_header_re were too large to work on Windows Python. Split them into small chunks. Bug: 767672 Change-Id: Ic283face324253a6d3104067237e1f41244375cf Reviewed-on: https://chromium-review.googlesource.com/997198Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#548640}
-
Kent Tamura authored
Git constructor needs platform= argument in order that git.bat works well on Windows. Bug: 767672 Change-Id: I1be316cca2211f99a2113c4ef576b30132da8ae0 Reviewed-on: https://chromium-review.googlesource.com/997320 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#548639}
-
Charlie Harrison authored
Bug: 827519 Change-Id: I395dcad4993ecad65ecf7b55d76e7004fc919d3c Reviewed-on: https://chromium-review.googlesource.com/987915Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#548638}
-
Peter Boström authored
Changes the explicit Chrome icon color to use kGoogleGrey700. Some icon colors are derived however, most of which are addressed. Derives icon colors based on text color and tab background colors based on deriving GoogleGrey700 from GoogleGrey900 for most icons as well as GoogleGrey700 from GoogleGrey800 for active tabs. Also pulls in a new batch of favicon icons to match the GG700 update. There are still text/context colors that have not been audited to use GoogleGrey900, but the changes are believed to not be so dramatic that they cannot be pulled in piecemeal. Bug: chromium:821996 Change-Id: Ic8638391146c1e43a7e2e75e19a46f4b8219913f Reviewed-on: https://chromium-review.googlesource.com/965030Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#548637}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c177b33bdde..46d83879919c $ git log 8c177b33b..46d838799 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 achuith cros_vm: Fix parsing of type='path' Created with: roll-dep src/third_party/chromite BUG=chromium:828589 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4439aecd4ca61af4021f2838cfafc9ae2b176047 Reviewed-on: https://chromium-review.googlesource.com/997767Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548636}
-
Bret Sepulveda authored
Bug: 829137 Change-Id: I1bcce9e0a61d0528318d9c58814fba3de9377434 Reviewed-on: https://chromium-review.googlesource.com/998997Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#548635}
-
Siddhartha authored
CFI table unwinder is not appilcable for builds with frame pointer enabled. Make sure can_unwind_with_cfi_table is set to false. No need to check for use_thin_lto. BUG=469376 Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6 Reviewed-on: https://chromium-review.googlesource.com/992890Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#548634}
-
Istiaque Ahmed authored
tabs api and webview have APIs for capturing tab contents, turn them to UIThreadExtensionFunction from AsyncExtensionFunction. AsyncExtensionFunction is deprecated and will be removed soon. Bug: 829174 Change-Id: I9cc390cc00903eab62b2e0b5ac42394333f243ec Reviewed-on: https://chromium-review.googlesource.com/997106 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548633}
-
Robert Ma authored
This CL contains some code health improvements as a by product of fixing issue 822041. Though the root cause of that issue was eventually fixed from upstream (https://github.com/w3c/web-platform-tests/pull/10323), these improvements are still good to have. * WPTManifest raises an exception when `wpt manifest` fails instead of directy exiting the process. Subprocess invocation is simplified. * lint-test-expectations now has a --verbose flag to print debug logs, including error messages from subprocesses (i.e. `wpt manifest`). * Use the canonical configure_logging in lint-test-expectations and LoggingTestCase in its unit test. Also make the unit test stricter as PRESUBMIT.py relies on the output. Bug: 822041 Change-Id: I4724904c61b3c5b6ed3239584ed03089f2b203ce Reviewed-on: https://chromium-review.googlesource.com/998341Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#548632}
-
Jay Civelli authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/dee930847568..f34a90b21090 $ git log dee930847..f34a90b21 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 jcivelli Expose a method in cpu.h that will soon be used by Chromium Created with: roll-dep src/third_party/ffmpeg Bug: 823931 Change-Id: I5c98a3e98f5f5fb87e46b0d6da17a05a0a0f09a1 Reviewed-on: https://chromium-review.googlesource.com/998185 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548631}
-
Kevin Bailey authored
Change from a strategy of having a separate suggestion type for tab switch suggestions to preserving the original type and (instead) adding flags which indicate that a tab switch could have occurred and (separately) did. We also populate these fields for metrics now. TBR'ing a rename of a previously approved change. TBR=calamity@chromium.org Bug: 780835 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I81a6e1c4173ae640e591cf53894c7dcc99ef2556 Reviewed-on: https://chromium-review.googlesource.com/963009 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#548630}
-
Raymond Toy authored
The members of the AnalyserOptions dictionary should have type double, not float. See https://webaudio.github.io/web-audio-api/#dictdef-analyseroptions We also correct the spec link in the idl file. Bug: 828641 Test: webaudio/constructor/analyser.html Change-Id: I25bace0d20a7e41a6e03e06999d724f0706371e1 Reviewed-on: https://chromium-review.googlesource.com/994374Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548629}
-
Xiangjun Zhang authored
Adds the controller that glues capturing with cast streaming. The interface for Mirroring service will change to mojo interface in later CL. Audio and media remoting support will be added later. Also, extracts FakeVideoCaptureHost in to a separate file to allow sharing between tests. Bug: 734672 Change-Id: Id38d376d09dac04317e3a3c01f0a5105630a4a9c Reviewed-on: https://chromium-review.googlesource.com/982992 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548628}
-
Kyle Horimoto authored
This CL adds conversions for the BeaconSeed and RemoteDevice message types. Bug: 824568, 752273 Change-Id: I03b76739ecc4a21aace82dfcd2b0a07972265455 Reviewed-on: https://chromium-review.googlesource.com/996642 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#548627}
-
Jun Choi authored
CTAP HID transport specification adds KEEP_ALIVE command. Add logic for handling keep alive messages. That is, message from HID device should be re-read after 100 milliseconds. Change-Id: Iecb002f141d1a57f5753d25d728a5f1d851323db Reviewed-on: https://chromium-review.googlesource.com/947193 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#548626}
-
George Burgess IV authored
Chrome OS wants to start uploading xz compressed profiles for simplicity (other cros bits use xz, apparently) and better compression: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/996904 The intent is to support both bzip and xz in Chromium while they make the transition, then remove bzip support after it's been stable for a week or so. This also makes us close our `urlopen` properly. It's not a big deal that we weren't before, but... Bug: None Test: Ran update_afdo_profile.py on bzip2 and xz profiles. Change-Id: I23cff0818c28b3f49c57376d76bf8144dcdab032 Reviewed-on: https://chromium-review.googlesource.com/997023 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#548625}
-
Xianzhu Wang authored
Workaround for now. We should investigate the root cause when we have concrete test cases. We had the workaround before https://chromium-review.googlesource.com/976947. Bug: 829269 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4bd729c4c443a6d39f6628852884466b5f23922f Reviewed-on: https://chromium-review.googlesource.com/998054Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548624}
-
Charlie Harrison authored
This is in preparation to add ad-tagging tests Bug: None Change-Id: I47073f4f904c0a59239b31ba7e6cb3f1387b72bc Reviewed-on: https://chromium-review.googlesource.com/988598Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#548623}
-
Gabriel Charette authored
Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/service_worker This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle() Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which focused on RunLoops with a variable name. The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. If there was a comment above the MessageLoop::ScopedNestableTaskAllower, it should have been moved alongside the augmented RunLoop. Includes should have been stripped if the was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 781352 Change-Id: Ia1793866f9ebdf502732dcd49861bf3b80c29894 Reviewed-on: https://chromium-review.googlesource.com/995973 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#548622}
-
Brian Anderson authored
To improve naming consistency, this changes instances of "Calculate" prefixes to "Compute". It also prefixes more methods with "Compute". Bug: 807463 Change-Id: I9ccebc5ffbdf42e24142e21d850ea4a8e8ac0364 Reviewed-on: https://chromium-review.googlesource.com/981518 Commit-Queue: Brian Anderson <brianderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#548621}
-
John Z Wu authored
Protocol implementation was not updated to match new signature. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ife923bfd9ad80962d322594fc7bacaf50a051a4e Reviewed-on: https://chromium-review.googlesource.com/998678Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#548620}
-
Alexei Filippov authored
BUG=825218 Change-Id: I003e8f60fd7df7cd469881917f47f0cdb2e1da42 Reviewed-on: https://chromium-review.googlesource.com/996590Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#548619}
-
Donn Denman authored
Updates the ContextualSuggestionsService to call the new ContextualSuggestionsMetricsReporter to do basic metric reporting. BUG=824185 Change-Id: I6db197cd0390abcda1337569e30b2f42961cac0f Reviewed-on: https://chromium-review.googlesource.com/994709Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#548618}
-
Becca Hughes authored
Create the arrows and style element on the overlay on demand when they are first needed. BUG=821961,821414 Change-Id: Ic695c7e3aef337e304d225575a40811a25243dbf Reviewed-on: https://chromium-review.googlesource.com/988686Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#548617}
-
Kevin Marshall authored
This roll incorporates a SDK fix which includes the QEMU-compatible build of zircon.bin for arrch64. Bug: 707030 Change-Id: Ib8efb5cdb5687af4f35b91fceb65a9343207dcf8 Reviewed-on: https://chromium-review.googlesource.com/999092Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#548616}
-
- 05 Apr, 2018 1 commit
-
-
Mohamed Heikal authored
Tab.loadurl is currently called in finishNativeInitialization in WebappActivity vs in initializeState in ChromeTabbedActivity. initializeState is called earlier in the async chain in ChromeBrowserInitializer. This CL moves the call to loadUrl to initializeState in WebappActivity. Testing shows that this change leads to a 50-70ms improvement in startup time: improvement average deviation Startup (ms) 81.86214 39.11936 StartupToNavigation (ms) 66.5648 34.37813714 NavigationToCommit (ms) 56.64914 20.09670629 NavigationToContentfulPaint (ms) 5.47332 29.81943543 StartupToContentfulPaint (ms) 72.03812 47.7408 NavigationToMeaningfulPaint (ms) 5.4415 29.80534286 StartupToMeaningfulPaint (ms) 72.0063 47.73242286 Bug: 825259 Change-Id: I90aee902d9d0fcef4972fafd40453f6f02b320d1 Reviewed-on: https://chromium-review.googlesource.com/995635 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#548615}
-