- 28 Feb, 2018 40 commits
-
-
Tommy C. Li authored
Bug: 737787, 817390 Change-Id: I789a31b49ff5c648520b84e08d63838e0324d58c Reviewed-on: https://chromium-review.googlesource.com/941404 Commit-Queue: Anthony LaForge <laforge@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Cr-Commit-Position: refs/heads/master@{#539938}
-
Eric Stevenson authored
This reverts commit 31b8b465. Reason for revert: Breaks downstream apk merging (https://crbug.com/817288) Original change's description: > bindings: Prepare V8ContextSnapshot on Android > > This CL makes it possible to create and use V8 context snapshot > files on Android, if a developer puts "use_v8_context_snapshot=true" > > The V8 context snapshot feature is currently supported and enabled on > Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment > showed 20% reduction of time to create V8 contexts. > On local Android machine, this feature shows 50% time recution. > > Beside it, in order to enable the feature on cross-build platforms > like Android, we have to build Blink twice. > So this CL does not flip the flag |use_v8_context_snapshot|. > > FYI, some numbers with the feature are written in the next CL; > https://chromium-review.googlesource.com/c/chromium/src/+/923623 > > > TBR=rockot > > Bug: 764576 > Change-Id: I7ee8a26d350b65b196854fc9209a52fb607b580d > Reviewed-on: https://chromium-review.googlesource.com/923683 > Reviewed-by: Cait Phillips <caitkp@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539558} TBR=michaelbai@chromium.org,caitkp@chromium.org,peria@chromium.org,kinuko@chromium.org,xhwang@chromium.org,nyquist@chromium.org,rmcilroy@chromium.org,rockot@chromium.org,haraken@chromium.org,mkwst@chromium.org Change-Id: Ifc644f2fdffbbdad3607e6eb0e867f283e80ff68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764576, 817288 Reviewed-on: https://chromium-review.googlesource.com/941387 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#539937}
-
Joshua Bell authored
Introduce basic feature usage tracking via the [Measure] IDL annotations, and add the API entry points to the appropriate enums. Bug: 161072 Change-Id: I56957fb943fbe4c6fb6c9ac589e15a6b747798f3 Reviewed-on: https://chromium-review.googlesource.com/940189Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539936}
-
Vaclav Brozek authored
Chrome on Android only allows the user to export passwords if that user is able to reauthenticate by unlocking the device. Once this reauth challenge is passed, Chrome remembers that for 60 seconds, so that the user does not need to reauthenticate again if they pause Chrome momentarily when exporting is in progress. However, the privacy review of the export feature explicitly requested that to start the export, the user always needs to reauthenticate, no matter how recent the last successful reauth was. Therefore this CL ensures that on every start of export (but not on resuming Chrome while the export is in progress), the user is reauthenticated. The CL also changes a helper method in the tests, because many tests so far made use of the fact that faking the last-reauth-timestamp evaded triggering the reauthentication. Bug: 812227 Change-Id: Ibb30b94261fad8a383d94f5c52d41cbc77a55cb8 Reviewed-on: https://chromium-review.googlesource.com/941231Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539935}
-
Yash Malik authored
This CL builds on comments from: https://chromium-review.googlesource.com/c/chromium/src/+/934621 Bug: 808456 Change-Id: I02cbee03f1b7f4214b43fe655453b8057a680cdb Reviewed-on: https://chromium-review.googlesource.com/940461Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#539934}
-
Michael Lippautz authored
Adds build infra for a new heap verification mode that can be enabled with the gn arg: enable_blink_heap_verificaton = true Bug: chromium:757440 Change-Id: I77d6ca4064b51c672b00267d21c4b5cf1f0998c6 Reviewed-on: https://chromium-review.googlesource.com/941222Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539933}
-
Ioana Pandele authored
Since the Settings > Save Passwords view will contain a button for password export as well, it should be renamed to the more general "Passwords". Bug:789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2ea88a88a7bfa989384cb302681bc37649d5aa72 Reviewed-on: https://chromium-review.googlesource.com/911798Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Menglu Huang <huangml@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#539932}
-
Paul Miller authored
Combine the crash_receiver_service and variations_service processes into a single webview_service process. This will save memory when crash and variations services are used simultaneously. Combine the crash/ and variations/ Java code into a single services/ directory. Create ServiceInit.java for common initialization code and to ensure ContextUtils.initApplicationContext() is called only once per service process lifetime. BUG=733857 Change-Id: I2588344d3d08d64f37cdd61d70d916438e32bcc4 Reviewed-on: https://chromium-review.googlesource.com/935902 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539931}
-
Ria Jiang authored
1. Changed HitTestQuery to operate in floating point for precision and updated tests. 2. Re-enabled SitePerProcessNonIntegerScaleFactorHitTestBrowserTest. MouseClickWithNonIntegerScaleFactor for viz hit-test. 3. Previously, SitePerProcessNonIntegerScaleFactorHitTestBrowserTest. MouseClickWithNonIntegerScaleFactor/0 actually went into the short circuit block (when there's only one RenderWidgetHostView) for non-viz hit-test, so it was not testing targeting. Added SitePerProcessNonIntegerScaleFactorHitTestBrowserTest. NestedSurfaceHitTestTest to test targeting for non-integer DSF. 4. Moved short circuit block to be for both viz hit-test and non-viz hit-test (tested MouseClickWithNonIntegerScaleFactor for viz hit-test before adding this short circuit). Bug: 816746 Test: site_per_process_hit_test_browsertests viz_unittests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0bbefff2d1ca0367fa28c17df586f63d7a925114 Reviewed-on: https://chromium-review.googlesource.com/938964 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#539930}
-
https://skia.googlesource.com/skia.git/+log/dabef9dddd4f..ba7a16519468 $ git log dabef9ddd..ba7a16519 --date=short --no-merges --format='%ad %ae %s' 2018-02-28 robertphillips Revert "Revert "Revert "Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)""" 2018-02-28 robertphillips Revert "Clean up GrDrawOpAtlas" 2018-02-28 robertphillips Revert "Fission GrAtlasGlyphCache in two" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I32d34d286a2635b9b955d10ffea6c4aedb833184 Reviewed-on: https://chromium-review.googlesource.com/941727 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539929}
-
Ian Kilpatrick authored
This introduces the LayoutChild API surface, (which only has a styleMap accessor currently). Each LayoutBox which is a child of a LayoutCustom will hold onto a LayoutChild object, acting as the script interface for the web developer. Bug: 726125 Change-Id: Iecdb01a38c0712dcda063b485c4207bde59f3995 Reviewed-on: https://chromium-review.googlesource.com/933092 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#539928}
-
Xianzhu Wang authored
Previously they were guarded by #ifndef NDEBUG because paint record dumping was only available in debug build. Now still guard by DCHECK_IS_ON() so that we won't build them into official releases. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I22886cd7a7fc1ef34069944534c6be79af63f757 Reviewed-on: https://chromium-review.googlesource.com/941419Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539927}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86431ec7..d5002715 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib990bd878e290a756843288c26145e1f8bc81fd3 Reviewed-on: https://chromium-review.googlesource.com/940345Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#539926}
-
Doug Arnett authored
New interface method PreviewsDecider::IsURLAllowedForPreview() checks a URL against the local blacklist and optimization hints whitelist if applicable. This reduced check is now used on the committed URL for NoScript (refactor from using ShouldAllowPreviewAtEct() at commit time). This reduces the preview logging cruft that the current commit time check adds. Bug: 816964 Change-Id: I2e81d06d3397cd3f3f7727f658ee8818c22e122c Reviewed-on: https://chromium-review.googlesource.com/922459Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#539925}
-
Elad Alon authored
Add a command line flag to enable (local) WebRTC event logging. The flag takes as argument the directory into which the logs will be saved. If the flag is used, enabling/disabling (local) WebRTC event logging from chrome://webrtc-internals will not be possible. The only way to change that is to restart the browser without the command line flag. As a drive-by, this CL removes an unnecessary check for WebRtcEventLogManager nullness, by making sure it would not be null in unit tests, regardless of timing. Bug: 815199 Change-Id: Ib8c732546c30645be823f1bdb6ad7fca8d423d26 Reviewed-on: https://chromium-review.googlesource.com/941322 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539924}
-
Ethan Kuefner authored
Bug: catapult:#4229 Change-Id: I2c7f90eac3f99178ea7729f3bfa14a44120d621f Reviewed-on: https://chromium-review.googlesource.com/940267 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#539923}
-
Raymond Toy authored
Add comments to show how to get the discrete time constant value for the formula for setTargetAtTime. No code changes at all. Change-Id: I6af196475671e030c665e5a968c18579bc8f7e83 Reviewed-on: https://chromium-review.googlesource.com/940455Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539922}
-
Philip Rogers authored
text-editor-formatter.js is no longer timing out on windows: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Feditor%2Ftext-editor-formatter.js While slow, the slowest run is 5s which is equal to the slowest mac run. This patch removes the timeout expectation. Bug: 781428 Change-Id: I707171e7a32224dc915570e692d33bf86d08d120 Reviewed-on: https://chromium-review.googlesource.com/941409Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539921}
-
kylechar authored
This CL moves implementation files for Ozone X11 into a more appropriate location in ui/ozone/platform/x11, instead of ui/platform_window/x11. Bug: 707406 Change-Id: If5673cc5283bb523eb5b8b1a8aa4d0b97133ea94 Reviewed-on: https://chromium-review.googlesource.com/941481Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539920}
-
Jay Civelli authored
The content-length related member variables occurring in a few classes (SaveFileResourceHandler and SaveItem) is not used. Removing it. Also now passing the correct content-description (it was always empty). A few minor clean-ups as well. This work is in preparation of changing that code to use the network service. Bug: 816644 Change-Id: I14f999fc3ce5b0bb77ecf9e1d35311ef7704db8a Reviewed-on: https://chromium-review.googlesource.com/938386 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539919}
-
Xiaochu Liu authored
1. Report more components. A component ID is copied from https://omahaconsole.corp.google.com 2. Reorder items in component_map to be consistent with protobuf. BUG=b:73814897 TEST=chrome compiles. Change-Id: Ia24c7a8cb63e7e42c6aa0ca2655d51b5d4e9e3b5 Reviewed-on: https://chromium-review.googlesource.com/939849Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539918}
-
Ella Ge authored
When long press on a draggable item to start dragging with touch, we should receive a touchcancel event. This CL changes it to not suppress pointercancel event when doing drag and drop. Bug: 708278 Change-Id: I754cf86dfce37f33164b797edb1f8a05acb82c9b Reviewed-on: https://chromium-review.googlesource.com/939649Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#539917}
-
David Grogan authored
Legacy layout erroneously sets box-sizing:border-box on non-table elements that have display:table when the element has a specified % height. Only <table> elements should have box-sizing:border-box. Bug: 598134 Change-Id: I66a4a6380ca60a88516a63d3df84faabd709d4c0 Reviewed-on: https://chromium-review.googlesource.com/940561 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#539916}
-
Max Morin authored
AudioOutputDevice currently expects all responses to be asynchronous, and this change also simplifies the code a bit. Bug: 816348 Change-Id: I66d51184f2553043578dda17a5cb7aeebb809a20 Reviewed-on: https://chromium-review.googlesource.com/937721 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#539915}
-
John Abd-El-Malek authored
Bug: 489301 Change-Id: I268767b48fae92c492165744e1f15389b082a33b Reviewed-on: https://chromium-review.googlesource.com/938752 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#539914}
-
Tommy C. Li authored
Fix double-click word select for steady state elisions. This bug is caused by the fact that we change the text in response to a double-click on the second mousedown. That confuses the double click word select logic, which saves the range into a member variable. There's no way for the selection controller to get the correct selected word except for us to inject an offset into it... Bug: 797354 Change-Id: I464d405920de7dfcbc317ed9ecbe8b664b920f8d Reviewed-on: https://chromium-review.googlesource.com/940603 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#539913}
-
rajendrant authored
DataUse.MessageSize.<ServiceName> histogram is recorded for each service. This histogram is used sparingly. Since there are more services, this per service histogram is not needed. Bug: 732638 Change-Id: I0d6a54ec4037da6692d8a5dcb7a537641aa111c1 Reviewed-on: https://chromium-review.googlesource.com/742690 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#539912}
-
Fredrik Hubinette authored
Change the multibuffer code to preload 1/32th of the normal preload when "preload=metadata" is used. This should work around problems that occur because WMPI says we have enough data while the demuxer may still be filling buffers. For a lot of videos, this means we'll be preloading 64k. Bug: 814328 Change-Id: Iae6945d63bf8298975eb51eda22b16189c7658df Reviewed-on: https://chromium-review.googlesource.com/937997 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539911}
-
Aleks Totic authored
Spec: https://quirks.spec.whatwg.org/#the-percentage-height-calculation-quirk It is bug compatible with Legacy. Two test results are interesting: external/wpt/quirks/percentage-height-calculation.html Here we pass/fail same tests except for one extra pass, and one extra fail. Failure is <table>, due to invalidation fast/block/basic/quirk-percent-height-table-cell.html This is an overconstrained <td>. I think that NG rendering is correct, and it matches FF. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I572571428c98fbd95abfea7539ca0ab6d16bbc06 Reviewed-on: https://chromium-review.googlesource.com/940335 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#539910}
-
Lei Tian authored
This CL add a new flag "Enable command line on non-rooted devices" to chrome://flags. If changed, it will set a flag in Chrome SharedPreferences. And when CommandLineInitUtil starts, it checks whether an alternative command line file could be used when: 1. The current build is "eng" or "userdebug" or 2. adb is enable and this is the debug app or 3. The flag is enable in SharedPreferences. Bug: 784947 Change-Id: I0ee0d2eadbc8b2f1b49b5e5959f7e72f8feda80d Reviewed-on: https://chromium-review.googlesource.com/861285Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#539909}
-
Ian Kilpatrick authored
This changes the filtered computed-style-map to being pre-populated. This shouldn't have any performance difference for the paint api, but should have increased performance for the layout api. Additionally this allows style for anonymous boxes to exist. Before we always had a Node->ComputedStyleMap, however with the layout api it is possible for access the style for an anonymous box. Bug: 726125 Change-Id: I2820001f158ac0938a277af491a05f1a72b8c734 Reviewed-on: https://chromium-review.googlesource.com/937905 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#539908}
-
Konstantin Ganenko authored
FormDataParserMultipart contract says that "*OCTET" part of body is read and passed as string of bytes. In case header has filename, octet part is ignored - store filename instead. Actual code doesn't implement it. It led to situation when octet data were read and were put as string to base::Value. That led to DCHECK as far as string value must be utf-8 string. The same problem occurs with FormDataParserUrlEncoded, where encoded part can be as utf-8 string or binary data. Bug: 813561 Change-Id: I453e5767e44334535253d1bd3fa4e857c2d3a3ff Reviewed-on: https://chromium-review.googlesource.com/910848Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539907}
-
Becky Zhou authored
Bug: 810433 Change-Id: I59aa22cefec747e16993e7f747a02087b80f6aac Reviewed-on: https://chromium-review.googlesource.com/935684 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#539906}
-
Chong Zhang authored
This CL: 1. Introduce |Tracked/HostChildURLLoaderFactoryBundle| to track and post updates to cloned bundles in the event of Network Service crash. 2. Add browser tests to make sure WebWorkers and frames from 'window.open()' can load URL after crash. Related Discussions: https://groups.google.com/a/chromium.org/forum/#!topic/network-service-dev/iWk6Dt9_GA0 Bug: 780956 Change-Id: I3d0b585757e957949d9c4816799ffaa19045ac97 Reviewed-on: https://chromium-review.googlesource.com/912276Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539905}
-
Zhiheng Vincent Li authored
CastWebContentsComponent.start() is called everytime when saying "OKG, play next" before the media app is stopped by a voice command. Because we lose the reference to the old intent receiver, the old one has no chance to unregister from LocalBroadcastManager, which would cause memory leak. Change-Id: Ie16fb82c220c48c5410cf57a6d829b2984880d95 Bug: b/73789608 Test: cast_shell_junit_tests Reviewed-on: https://chromium-review.googlesource.com/933581Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#539904}
-
Jun Cai authored
The initial upload patch of this CL is the same as: https://chromium-review.googlesource.com/c/chromium/src/+/877512 This reland CL addresses comments at: https://chromium-review.googlesource.com/c/chromium/src/+/877512/19 The initial upload patch of this CL uses empty credential to indicate that URLRequest::CancelAuth() needs to be called, which is incorrect because empty credentials are valid. The latest patch of this CL contains the fix for this issue. TBR=jam@chromium.org, tsepez@chromium.org Bug: 783990 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifdbab56badaf3e13b5f15f5aa0d31cfb764325c6 Reviewed-on: https://chromium-review.googlesource.com/938960 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#539903}
-
Ramin Halavati authored
Network traffic annotation tag is added to SpdyStreamRequest::StartRequest and is kept with the stream for all subsequent socket writes. Bug: 656607 Change-Id: Id106621ec54af003d174ea875564b049bc8f0e4a Reviewed-on: https://chromium-review.googlesource.com/936481 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#539902}
-
Jacob Dufault authored
Bug: 808486 Change-Id: Icb5491be8b04afa9935147f64c43a08877e34a73 Reviewed-on: https://chromium-review.googlesource.com/900306Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#539901}
-
Raymond Toy authored
The function HasSetTargetConverged was too restrictive and would continue to say the setTargetAtTime event was not converged even though the increment was so small as make no change in the value. Thus, adjust the criteria so that if the increment is too small to affect the value, consider the event has having converged. There's also a bug in HandleAllEventsInThePast where setTargetAtTime has converged and we've updated the default value but the timeline would return the old default value instead of the new converged default value. A couple of tests needed to be updated due to the change in the convergence criterion. Ran the test https://jsfiddle.net/8vo0gbav/52/ and the CPU now no longer goes to 100% as it did without this change. Bug: 813504 Change-Id: I506b31289b5b40380147d231d8b2ea41785d6600 Reviewed-on: https://chromium-review.googlesource.com/940273Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539900}
-
John Chen authored
As the preliminary step to resolve issue chromedriver:2222, modify the build script to archive the PDB file from each Windows build. Bug: chromedriver:2222 Change-Id: Ic8641eae20349ff436e0d1ec7ded1968fd97d4a6 Reviewed-on: https://chromium-review.googlesource.com/940169Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539899}
-