- 30 Sep, 2019 40 commits
-
-
Adrian Taylor authored
Clarifying documentation to make it clear that a disabled feature does not necessarily result in Security_Impact-None. Also, bringing note on Sheriffbot behavior up to date. R=cthomp@chromium.org, nasko@chromium.org Change-Id: I6073b579dc490e8dd67e0faf240ad8232cb58af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829743 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#701288}
-
Dan Harrington authored
Change-Id: I628b4ae3bc43c11764c64ba537491ae2d77fee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809503 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701287}
-
Jaeyong Bae authored
This is a reland of Ie6bc51cf71f82228df32db551489bf66168a54e6 OnAddressListChanged, OnCreditCardsChanged Instead it should have a single OnPersonalDataChanged call Bug: 923868 Change-Id: I08f99ddaadffb84bfb9fd6fb8584313fbf10a9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631451 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#664246} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680537 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#701286}
-
zhaoyangli authored
Added a flag to |ChromeTestCase| class to indicate whether +setUpForTestCase has been executed in a test case, preventing +setUpHelper from being called twice after one relaunch during test case set up. Bug: 1008495 Change-Id: I6f7b6fbda5d2fb08c98d6a61a66043852587f86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828076 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#701285}
-
David Tseng authored
Change-Id: I5af333c9554762e332999450fba1b432920e305f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825104Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#701284}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c475f5650417..a9dc7707d610 git log c475f5650417..a9dc7707d610 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 srisser@google.com Optimize "max(t, t)" to fold into just "t" 2019-09-30 amaiorano@google.com Fix regres script Created with: gclient setdep -r src/third_party/swiftshader@a9dc7707d610 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ia2815df7c84b516309952cc6e9ebbb526cd38ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832048Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701283}
-
Henry Jian authored
Previously we had AddToHomescreenManagerTest#testAddAdaptableShortcut broken because we were not mocking the AddToHomescreenView fully. This CL fixes this. Bug: 977173 Change-Id: I643d4e26c354ae14792a2e85f720edad712a60cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832287Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701282}
-
Robert Ogden authored
Change-Id: Ieda66129f16756e97cd72fae57aa618377e59e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831454Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#701281}
-
Patrick Monette authored
The classes that required ServiceWorkerContextCore to outlive them no longer take the context core by WeakPtr. Also fixed a few missing include for used headers. Change-Id: Id5f8079c631ed36ef83b50ddd24ac26c2ac3af9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830064 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701280}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I18acde0a5ef857875e94c0311930dd3b0a00fdd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832004 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#701279}
-
Austin Eng authored
Recent changes in Blink caused this to start crashing. Directly using v8::Null instead of ScriptValue::CreateNull fixes the issue. It looks like is related to crbug.com/1008765 where it's no longer value to create a Null ScriptValue when the value is no longer "in context". This CL applies a small fix for the crash so we can roll the WebGPU CTS and prevent further regressions. Bug: 1009635 Change-Id: I4d4de6b499b05bb1833ec34128239ca135692378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830283 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#701278}
-
Navid Zolghadr authored
When we are still waiting for the drop callback we shouldn't end the drag. Instead we should wait for the drop callback first (which sends a drop js event) and then end the drag (which sends a dragend js event) so that the ordering is guaranteed. Bug: 1005747 Change-Id: I8dd9eb4b5321e00f6c32c210541ce516eacafec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825457Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701277}
-
David Bertoni authored
Bug: 489687 Change-Id: I13da4c428a3dfcf30660d9a0a38465678b3cd55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797483 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#701276}
-
Evan Stade authored
PrerenderManager is already a profile keyed service, so will be shut down (with ShutDown()) and destroyed when the profile is destroyed. Since NOTIFICATION_PROFILE_DESTROYED comes before ShutDown(), in practive we never logged FINAL_STATUS_MANAGER_SHUTDOWN (see Prerender.FinalStatus histogram for confirmation). So to maintain continuity in UMA, this change obsoletes FINAL_STATUS_MANAGER_SHUTDOWN and replaces it by FINAL_STATUS_PROFILE_DESTROYED. Bug: 268984 Change-Id: I97f95d2f8d693432022955ba58ed152ff81a89db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830399Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#701275}
-
Rob Schonberger authored
Change-Id: I8d8b301ccb6b3d3b3abe48c1ea916a4bbe36d4cf Bug: 1009290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830237Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@google.com> Cr-Commit-Position: refs/heads/master@{#701274}
-
liberato@chromium.org authored
InMemoryURLIndexTest.AddNewRows InMemoryURLIndexTypesTest.OffsetsAndTermMatches InMemoryURLIndexTest.Retrieval KeywordProviderTest.URL InMemoryURLIndexTest.CacheSaveRestore OmniboxEditModelTest.InlineAutocompleteText Bug: 1009588 Change-Id: Ia3e749b64e5618bee25cac2874d4ba5e7ece1d45 TBR: jdonnelly@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830285Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701273}
-
Matt Jones authored
The onSheetReleased event is unused and a similar result can be achieved using onSheetStateChanged. Bug: 986310 Change-Id: Ia9da5333429a7d98ed463c29ada92350e3a05abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825888 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#701272}
-
Paul Lewis authored
Bug: 1009443 Change-Id: Iaf4ed0b2f02e016a665c42da2082c207e2a2ee6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829710Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#701271}
-
James Cook authored
https://chromium-review.googlesource.com/c/chromium/src/+/1825659 hid both the night light screen temperature and schedule when the night light toggle was off. We actually only want to hide the screen temperature slider. The schedule should always be visible. Bug: 1009416, 1000683 Test: updated browser_tests Change-Id: I04179face9d25a3c0517d823fd91247594c2ce4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831008 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
liberato@chromium.org authored
GCMDriverFunctionalTest.UnregisterWhenAsyncOperationPending GCMDriverTest.GCMClientNotReadyBeforeRegistration GCMDriverFunctionalTest.Register GCMClientImplTest.RegisterAgainWhenTokenIsFresh GCMClientImplTest.DispatchDownstreamMessageSendError GCMClientInstanceIDTest.DeleteAllTokens GCMClientImplStartAndStopTest.DelayedStartRace GCMClientImplStartAndStopTest.StartStopAndRestart GCMClientInstanceIDTest.GetToken Bug: 1009586 Change-Id: Id9a51969b6d4cd2caa63c8689faf8f9be31fbf69 TBR: fgorski@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829674Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the mojom.FaceDetection[Provider] interface, and adapt tests. Bug: 955171, 978694 Change-Id: I97c5ebebb2d3e3df24a4fe481987042ce0dff9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827279Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#701268}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the mojom.BarcodeDetection[Provider] interface, and adapt tests. Bug: 955171, 978694 Change-Id: I619bdfd9e96e08fd0648cf805710588d6ad3981c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827359Reviewed-by:
-
Patrick Noland authored
Now that we're launching to stable, Chromeshine should be on by default. Change-Id: I3a7176ad933ba4557f97fc81113d891f9e79e739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832290Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#701266}
-
Raul Tambre authored
Example error: Traceback (most recent call last): File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 14, in <module> import extract_histograms File "C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py", line 60, in <module> import HTMLParser ModuleNotFoundError: No module named 'HTMLParser' Also fixed deprecation warnings: C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py:150: DeprecationWarning: The unescape method is deprecated and will be removed in 3.5, use html.unescape() instead. return HTMLParser().unescape(line) ...C:\Google\chromium\src\tools\metrics\histograms\extract_histograms_test.py:481: DeprecationWarning: Please use assertEqual instead. self.assertEquals('This is a summary with & and " and \'', The changes are backwards compatible. Bug: 941669 Change-Id: Ieb22e72b37ec26886f3ca1341e487be4f0ba3ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830657 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701265}
-
Maksim Ivanov authored
Add the DCHECK into the ExternalPolicyDataFetcher's destructor that it's executed on the right sequence. Before this CL, the destructor contained the comment that stated that such DCHECK isn't technically possible due to unusual destruction order in some tests, but we can't repro this problem with the current ToT anymore. Bug: 727645 Change-Id: I6490227656a876d546cd5b659f5d88b2d2ec0dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828820Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701264}
-
Kristi Park authored
For grammatical correctness Change-Id: I2d5faa4acc6b1855c21c25cb23d9afacf243f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829295Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#701263}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/events to the recommended methods/types. Bug: 1007850 Change-Id: Id725e2236e305a5b0b1eb5f555c3c412b8139416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831866 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
sczs authored
Some ConfirmInfobars like Restore tabs are important enough that we don't want some users to miss them. Either because they are not presented because some other Infobar is being presented, or because they time out before the user has seen it. This CL adds a BOOL flag to InfobarCoordinator, which InfobarContainerCoordinator will use in order to add that Infobar's banner to the top of the queue and display it for a bit longer. I didn't want to create a more granular system since this might be temporary until we migrate some of these Infobars to alerts or something similar, and its also not currently needed. Bug: 961343 Change-Id: Icf03748ec50b63bd9c99ead96ccae5c7fc644b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828237Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#701261}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the shape_detection.mojom.TextDetection interface, and adapt tests. Bug: 955171, 978694 Change-Id: Ic528a0940a051c4dd692c2aa1bf08e1843ff8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826617Reviewed-by:
-
Ken Rockot authored
This reverts commit b78156eb. Reason for revert: Compile failures regarding template parameter shadowing: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/5546 Original change's description: > Roll abseil_revision 4ef574064e..ccdd1d57b6. > > Change Log: > https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4ef574064e..ccdd1d57b6 > Full diff: > https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4ef574064e..ccdd1d57b6 > > Bug: None > Change-Id: I8df493afa9903590cf61a51cda3b4988d122dfd7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819237 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701231} TBR=thakis@chromium.org,mbonadei@chromium.org Change-Id: I07a7c5ce83040a71d58fe7abc678b6c12a4b93b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831414Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#701259}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c37a501458e2..839a023619b5 git log c37a501458e2..839a023619b5 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 wl@gnu.org * src/sfnt/sfwoff2.c (reconstruct_font): Fix memory leak. 2019-09-30 wl@gnu.org [woff2] Reject fonts without `head' table. 2019-09-29 wl@gnu.org [woff2] Fix compiler warnings. Created with: gclient setdep -r src/third_party/freetype/src@839a023619b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Icf8a8a0488c0845d9d4fe2d9dd20e19bf5a6efd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831594Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701258}
-
Tim van der Lippe authored
Introduce a new namespace "Root" to be able to disambiguate between Runtime the namespace and Runtime the object. roll CodeMirror The above line is necessary to fix the presubmit, which complains about CodeMirror changes. This is only updating a type reference. Bug: 1006759 Change-Id: I04941d9f18649701060e3035f7eeb2ef3abb51e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829708Reviewed-by:
-
Kalvin Lee authored
This change makes the display name of print media available earlier - i.e. available from the moment the Papers are constructed in the backend. Bug: chromium:974707 Change-Id: If63b118c6c6c990cd5baa91095ac7195484a0cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829559 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701256}
-
Sahel Sharify authored
This is a reland of 3dd95e21 The payment_method_change_response is not renamed in the reland since clank repository is using PaymentMethodChangeResponse. The rename will be landed in a separate cl. Original change's description: > [Payments] Enable shipping and contact info delegation [4/5] > > This cl implements shipping address/option change events for PH. With > this change payment handlers can notify the merchant when the user > changes the selected shipping address/option, and wait for updated > details (e.g. new shipping cost, etc) from merchant. > > For overall flow please check > https://chromium-review.googlesource.com/c/chromium/src/+/1779003 > > Bug: 984694 > Change-Id: Id881ba22bf4c846a4570801bacc49e5d4e89a72b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804557 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700238} Bug: 984694 Change-Id: I9a1a84e56701287eb3625b6a681a3f346c47a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828101Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701255}
-
Mike Dougherty authored
Bug: 1007924 Change-Id: I9bf405a97da0209e568299a70d5804d15b2aaed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828746 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Ken Rockot authored
Bug: 999530 Change-Id: I3fb1beb7ae91322169f441f6425aff0124ba3064 Tbr: cammie@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829913Reviewed-by:
-
Kurt Horimoto authored
This ensures that FullscreenUIUpdaters stop observing their FullscreenControllers upon deallocation, preventing the referenced crash from occurring due to an observer being deallocated without being removed from the observer list. This CL also updates FullscreenUIUpdater to disconnect the observer when the FullscreenController is shut down. Bug: 1008487 Change-Id: Ic55eace199f12b3d5fe0f52301a4113fc770f94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828218 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/32eae4c231b4..4aded80e0498 git log 32eae4c231b4..4aded80e0498 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bd70e4cf..1d84c1e7 (701000:701137) 2019-09-30 mbonadei@webrtc.org Fix -Wtautological-constant-compare in test/fuzzers. 2019-09-30 nisse@webrtc.org New class ScopedJavaRefCounted 2019-09-30 srte@webrtc.org Refactoring CapBitrateToThresholds in SendSideBandwidthEstimation. 2019-09-30 ilnik@webrtc.org Fixes for support of disabling lower spatial layers in VP9 Created with: gclient setdep -r src/third_party/webrtc@4aded80e0498 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1007367 Change-Id: I70091604d042286f17dbc7dec6ac547d7acb066f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832356Reviewed-by:
-
Eric Orth authored
Was just used for MappedHostResolver, but moving to HostResolver to be more generally available to HostResolver implementations. Also rename to FailingRequestImpl. Bug: 1006902 Change-Id: Ifffe9971057d8e93a653593d93a6dc88e053f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828099 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#701250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c101eb826b8..699a19bcc20b Created with: gclient setdep -r src-internal@699a19bcc20b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iee3b8281492f73d46165f02635996a4fd81181e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701249}
-
