GitLab

Revert of Add GetAssociatedOutputDeviceID support to pulse. (patchset #7 id:120001 of https://codereview.chromium.org/2258143002/ )

Reason for revert:
Breaks audio playback on Linux Chrome OS
target_os = "chromeos" in gn args

( SoundsManager::Play fails).

Original issue's description:
> Add GetAssociatedOutputDeviceID support to pulse.
> We use the bus path for identification of devices. I have verified that it works with a headset connected with 3.5 mm connectors, and with a USB headset. Another nice thing with  his approach is that we should be able to easily find if a webcam has a built-in mic, since in this case the webcam and mic will typically be connected via the same USB port.
>
> BUG=636300
>
> Committed: https://crrev.com/cff5a1f78bd76f764a70efcdb9b908ff6a87c60f
> Cr-Commit-Position: refs/heads/master@{#415024}

TBR=guidou@chromium.org,tommi@chromium.org,maxmorin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636300

Review-Url: https://codereview.chromium.org/2322083003
Cr-Commit-Position: refs/heads/master@{#417523}

Add a CHECK() to crash the browser if a destruction order problem is
encountered.

This will be reverted once the information is collected.

BUG=641013

Review-Url: https://codereview.chromium.org/2315213002
Cr-Commit-Position: refs/heads/master@{#417522}

This patch moves |m_caretVisibility| from |CaretBase| class to |FrameCaret|
since |m_caretVisibility| is used only in |FramreCaret| class for improving code
health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2325933002
Cr-Commit-Position: refs/heads/master@{#417521}

Previously we invalidate paint (which will also cause raster invalidation)
of the subtree if z-index, transform changed on an object which will not
be composited. This requires logic to precisely predict compositing status
which is fragile and causes unnecessary paint invalidations.

We don't need to invalidate paint of object which just changes z-index,
transform etc. We can invalidate raster if needed after painting.

If a cached display item is moved out of the original chunk, invalidate
raster for it on both the old chunk and the new chunk.

If a cached display item is moved within the chunk behind any other
cached display item, invalidate raster for it.

Otherwise we don't invalidate raster.

BUG=526191
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2307623002
Cr-Commit-Position: refs/heads/master@{#417520}

BUG=627008
TBR=jsbell

Review-Url: https://codereview.chromium.org/2320963003
Cr-Commit-Position: refs/heads/master@{#417519}

There is still only a single Blimp tab, and the logic is for now very
simple: If there is already a blimp tab available, a new tab will be
WebContents based. If there are no blimp tabs, a blimp-based tab will
be created.

Also, when tabs are closed, it takes a while before the tab is really
destroyed, in case the user wants to undo the action. This feature
stays, but if the user selects "New Tab" or clicks the new tab button,
all the pending closures are first committed, ensuring that the tab
to be created might become a blimp tab, even if the current blimp tab
was pending closure.

Before this CL, the value 0 was always used fro the tab ID. This meant
that there would be a mixup between tabs that are closed and new tabs
that are created. This CL changes this so that each BlimpContentsImpl
gets its own unique ID, created client-side, and transferred to the
engine to be used for all communication regarding that tab, by an
update to the TabControlFeature to now include the ID.

The NavigationFeature is also updated to support receiving messages
after BlimpContentsImpl has been destroyed, which may happen, and
it now just logs those errors.

To ensure that this is visible in the tab switcher as well, a
workaround is added to ensure that the theme color is always shown,
even when on the new tab page. This is important in case where there
are many new tab pages, and one can not see which one is the blimp
tab, since the theme color is only updated when the tab navigates
away from the NTP.

To support the multiple IDs on the engine side, the Tab class is now
the implementor of the
EngineRenderWidgetFeature::RenderWidgetMessageDelegate instead of the
BlimpEngineSession. IME and compositor protos use the ID of the current
tab for their messages.

BUG=644467, 644774

Review-Url: https://codereview.chromium.org/2325893002
Cr-Commit-Position: refs/heads/master@{#417518}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/091029905a83..d961ec30c833

$ git log 091029905..d961ec30c --date=short --no-merges --format='%ad %ae %s'
2016-09-08 benjhayden Delete FailureValue
2016-09-08 benjhayden Move unit.html from value to base

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2317343004
Cr-Commit-Position: refs/heads/master@{#417517}

It served its purpose and is no longer needed. This is a simple revert
of r414123, r413080, r412464, r411775, and r410031.

BUG=623986

Review-Url: https://codereview.chromium.org/2328493002
Cr-Commit-Position: refs/heads/master@{#417516}

Now ChromeCast has switched to use mojo Renderer, nobody is using this
path any more.

BUG=571155
TEST=No functionality change

Review-Url: https://codereview.chromium.org/2325733002
Cr-Commit-Position: refs/heads/master@{#417515}

- Pin keyboard backspace can be held down to keep deleting.
- Pin keyboard key events used to doubled on settings/options.
- Pin keyboard placeholder displays correct message.
- Removed "clear" string, since the backspace is icon only now.
- Bubble now disappears when user presses a pin keyboard button after a wrong password has been entered.

BUG=642587
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2302483003
Cr-Commit-Position: refs/heads/master@{#417514}

It fails rather than times out after:
https://crrev.com/6f3528e03445a08f492462007724dd25120d372a

BUG=508734
TBR=jsbell

Review-Url: https://codereview.chromium.org/2324763004
Cr-Commit-Position: refs/heads/master@{#417513}

https://chromium.googlesource.com/chromium/src/+/8e6237357

BUG=643623
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/2313353004 .

Cr-Commit-Position: refs/heads/master@{#417512}

BUG=

Review-Url: https://codereview.chromium.org/2304453003
Cr-Commit-Position: refs/heads/master@{#417511}

R=rch@chromium.org
CC=jokulik@chromium.org,fayang@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2325733004
Cr-Commit-Position: refs/heads/master@{#417510}

(Redo due to http://crbug.com/645052)

By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass
TBR=xiyuan@chromium.org

Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
Cr-Commit-Position: refs/heads/master@{#417118}

patch from issue 2297193006 at patchset 120001 (http://crrev.com/2297193006#ps120001)

Review-Url: https://codereview.chromium.org/2324793003
Cr-Commit-Position: refs/heads/master@{#417509}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2f63c684f0aa..091029905a83

$ git log 2f63c684f..091029905 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 benjhayden Make ValueSet use an ES6 Map.
2016-09-08 benjhayden Improve usability of value-set-table's groupby-picker.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2318933009
Cr-Commit-Position: refs/heads/master@{#417508}

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Review-Url: https://codereview.chromium.org/2325003002
Cr-Commit-Position: refs/heads/master@{#417507}

Currently, we only send encodedDataLength for redirects. However, we
already know how much we read when sending ResponseReceived. This will
improve reporting for failed requests, as they don't get loadingFinished
with full encodedDataLength.

Previous CL: https://codereview.chromium.org/2101073002
BUG=622018

Review-Url: https://codereview.chromium.org/2167853003
Cr-Commit-Position: refs/heads/master@{#417506}

NativeWidgetMus::SetBounds() was not correcting for the display origin.

Also fix NativeWidgetMus::GetBoundsInScreen(), which had the same problem.

BUG=645291,644895
TEST=run mash with --multi-display, shelf appears on second display

Review-Url: https://codereview.chromium.org/2328523003
Cr-Commit-Position: refs/heads/master@{#417505}

SVGImageForContainer tracks a container zoom factor independently of
the actual container size.  This zoom factor needs to be accounted for
in imageForCurrentFrame() -- otherwise we end up producing an SkImage
with a different size than reported by SVGImageForContainer::size().

The easiest way to accomplish this is to use size() when calling
SVGImage::imageForCurrentFrameForContainer(), instead of the unzoomed
m_containerSize.

BUG=643623
R=fs@opera.com,davve@opera.com

Review-Url: https://codereview.chromium.org/2323853002
Cr-Commit-Position: refs/heads/master@{#417504}

Potentially used in: https://codereview.chromium.org/2280513002/

R=tsergeant@chromium.org
BUG=598017

Review-Url: https://codereview.chromium.org/2321883004
Cr-Commit-Position: refs/heads/master@{#417503}

BUG=641215

Review-Url: https://codereview.chromium.org/2319013006
Cr-Commit-Position: refs/heads/master@{#417502}

Now that Oilpan is shipped, we no longer need public/features.gni.

BUG=

Review-Url: https://codereview.chromium.org/2320343002
Cr-Commit-Position: refs/heads/master@{#417501}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d046985fcb95..2f63c684f0aa

$ git log d046985fc..2f63c684f --date=short --no-merges --format='%ad %ae %s'
2016-09-08 benjhayden Approve Destructuring and Subclassable Built-ins in style-guide.md.
2016-09-08 benjhayden Display "(empty)" and "(missing)" in value-set-table

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321863005
Cr-Commit-Position: refs/heads/master@{#417500}

Assertions are removed from some of the InputConnection methods that
merely post on UI thread. In doing so, mPendingAccent was changed to be
accessed only on UI thread.

However, beginBatchEdit() / endBatchEdit() implementations are quite
complicated and no evidence calling those on UI thread was found so far.

Also, for get* methods we return cached results.

BUG=643477

Review-Url: https://codereview.chromium.org/2299913003
Cr-Commit-Position: refs/heads/master@{#417499}

This removes some duplicated code.

BUG=634443

Review-Url: https://codereview.chromium.org/2326923002
Cr-Commit-Position: refs/heads/master@{#417498}

If a _loadCompletions was started while an earlier one was active, the earlier one could still be used.

BUG=none

Review-Url: https://codereview.chromium.org/2319393002
Cr-Commit-Position: refs/heads/master@{#417497}

This CL adds a new UMA metric to record the identifier of an infobar
which was visible to the user and hid another infobar behind it. This CL
also updates the visible/hidden check to simply query whether or not
another infobar exists. This is to correct an overcounting issue that
recorded infobars which appeared after another infobar was dismissed
as being hidden.

BUG=589163

Review-Url: https://codereview.chromium.org/2321923002
Cr-Commit-Position: refs/heads/master@{#417496}

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Review-Url: https://codereview.chromium.org/2328643002
Cr-Commit-Position: refs/heads/master@{#417495}

BUG=468355

Review-Url: https://codereview.chromium.org/2321823002
Cr-Commit-Position: refs/heads/master@{#417494}

Cr-Commit-Position: refs/heads/master@{#417493}

New:
* win: Speculative fix for LNK1285/delete-pdb-and-rebuild
* win: Support for [] ATL-style uuid() attributes
* win: __nop intrinsic now has a definition
* win: complete codeview debug info for vptrs

Also switch to gnuwin-5, which is identical to gnuwin-4
except that it has gnuwin32's od.exe too.

Also switch to the python version of the Android NDK
"make standalone toolchain" script, since the .sh version
is deprecated and stopped working after the recent NDK
update.

BUG=644351,644976,644977

Review-Url: https://codereview.chromium.org/2317123004
Cr-Commit-Position: refs/heads/master@{#417492}

It's more idiomatic in Blink land.

R=esprehn
BUG=

Review-Url: https://codereview.chromium.org/2316423002
Cr-Commit-Position: refs/heads/master@{#417491}

BUG=644373

Review-Url: https://codereview.chromium.org/2326893002
Cr-Commit-Position: refs/heads/master@{#417490}

In the renderer, extensions use sync IPCs to request port ids and
request the i18n message bundle. We're looking into fixing this, but
it'll be useful to know how much time it's taking now.

BUG=645261

Review-Url: https://codereview.chromium.org/2316093004
Cr-Commit-Position: refs/heads/master@{#417489}

Often times we are doing double work parsing color text to handle invalid
colors and then parsing color text again in setColorText. We should just
parse once and pass in the Color object to ColorSwatch.

BUG=642782

Review-Url: https://codereview.chromium.org/2310633002
Cr-Commit-Position: refs/heads/master@{#417488}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3d918b93..d87b834b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2313333004
Cr-Commit-Position: refs/heads/master@{#417487}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3b96eccc03f1e5ab9efa74b1afdfb5edc8c5feb0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/c958da49797facf429100595bceb4c49e8c94cd3 Switch bot_update to use exponential backoff on clone (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=472386

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2326953002
Cr-Commit-Position: refs/heads/master@{#417486}

It is expected to fix flaky build failures in the BUG.

Using source code names, this CL adds a dependency
chrome/test/base/ui_test_utils.cc
--> content/public/browser/render_process_host.h

Other dependencies
content/public/browser/render_process_host.h
--> services/shell/public/cpp/interface_registry.h
--> out/Release/gen/services/shell/public/interfaces/interface_provider.mojom.h
are already written.

BUG=633077

Review-Url: https://codereview.chromium.org/2321563004
Cr-Commit-Position: refs/heads/master@{#417485}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d674036d5ba7..d046985fcb95

$ git log d674036d5..d046985fc --date=short --no-merges --format='%ad %ae %s'
2016-09-08 benjhayden Make metric tests examine Histograms instead of Scalars
2016-09-08 benjhayden Move displaying errors from value-set-table to metric-side-panel

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2320853004
Cr-Commit-Position: refs/heads/master@{#417484}