- 25 Feb, 2020 33 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61bf4177c413..9aa1a9673a3c git log 61bf4177c413..9aa1a9673a3c --date=short --first-parent --format='%ad %ae %s' 2020-02-25 ehmaldonado@google.com git-cl: Add GetAuthor method and cache GetLocalDescription results Created with: gclient setdep -r src/third_party/depot_tools@9aa1a9673a3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051631 Tbr: agable@chromium.org Change-Id: Ia0b5ed36a26720d3a836728a3a97d22e6eb6157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070980Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744155}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1249ada986fc..5a921f8fadba git log 1249ada986fc..5a921f8fadba --date=short --first-parent --format='%ad %ae %s' 2020-02-24 cwallez@chromium.org Roll third_party/swiftshader/ 8def9063c..bdfcfe9cf (11 commits) 2020-02-24 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@5a921f8fadba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I54dee66cd6eddc762100cc0164fda88a2e05fd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070979Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d5a5c4801756..8fd825d3f61e git log d5a5c4801756..8fd825d3f61e --date=short --first-parent --format='%ad %ae %s' 2020-02-25 fancl@chromium.org Reland "Fixing dashboard & sheriff-config push-on-green" Created with: gclient setdep -r src/third_party/catapult@8fd825d3f61e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I4d3c741c3fa9013f4c36f9f096f73c5b7f64c021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071282Reviewed-by:
-
Giovanni Ortuño Urquidi authored
There are two changes in this CL needed for show_in_launcher and additional_search_terms. 1. Re-publish apps once SystemWebAppManager syncs them. When ExtensionApps and WebApps get notified of a new app installation SystemWebAppManager is still unaware of them. This is an issue because we store information relevant to the app in SystemWebAppManager e.g. additional_keywords and show_in_launcher. To fix this, we change ExtensionsApps (and in a follow up WebApps) to listen for SystemWebAppManager::on_apps_synchronized() and refresh the info for SystemWebApps. 2. Retrieve additional_search_terms and show_in_launcher from SystemWebAppManager in ExtensionApps when on_apps_synchronized() gets called. Bug: 1054195 Change-Id: I5af5e24bd4d61d524e3ad383093c1d00767b4106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065194 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744152}
-
Mason Freed authored
This contains no material changes. TBR=schenney@chromium.org NOTRY=true Change-Id: If653f72901935e69ae0cf5a469d60fc34d497612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071738 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#744151}
-
Erik Jensen authored
This still has a couple of rough edges: * Some layouts lacking a keypad thousands separator will show a decimal separator at both NumpadDecimal and NumpadComma. * IntlBackslash will appear on layouts where it's not typically present (usually generating '<'). * Japanese and Korean IME keys are not included even where applicable. * When the user modifies the enabled keyboard layouts or settings, several layout messages can end up being sent in rapid succession as the changes are applied. * Probably other things that will be revealed during testing. Bug: 1026029 Change-Id: Icb511db3d3b5715ab563a0f433443c977e5c805c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063850 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#744150}
-
Peter Kotwicz authored
This CL: - Adds tests for the status bar color in overview mode. - Adds @Feature({"StatusBar"}) to all status bar tests - Adds documentation for why ThemeTestUtils#assertStatusBarColor() is L+ BUG=1015627 Change-Id: If17b35cad970942add9525229da3275ac31b6adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069501 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744149}
-
yilkal authored
This cl also saves app activities for AppActivityRegistry. The list of applications are stored. The stored information includes: the application ids, the application states, the running active time of the applications, and the list of their activities (i.e. timestamp ranges when the applications were active). The information is stored every five minutes and it is restored when AppActivityRegistry is instantiated. Bug: 1050876 Change-Id: I7086f7fbf20c969b58d7af0ef398f7716171607d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063677 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#744148}
-
Stephen Roe authored
The scp operations to retrieve test data from fuchsia VMs on arm64 machines have infrequent errors (about 1 out of 3,000 test suites fail this way). This CL adds logging scp output on error to get more information about the fails. Bug: 1050072 Change-Id: I36b88863e5b3e9f27f0b43ea16ab67509d9bf39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066489 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744147}
-
Nate Chapin authored
Bug: 1052723 Test: fast/dom/HTMLScriptElement/script-append-child-in-detached-document.html Change-Id: Id1f0ad773644cbc3d5c0b5f556070c2d257a331b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070957 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#744146}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/05a90eab354e..16b67309ba83 git log 05a90eab354e..16b67309ba83 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 primiano@google.com Test: Improve FtraceProcfsIntegrationTest, skip if systrace is on Created with: gclient setdep -r src/third_party/perfetto@16b67309ba83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:149677011 Tbr: perfetto-bugs@google.com Change-Id: I8f1b27016219832c526069caeea3dab59fea2718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070978Reviewed-by:
-
S. Ganesh authored
Bug: 1055546 Change-Id: I61fb39ecf5778737cfd1535a05b94efe91317427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070839Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744144}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Lock Screen page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I34d0dc898bfd1829ccb5a3bf94fb24dbef8cba60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067396 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#744143}
-
Kent Tamura authored
FileChooserImpl can outlive ListenerProxy. We should clear FileChooserImpl::proxy_ on ~ListenerProxy(). This CL has no tests. We don't know how to reproduce crashes. Bug: 1054260 Change-Id: I2be7a8957f2f725c51081961357ef09f6dabb823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067819 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#744142}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/19304d88c8be..b5d977fae3b7 git log 19304d88c8be..b5d977fae3b7 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 bungeman@google.com Control opsz instead of CGFont in create_exact_copy. Created with: gclient setdep -r src/third_party/skia@b5d977fae3b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I822637c3cad35eb5ba5c06e97be8162b426cdb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071279Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f95054fa7d04..61bf4177c413 git log f95054fa7d04..61bf4177c413 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 ehmaldonado@google.com git-cl: Fix get_cl_statuses for Python 3 and add tests. Created with: gclient setdep -r src/third_party/depot_tools@61bf4177c413 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1002209 Tbr: agable@chromium.org Change-Id: I66764c20444b316e97ef14c7451ff71066cc39a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071277Reviewed-by:
-
chromium-autoroll authored
They have to be rolled simultaneously due to a breaking change. https://swiftshader.googlesource.com/SwiftShader.git/+log/214ec337a0b2..e162b023f539 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/79f8caf9154a..4a80497a8885 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: angleproject:4425 Tbr: swiftshader-team+autoroll@google.com Change-Id: I217cab114ce54357e0214252a26cce99c8ba1feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068835 Commit-Queue: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744139}
-
Gabriel Charette authored
This cl was generated by the same script used for https://chromium-review.googlesource.com/c/chromium/src/+/2026350 but without requiring base:: in front of the API usage. This catches usage that relied on ADL (argument-dependent-lookup) to reach the base:: namespace. I don't think we should be using ADL for ThreadPool (and assume it was likely unintentional?). TBR=ajwong@chromium.org (mechanical change for //base API) Bug: 1026641 Change-Id: I51f56d389b903c528b0fda7b3baab0083818d2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026312 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#744138}
-
Darin Fisher authored
Bug: 1050143 Change-Id: I7b5ac5d5aba763e644f372120578532ba79da7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070822Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744137}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e723c6de. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" ea6dba31 "Align <pattern> and <*Gradient> attribute collection" 7d52b1d5 "[v8][wasm] Fix WebAssembly streaming tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8f859fac76aadf3ccc67eb3e37bbd90da677dcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071075Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744136}
-
François Degros authored
Bug: 996549 Change-Id: I6c45c32116b2f7982f31837c9268253a69c7dd39 Cq-Depend: chromium:2061628, chromium:2059037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063512Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#744135}
-
Ella Ge authored
This CL removes badge icon from webapk&shortcut install, including a2hs and app banner. For splash icon, we want to fetch it for building the webapk proto, but don't want to do it together with primary icon, because it'll increase latency, and we only need the splash icon data after the user has initiated the install. For webapks, we are downloading all useful image data when computing the murmur2 hash, so we can use the the image data from webapk_icon_hasher, similar to crrev.com/c/2047166 did for the best shortcut icon. Bug: 1043271 Change-Id: Ibbe5b80796794b3f1c4b75cd81cdfc32cc61dfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032723Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#744134}
-
Yutaka Hirano authored
This reverts commit 9a31f5ab. Reason for revert: Speculative revert for LoadingPredictorBrowserTestWithOptimizationGuide.UsesPredictionsFromOptimizationGuideIfAvailable failures https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3477 Original change's description: > Reland "Add support for loading predictor to use hints from optimization guide" > > This is a reland of eed7024d > TBR=tbansal@chromium.org for chrome/browser/predictors/... > > Original change's description: > > Add support for loading predictor to use hints from optimization guide > > > > Will add metrics in a subsequent CL. This shouldn't affect any current > > metrics since the support is all behind a feature flag. > > > > Bug: 1050101 > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#743767} > > Bug: 1050101 > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744088} TBR=tbansal@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org Change-Id: If2d29382d644733504141aed662fe7c570cd8db8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071178Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#744133}
-
Jared Saul authored
Although the code was cleaned up, since the flags were left in flag-metadata.json, we got alert emails that the flags were going to be expiring. To prevent these alarming emails, just remove the cleaned-up flags. Also updates some other Autofill-related flags, incl. owners and expiry. Change-Id: Id8185a2b7c1dd62ae9822188194e9723705f26d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070965 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#744132}
-
Rakesh Soma authored
Bug: 1055120 Change-Id: Ie3b6832a4f4aca0e7c3ac688488fae0494b9dc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069500Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#744131}
-
Piotr Bialecki authored
Bug: 1054952 Change-Id: Ic03ce2e03fc8c6e55e5cc46faf49057f32593404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070966 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#744130}
-
Quinten Yearsley authored
When cpplint was enabled, there was discussion about its usefulness since clang-format is already enforced via presubmit checks. It was decided that cpplint could be somewhat useful until a clang-tidy analyzer was enabled, and at that point clang-tidy may cover any use-cases that were covered by cpplint (and many more). Now, clang-tidy is here and enabled, and cpplint should be disabled as it sometimes produces false positives. Bug: 1048144 Change-Id: I79be2b1660b186e16925be791f26b14c4e63f0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071358Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#744129}
-
Noel Gordon authored
CSS rgba color expressed as percentages using % is our preferred style these days. No change in visual behavior. Bug: 992824 Change-Id: I69d67b0d3eb135b8d909c3954c0a9010df9e6f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068229Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744128}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/def23d3c..9b2c573d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib73b8f11652b53c9bdfb779508e3a059e4159eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071295Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744127}
-
Eric Willigers authored
Tests using kAppDotComManifest now all call SetupAppWithURL This is in preparation for adding a configuration for web app tests. Bug: 1052722 Change-Id: I7b97eea18fb37a2373142ec41e2673d4acc9e198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069964 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#744126}
-
Michael Ludwig authored
Bug: 1044032 Change-Id: I4f577ce9f2cf2d45fdf1abcb5cf36973a5285495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068034Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#744125}
-
Kyle Milka authored
Reorder the first party share options to match the spec. Bug: 1009124 Change-Id: I0f90f6c2cc7edad008b2d49f67943fc49c366804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062574 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
-
Brandon Wylie authored
The ColorStateList needs to be different between the mic button and the delete button. Bug: 1054300 Change-Id: I97e88144c359e5c27cecfd7b99509051520a7808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067461 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
- 24 Feb, 2020 7 commits
-
-
Kevin Babbitt authored
We were using AriaRole as the node name, but AriaRole is intended as an informational property. ControlType is a better match for the notion of "role" in UIA and is better suited for this purpose in UIA specific tree dumps. Bug: 1039347 Change-Id: I16ce8a67b7a981a106ce6877b47b0fde0c585f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068653 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744122}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I45fbe737c714780a3c15044fca04c3ec58cfa882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071275Reviewed-by:
-
Katie D authored
Reader mode view page title now says "Loading..." instead of "Simplified view" on Desktop before the article title is populated. The article title is followed by "- Reader mode" to provide an indication to screen reader users that they are in a distilled page tab. Bug: 1016461 Change-Id: Ie7ab1ab1e89090e182c4c556bd22878ee876b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052487 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744120}
-
Caroline Rising authored
Make popped out extensions stay popped out if they have a context menu shown in the new extensions toolbar container. Previously we would only check if a context menu was running when trying to hide a popped out extension. In the case where the context menu was not yet running when this happened then the popped out extension would be hidden when it shouldn't be. This change lets the ExtensionsToolbarContainer keep track of an extension with an open context menu and adjust visibility accordingly. Bug: 943702 Change-Id: I547b16eb324852c9559238c646d189c39892fb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065009 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744119}
-
Esmael El-Moslimany authored
Bug: 1054741 Change-Id: Iae1362c77859c122c7100886788c64682aa569b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070735Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#744118}
-
Tom McKee authored
Before this change, running javascript like `performance.mark(...)` would result in a callstack like MakeGarbageCollected<PerformanceMark>(...) PerformanceMark::Create(<overload-1>) UserTiming::CreatePerformanceMark(...) Performance::mark() <v8-bindings-layer> `performance.mark(...)` while running script like `new PerformanceMark(...)` would result in a callstack like MakeGarbageCollected<PerformanceMark>(...) PerformanceMark::Create(<overload-1>) UserTiming::CreatePerformanceMark(...) PerformanceMark::Create(<overload-2>) `new PerformanceMark(...)` Note that, since the bindings layer calls into PerformanceMark::Create directly, PerformanceMark had to call UserTiming which had to call back to PerformanceMark. Apart from being a cyclic dependency, this also lead to confusion around which constraints needed to be checked at which points. This CL breaks the cyclic dependency between UserTiming and PerformanceMark by pushing all the validation into a single PerformanceMark::Create function. Along with this change comes better UseCount tracking for UserTimingL3 in the case where script runs `new PerformanceMark(...)`. Bug: 805566 Change-Id: Ic648b097734655b2c0e55db95e738b48bc8826c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003552 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#744117}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bfe5a68c1e31..19304d88c8be git log bfe5a68c1e31..19304d88c8be --date=short --first-parent --format='%ad %ae %s' 2020-02-24 nifong@google.com Move all canvaskit example resources to CDN 2020-02-24 herb@google.com Remove SkExclusiveStrikePtr. Replace it with sk_sp<SkStrike> Created with: gclient setdep -r src/third_party/skia@19304d88c8be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ieb238fd608000b4cede306771a41e47acf13c4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071115Reviewed-by:
-
