GitLab

https://chromium.googlesource.com/angle/angle.git/+log/6c59e4a156c3..bb52c523556e

$ git log 6c59e4a15..bb52c5235 --date=short --no-merges --format='%ad %ae %s'
2018-04-06 oetuaho Invariant declaration doesn't make a variable active

Created with:
  roll-dep src/third_party/angle
BUG=chromium:829553


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ie3721859163572a63d911bc96afc473d9c44fdeb
Reviewed-on: https://chromium-review.googlesource.com/1003036Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#549272}

Specifically, this includes metrics reported by ChromeOSMetricsProvider
in the system profile for UKM. The following fields will now be included:
- hardware.hardware_class
- hardware.internal_display_supports_touch
- hardware.bluetooth (and all the sub-fields)
- multi_profile_user_count

A note on the implementation: This reports the new short hardware class
field that is now reported to UMA (as of M67), as enabled by the kUmaShortHWClass
feature. This CL also improves this logic (both for UMA and UKM) by doing it
synchronously which is possible with the new implementation. The bluetooth data
is still retrieve asynchronously however - which is new for UKM service.

In addition, this CL fixes MetricsProvider initialization order in UkmService,
where previously the Init() call on providers was happening before providers were
added. This was not a problem before because the existing providers did not do
anything in Init().

This change also improe

Bug: 807663, 810872
Change-Id: I4b0dcb848e40a467a26feaf757f43aaf442be050
Reviewed-on: https://chromium-review.googlesource.com/996175
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549271}

Bug: 830853

Change-Id: I893b5d205d6f3e033e0d5cc7f95d4acc4391fd23
Reviewed-on: https://chromium-review.googlesource.com/1001475Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549270}

Better enterprise management detection. Detect additional OpenDirectory nodes and alternative identities. Filture out iCloud users.

Change-Id: I36e71f89928e180cfe257cae079a303fd8d7db74
Reviewed-on: https://chromium-review.googlesource.com/999263Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Boris Vidolov <borisv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549269}

These tests cannot invoke Print via the share menu on iOS11, so they
are redundant with the tests in JSPrintTestCase.

BUG=825431,683280

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0e9965dfddf1e49d583a5304d7392cd59ac63bca
Reviewed-on: https://chromium-review.googlesource.com/990533Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549268}

In monochrome webview mode onResourceLoaded currently rewrites all
resource ids inside resource arrays including system resource IDs. This
is a bug.

The first try to fix the bug (cl/952097) caused a performance regression
in webview startup so this is a different idea to fixing the same bug
that should hopefully not suffer from the same performance regression as
the previous.

Since resource IDs are sorted (so system resources are at the beginning
of the array).  This CL finds the index of the first non-system resource
ID and starts rewriting at that point.

NOTRY=true #win7_chromium_rel_ng extremely flakey

Bug: 821425
Change-Id: I9f6f3c517a8c09cbbefb9b584ab6f5bfc9c8477b
Reviewed-on: https://chromium-review.googlesource.com/999003
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549267}

As per steimel@'s comment in crrev.com/c/991293 we should always
create the play button as we use it when the video element is
very small.

BUG=821961,821414

Change-Id: Icec781d0cd49529c72dd21c88d54727e81236890
Reviewed-on: https://chromium-review.googlesource.com/1000722
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549266}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/da5abe6..aef0b3a

Bug: 806557, 829541, 830046
Change-Id: I2c1b6f58e8005094f3174b7c9a228a67ee2d379b
Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/996896
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549265}

We have evidence of DownloadCurrentCandidateOrAskFaviconService()
crashing due to current_candidate() being null, at least until recent
fixes.

Temporarily and as a precaution, we return early in case the problematic
scenario is reproduced. We suspect this condition is not reached in
trunk, but it's a simple workaround to cherry-pick.

Bug: 828196
Change-Id: I41e2236f341a9ed9e18a950540f096e9de42df0b
Reviewed-on: https://chromium-review.googlesource.com/1002093Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549264}

These methods are now unused after removing the Bluetooth Classic
implementation of EasyUnlock.

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: I5a2a30c7dbd83bc51441f7525030ea94526df32b
Reviewed-on: https://chromium-review.googlesource.com/1000728Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549263}

It pretends there is no history to query for or modify.
Chromevox calls only chrome.history.search

Bug: b/73383411
Test: local build

Change-Id: Ib46ea54b2a1d21faa380c5738c2cf84ad0244d94
Reviewed-on: https://chromium-review.googlesource.com/976336
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549262}

Also obsoletes some histograms. There is probably a lot more histograms
that we should remove in followups.

Bug: 788604
Change-Id: I263a3d6ab0fc612d38ea4ad794751f276cc37188
Reviewed-on: https://chromium-review.googlesource.com/999793Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549261}

This reverts commit 98d99996.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Avoid crashes if all favicons already processed
> 
> We have evidence of DownloadCurrentCandidateOrAskFaviconService()
> crashing due to current_candidate() being null, at least until recent
> fixes.
> 
> Temporarily and as a precaution, we return early in case the problematic
> scenario is reproduced. We suspect this condition is not reached in
> trunk, but it's a simple workaround to cherry-pick.
> 
> TBR=pkotwicz@chromium.org
> 
> Bug: 828196
> Change-Id: I4cc78ba01780beb59ad01a7388062f6db93b864c
> Reviewed-on: https://chromium-review.googlesource.com/1000453
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549053}

TBR=mastiz@chromium.org,pkotwicz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 828196
Change-Id: I362142e484667d85c784a884c46a07494247e349
Reviewed-on: https://chromium-review.googlesource.com/1003152Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549260}

The new PasswordManagerProxy class is an abstraction over
chrome.passwordsPrivate, used to test the passsword settings page
bahaviour.

Bug: 802352
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I12fba7cfdb4405477adf49ccb64f64d4b30a3d93
Reviewed-on: https://chromium-review.googlesource.com/883621Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549259}

This removes the usage of const scoped_refptr<DecoderBuffer>& in
favor of passing by value and using std::move.

I was experimenting with replacing it with std::unique_ptr,
but there are quite a few copies currently, so keeping it
ref counted seems reasonable for now. The conversion is half
the work, so I just finished it instead of reverting.

This fixes production code and tests which needed fixing to
compile; most other unittests are left untouched in terms of
using std::move optimally. Where possible inner functions have
been converted to const DecoderBuffer& where the pointer is
never expected to be null. Long chains of multiple inner
functions were converted to const DecoderBuffer*.

BUG=none
TEST=passes bots.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I390bc4e2fd8048e8c1c1f7725e0cc173bdd88850
Reviewed-on: https://chromium-review.googlesource.com/994058Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549258}

Android's AccessibilityNodeInfo does not have a separate field
for the value of a text field, but it does have a "hint" field.

Suppose a text field has some accessible label - like a
aria-label or a placeholder. Previously Chrome exposed that
as the field's text if the field was empty, and the hint if
the field had user-entered text. This is confusing because
once the user starts entering text, the label jumps from the
text to the hint.

Instead, always expose the label as the hint, and let the
text be empty initially.

BUG=828969
TBR=aleventhal@chromium.org

Change-Id: I4052a811d645a42b3fecf8e2e1a4b089a7da75b8
Reviewed-on: https://chromium-review.googlesource.com/994132Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549257}

Trigger a refill for select field that were unsuccessfully filled when
their content changes to the fillable value.

Only happen if all of the following are present.
- The select options changes after a user triggered fill
- If it happens less than 2 seconds after the fill
- Once per page
- If the select was set to be filled initially
- If the form has the same "NameForAutofill"

Change-Id: I4861efaa05e73ef281355158c3d3d3fbfa63e182
Reviewed-on: https://chromium-review.googlesource.com/996571
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549256}

This DumpWithoutCrashing is not providing any further useful information
so we'll disable it for now.

Bug: 828422
Change-Id: I73a62d09b0755375d8b353e620b4627611e8cd7a
Reviewed-on: https://chromium-review.googlesource.com/1000019Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549255}

Also added mojo::InterfacePtr<>::IsExpectingResponse().

Bug: 672469, 792441
Change-Id: I9c508cafae84b393e226834c4236724d59641829
Reviewed-on: https://chromium-review.googlesource.com/998166
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549254}

This is called every time the surface reference is added or removed. It
will be used in Viz DevTools to update the tree of surfaces.

Bug: 816802
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id07fc469a8fd395fac114dafb0d7c15e9809192d
Reviewed-on: https://chromium-review.googlesource.com/998411Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#549253}

Now that the waterfall has been updated to use the latest WebView,
remove test filter entries that are no longer needed.

Bug: chromedriver:1295, chromedriver:1941
Change-Id: I0f35c3ad62a0b365ac1d204157c2624546f8d379
Reviewed-on: https://chromium-review.googlesource.com/1000542Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549252}

The "background_page" key in an extension's manifest is restricted
to manifest v1 extensions, which we are removing support for. Remove
the check in ChromeDriver that looks for this.

Bug: 816677
Change-Id: I6835fecc261a4dbf8d2dafec47e3e32acddf107c
Reviewed-on: https://chromium-review.googlesource.com/988135Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549251}

Control Flow Integrity [1] indirect call checking verifies that function
pointers only call valid functions with a matching type signature. It
can't verify dynamically resolved function pointers, instead store them
in ProtectedMemory and calls them using base::UnsanitizedCfiCall() to
disable cfi-icall checks.

[1] https://www.chromium.org/developers/testing/control-flow-integrity

BUG=771365

Change-Id: I79b4c8a2bb6b7a77ff35860e7d4f7ad226745dca
Reviewed-on: https://chromium-review.googlesource.com/1000426Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549250}

Manual review of IMAGE/IMAGE+TEXT failures of build 4675 in
fast/text. I skipped all "ellipsis" tests before assuming
they're real failures, but by looking into them, there were
some glyph position differences due to text shaping
improvements.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia85c9a976e24f8abeedf4d8f4440ed1d1425fc6f
Reviewed-on: https://chromium-review.googlesource.com/1003013
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549249}

Basically, this CL ensures that when Daydream's 2D-in-VR path is enabled
that we (almost) never show VR-supporting chrome activities in 2D when
the user is in headset, even if Chrome is launched with a 2D intent.

Intents sent to the 2D launcher that can be supported by VR rendering
are forwarded to the VR launcher when the user is in headset (intents
that aren't supported by VR rendering will still show in Daydream's
2D-in-VR rendering path). If a ChromeActivity that supports VR is
launched directly while in headset, we just add the Daydream category to
the intent and continue with intent processing as usual.

If, somehow, Chrome was launched in 2D, then resumed while in headset,
Chrome will still render using the 2D-in-VR flow. This is fine for now
as Chrome will still be usable, and this situation is very difficult to
get into, but the user will probably be confused :P


This CL also avoids showing the request to exit VR prompt when 2D-in-VR
is supported, favoring immediately switching to 2D rendering mode and
showing the dialog or launching the Activity that triggered the request,
then returning to VR rendering after returning to Chrome.

Bug: 826732
Change-Id: I1a09f201554e4e3171f5657b0fb667acc6f4c784
Reviewed-on: https://chromium-review.googlesource.com/999997Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549248}

local-sdk.py used "gen.py" which was deprecated and removed from
Fuchsia.

Change-Id: I390c7458eb863e19167a6255db2aed6e9b8233c2
Reviewed-on: https://chromium-review.googlesource.com/1003077Reviewed-by: James Robinson <jamesr@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549247}

Bug:830600
Change-Id: If56f9e005014061483dcaa2bc4d39abf8314f09e

NOTRY=true
TBR=eyaich@chromium.org
CC=hablich@chromium.org

Change-Id: If56f9e005014061483dcaa2bc4d39abf8314f09e
Reviewed-on: https://chromium-review.googlesource.com/1002923Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549246}

Following bot results are included.
4673 4677

5 lines were removed and 16 lines were deflaked by consecutive
results since 4639.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I63b7b166f023cb31777ffa840b5844b83b3d92fb
Reviewed-on: https://chromium-review.googlesource.com/1002414
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549245}

Not clear why cold Chrome is receiving intents with voice search
results. I was not able to reproduce locally with initiating search and
then killing Chrome while voice overlay is in foreground. Going to just
load CTA in this scenario.

Bug: 829495
Change-Id: I63cb9bbce8b469be7370513d644565464261218c
Reviewed-on: https://chromium-review.googlesource.com/1000545Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549244}

This CL updates the modern media controls VR CSS to have the correct
pixel values based on the 0.66875 conversion factor.

Bug: 809021
Change-Id: Icc7cfbd4b53b9af8cfa3707a21e8c36b278b2872
Reviewed-on: https://chromium-review.googlesource.com/999734
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549243}

This adds an Engagement.IsHigh.Changed bit to the SessionFinished UKM
that will be true if the IsHigh bit changed during the lifetime of the
session.

BUG=814351

Change-Id: I48b296301a59d7f92ce6fd8ac7750c41ed2bbecd
Reviewed-on: https://chromium-review.googlesource.com/964181
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549242}

This is another config update that is part of renaming
these builders (at the same time as LUCI migration)

Bug: 790378, 790311, 790308
Change-Id: Ia7229dbb7de2675c28b5cd5b425542ea2232c89d
Reviewed-on: https://chromium-review.googlesource.com/1001292Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549241}

Change-Id: I76a741668409664e5f94a13988d826025e99de83
Reviewed-on: https://chromium-review.googlesource.com/1003172
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549240}

Cronet tests were recently enabled for desktop platforms, some
auto-generated code appears to call function pointers across module
boundaries. Blacklist these calls for now.

Change-Id: If3f7cf2ee84ca86f2d40b80773e5eea1c6e71716
Reviewed-on: https://chromium-review.googlesource.com/1003074Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549239}

The browser should not attach client hints to the
requests fetched from cross origins.

Bug: 817049
Change-Id: Ia7cedfbb6edaaf3616d6e2783965cc52f93c0cd9
Reviewed-on: https://chromium-review.googlesource.com/1000841
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549238}

Bug: 828404
Change-Id: Ie327e93f391376fd77cae2df998a921b4a9f0002
Reviewed-on: https://chromium-review.googlesource.com/1002873Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549237}

This change allows the toolbar for EoC to have a default click
listener attached to it. If the close button click listener does not
intercept the tap, the default one will. The new behavior is to expand
the bottom sheet when the toolbar is tapped.

Bug: 827371
Change-Id: I6ffe9388ad989a8db7a8ce19cff1b7c65b24379f
Reviewed-on: https://chromium-review.googlesource.com/1002985
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549236}

TBR=mef@chromium.org

Bug: 830707
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I455fb0013d65ca3d2c44d5e2b28dfd977ff61aa3
Reviewed-on: https://chromium-review.googlesource.com/1003114
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549235}

This src-internal directory contains proprietary icons for the Views
Cast dialog.

Bug: 826393

Change-Id: I5a23e2f9d813f8e5fa39eb0adb4a0177814b6b5c
Reviewed-on: https://chromium-review.googlesource.com/1003094
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549234}

Problem: There are 2 issues with these tests:
1. When testing glCopySubTextureCHROMIUM() the test does not clear
the previous error, so it fails when it calls glGetError(), as
the previous call to glTexImage2D also reports an error,
GL_INVALID_ENUM for GL_RED and GL_RG. This only occurs with ES2
devices.
2. When testing glCopyTextureCHROMIUM(), the error that will get hit
first and then returned depends on whether the test is being run
on a device with OpenGL ES2 or ES3+ capabilities. On ES2, the error
being returned is "internalformat GL_INVALID_VALUE".

Solution:
1. Clear previous error when testing glCopySubTextureCHROMIUM for
GL_INVALID_OPERATION so we get the error we are testing for.
2. Check if we get either GL_INVALID_VALUE or GL_INVALID_OPERATION,
as either is possible depending on which ES stack (ES2 or ES3) is
being executed base on the devices capabilities.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia99ea8a82341bd58fb634ea7144e142268ec6ab7
Reviewed-on: https://chromium-review.googlesource.com/1003075Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549233}