- 17 Jun, 2020 40 commits
-
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Ibbee5a552dc140af4f6ca01cfcf6aa4f1a3b1c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249799 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779369}
-
Ewann authored
This CL merges /#page-info-refactoring with /#improved-cookie-controls. Bug: 1063824 Change-Id: If3578cd4413a0e171ce59932608913ecf3f6469f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247735Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#779368}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I58c1887f9e2e3f491682d212412d225998591a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249676 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779367}
-
Trent Begin authored
This optional GUID is populated with the underlying NetworkStateProperties GUID field. If the Device does not have an associated network, the field will be empty. Bug: chromium:1085092 Change-Id: I5531022b887a9136a80c2f37d9398b3df663d3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247146 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Ayu Ishii authored
Per TAG review discussion [1], this change updates the set() method as follows: Promise<void> set(USVString name, USVString value); Promise<void> set(CookieInit cookieInit); dictionary CookieInit { required USVString name; required USVString value; USVString? domain = null; USVString path = "/"; DOMTimeStamp? expires = null; CookieSameSite sameSite = "strict"; }; [1] https://github.com/WICG/cookie-store/pull/141 Bug: 1087580 Change-Id: Ic22ae0bc7dfc3df71ac849b9acd894316fe01377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220556Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#779365}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I0d181f221f5f4dfe54c96d525191a69031e8b1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249740 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#779364}
-
Jonathan Mengedoht authored
[Passwords] Add 32-bit checksum field to AutofillRandomizedValue for crowdsourcing change password urls. Bug: 1095605 Change-Id: I3b7b40b7a9612e9c199697d9359e70fa857a7af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246594 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779363}
-
Tao Bai authored
The AutofillProvider interface was added for downstream coding when the Android autofill feature was first introduced. It wasn't necessary now. This patch shall also reduce the binary size a little bit. Bug: 1094377 Change-Id: I8896fbaa6260750d8b9e92df9ed67b4f5a0b26c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248170Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#779362}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Ie5cb39f54fb8d0cccc03dd02ce13755169d6f8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248687 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779361}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f5cd604cb9d0..1443609db494 2020-06-17 djsollen@google.com Revert "Update zlib DEPS" 2020-06-17 djsollen@google.com Update zlib DEPS 2020-06-17 johnstiles@google.com Enable implicit-fallthrough warnings on Clang. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ifde08f500d8e3d10098274bac140fe3e3594d92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249711Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779360}
-
Gauthier Ambard authored
This CL changes the way the UserAgent is stored and used. Now the UserAgent to be used when loading a page is stored in the WebState. Each NavigationItem is storing the UserAgent that was used when the item was loaded. This is the UserAgent that is used to display the option (request Mobile/Desktop) and to reload the page when navigating back/forward. As the UserAgent is now in the WebState, it has to be restored as part of the session restoration. This also allows the UserAgent to be kept when the preloader is used, as the session is restored. When the mobile/desktop version is requested, the NavigationManager is updating the UserAgent of the WebState. Bug: 1049094, 1076855, 1078343 Change-Id: I459ec728f01da814ba23bafc0aa7fb1e185f95e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193994Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#779359}
-
Jose Dapena Paz authored
CableDiscoveryData uses memcpy, without including the header that declares it. So include <cstring> is required. Bug: 819294 Change-Id: I1b8157d2565dc1333be51c6371de1f84374ceb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247037 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#779358}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I073c5b4200b92736ba533c176fb116f83f3ee8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248758 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. TBR=jorgelo Bug: 1031540 Change-Id: I4e85df6fa0687ec8b891d77f1fb788acf309b28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248763 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Xiqi Ruan authored
When user with child account tries to modify timezone preference, prompt parent access code validation dialog. Timezone changes can only be applied if the validation success. Bug: 997310 Change-Id: I90e1b5ebd79f5ca92dcc32223d637f37615e6699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210749Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779355}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I5040ce1488344ab719ff53b71286958b655798a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248764 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779354}
-
Fergal Daly authored
This is a bunch of tests that are broken by the fact that the RFH changes after navigation. Change-Id: I10578a56bbb382dd1e41a57f645e75d5ff51a3ba Bug: 1064944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245166Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#779353}
-
Adithya Srinivasan authored
Some permissions tests rely on a prompt being shown when requesting location access, but location access is automatically denied when geolocation is turned off in system settings. This causes flakes on certain bots that don't have geolocation enabled. Bug: 1094586 Change-Id: I08a6b5add43a90ea40ad99ec5272373ceaf03ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246925Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#779352}
-
Jimmy Gong authored
- Displays a message to indicate users that no print jobs are currently printing. Screen shot: https://screenshot.googleplex.com/YSGD579DA0U Bug: 1053704 Test: browser_tests Change-Id: I62ce23ac6cafc805e31a153cea4e847b49c3d619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244123Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#779351}
-
Robert Sesek authored
This is a reland of f4240b29 This fixes two issues: - A real UAF in ServiceResolverImplMac::OnResolveComplete, where the callback can delete |this|, so StopResolving() is now called before the callback. - A test-only UAF caused by the background thread outliving the object. The thread is now flushed and joined. The -stop methods for both NetServiceBrowser and NetServiceResolver are now called in their respective -deallocs, in case the Stop posted task does not run. Original change's description: > mac: Simplify the local_discovery ServiceWatcher and ServiceResolver. > > This removes the inner Container classes by moving the logic into the > ObjC classes that already exist. > > Bug: 1072841 > Change-Id: If22d2d90ce3235ce160a0b740337fd71353a7ef7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243995 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778341} Bug: 1072841 Change-Id: Ice53eb92d6c73c75ad6f276b301eaa1841536c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248076Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779350}
-
Ben Pastene authored
All test pools should now have the needed templates. Bug: 812428 Change-Id: Ia40c73ca7760b7be0aa03e5694e14142e502291b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248880Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#779349}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 85-4147.33-1591609549-benchmark-85.0.4163.0-r1 to 85-4147.33-1591609549-benchmark-85.0.4170.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I486c509b35f3b9890da4eab6d47570c77941dd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250118Reviewed-by:
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Drive by, this CL also changes the uses of blink::WebString to WTF::String. BUG=704136 R=guidou@chromium.org Change-Id: I99226ef3efbbf9d85ed3db45df5081e2f23f51ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246928 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#779347}
-
Maksim Ivanov authored
This makes the chrome.test.checkDeepEq() and the chrome.test.assertEq() functions more robust when handling the values of different types, in particular in the following scenarios: chrome.test.checkDeepEq([], {}); chrome.test.checkDeepEq([1], {0: 1}); Before this CL, both of these expressions evaluated to |true|, despite that the values are logically different. The bug was caused by the fact that iterating using a "for" loop may result in the equal key-value pairs for an object and an array, so it's not a sufficient criteria. The proposed fix is to additionally compare the results of the "Array.isArray" check. Also fix the "AppWindowApiTest.Get" test that was (accidentally?) relying on this bug. Bug: 1078761 Change-Id: I00f24a567ba8589e5445313d9b49dd7cf394f1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245913 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Omar Morsi <omorsi@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779346}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I23b0ca3dba58d76657f6acce9d8cd4a21ce505da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248633 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I3708de40ea110f27b8d3ab1e9e63df72cc2dba70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249765 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#779344}
-
Nick Burris authored
This patch makes PaymentAppProvider methods take a WebContents* instead of BrowserContext*. This is a first step toward making WebContents own PaymentAppProviderImpl rather than it being a singleton. The payment_handler_windows_ map is changed to a single payment_handler_window_, but note this is just to remove the BrowserContext* key dependency, we still enforce one payment request per browser via PaymentRequestDisplayManager. PaymentAppProviderImpl's RespondWithCallback and callback repository still depend on BrowserContext*, since the callback may outlive the WebContents. This will be cleaned up in step (3) of the bug, where the callbacks will be owned by PaymentAppProviderImpl instead of a singleton repository. Bug: 1075687 Change-Id: Ib4460b82f9938e973f067f45669a6031f7f0da3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240064Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#779343}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I232b5159e7816b2f2bb640ede69bed7fac7a75da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248630 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#779342}
-
Victor Costan authored
The original code converts the Origin to GURL, then uses net::GetHostOrSpecFromURL(). This is likely the result of mechanical conversions replacing GURLs representing origins with url::Origin. Change-Id: I1fb5e38987b569c88a69bed41450957a33db3f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249387Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779341}
-
Peter Wen authored
Since Googlers may not be able to use ssh in crostini, add a link for an alternate way to set up VS Code remote development on chromebooks. Tbr: minor doc change Bug: None Change-Id: Ie59e888dca4f7d86522584b012af671f8b544b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246859Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779340}
-
Devlin Cronin authored
The latest UX style indicates we shouldn't show a (x) button in modal dialogs. Update the extension settings overridden dialogs to match. Note that the dialog can still be dismissed without a decision by - hitting the escape key (which triggers the "closed" callback) - closing the parent widget Bug: 1079364 Change-Id: I4dea1c41656f76e5951267cfd3c2459ad9e148e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247352Reviewed-by:
-
Maksim Moskvitin authored
This CL removes DirectoryCryptographer and its last usages. Bug: 1083924 Change-Id: I800c9aee00c1f35e81fc177bf835ea76916bd760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228553 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779338}
-
Robert Ma authored
This reverts commit c75217d6. Reason for revert: https://crbug.com/1095643 Broke run_web_tests.py for Windows developers Change-Id: Id7422be7bed874a65cf35da952978f42f0cb76c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248725Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#779337}
-
Mohamed Amir Yosef authored
Bug: 1044038 Change-Id: I48ac13f6ffc6f44f990c5dfd7f3248ab3b614d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248629Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#779336}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Icf68406e5513792097ba9b7ed6da2e7e8b75b080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248576 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#779335}
-
Jonathan Backer authored
Change-Id: Ie4b2ecd7e64a19d17fb84790b844fc96751621a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246545 Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#779334}
-
Sven Zheng authored
Change-Id: I0b6e93ae809189b749d10b35365a52bf40297c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247349 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I0ed5a3c7a64e4fcc3a68a2ec0522d639f1fa4474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249801 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#779332}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Icaa271ea7e32c0494a7b3f578696e397e7cd0a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249675 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#779331}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Id378f4f3ceaabbfeabb83a02779708f5707c4fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248762 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
