- 22 May, 2020 14 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590091165-6474854792ed84c3f97a488e2950f553c812b299.profdata to chrome-mac-master-1590105571-9ab15c0da41a7aac619a0ba03729f850a564de99.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie259f6cb32cc7070f0c1b2940eb019e76f70a7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771273}
-
Ilia Samsonov authored
Adding optional high dpi builder to help triage, and later rebaseline, high dpi blink web tests configuration. Requires https://chromium-review.googlesource.com/c/chromium/tools/build/+/2203463. Bug: 1068400 Change-Id: I6e0f1ab41c133bba312982d3b0e697c4c41f7369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177372 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#771272}
-
Shawn Gallea authored
Only create media_overlay_ if ENABLE_MEDIA_OVERLAY is defined Bug: b/156276792 Test: Build cast_shell Change-Id: I490ab1ff2fe45ef516fa108b8e30389abb052fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212969 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#771271}
-
Kramer Ge authored
Software compositing is not supported on ChromeOS. Thus, GpuProcess_readback_webgl_gpu_process is marked permanently skipped. Bug: 1084796 Change-Id: I0b11acc5fa8ff22ed7df51868aedfc1eda35a6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212549 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771270}
-
Scott Violet authored
This converts kHungRendererDelay to a base::TimeDelta and moves constants that are only used in a single place to where they are used. BUG=none TEST=none Change-Id: Ib163eb931406d252ba696d6f4a974e8ef997608e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209561 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#771269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/942c97d6260f..db1a7975aacc 2020-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic451fe7e9f2da7949a5d978173a7ccf518f5bdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213016Reviewed-by:
-
Henrique Ferreiro authored
This CL moves cursor_factory_ozone.* to ui/base/cursor/cursor_factory.* to serve as a superclass for all platform cursor factories. Bug: 1029142, 1040499 Change-Id: I94370bfe98efd3af4c6596e2de652370d011ea7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188395 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771267}
-
Andrey Kosyakov authored
This is a test for http://crrev.com/c/devtools/devtools-frontend/+/2200666 Bug: 10781354, 1081270 Change-Id: I63a1e77a1ac76184d664b4a29e67ba519c74a4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200430 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#771266}
-
John Lee authored
Change-Id: I5923a4433bcbfd1a9538d533958b49beb1f17aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210910 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#771265}
-
Katie D authored
The DistillerRenderFrameObserver::SetIsDistillerPage was sometimes being called after DistillerRenderFrameObserver::DidCreateScriptContext, which caused the Distiller Javascript object never to be created and injected into the page. SetIsDistillerPage happened via a mojom call from the Browser process when WebContentsObserver::DidFinishNavigation occurred. It wasn't guaranteed to happen in any particular order. This was making a test flaky; relanding the test will happen in a separate change. It is cleaner to simply check if the page is distilled by checking that the URL is correctly formatted as a distilled page. AX-Relnotes: n/a Bug: 1016615, 1075439 Change-Id: I12cb5bb9e2975aca25a79333f251d1a28546f32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209281Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Asanka Herath authored
>> [privacy_budget] Introduce identifiability study settings >> >> The study settings provides gating criteria for filtering reported UKM >> entries. >> >> Bug: 973801 >> Change-Id: I7369965e8476a2d119e7ac4feaa93215534a37f7 >> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036807 >> Commit-Queue: Asanka Herath <asanka@chromium.org> >> Reviewed-by: Caleb Raitto <caraitto@chromium.org> >> Reviewed-by: Nico Weber <thakis@chromium.org> >> Cr-Commit-Position: refs/heads/master@{#769198} > > Reverted-by: Peter Conn <peconn@chromium.org> > Cr-Revert-Position: refs/heads/master@{#769210} > Cr-Revert-Reason: Unlisted dependency Cq-Include-Trybots: luci.chromium.try:android_compile_x64_dbg Change-Id: I56fedbe940150742199c5b94bcaba2cf13c8dae6 Tbr: caraitto@chromium.org, thakis@chromium.org Bug: 973801, 1083161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204137 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771263}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9b28b9695df9..10daf41d4115 2020-05-21 vecore@google.com Fixed IPEndpoint::ToString() so it prints the port and ip 2020-05-21 jophba@chromium.org Update style guide 2020-05-21 jophba@chromium.org Add basic functional tests for the CastAgent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I660e72c230ec455f5be4e3a540cc7c74cdd449f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213012Reviewed-by:
-
Xiaohan Wang authored
kLogJsConsoleMessages feature is used to control whether to log JS console messages, which provides developers a quick way to control whether to log JS messages. For example, some JS code uses a lot of log messages which can be noisy. Currently this feature only take effect on Android where it's disabled by default. This CL change the logic to check this feature on all platforms. On non-Android platforms the feature is enabled by default, which matches the existing behavior. To disable JS console messages in terminal, use --disable-features=LogJsConsoleMessages Change-Id: I0f42e71d63f55369d1d6721c2a1c5eb3b3ef4bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208352Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
-
John Lee authored
Fixed: 1072512 Change-Id: I3db9c6fd55dfc4620aa97dba6471719c6ba2b6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210728 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771260}
-
- 21 May, 2020 26 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a662485bdfb8..cd9e807ee9a7 2020-05-21 treehugger-gerrit@google.com Merge "Use stack_id instead of track_id for experimental_slice_layout_generator" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I68d400bd60c6029d84bee0d30d3674f85bc0c1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213009Reviewed-by:
-
Peter Kasting authored
Not only is this shorter, it fixes a bug where operator=() failed to copy one of the members. Bug: none Change-Id: I778a093ac7e31e38319421b76a5c174cd8b7d5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213023 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Peng Huang authored
This reverts commit aaa46efe. Reason for revert: the problem is fixed with https://crrev.com/c/2212811. This workaround is not necessary anymore. Original change's description: > skiarenderer: fixing flickering with skia renderer on Android > > The problem is because a recent CL https://crrev.com/c/2149640 which > implements ProduceOverlay() but doesn't provide gpu fence for the > overlay access. Workaround the problem by creating a gpu fence for the > primary plane in SkiaOutputDeviceBufferQueue when GL is used. > > Bug: 1082519,1085485 > Change-Id: I86431c866d94ee2f1e29a939aed11f6dab6a57b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212548 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771155} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: Ifa80a1fa5f89d69a9ffd9a3fb15b2e0820612535 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082519, 1085485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213104Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771257}
-
Jun Kokatsu authored
addHistograms can be called from either page load or refresh button. This change fixes a bug where refresh button would append new content instead of replacing them. Bug: 1084234 Change-Id: Ibf041f1c6c85535c88fae34bbb9ef75cdc44660e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207957Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to production logic. This disables a flaky WebsitePermissionsFetcherTest test case. TBR=finnur@chromium.org Bug: 1085592 Test: None Change-Id: Ide2fbb82f52aa6fcd77e2367f49ee8bdfc0d5547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212970Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771255}
-
Abigail Klein authored
The caption bubble controller receives a stream of transcriptions from the speech service to be set in the caption bubble. For long sessions, this text could be very long, which would slow down the rendering of the text in the caption bubble label. This CL removes characters from that string. We don't want to remove some arbitrary N characters, because then the user will be able to see the string re-wrap. We want to remove characters up to a line break. Suppose CaptionBubbleControllerViews::OnTranscription receives the string abcdefghijklmnopqrstuvwxyz. And suppose the caption bubble only shows 9 letters per line. The layout manager ensures that only the last two lines (starting at q) are visible. abcdefgh ijklmnop qrstuvwx yz In order for the user to not notice any line wrapping, we need to remove the characters a-p (index 0-17). To get the right number of characters, CaptionBubbleControllerViews gets the location of the line breaks from RenderText and cuts the stored text string up to the index where there is a line break that is not visible to the user. Bug: 1055150 Change-Id: Ifb59f5bcba39d0ce3de097a9f86bfbb11cbf16db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187137 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#771254}
-
Wenyu Fu authored
Bug: 1084756 Change-Id: Ife7f51c22c666d3bf087dba02706718177dc5c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212926 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#771253}
-
Ben Pastene authored
Moves all OOBE-related tests into another execution of browser_tests, and marks it experimental. Bug: 1071693 Change-Id: Ic790aa28c99486140195605ebad0956a14a0f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209557 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771252}
-
Chong Gu authored
Help debug issues specific to AEMU. Bug: 1084693 Change-Id: I106a1f03d9f81a183deb6c33afbc1abea51671a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212467Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#771251}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e5d042ae732b..5598ba3c0e6f 2020-05-21 mthiesse@chromium.org Bring back mkdir call in PushChangedFiles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1076580 Tbr: skyostil@google.com Change-Id: Ic07b9510f9f350ea379df78af99c7deae4064994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212723Reviewed-by:
-
David Bokan authored
This CL implements the compositor-thread<->main-thread routing and flow for cases that need to be main thread hit tested under scroll unification. Scroll unification is a project to remove all gesture scroll handling from Blink and rely solely on the compositor gesture handler. Design doc: https://docs.google.com/document/d/1smLAXs-DSLLmkEt4FIPP7PVglJXOcwRc7A5G0SEwxaY/edit Today, some scrollers cannot be scrolled on the compositor thread. There's a few primary reasons why this can happen: - The scroller is not backed by a cc::Layer so we can't hit test it. - Unreliable hit test in the presence of squashing layers - The scroller has a main thread scrolling reason. It has a cc::Layer and we can hit test it but, because of style reasons, scrolling it from the compositor would produce incorrect results. Under scroll unification, if the compositor can determine the correct ScrollNode to use, it can perform these kinds scrolls by mutating just the scroll node, then wait on a BeginMainFrame and commit to repaint the layers and update the property trees, just like today's main thread scrolling but without invoking the input handling code paths in Blink. In https://crrev.com/c/2089973 we made it so that the entire scroll tree is passed to the compositor. Thus, the first two cases above can be addressed by asking the main thread for the element_id of the ScrollNode to use. This CL implements the plumbing for this functionality. Background: When a gesture scroll begin (GSB) arrives, it first hits the WidgetInputHandlerManager. This will first dispatch to the compositor by passing it to InputHandlerProxy. In turn, InputHandlerProxy calls LayerTreeHostImpl::ScrollBegin. If LTHI determines it cannot handle the scroll, IHP returns into WIHM (via callback) which can queue events to the MainThreadEventQueue bound for Blink: DID_NOT_HANDLE v----------<---------+ | | GSB+-------------------v-------+ + -->+ WidgetInputHandlerManager +-->InputHandlerProxy<->LayerTreeHostImpl +---------------------------+ GSB | v +-------------+-------------+ | BLINK | +---------------------------+ Today, if the IHP returns event disposition DID_NOT_HANDLE to indicate that the compositor didn't consume the event, WIHM will forward the event and further events in the same sequence to Blink. The compositor will not be involved in handling these events. Changes in this CL: In this CL, we add a new compositor event disposition REQUIRES_MAIN_THREAD_HIT_TEST. This indicates to WidgetInputHandlerManager that the compositor can handle the scroll but it cannot resolve the ScrollNode and requests that the WIHM provide the element_id of the scroller at the event's position. Conceptually, a scroll has started as far as IHP is concerned; however, while we're waiting on the WIHM to provide an element_id, the compositor thread event queue is blocked. This ensures any incoming scrolls are queued and coalesced until the scrolling can truly begin. Note: Only gestures like Scroll and Pinch are processed in the queue; other events will be dispatched directly to the compositor as usual. When WIHM receives a REQUIRES_MAIN_THREAD_HIT_TEST disposition, it will post a task to Blink. However, unlike DID_NOT_HANDLE, the event isn't passed to Blink, WIHM will keep it and redispatch it to IHP when Blink replies. When Blink responds, WIHM passes the original event, as well as the Blink-provided element_id back to IHP. This once again calls LTHI::ScrollBegin, this time providing a ScrollNode element id so that hit testing isn't required. The queue is now unblocked and flushed. Subsequent scroll update events will be routed to the LTHI as if we are in a traditional compositor scroll: REQUEST_MAIN_THREAD_HIT_TEST v---------<---------+ | | GSB +-------------------v------+ + --->+ WidgetInputHandlerManager+-->InputHandlerProxy<->LayerTreeHostImpl +----+---+-----------------+ ^ | ^ | HitTest | +---------------------->InputHandlerProxy:: | | | ContinueScrollBegin+-----+ | | element_id +-----v---+-------+ | BLINK | +-----------------+ This CL doesn't yet implement the logic in LayerTreeHostImpl to return a REQUEST_MAIN_THREAD_HIT_TEST, hence this path isn't yet "live". Instead we leave some TODOs for a follow up CL. Bug: 1047182 Change-Id: I68a0ec3dddc23c7344ddbfc334f1e25618e43404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199610 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771249}
-
Khushal Sagar authored
Images that need to support scanout on Android require explicit fence synchronization which is not support by the GL backing. Ideally it shouldn't have to be because scanout should use the AHB backing which already has support for this. R=penghuang@chromium.org Bug: 1085485,1082519 Change-Id: Ib6bdd9f46ca31a81e764c9bd46693a6b5e302f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212811 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
wutao authored
The bug has been fixed. Clean up the comment. Bug: b/148818448 Test: pass current tests Change-Id: I460da30ca2d70d8af7e3d1c0efb4ac19415e8217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212933Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771247}
-
chrome://newtabTibor Goldschwendt authored
This is a reland of 142274a8 with a fix for DiceBrowserTest.EnableSyncAfterToken. Original change's info: > Bug: 1015293 > Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771116} TBR=thestig@chromium.org Bug: 1015293, 1085540 Change-Id: I05450e311b9458b6927763cbf6b4c75c0621b56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212818Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771246}
-
Xing Liu authored
FakeTileService now post the callbacks. and invoke the callback for StartFetchForTiles(). TBR=orinj@chromium.org Bug: 1077913 Change-Id: I8d06ca1bee02e513ccf2a2cf1838b01004bdb81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198638 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#771245}
-
Greg Thompson authored
BUG=108176 TBR=fdoray@chromium.org, nicolaso@chromium.org Change-Id: I076fa8233729c8006c1963492ccf3a3bce36a78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212046Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#771244}
-
Nathan Zabriskie authored
This reverts commit 6f601682. Reason for revert: The CL that caused these tests to fail has been reverted. Reenabling these tests to confirm issue is resolved. Link to other revert: crrev.com/c/2212560 Original change's description: > Disable flaky PaintCanvasVideoRendererTest tests > > No change to production logic. This disables flaky tests. > > TBR=dalecurtis@chromium.org > > Bug: 1085516 > Test: None > Change-Id: I1eb617e7ca8dcb1edce3ebffdb2fa17bb566a650 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212754 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771175} TBR=dalecurtis@chromium.org,ntfschr@chromium.org Change-Id: I07e8cb64f3c92f113837c476b7ffc2122c4eba45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212994 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771243}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f601682. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" fc4093a6 "Move mouse-pointer-preventdefault.html to wpt" 617dfcdd "[ScrollTimeline] Run tests on cc if threaded compositing is enabled" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7bbfe715650a6928456d6305f8175109297cdb9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212302Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771242}
-
Matthew Mourgos authored
Bug: 1085286 Change-Id: Idc4ca14e4373988461995a6a00713bf6226e9346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212757 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#771241}
-
Nathan Zabriskie authored
This reverts commit eeb9431b. Reason for revert: This CL seems to have caused flakiness in some PaintCanvasVideoRendererWithGLTests. Reverting to investigate before attempting to reland the change. TBR=khushalsagar@chromium.org Original change's description: > Move CPU VideoFrame YUV Uploading code into yuv_util > > This patch unifies CPU VideoFrame uploading/conversion code for OOPR > and GPU rasterization. Now clients can call ConvertFromVideoFrameYUV > with CPU backed VideoFrames in addition to wrapped frames. > > Bug: 1058992 > Change-Id: I89c37179b12fe1375fa7a6f7d919f135f77b5857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200084 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770729} TBR=kbr@chromium.org,sandersd@chromium.org,khushalsagar@chromium.org,nazabris@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058992, 1085516 Change-Id: I74ad2b483b89eaf729ee279bd7438243e2bb52a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212560 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#771240}
-
Steven Bingler authored
Correct the histogram names for the schemeful same-site context downgrade UMAs by adding "Cookie." Bug: 1085517 Change-Id: Id3f46ad118a24e37123bb95c7876ab464f550fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212842Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#771239}
-
shrekshao authored
Implement OES_draw_buffers_indexed WebGL extension for Angle Passthrough. Not implemented for the validating command decoder. Corresponding WebGL CTS is already rolled in. Bug: 1058744 Change-Id: I69ffef0065b5b5789dce78fb92b249d5dd79d0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173593Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52e9a761fba0..456c48d718c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC avi@google.com,ramyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: avi@google.com,ramyan@google.com Change-Id: Ifadd8c215bd45faa874da59449a4b3cd997185a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211845Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771237}
-
Xinghui Lu authored
This reverts commit 596bbbfe. Reason for revert: Check failed: checker.CalledOnValidSequence() during destruction. TBR=drubery@chromium.org Original change's description: > Move ChromePasswordProtectionService to be a KeyedService. > > Bug: 1058431 > Change-Id: Id831530b726e63cfcba71dbcb86af8bf00e11dd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198536 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769913} TBR=drubery@chromium.org,xinghuilu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058431,1085536 Change-Id: I1047ec0f415a4504d13edb52f8809d6c946073a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212817 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771236}
-
Tommy Steimel authored
This CL changes Kaleidoscope to remove the KaleidscopeContentUI WebUI and instead use a chrome-untrusted:// frame. This allows us to remove the network requests exemption. We also move the remaining Kaleidscope WebUI URL constants into the kaleidoscope internal repo. Bug: 1039904 Change-Id: Ia99e1a6914d47ea129d4fbbb9050a511c9232ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145674 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Justin Miron authored
Changing the coordinate system of the main frame document lead to inaccurate intersection observation due to errors in the transformation code. Reverting back to main frame document system to expedite the fix as changing the coordinate system to correctly performan transformations with OOPIF is more involved. This change also disables UKM recording for ad density as main frame document intersections are not accurate. BUG=1084786 Change-Id: I758f9d3d3a639193cdfd7cac4c379d5571074bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211280Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#771234}
-
