GitLab

This CL implements the compositor-thread<->main-thread routing and flow
for cases that need to be main thread hit tested under scroll
unification. Scroll unification is a project to remove all gesture
scroll handling from Blink and rely solely on the compositor gesture
handler.

Design doc: https://docs.google.com/document/d/1smLAXs-DSLLmkEt4FIPP7PVglJXOcwRc7A5G0SEwxaY/edit

Today, some scrollers cannot be scrolled on the compositor thread.
There's a few primary reasons why this can happen:

  - The scroller is not backed by a cc::Layer so we can't hit test it.
  - Unreliable hit test in the presence of squashing layers
  - The scroller has a main thread scrolling reason. It has a cc::Layer
    and we can hit test it but, because of style reasons, scrolling it
    from the compositor would produce incorrect results.

Under scroll unification, if the compositor can determine the correct
ScrollNode to use, it can perform these kinds scrolls by mutating just
the scroll node, then wait on a BeginMainFrame and commit to repaint the
layers and update the property trees, just like today's main thread
scrolling but without invoking the input handling code paths in Blink.

In https://crrev.com/c/2089973 we made it so that the entire scroll tree
is passed to the compositor. Thus, the first two cases above can be
addressed by asking the main thread for the element_id of the ScrollNode
to use. This CL implements the plumbing for this functionality.

Background:

When a gesture scroll begin (GSB) arrives, it first hits the
WidgetInputHandlerManager. This will first dispatch to the compositor by
passing it to InputHandlerProxy. In turn, InputHandlerProxy calls
LayerTreeHostImpl::ScrollBegin. If LTHI determines it cannot handle the
scroll, IHP returns into WIHM (via callback) which can queue events to
the MainThreadEventQueue bound for Blink:

                           DID_NOT_HANDLE
                       v----------<---------+
                       |                    |
GSB+-------------------v-------+            +
-->+ WidgetInputHandlerManager +-->InputHandlerProxy<->LayerTreeHostImpl
   +---------------------------+
            GSB  |
                 v
   +-------------+-------------+
   |           BLINK           |
   +---------------------------+

Today, if the IHP returns event disposition DID_NOT_HANDLE to indicate
that the compositor didn't consume the event, WIHM will forward the
event and further events in the same sequence to Blink. The compositor
will not be involved in handling these events.

Changes in this CL:

In this CL, we add a new compositor event disposition
REQUIRES_MAIN_THREAD_HIT_TEST. This indicates to
WidgetInputHandlerManager that the compositor can handle the scroll but
it cannot resolve the ScrollNode and requests that the WIHM provide the
element_id of the scroller at the event's position. Conceptually, a
scroll has started as far as IHP is concerned; however, while we're
waiting on the WIHM to provide an element_id, the compositor thread
event queue is blocked. This ensures any incoming scrolls are queued and
coalesced until the scrolling can truly begin. Note: Only gestures like
Scroll and Pinch are processed in the queue; other events will be
dispatched directly to the compositor as usual.

When WIHM receives a REQUIRES_MAIN_THREAD_HIT_TEST disposition, it will
post a task to Blink. However, unlike DID_NOT_HANDLE, the event isn't
passed to Blink, WIHM will keep it and redispatch it to IHP when Blink
replies.

When Blink responds, WIHM passes the original event, as well as the
Blink-provided element_id back to IHP. This once again calls
LTHI::ScrollBegin, this time providing a ScrollNode element id so that
hit testing isn't required. The queue is now unblocked and flushed.
Subsequent scroll update events will be routed to the LTHI as if we are
in a traditional compositor scroll:

                      REQUEST_MAIN_THREAD_HIT_TEST
                        v---------<---------+
                        |                   |
GSB +-------------------v------+            +
--->+ WidgetInputHandlerManager+-->InputHandlerProxy<->LayerTreeHostImpl
    +----+---+-----------------+                              ^
         |   ^                                                |
 HitTest |   +---------------------->InputHandlerProxy::      |
         |   |                       ContinueScrollBegin+-----+
         |   | element_id
   +-----v---+-------+
   |     BLINK       |
   +-----------------+

This CL doesn't yet implement the logic in LayerTreeHostImpl to return a
REQUEST_MAIN_THREAD_HIT_TEST, hence this path isn't yet "live". Instead
we leave some TODOs for a follow up CL.

Bug: 1047182
Change-Id: I68a0ec3dddc23c7344ddbfc334f1e25618e43404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199610
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771249}

Images that need to support scanout on Android require explicit fence
synchronization which is not support by the GL backing. Ideally it
shouldn't have to be because scanout should use the AHB backing which
already has support for this.

R=penghuang@chromium.org

Bug: 1085485,1082519
Change-Id: Ib6bdd9f46ca31a81e764c9bd46693a6b5e302f5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212811
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771248}

The bug has been fixed. Clean up the comment.

Bug: b/148818448
Test: pass current tests
Change-Id: I460da30ca2d70d8af7e3d1c0efb4ac19415e8217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212933Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771247}

This is a reland of 142274a8 with a fix
for DiceBrowserTest.EnableSyncAfterToken. Original change's info:
> Bug: 1015293
> Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771116}

TBR=thestig@chromium.org

Bug: 1015293, 1085540
Change-Id: I05450e311b9458b6927763cbf6b4c75c0621b56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212818Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771246}

FakeTileService now post the callbacks. and invoke the callback for
StartFetchForTiles().

TBR=orinj@chromium.org

Bug: 1077913
Change-Id: I8d06ca1bee02e513ccf2a2cf1838b01004bdb81a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198638
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771245}

BUG=108176
TBR=fdoray@chromium.org, nicolaso@chromium.org

Change-Id: I076fa8233729c8006c1963492ccf3a3bce36a78b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212046Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771244}

This reverts commit 6f601682.

Reason for revert: The CL that caused these tests to fail has been
reverted. Reenabling these tests to confirm issue is resolved. Link
to other revert: crrev.com/c/2212560

Original change's description:
> Disable flaky PaintCanvasVideoRendererTest tests
>
> No change to production logic. This disables flaky tests.
>
> TBR=dalecurtis@chromium.org
>
> Bug: 1085516
> Test: None
> Change-Id: I1eb617e7ca8dcb1edce3ebffdb2fa17bb566a650
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212754
> Reviewed-by: Nate Fischer <ntfschr@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Nate Fischer <ntfschr@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771175}

TBR=dalecurtis@chromium.org,ntfschr@chromium.org

Change-Id: I07e8cb64f3c92f113837c476b7ffc2122c4eba45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1085516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212994
Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
Reviewed-by: Nathan Zabriskie <nazabris@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#771243}

Using wpt-import in Chromium 6f601682.
With Chromium commits locally applied on WPT:
f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html"
45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent"
fc4093a6 "Move mouse-pointer-preventdefault.html to wpt"
617dfcdd "[ScrollTimeline] Run tests on cc if threaded compositing is enabled"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I7bbfe715650a6928456d6305f8175109297cdb9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212302Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771242}

Bug: 1085286
Change-Id: Idc4ca14e4373988461995a6a00713bf6226e9346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212757
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771241}

This reverts commit eeb9431b.

Reason for revert: This CL seems to have caused flakiness in some PaintCanvasVideoRendererWithGLTests. Reverting to investigate before attempting to reland the change.

TBR=khushalsagar@chromium.org

Original change's description:
> Move CPU VideoFrame YUV Uploading code into yuv_util
>
> This patch unifies CPU VideoFrame uploading/conversion code for OOPR
> and GPU rasterization. Now clients can call ConvertFromVideoFrameYUV
> with CPU backed VideoFrames in addition to wrapped frames.
>
> Bug: 1058992
> Change-Id: I89c37179b12fe1375fa7a6f7d919f135f77b5857
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200084
> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770729}

TBR=kbr@chromium.org,sandersd@chromium.org,khushalsagar@chromium.org,nazabris@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1058992, 1085516
Change-Id: I74ad2b483b89eaf729ee279bd7438243e2bb52a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212560
Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com>
Reviewed-by: Nathan Zabriskie <nazabris@microsoft.com>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771240}

Correct the histogram names for the schemeful same-site context
downgrade UMAs by adding "Cookie."

Bug: 1085517
Change-Id: Id3f46ad118a24e37123bb95c7876ab464f550fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212842Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771239}

Implement OES_draw_buffers_indexed WebGL extension for Angle Passthrough.
Not implemented for the validating command decoder.

Corresponding WebGL CTS is already rolled in.

Bug: 1058744
Change-Id: I69ffef0065b5b5789dce78fb92b249d5dd79d0a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173593Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#771238}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52e9a761fba0..456c48d718c1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC avi@google.com,ramyan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024586
Tbr: avi@google.com,ramyan@google.com
Change-Id: Ifadd8c215bd45faa874da59449a4b3cd997185a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211845Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771237}

This reverts commit 596bbbfe.

Reason for revert: Check failed: checker.CalledOnValidSequence() during destruction.

TBR=drubery@chromium.org

Original change's description:
> Move ChromePasswordProtectionService to be a KeyedService.
>
> Bug: 1058431
> Change-Id: Id831530b726e63cfcba71dbcb86af8bf00e11dd0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198536
> Reviewed-by: Daniel Rubery <drubery@chromium.org>
> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#769913}

TBR=drubery@chromium.org,xinghuilu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1058431,1085536
Change-Id: I1047ec0f415a4504d13edb52f8809d6c946073a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212817
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771236}

This CL changes Kaleidoscope to remove the KaleidscopeContentUI WebUI
and instead use a chrome-untrusted:// frame. This allows us to remove
the network requests exemption. We also move the remaining Kaleidscope
WebUI URL constants into the kaleidoscope internal repo.

Bug: 1039904
Change-Id: Ia99e1a6914d47ea129d4fbbb9050a511c9232ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145674
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771235}

Changing the coordinate system of the main frame document lead to
inaccurate intersection observation due to errors in the transformation
code.

Reverting back to main frame document system to expedite the fix as
changing the coordinate system to correctly performan transformations
with OOPIF is more involved.

This change also disables UKM recording for ad density as main frame
document intersections are not accurate.

BUG=1084786

Change-Id: I758f9d3d3a639193cdfd7cac4c379d5571074bcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211280Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#771234}

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ib2821bb00948dbbb84f037a33f9ac452d6bcb964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208783Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771233}

No behavior change. This CL reduces potential risks of use-after-free
bugs. This CL is followup CL. FileSystemDispatcher was already
migrated before, but there were remaining mojo objects.

Bug: 1049056
Change-Id: Ib9933ee186ecca6d5cc73bf70a6d9a5ee429c010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211564Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771232}

This CL removes metrics Download.Service.Clients.InflatedFullBrowser*.

We have seen the behavior from this metrics that reduced mode to full
browser mode transition can happen in rare case.

Bug: 1072515
Change-Id: I9af5129222ec82ef4bba013f4ecc6801b9d03b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207777Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771231}

The test fails on Nexus 5 with SkiaRenderer enabled. When fixing the
tags, so running with SkiaRenderer had the skia-renderer tag, this test
started failing again because the suppression had no-skia-renderer as
the tag. The test fails both with and without SkiaRenderer enabled so
remove the tag.

Bug: 1069551
Change-Id: I9e2016d01c800fe6ba41673648c32fe0095a9eda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212456
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771230}

Previously, the page height was set -webkit-fill-available, which we
found behaves like 100% on some and like fit-content on other machines.
The logic for determining visibility of the scroll borders expects the
page height to encompass the children, which is the default
behavior for block elements. Thus, we remove the height style.

Bug: 1085280
Change-Id: I4f8db68647d315ca256049664c6248326ec039ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212961
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771229}

This CL also adds the system notification warning level as a field in
Notification.

BUG=1073726

Change-Id: I7e432f362fc6269e3fe06c671bfca0588850f539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200630
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771228}

Enum label for compositor only frame of CompositorLatency.Type is added.

The enum was updated in the change below but the label was not updated.
https://chromium-review.googlesource.com/c/chromium/src/+/2155009

TBR=schenney@chromium.org

Bug: none
Change-Id: I16ce30ac5b5f23eb20afea390df088cb6694135e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212787Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771227}

MB configs for the beta/stable trybots for PGO.

Bug: 1081356
Change-Id: I7e517bdbe36aa926053e3beb5f92289f586dacc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212559
Auto-Submit: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771226}

When hidden networks are first configured, they don't have a matching
NetworkState for the newly generated guid, but we still need to record
which user is the owner.  When retrieving the prefs, now check the
default profile for metadata about the guid if none exists on the user
profile, there are a few reasons this could happen now.

Bug: 966270
Change-Id: Id6368fce766907384aa4f41c1f03d458a2113a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211743
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771225}

For most unit tests, they can use Widget's new API which takes a
unique_ptr instead of a raw pointer. Therefore, the ownership of that
View is clearer.

This CL also change a few non-test cases that are straightforward to use
the new API.

BUG=none

Change-Id: I51b5fb6e767831cfc346cd6f0afc3446210246e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208258Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771224}

Roll Chrome Win32 PGO profile from chrome-win32-master-1590076755-e9de4b57569c4058e940202038caaf51f7563125.profdata to chrome-win32-master-1590091165-57e2eb3ac957bb561cdabd6b908ea2826fe03189.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Icd5fc93ce26332786bf647d7b4118f829affa842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213007Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771223}

Bug: 1081350
Change-Id: I2b1824abefbd7fc3e8ce1c0cb433896161bab4e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211123Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771222}

Bug: 1084931
Change-Id: I4c1c31698b7877d3fa8d71765768f8a0b11d1282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212804Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771221}

Bug: 1081250
Change-Id: Id0924545fbdb1eb28ae3c8fe015559fd3e9c53d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191785
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771220}

We will soon be using `acorn.mjs`, which would previously throw errors
when loading, as `type="module"` enforces strict MIMEtype checking.

Bug: 1011811
Change-Id: I1eaea02f94ebf74ee8fc32678cf29dde86c25b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212124
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771219}

Roll Chrome Win64 PGO profile from chrome-win64-master-1589976000-30e90b5636af5c2bba45569eb90bae781c77ad14.profdata to chrome-win64-master-1590091165-7a7a14d98fbe05f411f7ca7cd83845ea7366876a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I271e611109de452279443db9a176f9e89d3ce0d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213008Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771218}

This CL adds U+0A5C as a lookalike character to the digit 3.  This
change appears to impact no domains seen in UKM.

Fixed: 1085315
Change-Id: Iea9930363d853f154e2d781646a1b0b5da7fbbfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212807
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771217}

This includes 3 fixes determined from turning on amp carousel page
translation:
  1. Only try to translate subframes that are visible.
  2. Adds retry count to CheckTranslateStatus (to break rare loop).
  3. Fixes overall translate error code to the one for the main frame.

Note that these changes are in classes only used with Feature flag so
no risk to mainline regressions.

Bug: 1084262
Change-Id: I03541b9ab78813b2ace55e9b5e0379a8e952f8d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211042
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771216}

Bug: b/157229763
Test: new js test
Change-Id: I759e303d43bef8ee620c51960524f26c7510f0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212664
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771215}

Due to the introduction of ImageFetcher.Params, some old APIs can be
deleted. All plumbing for fetchImage() should use the Params now.

Bug: 1076515
Change-Id: I5c4cbda79c882a0b763fcad86b84625366c20018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192379Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Luca Hunkeler <hluca@google.com>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771214}

Change-Id: If8f9a3498573cfd17e21dc8d0819a06c58579dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208099
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771213}

WindowAndroid needs to be explicitly destroyed. Caught this while trying
to add LifetimeAssert to WindowAndroid to enforce this.

Bug: 1081250
Change-Id: I2e888b8875f856946abb83fb91fd32d60845304b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212793Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771212}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6f723ebbe3b0..2cf9621d6d6f

2020-05-21 dneto@google.com Reorder member init to match decl order (#2241)
2020-05-21 40001162+alelenv@users.noreply.github.com Add support for primitive culling layout qualifier. (#2220)
2020-05-21 rharrison@google.com Replace incorrect uint32_t with correct int vars (#2235)
2020-05-21 shuizhuyuanluo@126.com Do not build glslang-testsuite when ENABLE_CTEST is disabled (#2240)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com
Change-Id: I4b5d3dfae32bd796af4a6612eafd3b9bf14225d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212358Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771211}

EnumerateSharedWorkers() is meant to allow an observer to
"catch up" to the notifications it missed by registering late.
This must include the OnFinalResponseURLDetermined() call.

Bug: 993029
Change-Id: Ib23b269b825c878682bb920651c999bd169f09a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204519
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771210}