- 31 Jan, 2018 40 commits
-
-
James Cook authored
Disable it in viz_browser_tests via filter file so we can get the Mojo FYI bot green. it's been failing for > 1 week and > 200 builds. Bug: 807465 Change-Id: I4f067303cc74d607d519fd7f72b20d5b75d92c28 Reviewed-on: https://chromium-review.googlesource.com/894634Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533272}
-
Vadym Doroshenko authored
Atm in case when Password Manager tries to fill a password form and encounters inputs with the same names it stops processing such form. This CL implements that the first field will be filled. Bug: 803215 Change-Id: Ia1ec0f1de8390c59308e8c70cbaebe285ae7431d Reviewed-on: https://chromium-review.googlesource.com/886707 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533271}
-
Nicolas Dossou-gbete authored
Additionally to scaning the first level of third_party for README.chromium files, these directories can now contain an additional_readme_paths.json file that lists subdirectories that will contain the actual third_party dependencies to take into account for credits generation. Bug: 794210 Change-Id: If6eef9fcd615bd96b9a260f9ae4d0c0c4fd6405a Reviewed-on: https://chromium-review.googlesource.com/822612 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533270}
-
Nico Weber authored
* make gperf.py call generate_gperf() both when it's invoked via use_jinja_gperf_template() as well as when it's called directly as a standalone script * make generate_gperf() do massaging of gperf's output to remove uses of the `register` keyword (needed to build with -std=c++17) and replace `/*FALLTHROUGH*/` with real FALLTHROUGH statements (needed for -Wimplicit-fallthrough) * remove now-unneeded suppressions for -Wdeprecated-register * remove TODO about removing gperf.py; that's from a time when the script was 1 non-comment line long * bump check_output() requirement in comment to 3.4 (since that added the input= parameter) * add missing dependency on gperf.py to build steps calling it through the jinja interface, so that these edges rerun when gperf.py gets modified * add a comment mentioning gperf.py at the start of the generated outputs * make :character_data not call gperf.py since it doesn't use gperf, and make it use compiled_action() instead which is made for exactly character_data's use case No intended behavior change. Bug: 752720,177475 Change-Id: I56372729bb47787e2d41a5dff2f30804574770f0 Reviewed-on: https://chromium-review.googlesource.com/891141 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#533269}
-
Mugdha Lakhani authored
Bug: 799483 Change-Id: Id180ebd58acefa8f047858101c586b940b435e70 Reviewed-on: https://chromium-review.googlesource.com/887083 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#533268}
-
Elly Fong-Jones authored
This change introduces a new command line flag, --polychrome, which causes a mac_views_browser build to use the existing Cocoa UI instead of the new Views browser UI. This involves: 1) Linking all of the Cocoa UI in when building the Views browser; 2) Resolving symbol and filename conflicts; 3) Introducing views_mode_controller::IsViewsBrowserCocoa(); 4) Having BrowserWindowFactory choose which type of BrowserWindow to create based on the value of views_mode_controller::IsViewsBrowserCocoa() This change also makes unit_tests build, but not any other targets - it is likely that browser_tests does not build. The resulting mac_views_browser *runs* but is unstable because of bug 804950, which is hard to address without this CL being landed. The current name is deliberately a bit silly, under the theory that we'll pick a better one once the approach solidifies :) Bug: 802257,804950 Change-Id: I30aaef7ed08dd11b66d59d5b816f57641bf2f209 Reviewed-on: https://chromium-review.googlesource.com/874730 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533267}
-
Maxim Kolosovskiy authored
In https://chromium-review.googlesource.com/c/chromium/src/+/725342, enum.xm wasn't updated properly. It should corresponds to |ShowAllSavedPasswordsContext| Bug: 739343, 775825 Change-Id: I0129522e95414412aeb6f271d0aa07cc236801cf Reviewed-on: https://chromium-review.googlesource.com/893560Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#533266}
-
https://webrtc.googlesource.com/src.git/+log/70294c8eab2f..3c706972bad7 $ git log 70294c8ea..3c706972b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib690a34c8ca7172f14fc7f1917f61c242c05c948 Reviewed-on: https://chromium-review.googlesource.com/894711 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533265}
-
Christos Froussios authored
I also changed the timing on the IN_PROGRESS update to occur as soon as the destination is known. If we happen to still be serialising, that is an implementation detail that should not be affect the UI. Bug: 785237 Change-Id: Ie9466840b1e4bf11ddfaa4c69045326ab3b11fe3 Reviewed-on: https://chromium-review.googlesource.com/789330 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533264}
-
Bence Béky authored
Add unittest to document existing Websocket behavior with existing HTTP/2 connection: if there is an HTTP/2 connection open to a server, a Websocket request should not use it, but instead open a new connection with HTTP/2 disabled. Bug: 801564 Change-Id: Ibff7278cb298491f8183ca0946acfef39c7e8309 Reviewed-on: https://chromium-review.googlesource.com/891738 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#533263}
-
Naina Raisinghani authored
Revert "Replace CSSPropertyValueSet in @font-face related objects with a new AtRuleDescriptorValueSet." This reverts commit 4e4f284d. Revert "Fix segfault in AtRuleCSSStyleDeclaration::getPropertyValue" This reverts commit 32c5f6b3. Bug: 807229 Change-Id: I5c92de4734440709c60b383c485967795e9643b2 Reviewed-on: https://chromium-review.googlesource.com/895225 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#533262}
-
Boris Sazonov authored
This CL removes context parameter from SigninManager instance getter. It also removes context parameter from FirstRunSignInProcessor.updateSigninManagerFirstRunCheckDone, as it becomes unused. Bug: None Change-Id: I49aebc25becfce676a3eba1e15d7c4451c0ba36c Reviewed-on: https://chromium-review.googlesource.com/883806Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70bfb939..13ef7708 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I05fe99a062e02526d70c4511ce26e7ec0fad3756 Reviewed-on: https://chromium-review.googlesource.com/895562Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533260}
-
Henrik Grunell authored
That is, after input stream creation. It will be removed from the underlying WebRTC component shortly. Bug: webrtc:8346 Change-Id: Ib80b27b4580b737bcfec7f80acc9207ddafab419 Reviewed-on: https://chromium-review.googlesource.com/888703Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533259}
-
Eric Willigers authored
Test that perspective-origin supports the <position> grammar https://drafts.csswg.org/css-transforms-2/#perspective-origin-property https://drafts.csswg.org/css-values-4/#typedef-position and not the additional forms allowed by the <bg-position> grammar https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position Blink has deprecated <bg-position> support in perspective-origin (and other contexts other than background-position), so the expected failures are while we wait for removal in M68. BUG=804187 Change-Id: I9e93af5a5af0975fca82aadd4485c601c439969f Reviewed-on: https://chromium-review.googlesource.com/895222 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533258}
-
Roman Sorokin authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/55af1ecf9588..03017732129d $ git log 55af1ecf9..030177321 --date=short --no-merges --format='%ad %ae %s' 2018-01-25 ljusten authpolicy: Add domain join errors 2018-01-23 allenvic smbprovider: Add WriteFile protobuf 2017-12-19 igorcov system_api: D-Bus constant for TpmAttestationGetEnrollmentId 2018-01-24 ljusten Remove deprecated AuthPolicy D-Bus method names 2018-01-21 ljusten authpolicy: Add ERROR_NO_WINDOWS_POLICY Created with: roll-dep src/third_party/cros_system_api BUG=chromium:805908 Change-Id: I87859bf3e03d9c3668d731041317b31379a7a1e0 Reviewed-on: https://chromium-review.googlesource.com/893271Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533257}
-
https://chromium.googlesource.com/catapult.git/+log/7c98d04db58b..12ffa8933991 $ git log 7c98d04db..12ffa8933 --date=short --no-merges --format='%ad %ae %s' 2018-01-31 perezju [Devil] Dismiss errors in GetRecursiveDiskUsage 2018-01-25 perezju [Telemetry] Move profile setup on desktop to its possible browser Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I349d5d5c652ff38030b5ad74c49ad136e791b421 Reviewed-on: https://chromium-review.googlesource.com/895406 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533256}
-
François Beaufort authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I042e565d27078e50ae6ac3ce01726452df3a9e2d Reviewed-on: https://chromium-review.googlesource.com/886943 Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#533255}
-
tzik authored
This CL contains: - Convert MIDIOutput::pending_data_ to contain DOMUint8Array instead of Vector, so that we don't need an extra copy on the lazy open case. - Take care null or non-Document ExecutionContext. - Misc clean up. Change-Id: I33862de0aa39ddd68dc9ee5e4a594caf1e8f7437 Reviewed-on: https://chromium-review.googlesource.com/895129 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#533254}
-
https://webrtc.googlesource.com/src.git/+log/1a2f20748581..70294c8eab2f $ git log 1a2f20748..70294c8ea --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5c97ecb038fdb960da05336e576eb190e7418e8b Reviewed-on: https://chromium-review.googlesource.com/895284 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
tzik authored
Change-Id: I9fc550a2dbab74cf7f7a8c9bc52c127f6786b068 Reviewed-on: https://chromium-review.googlesource.com/888399Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#533252}
-
Vaclav Brozek authored
The bug tracked adding viewing of passwords to iOS settings. There were two remaining TODOs: * An outdated comment in a test. * A refactoring suggestion for trading off code complexity for test complexity (add a delegate API to make a particular EG test a unit test). The refactoring suggestion does not seem justified -- the current EG tests are stable and working well. Therefore this CL removes both TODOs. Bug: 159166 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20658b94b4fa190a2ffa442af6f9f7b4ec1aeed4 Reviewed-on: https://chromium-review.googlesource.com/892818Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533251}
-
Kent Tamura authored
Bug: 648828 Change-Id: If19afe0ad2aa29eb5a042306f260d5eac77e0f0e Reviewed-on: https://chromium-review.googlesource.com/895423Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533250}
-
Christos Froussios authored
Bug: 790990,789561 Change-Id: I89dae77899c27ea166ed75c038a82fe0a1278b9a Reviewed-on: https://chromium-review.googlesource.com/893378Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/842d424d..70bfb939 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If391a2158ee94d123222f76d608183c2d579149b Reviewed-on: https://chromium-review.googlesource.com/894309Reviewed-by:
-
Gauthier Ambard authored
This CL updates the location bar container, updating its background color and its height to follow the fullscreen progress. It also updates BVC so the location bar is always displayed. Bug: 804731 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f5b2a750cf1593c8d4c7f12163a9db90dc34090 Reviewed-on: https://chromium-review.googlesource.com/883283Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#533247}
-
Raphael Kubo da Costa authored
Since e1c54ad2 ("Update PromiseRejectionEvent IDL to match latest spec") from more than 2 years ago the code is returning undefined instead of null. Make the comment match the code to avoid confusion. TBR=yukishiino,haraken No-Try: True Change-Id: Ie931aef81fbe7510ccbf7b1c0e3753b32a64e948 Reviewed-on: https://chromium-review.googlesource.com/894384 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#533246}
-
Gauthier Ambard authored
This CL adds the standard actions (cancelling omnibox edit and recording metrics) to all the toolbar buttons. Bug: 806274 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifbc108f852ae5f521343f3ea8065a8637c8afb68 Reviewed-on: https://chromium-review.googlesource.com/893266 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL rotates the tools menu button (3 dots) by 90 degrees. It also rotates the animation when an item is added to the reading list. Bug: 807285 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8553993c8e4b9f38579159087480c1adf82d23e8 Reviewed-on: https://chromium-review.googlesource.com/893360 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
With this CL, when a toolbar button associated with a named layout guide is shown, all the constraints on the named layout guide are removed and the layout guide is constrained to the toolbar button. Bug: 802034 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I967729b7cd939fccd5821d4dfc84df8d3055e587 Reviewed-on: https://chromium-review.googlesource.com/883809Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#533243}
-
Gauthier Ambard authored
This CL changes the scroll view of the WKWebView used in CRWWebViewContentView so it doesn't clips to bound its content. It allows the content of the WebView to be fully displayed on the page, including below the toolbar. Bug: 805845 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3591b354a21ebb7b9f29500bc93f697e37547129 Reviewed-on: https://chromium-review.googlesource.com/887041 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes file encoding of "thai-word-at-document-end.html" to UTF-8 from UTF16-LE to make git and tools to recognize it as text file instead of binary for ease of maintenance. There is another instance in WebKit: https://trac.webkit.org/browser/webkit/trunk/LayoutTests/editing/selection/thai-word-at-document-end.html TBR=yosin@chromium.org NOTRY=true Change-Id: I64d9318db55c73a17a6154336e7ac35faee73c52 Reviewed-on: https://chromium-review.googlesource.com/895216 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Christopher Cameron authored
When allocating an anonymous IOSurface-backed GLImage, we have the sequence of calls - IOSurfaceCreate - IOSurfaceCreateMachPort - IOSurfaceRelease (implicitly in ScopedCFTypeRef<IOSurfaceRef>) - IOSurfaceLookupFromMachPort The final call persistently fails on some machines. This adds a CHECK when that call fails, so we can assess how often it occurs in the wild. This also adds a call to IOSurfaceCreateMachPort and IOSurfaceLookupFromMachPort before the implicit IOSurfaceRelease, to see if this may be the result of a reference counting bug. Add lots more LOG(ERROR) spew to help further diagnose this. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie630067759d0bdf096be907986e53afdc632b15d Reviewed-on: https://chromium-review.googlesource.com/895142 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#533240}
-
Katie D authored
This fixes a bug with absolutely positioned webviews in apps such as Hangouts. Note that AutomationApiTest.LocationInWebView fails without the change to AXLayoutObject.cpp. Bug: 801995 Change-Id: I1a3e8e66f3f64b7ec6f619076374438aad901d65 Reviewed-on: https://chromium-review.googlesource.com/894182Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533239}
-
Alexandr Ilin authored
This CL reenables SpeculativePreconnect field trial since the fix https://crrev.com/c/778899 addressing performance regressions was landed. The predictors::kSpeculativePreconnectFeature is explicitly disabled in net::Predictor browser tests because the LoadingPredictor if enabled intercepts all prefetch and preconnect coming from a renderer. Bug: 699080 Change-Id: Id5e4bb785943e1963f2a6a8802f738f491bb7544 Reviewed-on: https://chromium-review.googlesource.com/893459Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533238}
-
Friedrich Horschig authored
This CL completely drops all UI elements that previously popped back in when the results are empty. Reason being, that 1. the link would redirect the user to the same passwords that are synced to the device they are using right now. 2. the "Saved passwords appear here" text would indicate that the user hasn't saved any passwords yet which is not correct. (Another text is not necessary as the interaction with the search field should give enough context for the empty list). Bug: 807300,807302 Change-Id: Ice2dab3a5f6ee280a33ef559d540cc0ca6e082cc Reviewed-on: https://chromium-review.googlesource.com/894002 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533237}
-
Yuta Kitamura authored
WebTaskRunner is being deprecated. Use SingleThreadTaskRunner instead. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id7550222db748583b9e7fc1449a14964b9a497c3 Reviewed-on: https://chromium-review.googlesource.com/895064Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533236}
-
Kent Tamura authored
The function contains autonomous custom element processing. It's unexpected in many cases. If it's called with known HTML tags, custom element processing is unnecessary and it should be replaced with Document::CreateRawElement(). If it's called with arbitrary tag names, custom element processing is necessary and it should be replaced with Document::createElement(). This CL is a preparation to remove HTMLElementFactory::createElement(). Bug: 806641 Change-Id: I00dae6c2cdac18eccd1580a72d94862b5cb2d657 Reviewed-on: https://chromium-review.googlesource.com/895203Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533235}
-
Kent Tamura authored
Add custom built-in element support to <embed>, <object>, and <form>. Bug: 805281, 806184, 806185, 806187 Change-Id: I920ea11ed0b5884c69d3c1aee04e18f7fa62e9f2 Reviewed-on: https://chromium-review.googlesource.com/895234Reviewed-by:
-
arthursonzogni authored
This fixes https://crbug.com/796561 and adds a regression test. The issue was a race between the browser and renderer processes while updating the renderer's history. The renderer's history is updated in * RenderFrameImpl::CommitNavigation and in * RenderFrameImpl::DidCommitProvisionalLoad. ┌────────┐ ┌───────┐ │Renderer│ │Browser│ └───┬────┘ └───┬───┘ │ BeginNavigation │ │ - url=iframe.html │ │ - history_offset = 0 │ │ - history_length = 1 │ 1) │ ──────────────────────────> ┐ │ │ │ │ DidCommitProvisionalLoad │ │ │ - "pushState" │ │ │ - history_offset = 1 │ │ │ - history_length = 2 │ │ 2) │ ──────────────────────────> │ │ │ │ │ CommitNavigation │ │ │ - url=iframe.html │ │ │ - history_offset = 0 │ │ │ - history_length = 1 │ │ ┌─│ <───────────────────────────┘ │ │ │ │ │ DidCommitProvisionalLoad │ │ │ - url=iframe.hmtl │ │ │ - history_offset = 0 │ │ │ - history_length = 1 │ └>│ ──────────────────────────> ┌───┴────┐ ┌───┴───┐ │Renderer│ │Browser│ └────────┘ └───────┘ What happens in the bug. 1) An iframe is created: [history.offset = 0, history.size = 1]. 2) history.pushState: history is updated [offset = 1, size = 2]. 3) CommitNavigation is received, history is updated using the old values transmitted in 1) with BeginNavigation. This CL update the values sent in CommitNavigation. This reduce considerably the duration when the race can happen. Before this CL, the race could happen if a history.pushState is sent in between BeginNavigation and CommitNavigation (~300ms <-> severals seconds). After this CL, the race happens if the history.pushState is sent between when the CommitNavigation message is sent and when it is received by the renderer process. Bug: 796561 Change-Id: I7bf72fadbf9f4946da28126a394adddf051f49a8 Reviewed-on: https://chromium-review.googlesource.com/881171Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533233}
-
