- 26 Aug, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f269f8e76a47..4857c934a09c Created with: gclient setdep -r src-internal@4857c934a09c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: If6aaf9554389bd6474bffee9e31d9c33de8dbff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771037Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690435}
-
Xianzhu Wang authored
They are true more commonly in real world and tests. This doesn't affect production code because they are always initialized by cc::PropertyTreeBuilder or blink::PropertyTreeManager. Their cc::Layer corresponding values (to be removed as BlinkGenPropertyTree has launched) are already true by default. This affects only tests that create the nodes directly, e.g. those using the functions defined in property_tree_test_utils.h. Bug: 994361 Change-Id: I6be1ef0355c11cd7c3c124d020c487aac2958456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770038 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690434}
-
Weiliang Chen authored
When using a BufferQueue, the OutputSurface is treated as an Overlay, and is made into an OverlayCandidate. That overlay candidate is then pushed in as the front of the candidate list. This CL changes it into its own type instead of checking for a bool on OverlayCandidate. This is CL 1/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I7e61732de09bddeb63d6f2ba69991d82d297bea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739980 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#690433}
-
Ivan Šandrk authored
Since we're in the process of changing the approach slightly, roll back and then re-enable once we update the approach. TBR=rsorokin@chromium.org Bug: 891222 Change-Id: Ib26cf93cb7780e795294709e3589ac06d57ae0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771781 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#690432}
-
Marijn Kruisselbrink authored
These tests are flaky on ASAN builds, see bug for details. Tbr: rdevlin.cronin@chromium.org Bug: 997634 Change-Id: I07ecffd1050c51e3957109b3f0ee491f7a78bd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769582Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#690431}
-
Khushal Sagar authored
R=fserb@chromium.org Bug: 900706, 995142 Change-Id: I7221db94e63f11d67c45cbafcc019b3995f8fe8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765659 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#690430}
-
Peter Wen authored
Built locally @265454220 and uploaded to CIPD. Updated ModuleInstaller to use the new SplitCompat API. Add new play core activity to expected manifest file. Changes from original CL: Includes fix from play core for NPE. Reland of original CL: https://crrev.com/c/1764804 Tbr: Reland with no chrome changes Bug: 996212 Change-Id: I9de3a3c54beea64fc526a9b380eef2bd608a26c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771737Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690429}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/25cc723823e3..f19c328b5ba5 git log 25cc723823e3..f19c328b5ba5 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 enga@chromium.org Fix NextPowerOfTwo for 64-bit MSVC Created with: gclient setdep -r src/third_party/dawn@f19c328b5ba5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I6714455e05826d59ab16ada891983f1ebfe4c3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769581Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690428}
-
Marijn Kruisselbrink authored
This test has been very flaky on ASAN build lately, so disabling. See bug for details. Tbr: msw@chromium.org Bug: 997634 Change-Id: Ie04c0795470860891feabdda9d3dbce3c2a40a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769585Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Maksim Sisov authored
The fuzzer has been broken after some major refactorings done. We have not noticed it as long as there is not buildbot for that. This CL fixes it. Bug: 578890, 873132 Change-Id: Iea7c4b8f8415d8fdbf091595c09ccfd1e69c6d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768697Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#690426}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f2f111d77fa8..87b106a0944e git log f2f111d77fa8..87b106a0944e --date=short --no-merges --format='%ad %ae %s' 2019-08-26 jmadill@chromium.org Fix trace logging in Debug. 2019-08-26 ianelliott@google.com Vulkan: Enable ES1_VULKAN testing in end2end tests. Created with: gclient setdep -r src/third_party/angle@87b106a0944e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I52e3915464aca243567d299877bb248fa33dc18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770694Reviewed-by:
-
Doug Arnett authored
TBR=tbansal@chromium.org Bug: 997697 Change-Id: I25b1b67ba8950c8c615b5458895f6eb3eb806233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771392Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#690424}
-
John Chen authored
Creating an error Status object is expensive, as it generates a stack trace. Avoid creating such object until it is needed. Bug: 997414 Change-Id: I694981761135a987f3bd767617eaf0206ce62af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769580Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690423}
-
Andrew Luo authored
Change-Id: I49e7cab2a169292d3650aea164da068ce69871d0 Bug: 997309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763263 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#690422}
-
Clark DuVall authored
Bug: 996603 Change-Id: I335cc43743de4f4c4ba66fa14a096182fbbf4bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771385Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690421}
-
James Cook authored
The SplitSettings project has moved OS-specific settings, including Bluetooth, into a separate WebUI surface. Directly open the Bluetooth settings subpage from the bluetooth chooser "adapter off" link, rather than opening browser settings and trying to do a search. Bug: 994896 Test: Turn adapter off, open https://permission.site, click bluetooth, click "Turn on bluetooth" link Change-Id: I602d979c88f3d89c82702e92ad3bb81230f03698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771841Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#690420}
-
sczs authored
Bug: 979201 Change-Id: I9d5ed63fc694dc10d564d3e4255187470b619943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762573Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#690419}
-
John Chen authored
Update run_py_tests.py to attempt to locate Chrome binary automatically, to make RemoteBrowserTest compatible with CQ. Bug: chromedriver:2277 Change-Id: Iee82313ac5d38315f1017961c487dc202025196b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769722Reviewed-by:
-
Kyle Milka authored
The button labels on the richer picker were slightly too big and became misaligned when minimum font size was set to huge on Windows. Bug: 996160 Change-Id: Ibda385b544637e3d1d893bbed85c885c92178750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769579Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#690417}
-
Andrei Chulkov authored
Casting pointers to numeric types other than intptr_t is a potential security issue. Replaced with casts to intptr_t. Change-Id: I4905401dcc93b89efad8437b0b6f17412cfe2925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765710Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Andrei Chulkov <achulkov@google.com> Cr-Commit-Position: refs/heads/master@{#690416}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7064c6b3b409..e21a095bc454 git log 7064c6b3b409..e21a095bc454 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 saklein@chromium.org BundleAutotestFiles: Refactor to chroot and sysroot arguments. Created with: gclient setdep -r src/third_party/chromite@e21a095bc454 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I60c35d055fb5a7ec14cd02535672559c280fe0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771583Reviewed-by:
-
Nico Weber authored
Including directories full of generated files causes incorrect incremental builds. There's already a data_deps on the action, so just setting `outputs` correctly makes that do the right thing, without needing the explicit directory. To make sure this does the right thing, I ran gn gen out/gn --runtime-deps-list-file=<(echo -e \ //chrome/test:performance_test_suite\\n\ //chrome/test:ct_telemetry_perf_tests_without_chrome) (...which is what tools/mb/mb.py gen -m chromium.perf -b linux-builder-perf \ --swarming-targets-file \ <(echo -e performance_test_suite\\nct_telemetry_perf_tests_without_chrome) \ out/gn runs behind the scenes.) I the compared these files before and after this patch: out/gn/obj/chrome/test/performance_test_suite.stamp.runtime_deps out/gn/obj/chrome/test/ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps $ diff -u performance_test_suite.stamp.runtime_deps out/gn/obj/chrome/test/performance_test_suite.stamp.runtime_deps -gen/components/subresource_filter/tools/ +gen/components/subresource_filter/tools/default_local_state.json $ diff -u ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps out/gn/obj/chrome/test/ct_telemetry_perf_tests_without_chrome.stamp.runtime_deps -gen/components/subresource_filter/tools/ +gen/components/subresource_filter/tools/default_local_state.json I then grabbed an existing isolate off a recent https://ci.chromium.org/p/chrome/builders/ci/linux-perf build from a performance_test_suite run: tools/swarming_client/isolateserver.py download -I https://chrome-isolated.appspot.com \ --namespace default-gzip -s d60732b5f6374dc56d1b01c2e54c82fc411c83e5 --target foo And inspected all the files in the tools directory: $ ls foo/out/Release/gen/components/subresource_filter/tools/ GeneratedRulesetData default_local_state.json (gen/components/subresource_filter/tools/GeneratedRulesetData was already in the .runtime_deps files.) Bug: 912946,884035 Change-Id: Ife400071aa25589c66abfe693108a483ad14870d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769204 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690414}
-
Jan Wilken Dörrie authored
This change implements hiding the bubble when the leak dialog is about to be shown. Bug: 986317 Change-Id: Ie53dd100d11d3e9015f9d9c0cc948d54ea430982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768531 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Ryan Hamilton authored
Bug: 997355 Change-Id: I8556f620cedcd5529cf4ef5c1803e1e4de1f5a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771389Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690412}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d617d5d29ca5..ea07123fedc7 git log d617d5d29ca5..ea07123fedc7 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 michaelludwig@google.com Define Usage and image+origin wrapper for image filters 2019-08-26 fmalita@chromium.org Add a colortype conversion bench 2019-08-26 egdaniel@google.com Remove GrGpuTextureCommandBuffer class and rename to GrOpsRenderPass. 2019-08-26 reed@google.com remove unneeded noemptycheck variants of intersect 2019-08-26 herb@google.com Rename SkGlyphCacheState -> RemoteStrike Created with: gclient setdep -r src/third_party/skia@ea07123fedc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ieba9823ab83403d1faa5f9e91911b44b07f3624b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771581Reviewed-by:
-
Jun Mukai authored
It is not clear which file stores the tracing data when --trace-dir is specified. Bug: none Test: manually Change-Id: I6e80e8f62adfa2091d271eaef1732891b69e33ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769801Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#690410}
-
Daniel Rubery authored
Bug: 980784 Change-Id: Ie37f1281ec068e6114abc815daa02a86a8a31602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769045 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#690409}
-
Andrey Kosyakov authored
This reverts commit b0caf8a2. Reason for revert: broke some protocol clients. Original change's description: > [DevTools] Perform Session id surgery in Blink. > > That is, for messages coming from Blink, perform the surgery there. > For messages that come from the browser, perform the surgery in > content::DevToolsSession as before. > > Longer term, we may include the session id prior to serializing the > message. But this requires much deeper changes to the bindings etc., > so this just moves the computation closer to where it will be > eventually. > > Change-Id: I16efafec72e8077d7aaab6458f5253ddb018fd96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734142 > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690168} TBR=dgozman@chromium.org,dcheng@chromium.org,caseq@chromium.org,johannes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I89d2e6a11fd38a0ab0484e26af793ebd230692a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771549Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#690408}
-
James Cook authored
UX prefers the icon to always be visible. Clicking on the icon closes the drawer. http://screen/5CjhZ4caxB1 Bug: 988012 Test: added to browser_tests Change-Id: I1c593619126ca6394ccdf7bf93e3479dad1a8b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764758 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#690407}
-
Kamila Śledź authored
The switch for the endpoint is --public-accounts-saml-acl-url. Bug: 984021 Change-Id: I9a7250d0c49e63b2ff08d0f5254e012ebf763b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760730Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/428c0b21e872..793707262d8d git log 428c0b21e872..793707262d8d --date=short --no-merges --format='%ad %ae %s' 2019-08-26 chrisforbes@google.com Fix misleading UNIMPLEMENTED in image load Created with: gclient setdep -r src/third_party/swiftshader@793707262d8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ic31b55cd8b5699a452d7f43d9c6d6b8ae979d436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771582Reviewed-by:
-
Morten Stenshorne authored
This is partly clean-up, partly preparations for column-span:all, and at least one fix: When a multicol container is nested inside another fragmentation context and has column-fill:auto, we shouldn't balance the columns, since its fragments are constrained by the outer fragmentation context. CalculateBalancedColumnBlockSize() now honors incoming break tokens, rather than starting from the beginning of the content. Change-Id: I3ddfde60ec310e11e09944b0b0ccb6964ca5fa96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766071 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#690404}
-
Bailey Berro authored
Previously on managed CrOS devices, the managed-footnote banner displayed a "Your Chrome[book|box|bit] is managed by domain.com". Now, only show this message in OS-Settings. In all other instances (Browser Settings, Downloads, Bookmarks, History), show "Your browse is managed by domain.com. Also, when in OS-Settings, chrome://management should open in a new browser tab. Bug: 996533, 996897 Change-Id: Iec7235e4e837f9fcad6ecec46d6408cc5a974a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769041 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#690403}
-
Aleks Totic authored
Do not DCHECK if values are saturated. Bug: 996085 Change-Id: I1f9b299aef1f8bd5f18d6f4f05d50e33a7c1609d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769517 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
This CL moves PointerDetails class to its own source files as well as to //ui/events:events_base build target, so that it can be used in events_x.{h,cc} and reused in x11_event_source_default.cc, thus cleaning up touch PointerDetails creation code, especially in X11 code. This is part of PlatformEvent migration to ui::Event for Aura/X11. Bug: 965991 Test: event_unittests (no functional change) Change-Id: I9a64a7c93cec772b51f770d0da2090ed641976b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765572Reviewed-by: -
Luum Habtemariam authored
This is a reland of 66630f37. Reverted in 1764333 for breaking linux-chromeos-rel. This change incorporates the fix. Original change's description: > Removing dead ServiceManager constants > > Since ServiceManager went away, we're clearing up some leftover > CupsProxyService constants. Trivial change. > > Bug: chromium:945409 > Test: confirmed service behavior unchanged > Change-Id: I45ffdeb3b0ad1990798a4a4d5115e791a6eefbfe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764430 > Auto-Submit: Luum Habtemariam <luum@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689164} Bug: chromium:945409, chromium:996442 Change-Id: Ie2d2a835787d5d3c178ee632f00031f30746d1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764525Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#690400}
-
Fredrik Söderquist authored
* Pass const Document& to IsWellFormedDocument(...) helper. * Return SVGElement* from CreateInstanceTree(...). * Remove unnecessary local variable in ExpandUseElementsInShadowTree(). Bug: 997176 Change-Id: If1607a7332eb2b5e36ae8ed11e8eac42adb60574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768640 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#690399}
-
Marijn Kruisselbrink authored
Tbr: juncai@chromium.org Bug: 997549 Change-Id: I72c5b6949408d03b0716ab0223ce10654f11bf3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771553Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#690398}
-
Dan Beam authored
This CL simply adds a feature ([k]NtpRealbox). This is for a11y purposes and to fix the [currently somewhat broken] NTP fullscreen experience, and to allow on-focus suggestions. R=mahmadi@chromium.org BUG=243926, 778489, 996516 Change-Id: Ic7347be02391290dfc6214a1754558e91b6c7802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769035 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690397}
-
Vadym Doroshenko authored
is_gaia_with_skip_save_password_form is already inside submitted_form. Bug: 831123 Change-Id: I671cb3d2f1e423ef9128e3c05b8c26805d4c156e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768533Reviewed-by:
-
