- 21 May, 2020 40 commits
-
-
Trent Begin authored
Now that ShillPropertyManager listens for changes to the Prohibited Technology property, add a unit test that ensures NetworkHealth correctly reports the kProhibited state. Bug: chromium:1081488 Change-Id: Id4977581b439e6b634dfdad1401b595bd6681605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197149 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771184}
-
Sonny Rao authored
We're still monitoring many of these and they can be useful in detecting regressions. Platform.SwapOutShort Platform.SwapOutLong Platform.SwapInLong Platform.SwapInShort Platform.ZramCompressedSize Platform.ZramCompressionRatioPercent Platform.ZramSavings Platform.ZramZeroPages Platform.ZramZeroRatioPercent Platform.CompressedSwapSize Platform.MeminfoShmem Platform.MeminfoMemUsedDerived Platform.MeminfoMemFreeDerived Platform.MeminfoMapped Platform.Mem Platform.MeminfoAnonPages Platform.MeminfoInactive Platform.MeminfoCached Platform.MeminfoProcessDataTotal Platform.MeminfoInactiveAnon Platform.MeminfoSwapUsedPercent Platform.MeminfoFileTotal Platform.MeminfoActiveAnon Platform.MeminfoInactiveFile Platform.MeminfoSwapUsed Platform.MeminfoBuffers Platform.MeminfoMemFree Platform.MeminfoActive Platform.Meminfo Platform.MeminfoUnevictable Platform.MeminfoActiveFile Platform.MeminfoMemTotal Platform.MeminfoSlab Platform.PageFaultsLong Platform.PageFaultsShort Bug: 1084075, 1084076, 1084077, 1084071, 1084073, 1084074 Change-Id: I525ca24ad20e6d5f98f9c0c5ebebe75a1740afc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208824Reviewed-by:Brian White <bcwhite@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771183}
-
Sahel Sharify authored
This cl extends the expiration time of the following histogram since its event count needs to be monitored during Gpay+PH experiment roll out. PaymentRequest.ServiceWorkerStatusCodeTimeout TBR=rkaplow@chromium.org Bug: 1070245 Change-Id: I86d8402670ca88bd4260367b58abefed7651b381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212784Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771182}
-
Reilly Grant authored
These functions may cause DLLs to be loaded for socket providers in the process of enumerating device services. This macro temporarily boosts this background thread's priority in order to avoid a priority inversion where the main thread (and others) hang while this low priority thread holds the dynamic library loader lock. Observed this hang in crash/08cf98f7a1b73d12. Bug: 973868 Change-Id: Ibb80c37c735471958f7b41460831aad2891ccf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212671 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#771181}
-
Sonny Rao authored
These are related to CrOS performance and are still used. Platform.CpuUsage Platform.BootSectorsWritten Platform.LogicalCpuCount Platform.BootSectorsRead Platform.CpuFrequencyThermalScaling Bug: 1084067, 1084070 Change-Id: I34e62d39a5833d7c242fd7c9958871179950d1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211018Reviewed-by:Mark Pearson <mpearson@chromium.org> Commit-Queue: Sonny Rao <sonnyrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771180}
-
Ramya Nagarajan authored
This reverts commit 142274a8. Reason for revert: Consistent test failures in https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux It looks like EnableSyncAfterToken also needs an updated GURL. Original change's description: > WebUI NTP: redirect sign-in to chrome://newtab > > Bug: 1015293 > Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771116} TBR=droger@chromium.org,thestig@chromium.org,tiborg@chromium.org,aee@chromium.org Change-Id: Ia5700a01efee9ee198cb5615fd59232ba481402f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212809Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771179}
-
Xi Han authored
Bug: 1077022 Change-Id: I0dc8926c8d756d816b1f994e4353836f825125a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199717Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771178}
-
Leonard Grey authored
Kiosk mode is very rare and getting command line arguments isn't free, so let's not check every single time we process an event. The switch is left over from something more complicated, so we can get rid of that too. Bug: None Change-Id: I5ada32fdb003cc51228106a9bf415933ee84c05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212453Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#771177}
-
Austin Orion authored
Some captured frames have a negative height value, and this leads to a crash when computing the hash as it tries to memcpy from an invalid address due to this value being negative. This began happening after this change: https://chromium-review.googlesource.com/c/chromium/src/+/1952554 Which switched us from base::Hash (which would return 0 for negative sized or null input) to base::FastHash which is not as fault tolerant. This check mitigates the crash, but screen capturing in these scenarios is still broken, only black frames will be presented. This was tested by forcing the heights to be negative on all the frames received from the screen capturer and testing the functionality on https://webrtc.github.io/samples/src/content/getusermedia/getdisplaymedia/ Further investigation is needed to root cause why these frames have negative height values. Bug: 1066765 Change-Id: I01870594badab2c90fb30323a0f826f3fb4b7232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210932 Commit-Queue: Austin Orion <auorion@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#771176}
-
Nate Fischer authored
No change to production logic. This disables flaky tests. TBR=dalecurtis@chromium.org Bug: 1085516 Test: None Change-Id: I1eb617e7ca8dcb1edce3ebffdb2fa17bb566a650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212754Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771175}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 870d5163. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ia29634f817bf883b9d00ede23742e1df97b712ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212322Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771174}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, existence of TabModelFilter was used to determine whether we should use pre-native PseudoTab or not, but having a TabModelFilter doesn't necessarily mean it's already restored. This CL uses TabModelSelector#isTabStateInitialized instead. Bug: 1080810 Change-Id: Id8aa5e1a61cfa563f4f56b64d6c09ea0fd2b277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206223 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771173}
-
Ethan Jimenez authored
1. Filter out unnecessary `EVENT_OBJECT_STATECHANGE` events in `AccessibilityEventsScrollVerticalScrollPercentChange` and `AccessibilityEventsScrollHorizontalScrollPercentChange`. Bug: 1047282 Change-Id: I2e638be74eeb1e766a55e6d3d5cfaf3a6167578c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209537Reviewed-by:
Victor Fei <vicfei@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771172}
-
James Long authored
Unit tests are added for the three existing files in the /src/tools/android/dependency_analysis directory, and a presubmit file is added to run the tests automatically. A small bug was also fixed in `process_jdeps.py` to only ignore lines of the form `a -> not found b` instead of ignoring lines with the substring `not found` entirely (a valid form is `a -> b not found`) Bug: 1085063 Change-Id: I5e4d747977c1eba02b4416a083010f003dab15a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208301Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#771171}
-
Andrew Grieve authored
It's pretty bitrotten at this point and R8 is serving us well. Bug: None Change-Id: I6aa003237b2aef1c9004f7234285a5e3e9c1169b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212545 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#771170}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c9eb1c3712fa..942c97d6260f 2020-05-21 ehmaldonado@google.com update_depot_tools: Pull changes first before updating tools on Win. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8e159ed9d2aee64941c31e9942e16ccfa1594639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771169}
-
Ben Joyce authored
If you run the fetchall script the enable_bytecode line is removed. It is needed to break a dependency cycle. supports_android is needed as a third_party/guava dependency. I assume this slipped in when the bytecode checker was disabled. https://chromium-review.googlesource.com/c/chromium/src/+/2212449 Bug: 1080903 Change-Id: I0a3f9ff04acd9eb7c8407b1c9cd01f967dffdde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212449Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#771168}
-
Alexei Svitkine authored
Bug: 1072801 Change-Id: Iea07b22fc426c3bfcd9e91f3daf1f818fd8a68a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212551Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#771167}
-
Nate Fischer authored
No change to logic. This adds histograms to capture metrics about the new non-embedded histogram service. This measures the number of metrics received by the service and logs whether transmission was successful or not. Fixed: 1084180 Test: None Change-Id: I851a7b8ed13f9f931ad05f670f3f01e37d15ef4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210974Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771166}
-
Li Lin authored
This change is preparing for adding more public interfaces, for example browser delegate client. Bug: 1084379 Test: manual Change-Id: I06dcc3d752b2dd8feadd5768f6a6d512855aa270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210961 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771165}
-
Alex Chau authored
Bug: 1084574 Change-Id: I55c4f059f473737589d9f8c896d71bcfbbe13098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212127Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#771164}
-
Shawn Gallea authored
This is needed to determine if rounded corners are needed via window visibility. Bug: b/156276792 Test: On device Change-Id: Ibd893ccdac4af1e72789f8217b99433a41b8b25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202533 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#771163}
-
Ahmed Fakhry authored
We found that a process snapshot was being built multiple times individually while the task manager is running by vm and arc code. Since each build of the process snapshot is full walk of /proc fs, this is wasteful and unnecessary. This CL introduces the ProcessSnapshotServer to serve a process snapshot to its vm and arc clients that is refreshed only once every certain delay that matches the smallest one requested by all clients. BUG=chromium:1083062, b/154362057 TEST=Manually, added some tests. Change-Id: I68ea1cfad6b024dc47276e4681a408f052ec3240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183473 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771162}
-
Yi Gu authored
The scroller in the updated tests is not composited by default. When we run the tests with the virtual/threaded test suite, the tests can not properly run on the compositor because cc::ScrollTimeline is considered as inactive, i.e. scroller is not in cc::ScrollTree because it's not composited. This patch forces compositing the scrollers if the animation needs to play. Note that once all ScrollNodes including uncomposited ones are in the compositor after the scroll unification (crbug.com/476553), we no longer need to add will-change to the scrollers. Bug: None Change-Id: I0e379abb071c9bffc58f2167f4cac9f92edbb9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211048Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771161}
-
ckitagawa authored
If a recording contains a reference to a GPU accelerated image it cannot be accessed from another thread. As such serialization should be done only on the capturing thread. Bug: 1084183 Change-Id: Ibe13c5e636d94b0fabb86a152ec4225e31088c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212451 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#771160}
-
Liviu Tinta authored
Move mouse pointerevents compat events to wpt Change-Id: I9581dde4d6016a3eb81ea16674c439e63897523c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199985 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771159}
-
Ramya Nagarajan authored
This reverts commit be2aab1c. Reason for revert: Step "compile" failing on 3 builder(s) Builder: chromeos-betty-pi-arc-cfi-thin-lto-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome First failing build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/b8879666664893307472 -------------------- Builder: chromeos-arm-generic-cfi-thin-lto-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-arm-generic-cfi-thin-lto-chrome First failing build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-arm-generic-cfi-thin-lto-chrome/b8879668479378837648 -------------------- Builder: chromeos-eve-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome First failing build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/b8879665644223805168 Original change's description: > Remove set_owned_by_client() from AutoclickScrollPositionHandler. > > It's safe for the Widget to own the underlying View via > SetContentsView(). This was not immediately obvious; much of this CL is > adjacent refactoring and cleanup that simplifies the ownership/lifetime. > > Bug: 1044687 > Change-Id: I76cbc402edb7195c42cbae679a89839384d0615a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210914 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771122} TBR=pkasting@chromium.org,katie@chromium.org Change-Id: I7a18d84cfae23938b683f9a3aaf7b533781b975a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212824Reviewed-by:
-
Bo Liu authored
Users reporting issues with DFM installs. Bug: 1064314 Change-Id: I0b113ce1b822ca8281289372f91681e8a0eb77be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212484 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771157}
-
behdad authored
Updates: - Guides added for adding experimental attribute to a story and when to do so. - How to run perf tests locally is added to the document Bug: none Change-Id: Ie2c3f34906d185cd3992e4a614c49f43e4c3ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210632Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771156}
-
Peng Huang authored
The problem is because a recent CL https://crrev.com/c/2149640 which implements ProduceOverlay() but doesn't provide gpu fence for the overlay access. Workaround the problem by creating a gpu fence for the primary plane in SkiaOutputDeviceBufferQueue when GL is used. Bug: 1082519,1085485 Change-Id: I86431c866d94ee2f1e29a939aed11f6dab6a57b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212548Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771155}
-
Wan-Teh Chang authored
Pass gfx::ColorSpace by reference to the YUVToRGBConverter constructor. Change-Id: I1f704e0eff21fbee47ab27df6f3c557684303812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211937Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#771154}
-
Henrique Nakashima authored
A bug in JellyBean with rewinding buffers required a workaround. JellyBean has not been supported for a while, so this can be removed. Change-Id: I99aa7ea55ded13e9748b34c3902ce085fade4c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212448Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#771153}
-
Noel Gordon authored
CL:2144427 added Polymer iron-a11y-announcer.html to cr_toast.html but no dep for same to the js_library("cr_toast") build rule: fix that and add the same dep to js_library("cr_toast.m") per review comments. Minor: add @private CLosure markup to announceA11yMessage_(). Bug: 1033660, 1002391 Change-Id: Ic0cfbe4177c7813339481dfa5d5c5c7e289f9ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210194 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:dpapad <dpapad@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771152}
-
Nicolás Peña Moreno authored
This CL adds the LCP content type and the LCP algorithm termination state to a new event PageLoad_Internal which may not be sampled at the same rate as the PageLoad event. Ukm collection review: https://docs.google.com/document/d/10UwogGASJIoEQvuOaZOHgG8XTnyE7HMgvjKcceKOwqU/ Bug: 1082483 Change-Id: Ie002d201a529366231d0d6b6e5e8c01756b307ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202116 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
This will help us detect failures caused by LibAssistant sending the |OnInteractionFinished| event before all the responses (like |OnOpenAndroidApp|) are received. This will help us detect if the current test failures are caused by this, or if there is some other cause we need to find. The failure looks as follows (newlines added for commit message only): assistant.OpenAndroidApp [ FAIL ] Failed to send the Assistant text query: Error: OnOpenAppResponse was called after the interaction was closed Bug: b/157144814 Change-Id: I22b29f1d7bcdebd3844cf996ffe1fbfece42754d Tests: Tast tests with pattern "*ssistant*" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211049 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#771150}
-
Megan Jablonski authored
Bug: 1077547 Change-Id: I36a18d846e75fd89237e28b777910d88a346e354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208545 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#771149}
-
Alison Maher authored
We were previously setting forced colors at the body element. However, we should instead set these at the root html element. Bug: 970285 Change-Id: I0719d09fb7993a02162cca24a266c6a0c8eb70fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211124Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771148}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/10792279b603..48c10ec7c5b0 2020-05-21 treehugger-gerrit@google.com Merge "Create tables for cpu info" 2020-05-21 simonmacm@google.com Merge "Improve time-in-state UI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I39bf781a49a85158e1cb7f52268de7a40ba1bf88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212684Reviewed-by:
-
Patrick Monette authored
This change simply renames OnWorkerStarted() and OnBeforeWorkerTerminated() with OnWorkerCreated() and OnBeforeWorkerDestroyed() to be be more in line with the SharedWorkerService observer interface. No behavior changes. Bug: 993029 Change-Id: I53582e7d7704116166127de426ed581cf1dd4b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200077 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#771146}
-
wutao authored
Bug: b/157099464 Test: pass current tests. Change-Id: Ie364f743da23dc73b136c77416a630db3ba6e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209891Reviewed-by:
-
