GitLab

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rockot@chromium.org

Bug: 825327
Change-Id: If17acb98d53b8a6a352a0c09699ddb60915393d0
Reviewed-on: https://chromium-review.googlesource.com/1024808Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553292}

BUG=chromium:829085
TEST=Tested manually on device

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9353962f50ba3ea78abe8251e4ec3c2f140cb432
Reviewed-on: https://chromium-review.googlesource.com/1008967
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553291}

This CL fixes the misalignment of the hosted app menu button
anchor point by updating its view bounds.

Overriding CalculatePreferredSize() didn't update the behaviour
of GetHeightForWidth() which caused it to be cropped by the
container's BoxLayout. LabelButton::SetMinSize() exists and
should be used instead.

Before rects:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=335982&signed_aid=hz80AUGwixvyOI7d2jCIYQ==&inline=1

After rects:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=335983&signed_aid=9NLhUbDPYjh_YRMnsVABAw==&inline=1

Bug: 836099
Change-Id: I77ad668816df936bbb3129aa1253330382fe22c5
Reviewed-on: https://chromium-review.googlesource.com/1025592Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553290}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/034c66d8..0cf37360

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia7bae3fcf6b6f21cbcb7b7c9809fb7226110a429
Reviewed-on: https://chromium-review.googlesource.com/1026474Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553289}

Adds the SessionStorageLevelDBWrapper class, which works with the
SessionStorageMetadata and SessionStorageDataMap classes to support
shallow cloning for SessionStorage data maps.

TBR-ing jam for content/browser/BUILD.gn

TBR: jam@chromium.org
Bug: 716490
Change-Id: I1a3ad1a79f39ef001bd4489591d6e99ab0f6347f
Reviewed-on: https://chromium-review.googlesource.com/954410
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553288}

This reverts commit e34f08fa.

Reason for revert: using_sanitizer should also set enable_frame_pointer on android.
The cfi bot was broken because it enabled cfi unwinding with frame pointers.

Original change's description:
> Revert "Fix conditions for can_unwind_with_cfi_table with frame pointers"
>
> This reverts commit 5e4c7d7b.
>
> Reason for revert:
> Speculative revert for failing base_unittests on Android,
> CFIBacktraceAndroidTest.TestUnwinding.
>
> See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579
>
> Original change's description:
> > Fix conditions for can_unwind_with_cfi_table with frame pointers
> >
> > CFI table unwinder is not appilcable for builds with frame pointer
> > enabled. Make sure can_unwind_with_cfi_table is set to false.
> > No need to check for use_thin_lto.
> >
> > BUG=469376
> >
> > Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6
> > Reviewed-on: https://chromium-review.googlesource.com/992890
> > Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#548634}
>
> TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org
>
> Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 469376,826718
> Reviewed-on: https://chromium-review.googlesource.com/999635
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548765}

Change-Id: Ic6637dfe890a51264f9d151a681534fe92fc9354
Bug: 469376, 826718
Reviewed-on: https://chromium-review.googlesource.com/1000412
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553287}

The flag is not currently used and disabled.

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idf29f755276aedd56d78522a24cda21703be2929
Reviewed-on: https://chromium-review.googlesource.com/1024925Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553286}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rch@chromium.org

Bug: 825327
Change-Id: I683a3fc7b20d41d4d069fb9e7fd0b4cdcf915028
Reviewed-on: https://chromium-review.googlesource.com/1024494Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553285}

This change will keep web content area in sync with displayed URL.
Previously displayed pending URL (like data:exe) did not match web
content.

Bug: 835400
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6417df266dd54b8aad0790b52bc2c576ead52d48
Reviewed-on: https://chromium-review.googlesource.com/1022743Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553284}

js_modules is used by closure during compilation.
It is not needed if there is no compilation.

This CL fixes the gn error on js_modules not being used
when compiling with compile_javascript=false.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9de8b97214e97c068f55b770a4f296bb1c9bee4d
Reviewed-on: https://chromium-review.googlesource.com/1024839
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553283}

This change cleans up some logic in BrowserPlugin and
RenderFrameProxy, now that we fully support child-allocated local
surface IDs. Additionally, it removes AutoResize sequence numbers
from the code, as these were no longer used.

Bug: 811944
Change-Id: Ic15d6fbdbb2851282b9604dadfb7be47e315d506
Reviewed-on: https://chromium-review.googlesource.com/1024490Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553282}

This CL is a refactor with no intended behavior change.

It updates the semantics to explicitly take ownership of the WebContents.

Bug: 832879
Change-Id: Icb8ffbd89b3d598ccdf228ad7d0e297b9f6f5bbc
Reviewed-on: https://chromium-review.googlesource.com/1026270Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553281}

https://webrtc.googlesource.com/src.git/+log/7741b7ac499b..70244d225207

$ git log 7741b7ac4..70244d225 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4404f13e55eff25fdfc279f45777843c042d09a9
Reviewed-on: https://chromium-review.googlesource.com/1026512Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553280}

Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/abd0824ba6..af7882601a
Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/abd0824ba6..af7882601a

Bug: None
Change-Id: Ifac076ed4c5b190b6fa28b2cbf0a1810f3b273fe
Reviewed-on: https://chromium-review.googlesource.com/1025732Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553279}

This is a followup addressing an advice from sadrul@ in
https://chromium-review.googlesource.com/c/chromium/src/+/1017300

BUG=828462
TEST=bots
R=sadrul@chromium.org,piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iea8ab8a76adf0d5728480d1fc97087dc6d5cb7c1
Reviewed-on: https://chromium-review.googlesource.com/1024493Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553278}

The Apple interpretation as gamma=1.961 will be used when the video
frame is displayed as an overlay, so use that interpretation in the GL
compositing path as well.

Bug: 836351
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7aee20d08e8162dd2bbfdc20ba3235789a5a6216
Reviewed-on: https://chromium-review.googlesource.com/1026430Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553277}

Previously, we would defer commit when the child didn't yet have a
LocalSurfaceId. This meant we needed a special case to call
DidResizeOrRepaintAck() early when commit would be deferred.

But now the child has the ability to allocate its own
LocalSurfaceId. As a result, we no longer need to defer commit. And
thus, no longer need to call DidResizeOrRepaintAck() early.

BUG=805073,811944,836009

Change-Id: I4e85e926f217cf0fd2d4b5ed3854f09e7145e5a8
Reviewed-on: https://chromium-review.googlesource.com/1024739Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553276}

This is a reland of 89dbe1f8

Original change's description:
> Fix build errors with upstream libassistant change
> 
> Test: build locally with upreved libassistant
> Bug: None
> Change-Id: I3db67f5a77824fcf0831447f353baba6167b0801
> Reviewed-on: https://chromium-review.googlesource.com/1025268
> Reviewed-by: Muyuan Li <muyuanli@chromium.org>
> Commit-Queue: Muyuan Li <muyuanli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552972}

Bug: None
Change-Id: Ibbd692cbde43012504d3790a9be8e7911be87149
Reviewed-on: https://chromium-review.googlesource.com/1026256Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553275}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=tsepez@chromium.org

Bug: 825327
Change-Id: I23484e311db823f08ac571bf34411f960cd8fb3e
Reviewed-on: https://chromium-review.googlesource.com/1024316Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553274}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5911beeac2719301ed7bbb3d154a5e9aaab4b596
Reviewed-on: https://chromium-review.googlesource.com/1017583Reviewed-by: Steve McKay <smckay@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553273}

Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/ui/webui/sync_internals_ui_unittest.cc

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=pavely@chromium.org

Bug: 825327
Change-Id: Ic0b91000c8cd7fb5a08d97cf374d2fec8453038e
Reviewed-on: https://chromium-review.googlesource.com/1024396Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553272}

Page.captureScreenshot blocks on arrival of a LatencyInfo with
BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT component. However, the
browse process does not receive latency info when Viz is enabled.
Plumb latency info with BROWSER_SNAPSHOT_FRAME_NUMBER_COMPONENT
component from viz to the browser process.

TBR=boliu@chromium.org

Bug: 810037
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia81b0644f29a37059a7b3e0303074fb0db340757
Reviewed-on: https://chromium-review.googlesource.com/1020301Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553271}

Marks methods on the Command Line API that produce no JS-observable
side-effect.

Bug: 829571
Change-Id: I7920b2ded3eada33fc2d000aa46a0a7eef61daca
Reviewed-on: https://chromium-review.googlesource.com/1025171Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553270}

There are multiple types of iTunes media, only show StoreKit for apps

Bug: 835940, 835404
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia355c97e2f556cd96faaecd478e950541cf03286
Reviewed-on: https://chromium-review.googlesource.com/1025177Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553269}

This patch exposes BrowserContextId as a part of TargetInfo.
This helps to attribute pages to the browser contexts they
belong to.

BUG=836272
R=dgozman

Change-Id: I93d54756c98124a077bd979c207c0c7cd7e38971
Reviewed-on: https://chromium-review.googlesource.com/1026391Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553268}

Ninja has a quirk that makes it blind to incremental source file
changes, so long as the source files' timestamp precedes the last
build time. As a result Ninja was not correctly picking up changes
in SDK rolls, resulting in an unbootable combination of fresh and stale
build files.

This CL effectively implements a recursive "touch" on the SDK files,
which gives an unambiguous change signal to Ninja.

Change-Id: I6b5e15a2b4404fcc7a2f52ebf76f75f80a0a6605
Reviewed-on: https://chromium-review.googlesource.com/1025376Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553267}

They are flaky.

BUG=785555
TBR=satorux@chromium.org
NOTRY=true

Change-Id: I9e2fbaf9bb1efacc50da6e1b8cd855d379e34568
Reviewed-on: https://chromium-review.googlesource.com/1026560Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553266}

The NTP (New tab page) renderer is a semi-priveleged process having access to
some special APIs. But currently, network requests made by an NTP renderer can
be intercepted by extensions using the web request API.

This CL hides network requests made by an NTP renderer from extensions. This
works since it's guaranteed that the NTP won't share the renderer process with
any other site.

BUG=797461

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id8523aa7cbb4e5fb74256fa6cfc180709849568a
Reviewed-on: https://chromium-review.googlesource.com/1018724
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553265}

There is a pre-existing bug on Mac where Control + A performs "Select
all" instead of Command + A. The equivalent context menu item just sends
the keystroke to perform "Select all". As such, when it tried to do the
right thing and use the Command modifier, "Select all" does not actually
work.

To fix this quickly, just make the context menu item send Control + A.
Of course this is not ideal, but making Command + A perform "Select all"
is harder than it appears.

BUG=834735,836074

Change-Id: I2c8201772d7e901984c427d0977a1fb899f802b5
Reviewed-on: https://chromium-review.googlesource.com/1025403Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553264}

Its use of feature flags causes data races.

The first attempt in https://chromium-review.googlesource.com/1026462
got incorrectly reverted by FindIt.

BUG=836359
TBR=xidachen@chromium.org
NOTRY=true

Change-Id: Icfeaf23ccb69b3b1e80f6df10556f5c75e663a71
Reviewed-on: https://chromium-review.googlesource.com/1026557Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553263}

Bug: 834899
Change-Id: I160ebe1b8e830851291e89fdc8b2a860881637f7
Reviewed-on: https://chromium-review.googlesource.com/1025651Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553262}

This change just show the default penguin icon on the shelf for all
running Crostini apps. Subsequent CLs will change to use real app
specific icons.

BUG=chromium:819444
TEST=Manually tested on an eve device.

Change-Id: Ic5001edc1cf4a51acd54ea99ab43bbc1afa69dcf
Reviewed-on: https://chromium-review.googlesource.com/1023292Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553261}

Audio service runs in an unsandboxed utility process behind a flag.
Not all the content dependencies on AudioManager are removed yet,
so:

***when Audio process is enabled***, the state is weird:
1) 2 instances of AudioManager are running:
* one hosted in the BrowserMainLoop (provides audio streams),
* another living in the audio process (provides audio system
information and debug recording interfaces).
2) It also means that debug audio recording not
working (because there are no audio
streams going through the audio process).

When Audio process is disabled (default), Audio service runs embedded
in content and everything works properly (the CL has no effect).

The goal of this CL(if it is landable) is to simplify local manual
testing when developing the audio service.

Change-Id: I5382ba60efa924a314f77803fed119e3d3ebda70
BUG: 672469
Reviewed-on: https://chromium-review.googlesource.com/1016983
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553260}

The test failed in debug bots because we direct reparent the HWND to
another shell and skip full window reparent logic then shell close also
overwrite some state.

In this patch, we moved shell close to the end of test body.

Bug: 833661
Change-Id: I06c639a1c1620fe3a06af2eb6606970a6a86c78c
Reviewed-on: https://chromium-review.googlesource.com/1025119Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553259}

BUG=internal b/78359662
TEST= cast_bluetooth_unittests

Change-Id: Idd10f3edcc161b964cfda90826058564d55c6a6a
Reviewed-on: https://chromium-review.googlesource.com/1022953
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553258}

BUG=693090
TBR=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I722b61b1c7276e6957b39c9d141224fd48db8498
Reviewed-on: https://chromium-review.googlesource.com/1024472Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553257}

Use GetTargetVisibility instead of IsVisible to determine whether we should
hide or show the backdrop according to visibility of the app list. Since we
can get the app list visibility change notification immediately through
GetTargetVisibility regardless of the animation.

Bug: 760359
Change-Id: I8b1494144e541b4a646026c285151f524f0cb91b
Reviewed-on: https://chromium-review.googlesource.com/1025215Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553256}

This base::RefCountedMemory subclass owns a
base::ReadOnlySharedMemoryMapping instance.

To demonstrate the usefulness of this new class, convert PdfCompositor
from mojo::ScopedSharedBufferHandle to base::ReadOnlySharedMemoryRegion.
Use base::RefCountedSharedMemoryMapping to wrap memory regions and avoid
data copies.

While changing PdfCompositor, turn some DCHECKs into actual checks,
since there is no guarantee shared memory options will always succeed.

BUG=826213

Change-Id: I3135235ea350f58c83606e530b33ed6aa7be3cb5
Reviewed-on: https://chromium-review.googlesource.com/989429Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553255}

More fuzzers need to be added to Zucchini for launch including
adding support for protobuf based fuzzers. To facilitate this a new
fuzzers/ subdirectory will help to separate Zucchini from its fuzz
related infrastructure.

Bug: 835341
Change-Id: Ib18bfe9bb0b0050e94fa7bdca22fb99c735d9141
Reviewed-on: https://chromium-review.googlesource.com/1026475Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Cr-Commit-Position: refs/heads/master@{#553254}

https://pdfium.googlesource.com/pdfium.git/+log/90e03b9b3f45..6453a67d84dc

$ git log 90e03b9b3..6453a67d8 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 dsinclair Remove CFX_BlockBuffer
2018-04-24 hnakashima Fix edit text rendered with wrong offsets after deletion.
2018-04-24 dsinclair Cleanup CFX_XMLParser entity conversion
2018-04-24 hnakashima Fix caret moving to next line on click in multiline XFA edit.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:835924,chromium:832293


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3b1032022230598dcb53c04384247169802053c9
Reviewed-on: https://chromium-review.googlesource.com/1024605
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553253}