GitLab

(Compared to https://codereview.chromium.org/2308313003/, this version
fixes chrome/installer/linux/BUILD.gn by including all required files)

There is nothing really chrome-specific in the process_version()
template, and if we stop always passing some files in chrome/ on every
invocation it is possible to generalize it and move it to build/util
instead (and fix some layering violation comments along the way).

Compared to its previous incarnation, process_version() no longer passes
LASTCHANGE, BRANDING and VERSION automatically to version.py. This makes
it easier for callers to specify their own |sources| with values that
may override those set in those 3 files.

A new wrapper, process_version_rc_template(), was introduced to cater
for callers (generally Windows ones) who need to process a .rc.version
file that requires the values from LASTCHANGE, BRANDING and VERSION. It
always passes those 3 files to process_version() before any optional
additional |sources|, and |template_file| defaults to
chrome_version.rc.version.
Since this template depends on files from //chrome, it lives in the
newly-added //chrome/process_version_rc_template.gni.

R=dpranke@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org,ddorwin@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2341673003
Cr-Commit-Position: refs/heads/master@{#419377}

When orthogonal writing mode roots have floating siblings, its
containing block may still have old or even deleted LayoutObjects.
This occurs when LayoutMultiColumnFlowThread::populate(),
LayoutBoxModelObject::moveChildrenTo() with !fullRemoveInsert,
or more, for the optimization purposes.

This patch clears such objects to be re-created when the containing
block is laid out.

BUG=604095, 633409, 646178

Review-Url: https://codereview.chromium.org/2025543002
Cr-Commit-Position: refs/heads/master@{#419376}

This fixes OOM crashes in the mediaserver process on older devices
by suspending players more frequently and preventing unused players
and SurfaceTextures from ever being created. Both fixes are required
to enable playback on JellyBean devices; independently neither is
sufficient for playback to succeed.

- On low end devices, suspends all idle players immediately upon
  playback of another player.
- On low end devices, if a codec already exists, codec creation is
  deferred until the first Decode() call. Resolves issues with sites
  like vimeo.com that are appending initialization segments to MSE
  but never any further data.
- Once more than 2 players exist on a low end device, every extra
  player will cause immediate idle player collection. Normal devices
  will now do this after 8 players.

A followup CL will set preload=none for all JellyBean devices.

BUG=612909
TEST=manual, new tests.

Review-Url: https://codereview.chromium.org/2333983002
Cr-Commit-Position: refs/heads/master@{#419375}

https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer/+log/96e97b4..eb9b8b0

BUG=539572
TBR=aizatsky@chromium.org, inferno@chromium.org, kcc@chromium.org, ochang@chromium.org

Review-Url: https://codereview.chromium.org/2352453002
Cr-Commit-Position: refs/heads/master@{#419374}

There has been a discrepancy between how the subresource filter and the rest of
Safe Browsing defines the meaning of `redirect urls`. For the redirect chain A
-> B -> C, the SafeBrowsingResourceThrottle considers A as the |original_url|
and [B, C] as |redirect_urls|.  In contrast, the subresource filter expects C
as the resource URL and [A, B] as redirect URLs.

This CL performs the correct transformation on the |redirect_urls| list before
passing it from the SafeBrowsingResourceThrottle to the subresource filter.
Plus, it also avoid calling out to the ContentSubresourceFilterDriverFactory in
case the unsafe resource is not a main frame document.

BUG=646800,609747

Review-Url: https://codereview.chromium.org/2339733003
Cr-Commit-Position: refs/heads/master@{#419373}

This CL modifies the GamepadMappings class to use subclasses
for mappings rather than static methods. The advantage is that
the unknown gamepad mapping can keep state around that allows
it to create heuristic mappings at GamepadDevice constrution
time. This allows stable mappings that don't depend on input
to decide correctly. This also means we aren't doing string
parsing on each gamepad event anymore.

With this change, Moga Pro, Nexus Player (ASUS) Gamepad, and Razer
Serval controllers are working correctly without explict mappings.

Before the change, the D-Pad on Moga, Serval, and ASUS Gamepad were
non-functional. The triggers on the Moga didn't work at all, and the
Serval and ASUS Gamepad's triggers were swapped with the shoulder
buttons.

TEST=http://html5gamepad.com/
BUG=615656

Review-Url: https://codereview.chromium.org/2071223002
Cr-Commit-Position: refs/heads/master@{#419372}

Revert of Show ancestor hierarchy in accessibility panel (patchset #10 id:180001 of https://codereview.chromium.org/2322413003/ )

Reason for revert:
Fails the compile step on Linux ChromiumOS GN (headless_unittests)

Original issue's description:
> Show ancestor hierarchy in accessibility panel
>
> BUG=560525
>
> Committed: https://crrev.com/3558706c1b2a630557929b61fefc74e28975f3a6
> Cr-Commit-Position: refs/heads/master@{#419369}

TBR=dmazzoni@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,aboxhall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=560525

Review-Url: https://codereview.chromium.org/2351443003
Cr-Commit-Position: refs/heads/master@{#419371}

This patch uses testharness.js asserts to test canvas
on tranlsate reset and transform-translateZ property

BUG=639732

Review-Url: https://codereview.chromium.org/2343793002
Cr-Commit-Position: refs/heads/master@{#419370}

BUG=560525

Review-Url: https://codereview.chromium.org/2322413003
Cr-Commit-Position: refs/heads/master@{#419369}

Removing strings since the feature won't be required anymore.

BUG=NA

Review-Url: https://codereview.chromium.org/2347353002
Cr-Commit-Position: refs/heads/master@{#419368}

Cr-Commit-Position: refs/heads/master@{#419367}

I have verified that vh/vw are resolved by the style system before these
units reach layout, so we don't need to worry about DeviceWidth/DeviceHeight
here.

R=mstensho@opera.com,eae@chromium.org,ikilpatrick@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2344193003
Cr-Commit-Position: refs/heads/master@{#419366}

When playing encrypted media and decrypting stalls due to missing key,
add a message to indicate when a key is added and decryption tries to
start again.

BUG=645304
TEST=checked chrome://media-internals

Review-Url: https://codereview.chromium.org/2334953002
Cr-Commit-Position: refs/heads/master@{#419365}

BUG=647036

Review-Url: https://codereview.chromium.org/2342563003
Cr-Commit-Position: refs/heads/master@{#419364}

BUG=634443

Review-Url: https://codereview.chromium.org/2341943002
Cr-Commit-Position: refs/heads/master@{#419363}

BUG=598338

Review-Url: https://codereview.chromium.org/2347923002
Cr-Commit-Position: refs/heads/master@{#419362}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b22608753f37..ff40d4569c8b

$ git log b22608753..ff40d4569 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 aiolos Remove reference builds for Android-K compatible 64bit Chrome.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2343313002
Cr-Commit-Position: refs/heads/master@{#419361}

Less comments, more type safety.

BUG=581865
R=danakj@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2014103002
Cr-Commit-Position: refs/heads/master@{#419360}

When the Security.showCertificateViewer command is received by the
browser, it should show the certificate for the visible entry, not
necessarily the last committed entry, because there might be a transient
entry for an interstitial overlaying the last committed entry.

BUG=647759

Review-Url: https://codereview.chromium.org/2344113003
Cr-Commit-Position: refs/heads/master@{#419359}

Updating per PM feedback.

BUG=645540

Review-Url: https://codereview.chromium.org/2342313004
Cr-Commit-Position: refs/heads/master@{#419358}

BUG=645626

Review-Url: https://codereview.chromium.org/2342963003
Cr-Commit-Position: refs/heads/master@{#419357}

This is because they are only available/needed on chromeos.

On my local test setup, I see a reduction of 6672 bytes in chrome binary:

gn gen out/Release --args=' use_goma=true is_clang=true \
is_component_build=true proprietary_codecs=true ffmpeg_branding="Chrome" \
safe_browsing_mode=1 enable_google_now=true is_debug=false \
dcheck_always_on=true '

ninja -C out/Release chrome

With this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61439904 Sep 15 16:03 out/Release/chrome
Without this change:
ls -al out/Release/chrome:
-rwxr-x--- 1 lazyboy eng 61446576 Sep 15 16:04 out/Release/chrome

BUG=376319
Test=Expect no visible change.

Review-Url: https://codereview.chromium.org/2344783004
Cr-Commit-Position: refs/heads/master@{#419356}

It's not inteneded to be used in main.

BUG=none

Review-Url: https://codereview.chromium.org/2348013002
Cr-Commit-Position: refs/heads/master@{#419355}

Instead, put a PaintController on the root FrameView and paint into it with the
"classic" non-composited path.

BUG=646188

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2322073006
Cr-Commit-Position: refs/heads/master@{#419354}

This prevents the toggling when user just wanted to select text.
Note that simple click usually clears the selection and element will be toggled.

BUG=none

Review-Url: https://codereview.chromium.org/2346873005
Cr-Commit-Position: refs/heads/master@{#419353}

BUG=626752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2332483002
Cr-Commit-Position: refs/heads/master@{#419352}

BUG=646814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2344273003
Cr-Commit-Position: refs/heads/master@{#419351}

These includes are included as part of the runtime_library_javatests target

BUG=None

Review-Url: https://codereview.chromium.org/2344953002
Cr-Commit-Position: refs/heads/master@{#419350}

BUG=619055

Review-Url: https://codereview.chromium.org/2348693004
Cr-Commit-Position: refs/heads/master@{#419349}

This patch adds checks to see which call site is invoking a
CheckAndIssueSignals without a tile_task_manager_. Code inspection
didn't point at any obvious culprits. Hopefully these checks will.

R=danakj
BUG=642927
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2341323003
Cr-Commit-Position: refs/heads/master@{#419348}

BUG=625089

Review-Url: https://codereview.chromium.org/2349043002
Cr-Commit-Position: refs/heads/master@{#419347}

BUG=634443

Review-Url: https://codereview.chromium.org/2337373003
Cr-Commit-Position: refs/heads/master@{#419346}

Updating Polymer to get mouse cursor change from Pull Requests we
submitted.

BUG=425627
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346073003
Cr-Commit-Position: refs/heads/master@{#419345}

In dictionary_v8.cpp, the extra null check was wrong or redudant
depending on nullabilty:

 * If the member isn't nullable, then passing null should throw
   TypeError.

 * If the member is nullable, then a null check is already emitted
   earlier, and so that part of the condition is always true.

The affected dictionaries were identified by looking at the resulting
changes in the generated bindings. Any affected member was made nullable
so that this change in itself is not observable, but the right behavior
is achieved if those changes are individually reverted.

A few cases that were not given TODOs:

 * MessageEventInit, because the existing TODO is appropriate.

 * MediaStreamEventInit, because it has no spec and MediaStreamEvent's
   corresponding attribute is already nullable.

 * SpeechRecognitionEventInit, because it has no spec.
   SpeechRecognitionEvent's attributes were made nullable because they
   can now in fact be null.

A number of spec issues were discovered, linked with the TODOs.

BUG=647693

Review-Url: https://codereview.chromium.org/2342393002
Cr-Commit-Position: refs/heads/master@{#419344}

Previously we assumed that DestopView.onAttachedToWindow() will only be called
after DesktopView.init() is called but this is not true when we enter split
screen mode. Since the lifecycle of View.onAttached... and View.onDetached in
relate to Activity.onCreate() and Activity.onDestroy() is not well documented
and behaves quite surprisingly, it may be better to just rely on the lifecycle
of the activity itself.

This CL removes DesktopView's onAttachedToWindow() and onDetachedFromWindow()
overrides and handles initialization and invalidation by Desktop's onCreate()
and onDestroy().

BUG=647823

Review-Url: https://codereview.chromium.org/2348563004
Cr-Commit-Position: refs/heads/master@{#419343}

BUG=632626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2349613002
Cr-Commit-Position: refs/heads/master@{#419342}

BUG=none

Review-Url: https://codereview.chromium.org/2346863003
Cr-Commit-Position: refs/heads/master@{#419341}

BUG=560466

Review-Url: https://codereview.chromium.org/2348583002
Cr-Commit-Position: refs/heads/master@{#419340}

BUG=618447, 619264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=cwallez@chromium.org, zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2350503002
Cr-Commit-Position: refs/heads/master@{#419339}

This is the final patch in the series that abstracts the LayerTreeHost
class to provide an implementation that run the impl thread components
in-process (single-threaded and threaded compositor). This renames that
existing implementation to the LayerTreeHostInProcess.

Next up, we add an implementation that handles remoting the content
provided to the compositor across a network boundary.

BUG=625283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2340143002
Cr-Commit-Position: refs/heads/master@{#419338}