GitLab

1. add checks for hide crash button to be displayed in every
showingCrashTest
2. testHideCrashButton: checks if hide crash button removes the crash
from the view

Bug: 1059944
Test: run_webview_instrumentation_test_apk -f *CrashesListFragmentTest*
Change-Id: Iec4d623802468d4d7269384e0ad722a224b1b8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405573Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Azhara Assanova <azharaa@google.com>
Auto-Submit: Azhara Assanova <azharaa@google.com>
Cr-Commit-Position: refs/heads/master@{#806679}

The previous behaviour had those events reported with whatever verdict
Chrome received afterwards, which is inaccurate as the upload was
allowed.

Bug: 1120952
Change-Id: Ie503eac951a835aacbb977cd014e8ca31db4f4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406536Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806678}

This adds a feature that limits the number of entries in
each Safe Browsing list to 2^{18}, which can be used to
measure the impact of limiting the size of the Safe
Browsing database.

Change-Id: Ieef0697ca60e6cd2c65e13b32b425a6ce08c0844
Bug: 1127429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402112
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806677}

BUG=1096303

Change-Id: Ib8ab6c447f11da6ddb37275fed67ec8e2946d141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405937Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Auto-Submit: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806676}

This is a reland of 3480cbb1

I had to revert the original due to small time regressions in time to
navigation commit time and a larger regression in memory.

I've deferred the initialization of the warm compositor to after we know
we likely have something to show to avoid this regression as much as
possible. This improves things by O(10 ms) still, but is not as
significant of an improvement as before.

Original change's description:
> [Paint Preview] Pre-warm compositor
>
> This CL adds the ability to pre-warm a compositor process for use by
> paint preview show-on-startup.
>
> 1. The compositor is started when native is initialized if the
>    experiment is enabled.
> 2. Depending on the situation the compositor is then used or killed.
>    a. Compositor is used: disconnect handler is updated and it is used
>       as if there was a compositor already.
>    b. Compositor is not used: the process is killed immediately.
>
> This moves initialization of the compositor service up to O(100 ms)
> earlier (in local tests).
>
> Bug: 1126180
> Change-Id: I1e6f627403e8c020b6551c510ad908bba0fc24a2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398562
> Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805317}

Bug: 1126180
Change-Id: I7f7764bb080622b990dfadb7a99957cc9d992668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403580Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806675}

This prompts the user to select an area.
It will be implemented in a follow-up CL.

Bug: b/165356952
Tests: manually deployed
Change-Id: I33c1cc49c4cea542b87256cb00ac3370ef8a4427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376026
Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806674}

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I1d381903ba67fb0ab666976478f909212bf8ba5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409939Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806673}

Bug: 1113715
Change-Id: Ia927f27bba18eedf56447fa05afd3bddde679331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273128
Commit-Queue: Clovis PJ <clovispj@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806672}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I4b8e797d5bf9415efa7d05163fb961887093a697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410322Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806671}

This CL makes sure that the NTP is correctly layout with MultiWindow.
With MultiWindow, the NTP view is created with a frame of CGRectZero.
Without MultiWindow, the frame is the one of the app.
Forcing the layout after setting the frame, ensures that the elements
are correctly positioned and sized.

Fixed: 1121993
Change-Id: I1c8ae1c468934a36eedd7687348547bf5885e1e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410379
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806670}

This CL updates the subtitle string for the web sign-in bottom sheet
according to the latest UI mock.

Screenshot: https://crbug.com/1119718#c2
Bug: 1119718
Change-Id: I0babfaece628a469944f170bcbe920aa559cbd01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367681Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806669}

This reverts commit b1f4b048.

Reason for revert:
Loses test coverage on hundreds of tests from only a single
DCHECK failure. This did not appear to affect cq so should
not affect developer productivity. Re-enabling and going to
resolve the DCHECK failure instead

Original change's description:
> Disable AwSettingsTest.
> 
> Bug: 1126917
> TBR: boliu@chromium.org
> Change-Id: I77d7c6e12f975cb2cb17f5a9ee015d714f3a559b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405702
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Reviewed-by: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806206}

TBR=hanxi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1126917
Change-Id: Idf6793a92576518c0898e736d64912925c6a3196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410340Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806668}

flat_set is simply a sorted vector without duplicates. Previously we
were relying on runtime debug-only checks that our vectors were sorted,
despite needing sorted vectors for the code to be correct. Now sorting
is assured by the data structure.

Bug: 1102701
Change-Id: I6a10dda01e6ef9e2ae8bea38e207afe10137c3b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398449
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806667}

R=dpapad@chromium.org
BUG=none

Change-Id: Ifb796b08338cfd17e0c99a06aaad6f2a934e7748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020864
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806666}

render_frame_host->is_mhtml_document() became false after a
same-document navigation, which is wrong.

This is fixed by here.

R=acolwell@chromium.org,nasko@chromium.org
TBR=nasko@chromium.org

Bug: 1126391
Change-Id: Ie473c396ea9769356c39d8eee1d1915c0a136807
Fixed: 1126391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404340Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806665}

Revert "Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu"

This reverts commit 24c91f76.

Reason for revert: Resulting browser process crashes

Original change's description:
> Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu
> 
> Consolidated logic by having RenderViewContextMenu::ExecTranslate call
> TranslateManager::InitiateManualTranslation, and RenderViewContextMenu::AppendPageItems call
> TranslateManager:CanManuallyTranslate.
> 
> Bug: 898168
> Change-Id: If91cf98626f73d0c357522f8fdca840695185bc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385636
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Megan Jablonski <megjablon@chromium.org>
> Commit-Queue: Anthony Cui <cuianthony@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806161}

TBR=avi@chromium.org,sclittle@chromium.org,megjablon@chromium.org,cuianthony@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 898168
Change-Id: I23e202b72625365eedcd124af000c972ced3f816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409140Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806664}

Bug: 1123202
Change-Id: I0c766d95e62059f815cbec907d8703c522963150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409218
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806663}

Remove an used dep of the tests of DefaultBrowserPromo.

Bug: 1090103
Change-Id: I49c9cdc88bd773cd47a48b877227c307354c39a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408875
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Auto-Submit: Lijin Shen <lazzzis@google.com>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806662}

Change:
* Inline onMinimalUiDismissed() and onMinimalUiErroredAndClosed() as
they are just one-liners,

Bug: 1108099

Change-Id: I77097396926519566dd4e2ac778818f4d6ba990d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404752
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806661}

This metric is still useful and I track it on a weekly basis.

Bug: 1125785
Change-Id: I328f51b59b907135f7d56fadd44cc4c0ff3634b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408732Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806660}

In this CL, all effect node that is affected by backdrop filter is marked.
So that the layer can find the LCD text disallowed reason for the backdrop filter.

Bug: 1115564
Change-Id: Iad23ca619d21d7436786fe9d6e112a198ca638d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404908
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806659}

This reverts commit 249ce21a.

Reason for revert: 

Suspicion of breaking 30-odd accessibility tests (DumpAccessibilityEventsTest.*, DumpAccessibilityTreeTest.*) starting with

https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15793
https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25463


Original change's description:
> [Ash] Simplify accessibility tray view
> 
> After refactoring of AccessibilityControllerImpl, we can finally
> leverage that modularity by removing tons of identical calls.
> 
> Bug: 2390184
> Change-Id: I1c42bff577a844af80584ba6acd8da81e7b9b704
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398687
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806594}

TBR=xiyuan@chromium.org,apotapchuk@chromium.org

Change-Id: Iaee9d02267fd87eabc94930da410ff870079282c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 2390184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410341Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806658}

This dialog is shown on the winlogon desktop to prompt for Google
credentials to use for Windows login. It appears in testing to
still work properly when window-modal.

Bug: 1121132
Change-Id: Ibb611ef58fafb14948f79173211e29eddf678584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405701Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806657}

https://webrtc.googlesource.com/src.git/+log/71d7c8e3cdd6..8452ea86c5cb

2020-09-14 mirtad@webrtc.org Synchronize modifications to frame_extra_info_ in jni::VideoEncoderWrapper.
2020-09-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1b3e75b8..ff96bd07 (806461:806570)
2020-09-14 philipel@webrtc.org Removed old OnDecodedFrame callback.
2020-09-14 nisse@webrtc.org Fix standard GetStats to not modify NetEq state.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I711888b2bae340570af11f86b8c9d9607edacf74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410200Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806656}

This reverts commit d4e7ee66.

Reason for revert: Broke Lollipop Phone Tester tests.
See below link for details.
https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/26949

Original change's description:
> Reland "base/allocator: Add a thread cache to PartitionAlloc."
> 
> Changes: disabled the thread cache on Windows.
> 
> Original change's description:
> > base/allocator: Add a thread cache to PartitionAlloc.
> >
> > This CL adds a thread cache to PartitionAlloc. It is optional, only
> > applies to thread-safe partitions, and uses the same freelist encoding
> > and bucketing as the main allocator.
> >
> > The thread cache is added "in the middle" of the main allocator, that is:
> > - After all the cookie/tag management
> > - Before the "raw" allocator.
> >
> > That is, the general allocation flow is:
> > 1. Adjustment of requested size to make room for tags / cookies
> > 2. Allocation:
> >   a. Call to the thread cache, if it succeeds, return.
> >   b. Otherwise, call the "raw" allocator <-- Locking
> > 3. Handle cookies/tags, zero allocation if required
> >
> > On the deallocation side, the process is reversed:
> > 1. Check cookies / tags, adjust the pointer
> > 2. Deallocation
> >   a. Return to the thread cache of possible. If it succeeds, return.
> >   b. Otherwise, call the "raw" allocator <-- Locking
> >
> > The thread cache maintains an array of buckets, the same as the parent
> > allocator. A single thread cache instance is only used by a single
> > partition. Each bucket is a linked list of allocations, capped to a set
> > maximum size. Elements in this "freelist" are encoded the same way they
> > are for the main allocator.
> > Only the smallest buckets are eligible for caching, to reduce the
> > memory impact.
> >
> > There are several limitations:
> > - Only a single partition is allowed to have a thread cache
> > - No periodic purging of thread caches is done
> > - No statistics are collected
> >
> > The last two limitations will be addressed in subsequent CLs. Regarding
> > the first one, it is not possible to use Chrome's native thread local
> > storage support, as it allocates. It is also desirable to use
> > thread_local to improve performance.
> >
> > Bug: 998048
> > Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206
> > Commit-Queue: Benoit L <lizeb@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#805697}
> 
> Bug: 998048
> Change-Id: I23b70f6964bb297502921d1a08bf128d9093d577
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404849
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Benoit L <lizeb@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806597}

TBR=haraken@chromium.org,lizeb@chromium.org

Change-Id: Iedf9f99609ccd57e1a0754c8dfd8cda3a5f85539
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 998048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410422Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806655}

Using wpt-import in Chromium cc7fafa8.
With Chromium commits locally applied on WPT:
efd3138b "[mathml] Make math display values on non-MathML elements compute to flow"
077d63da "[blink] Fix top-level-await error reporting"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: I55de6132fd06476528335fa74a44914cdf55cc5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409918Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806654}

Bug: 1091507
Change-Id: I29a291ee7a9db36a665bf0663c27f08b876486ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406684Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806653}

Screenshots: https://crbug.com/1077766#c38
Bug: 1077766
Change-Id: I15d2d7c6ccf229f69e5ab7ed30e50d229dac786a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396075
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806652}

LocationBarModel.

This CL returns a non primary OTR profile when mTab is null for
LocationBarModel#getProfile.

This CL also adds tests.

Bug: 1127695
Change-Id: I2aa2e63229826e50e1602630d6fef2e6197395a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409298Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806651}

By using paddings instead of margins (and adding a symmetric bottom
padding), the touch target size increases as demanded by mocks).

Screenshot in the bug.

Bug: 1109727
Change-Id: I0cab8af44002fe2c9978ed770e7678d73d87e6e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409959Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806650}

https://android.googlesource.com/platform/external/perfetto.git/+log/9edd1a906f57..bef393a5a340

2020-09-14 lalitm@google.com Merge "tools: replace \ with _ in include guard as well"
2020-09-14 treehugger-gerrit@google.com Merge "Displaying Flow Events in the UI"
2020-09-14 lalitm@google.com Merge "gn: make generate_descriptor consistent between chrome and standalone"
2020-09-11 treehugger-gerrit@google.com Merge "chrome_config: Add client priority setting"
2020-09-11 fmayer@google.com Merge "Check whether all allocations are sampled for accurate test."
2020-09-11 hjd@google.com Merge "ui: Fix build dependencies"
2020-09-11 lalitm@google.com Merge "tp: add missing array header"
2020-09-11 lalitm@google.com Merge "as_pandas() -> as_pandas_dataframe(); add __str__ representation"
2020-09-11 lalitm@google.com Merge "tp: move metrics descriptor generation to build time"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I1287524252c58e915bf0b4233eaa683a38c33bb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408970Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806649}

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I504a5b2aa41ee1db66b84162e0938552544cce62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410024Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806648}

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: Id1340e7ec64d65905152a1588fbda307fa38f884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410237Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806647}

These targets fail to build or link if depended upon without
`enable_rlz_support`. It is a stronger and more relevant condition than
`!is_android`, see: rlz/buildflags/buildflags.gni

Split out from crrev.com/c/2383400

Bug: 898837
Change-Id: Ie675921f61c626eb9a8808df335bc88f309ea31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409073
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806646}

Updates the illustration image. The modal will now be a form sheet
presentation, making it smaller. The bottom button will not be padded
on the bottom with the layoutMargin's bottom value so that the button is
slightly closer to the edge. This will give the buttons and content
more space. Popovers width will be capped at 300pt so that they will
fit a more square shape for iPads.

Bug: 1107489
Change-Id: I0d8f400ef8e249f9c5ea3d6b0c4ab939282a3a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405540
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806645}

Roll Chrome Mac PGO profile from chrome-mac-master-1600062449-eb397872f2f81f98b45c4ec794b206b9a087897d.profdata to chrome-mac-master-1600084447-6a3b264d40de14a9dcaaf57db5d6240ab2f7fff3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I76a585b661f5347dc81d20149072dc707142409a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410197Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806644}

These tests fail when Schemeful Same-Site is active due to them
using an HTTP top-level with HTTPS subresources.
Because none of the tests appear to require an insecure top-level site
to test their assumptions, change them to use HTTPS instead which
avoids the issue.

Bug: 1127348
Change-Id: Ic3d7f7c87b683ab4506203e679a6bb6ba3d0e1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404805Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806643}

Adds a per-scene incognito blocker. Removes the old blocker.
The new blocker is implemented as a scene agent that monitors the scene
for state changes and checks a new SceneState flag
|incognitoContentVisible| that was previously owned by SceneController.
Removes old tests and adds new ones.
Uses window ordering by windowLevel instead of keyWindow, which is
actually possible even before scene startup.

especially with full-screen video in an incognito tab.

Fixed: 1125969
Test: on iOS 12, 13, 14 devices test that the incognito blocker works,
Change-Id: I3192908c61fecc7d548383dab4d068a05f4c3ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404855
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806642}

This reverts commit 8668ae66.

Reason for revert: Fixing build error on Android builder starting on https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/221587.

!!!! Skipping CQ because Android build on perf waterfall has been failing for 2 days.

Original change's description:
> Revert "Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision)"
> 
> This reverts commit 608a0e43.
> 
> Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that.
> 
> Original change's description:
> > Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision)
> > 
> > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bb03bb4b22d..44c9ca6a2c0e
> > 
> > If this roll has caused a breakage, revert this CL and stop the roller
> > using the controls here:
> > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> > Please CC orphis@google.com on the revert to ensure that a human
> > is aware of the problem.
> > 
> > To report a problem with the AutoRoller itself, please file a bug:
> > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> > 
> > Documentation for the AutoRoller is here:
> > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> > 
> > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> > Bug: chromium:1040645
> > Tbr: orphis@google.com
> > Change-Id: I586d0a124bb943405b379d527767540d5730141e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405975
> > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/master@{#806112}
> 
> TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com
> 
> Change-Id: I55721462acc6cdeb5da2584ae493d1e119072c3c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1040645
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406521
> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
> Cr-Commit-Position: refs/heads/master@{#806329}

TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,wenbinzhang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1040645
Change-Id: I00393b7a94df4eae2c5e31ee5f74979785deaf41
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410438Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806641}

This test still fails on Fuchsia, but this should produce better errors.

Bug: 1127298
Change-Id: I9c6d18ad1ce863814628d052031b932c53fb9ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408399Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tamir Duberstein <tamird@google.com>
Cr-Commit-Position: refs/heads/master@{#806640}