- 21 Oct, 2020 40 commits
-
-
Roman Arora authored
Close button focus and navigation aspects to be addressed in crbug 1113470. Bug: 1099917 Change-Id: I7f42dd62381a345eb0cf807c48d5f8eb3b79b70e Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3203733Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Tom Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819581}
-
Roman Arora authored
Check for key event modifires before triggering keyboard navigation. Fixed: 1111003 Change-Id: Icccfc2938d4812974b628273edc7d68fc825a559 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3202978Reviewed-by:
-
Tom Lukaszewicz authored
This CL temporarily hides the close tab icon given the close tab functionality has not yet been fully plumbed in. This change will help avoid confusion when enabling Tab Search for early users looking to give feedback. Bug: 1099917 Change-Id: Ieed4c7d4220bb2edd07c0056198ac7d8490cb15f Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3204546Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I3684b450523e4ec79fcd4dfc6497625982e4b79f Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3203117Reviewed-by:
-
Yuheng Huang authored
Localization strings will be addressed in a follow up CL. Bug: 1099917 Change-Id: I537d681272524b747bd7d35bbf903d812984363b Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3202980Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#819577}
-
Roman Arora authored
Fix scroll bug on repeated quick press of up/down keys on first/last selector entries. Fixed: 1110505 Change-Id: I84c015cfd21c6b8c8dd477dcd327ef23e09012ae Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3201593Reviewed-by:
-
Tom Lukaszewicz authored
Updated CSS to better align with figma mocks. Aligned hover color values to those used in the new-tab-page. before: https://drive.google.com/file/d/14924TmDxdzhC6CepFJSn6BxT-hWc3OXc after: https://drive.google.com/file/d/1S7j2xX_nlUXOuSQkN8Sl0kaq67mrdel9 Bug: 1099917 Change-Id: Ia369ea168740309c2dff12ad384ed8c0090d584d Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3197970Reviewed-by:
-
Tom Lukaszewicz authored
Updated JSDoc information to support using the CrSearchFieldBehavior with with the non-legacy class based Polymer3 syntax. Related CL: https://crrev.com/c/2333208 Bug: 1099917 Change-Id: Id514a5b20e19700a3f7b2948f6a2c7f36caf8d58 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3194288Reviewed-by:
-
Tom Lukaszewicz authored
Added the SearchField component to the TabSearch WebUI. The search field adheres to current UX style specifications for Read Later and Tab Search features. Dependent CL (update to Polymer bundle): https://crrev.com/c/2324810 Before: https://drive.google.com/file/d/1A_ikRVaaqhYH1k9RXSnH1aWWknAwajZF After: https://drive.google.com/file/d/1rN_-548iNgbWDvlVH9l_CZQXgydRtgyc Bug: 1099917 Change-Id: Id92c573aee7463e626773ff514a1b50d3ee18648 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3177409Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#819573}
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2290996 Bug: 1099917 Change-Id: Ic96dd27394ab8495d00a3a723c19e80239c99404 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3158203Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I95480e8bef7de7197642997cebf1296b5c0a1563 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3187724Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819571}
-
Roman Arora authored
Tab Search UI related changes: - Custom tab-search-item component that represents each tab item - Show only hostname of tab url on tab-search-item - Close tab icon for certain list-item states - Keyboard navigation for tab-search-items Bug: 1099917 Change-Id: Idae91276a66b5b8e2efd7914266ea73107c58d34 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3154044Reviewed-by:
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2298282 Bug: 1099917 Change-Id: I45fb78b7013b46b5ac3c00f905631fc63d871c87 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3164617Reviewed-by:
-
Yuheng Huang authored
Tab Search is served by TabSearchUI with chrome://tab-search. It's guarded by compile flag enable_tab_search and enabled by --enable-features=TabSearch Bug: 1099917 Change-Id: I6621bd9fc2e7489b94a46fa0997cdb8f5f193d93 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3137445Reviewed-by:
-
Theresa Wellington authored
Conslidating team mailing lists. Change-Id: If933ddcf81ccd5563c90e2adfb9eaf96714af5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#819567}
-
Jesse Doherty authored
Change-Id: Id2cbe3d9ee41b44b00d48bb9271682b4294d1d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490023Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#819566}
-
Sebastien Marchand authored
See the internal counterpart for this CL at cl/338334637 Bug: 1121427 Change-Id: I0be4895755eb476e06b0e825e8bd03fa25281b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490943Reviewed-by:
-
Matt Wolenetz authored
Adds a readonly, boolean-valued, static attribute named `canConstructInDedicatedWorker` to the MediaSource interface. Currently, this attribute is only visible to web apps if the RunTimeEnabledFeature "MediaSourceInWorkers" is enabled. When visible, this attribute always returns true. The primary goal of having this attribute is to enable web app's main thread to proactively determine whether or not MSE is supported from a dedicated worker context *before* deciding whether or not to create or try using MSE from such a context. As an initial example of this use case, the existing MSE-in-Workers web_tests are updated to use this new attribute's existence and value to fail-fast rather than potentially flakily fail (e.g. previously, the ...worker-terminate test might flakily pass/fail some of its test cases on implementations lacking MSE-in-Workers support if the test completed before handling receipt of error message from worker.) A further test is added to ensure that, if the attribute is missing or exists but is not `true`, a dedicated worker does not have ability to construct a MediaSource instance. See also https://github.com/w3c/media-source/issues/175 for further discussion which led to this new attribute. BUG=878133 Change-Id: I697ca6adc5b5dc65d5c5084ff67a541430a9237b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487834 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#819564}
-
Nidhi Jaju authored
This is a reland of a2505c5b Original change's description: > Remove NotEnumerable from Writable Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from writable streams. > > Bug: 1093862 > Change-Id: I935a9f8726b3cb1dc4efb5b4d6db71384c8efe37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485664 > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Nidhi Jaju <nidhijaju@google.com> > Cr-Commit-Position: refs/heads/master@{#819181} Bug: 1093862 Change-Id: Iaf54f395cc649b85cbc834dc18baf94855d53613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489110 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#819563}
-
Sophey Dong authored
This bug fix has been launched since M84. Bug: 1124205 Change-Id: I99dd4b7edbab9443c10169144f5ecf3b115c74f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391508Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#819562}
-
Tim Song authored
Currently, the notification icon is styled based on an accent color in the standard notification system. However, for PhoneHub, our icons have color, so we need to add a new field to reflect this behaviour. BUG=1140893,1106937 Change-Id: I892ab724b17cc2b17d20555ce68631fab055a418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489165 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819561}
-
Thomas Lukaszewicz authored
This reverts commit 315d5cdf. Reason for revert: Reverting due to suspect in linux-chromeos-rel build breakage. First broken build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42155 Original change's description: > Multipaste: Add flag for resetting nudge prefs on new session > > Add a flag which, when enabled, will reset the clipboard nudge prefs > on a new user session. This will allow the nudge to be shown again. > > Bug: 1140656 > Change-Id: I312f05eed655fc1657843d2b7a45214bb671bebe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489020 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819483} TBR=newcomer@chromium.org,mmourgos@chromium.org Change-Id: I49212699a83e3e023c2a0cdf10ffbe96db19528e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491157Reviewed-by:
-
Ken Buchanan authored
The previously observed crashes no longer repro for me in tests or exercising the API in browser. The crash had been very reliable before. This CL enables the tests to see if the issue has somehow become resolved. Fixed: 1123273 Change-Id: Id23ef5ba460267cd013eeaa533e1a8caec7330a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490512 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819559}
-
Zhenyao Mo authored
The feature does not work with GL renderer. Also, set |supports_target_damage| cap to false on Windows. Otherwise we saw black flashes when switching from video overlay mode to chrome compositing mode. BUG=1122686,1117185 TEST=manual R=kylechar@chromium.org Change-Id: I9e759b2b58e26b76972fb0e3373540f83a560904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490411 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#819558}
-
Austin Sullivan authored
- Add SandboxFileStreamWriter unit tests - Normal + Incognito modes - Restructure unit tests to be shared between Local, Memory, and SandboxFileStreamWriters Change-Id: Ic0e6daede15c0937a8e65b9f6c8d8a77425b2306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422682Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#819557}
-
tby authored
We currently send a request to ItemSuggest on login if the suggested files experiment is enabled. This generates too much peak QPS, so we would like to only issue this 'warmup' request if the user has ever used the launcher before. This CL: 1. Adds a synced pref to track whether a search result has ever been launched from the launcher. 2. Gates the warmup query behind that pref, so long as the gating itself hasn't been disabled via Finch (in case we want to reverse this decision later). Bug: 1034842 Change-Id: Id226f94274fd0fb4fb89680eb90056894587c74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485995Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#819556}
-
Dale Curtis authored
This reverts commit de6e338e. Reason for revert: Should be fixed by https://crrev.com/819550 Original change's description: > Set use_vaapi=false in fuzzer builds. > > Bug: 1140770 > Change-Id: I0c9877f5cb24bb66c86df3577caee71a9fdca102 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487742 > Commit-Queue: Oliver Chang <ochang@chromium.org> > Auto-Submit: Oliver Chang <ochang@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819249} TBR=ochang@chromium.org,tikuta@chromium.org Change-Id: If383a43d03d61b581df2451f133b2d5bfe4b09ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491220Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819555}
-
Tarun Bansal authored
Move connectivity detector to a common directory. This CL does not make any functional changes, but it allows for reuse of connectivity detector by other features. Change-Id: Ic3ac9693301eba47d4d44134fd609d1d6644416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460831Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819554}
-
Tarun Bansal authored
Make NQE signal strength unit test more robust by approximately checking for the histogram count. Bug: 1130720 Change-Id: Ic535966d94ec0a5b312f51c20b71dfceaf0be0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484302 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819553}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d139f2661939..9606cffa66d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib1d0cc6496286387d8ce555068d9e746957efbe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489672Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819552}
-
Jamie Madill authored
This will not have a speed up but will allow ANGLE to complete the transition to the standalone test runner. Also increase the sharding parameter for these tests. Right now they only run on Android. Bug: angleproject:5124 Bug: 1140626 Change-Id: I61847aa30e0b00226e5961b78bc29cac52c659e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489723 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#819551}
-
Jerome Jiang authored
Add libvpx as deps to libvp9rc instead to avoid duplication. Bug: 1140770 Change-Id: I2bdeb2985008cc31eb24abff50a1da290192f50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490506Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#819550}
-
Yu Han authored
This is a reland of 0397ac4e The original CL was reverted because it caused two tests failures on the win7 platform [1]. I think what happened I manually corrected the rebaseline tool's merging of some of the expected files. These led to not removing the expected files for these two tests on win7 platform. And since CQ's win7 builder doesn't auto run, it CL passed where it should have failed. I've since removed these two invalid expected files from win7 platform. In addition, I removed fuchsia/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-picker-appearance-expected.png because its incorrect and I don't see the virtual suite tested on fuchsia. Ran CQ on all platforms and they passed. [1] https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/b8866243899672370144 Original change's description: > [Controls Refresh] Update controls styles for dark mode > > This CL updates the dark mode styles for the following controls: > 1. <meter> - border color. > 2. multi-select - foreground text color. > 3. Button: Dark mode button design has no border and has unique fill > color. Thus, a specific set of color enums is created for only > buttons. Button's border color is styled to match its fill color > in order to give the appearance of no borders and keep its > dimensions unchanged. This impacts: button, file, and color > controls. > > > Bug: 1107290, 1099624 > Change-Id: I141c199f93acac2b950b8af7195e863f811c2f4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469357 > Commit-Queue: Yu Han <yuzhehan@google.com> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818119} Bug: 1107290 Bug: 1099624 Change-Id: I3097043a036da08dc201e0ce78ecc2ed1c94a1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485039Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819549}
-
Ben Pastene authored
This reverts commit 9d5ab21c. Reason for revert: suspected to be causing Unknown function unpak("unpak_v3") errors eg: https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel/403265? https://ci.chromium.org/p/chromium/builders/try/chromeos-arm-generic-rel Original change's description: > WebUI: Delete unpack_pak > > Remove unpack_pak.py script and associated rule and tests. grit + unpack > rules are no longer needed to generate inputs for optimize_webui since > the introduction of the new preprocess_grit rule. > > Bug: 1132403 > Change-Id: I52fed86461108904abe8e319f3a015e8daa21aa0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490332 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819539} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Ib27403a02332ca2bbae464930fa23882657d29f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490670Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#819548}
-
Charlene Yan authored
CalculateAvailableWidthForTabs takes into account the fixed tabstrip width for closing mode |override_available_width_for_tabs_|. Bug: 1140423 Change-Id: I5bec3dde8f4b14990d4556a6c424d42b75acd89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488881 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819547}
-
Kartik Hegde authored
Switch kFailedToResolveAllHosts to the clearer kHostResolutionFailure to denote when one or more hosts failed DNS resolution. BUG=chromium:956783 TEST=unit_tests --gtest_filter=DnsLatencyRoutineTest.* Change-Id: I0392df692919a55896e439edc5f53801d756873d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490069Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#819546}
-
Elly Fong-Jones authored
This change removes CrostiniAppRestartView, replacing it with: * Construction and configuration of a bare View + DialogDelegate pair * A pair of public functions that create and show this dialog This change also adds some unit test coverage for this dialog to ensure that I didn't break it when doing this refactor. Bug: 1075649 Change-Id: I7de0e2386de14aa6aec8917c630f64a69df26832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490345 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#819545}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/4f79c8405028..0ce070474164 2020-10-21 dsinclair@chromium.org Remove type alias struct variant. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I35688907dd5f9a260909610f875a4efaae580843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490164Reviewed-by:
-
Zhaoyang Li authored
Test runner will copy attachments from xcresult to output folder (isolated output in infra) for all failed tests in each attempt. Screenshots will be collected only from failing steps to avoid noise. Other attachments will be collected from every step. - Put the copy logic in private methods and called these in public collect_test_results. - Improved and unified variable naming where touched. - Removed unused plist check where touched. - Fixed and added tests for xcode_log_parser. Bug: 1047704 Change-Id: I448c785a256702d93698e5c73ef89b7477efbc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473499Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#819543}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/553115ec991c..726aef930d80 2020-10-21 jalyn@microsoft.com Partial reland: Remove dependencies on ShortcutsScreen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140386,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5c045c6ffe5bf6e73de481816c8c0dd603325bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490163Reviewed-by:
-
