- 01 Nov, 2019 40 commits
-
-
Ken Rockot authored
On Android we can somehow observe utility process crashes without observing process launches. This is a simple fix to avoid memory bugs in that case. Also fixes a related leak in the internal ServiceProcessTracker, where we were never cleaning up ServiceProcessInfo entries after process termination. Bug: 1016027 Change-Id: Ia5a8df891547cb7a2f01c869d16b014a8b249423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894627Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#711829}
-
Rodney Ding authored
- New doc explaining how to initialize blink features in content layer - Update feature flag guides to point to the new doc Bug: 832393 Change-Id: Id0cd47a2b926c55e15516242cbf6382e199b1537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873991Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#711828}
-
David Van Cleve authored
This CL adds logic processing ESNI DNS responses and surfacing the results via ResolveHostRequest. It contains some nontrivial functionality and some boilerplate. The nontrivial functionality (host_resolver_manager.cc and unittests): - adds the addresses from ESNI records to the *address list* contained in the HostCache entry, so that existing TCP connection logic will be able to connect to ESNI-accompanied addresses in the same manner as addresses without ESNI keys. Before sorting the addresses, partition them on whether or not they have accompanying ESNI keys, so that the stable sort in AddressSorter implicitly breaks ties in favor of addresses associated with ESNI keys. The boilerplate (all changes except HostResolverManager): - extends all "expect only one field is present" logic in prior host_resolver_manager unittests to reflect that there's now another field - extends all switches on DnsQueryType to accommodate DnsQueryType::ESNI - extends all subclasses of ResolveHostRequest to implement GetEsniContent() Testing: - Adds a new group of HostResolverManager unittests for ESNI queries. R=ericorth Bug: 1003494 Change-Id: I49a18dd4937737c2d22d0fc0357b9e6a3a40e7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874248Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#711827}
-
Ryan Daum authored
rounded_window_corners_default.cc was missing from the build target. Bug: internal b/141369549 Test: unit test Change-Id: Ib25fd665e630f2c115f420bc4f6d5b7e3dfe3a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895868Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#711826}
-
Alexander Timin authored
Use a weak ptr factory instead of a base::Unretained to ensure that we don't get a UAF after deleting BackgroundTaskUpdateScheduler or cancelling a task. R=agrieve@chromium.org,tiborg@chromium.org BUG=880565 Change-Id: Ib6ce448625b3bbb99776dec75d3e8110ab987a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895659Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711825}
-
Henrique Nakashima authored
Use this to add verifications that the expected calls are made to BackgroundTaskSchedulerExternalUma. Bug: 1017130 Change-Id: Ica99e12df6d1d655f1d2fdba8ad20b5065a2170a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884821Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711824}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable this test as it is being run and is flaking. Tbr: reillyg@chromium.org Bug: 1020591 Change-Id: I8dea9bc8f0e3ef23bb733c9912e0011c5ac4253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895798Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b1ae70fb..5689bf7c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d82f1cd93488c34cdb5c5a6f3888edfb9210e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895394Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711822}
-
Yue Zhang authored
This CL adds TabGroupsContinuation feature flag and hide tab group naming and selection-mode in dialog behind this flag. Also, unit tests are added to make sure the flag setup is properly reflected. Bug: 1018841 Change-Id: I88737144e710b694f3cccf4a1b7a5f0763916a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885016Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711821}
-
Henrique Nakashima authored
SharedPreferencesManager should be used instead. Bug: 1017800 Change-Id: I49f8a702e456ce636658b233a620066451b26858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893502 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#711820}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=torne@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I39d0a74b1bec2148a9dec777ace504bb0a1de4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895642 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#711819}
-
Rohit Rao authored
BUG=699306 Change-Id: Ide0eba1f60a766ab0913642921dca725e28e258b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894016Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#711818}
-
Natalie Chouinard authored
The PrefServiceBridge Java caller object is not used on the native side remove it from all calls. Bug: 1016957 Change-Id: I3987dd419723fd9a11f00c93fa45a8e738574a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894268Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#711817}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable these tests as they are being run and are flaking. Tbr: jamiewalch@chromium.org Bug: 1020591 Change-Id: I6f0d29981323617bfbb569ecfd28e1550242039d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895783Reviewed-by:
-
Anastasia Helfinstein authored
This is a pure refactor, with no change in logic or behavior. It groups functions by simplicity, and alphabetizes within those groups. Bug: None Change-Id: I5eda83d75e50a30ed8ae5e7c2c3ef1444d20601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891015 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711815}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05ff793e61e6..41eccb9d43eb Created with: gclient setdep -r src-internal@41eccb9d43eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I46c30f94ef3ebf51e1e2694a6f41fa9ce41e2635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894685Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711814}
-
Yun Liu authored
I complied all suites locally with the same gn args as android-code-coverage-native, and these suites in exceptions.pyl failed due to linker errors (crbug in comment). Exclude these suites for now until linker issues are fixed. Bug: 985574 Change-Id: I50cbc195153bc6d93a8c2bd0f8952a72d869e65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893116 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Yun Liu <yliuyliu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#711813}
-
Anastasia Helfinstein authored
Bug: 1018327 Change-Id: I667be3f714fcea00d2238e3f60144d8118c99bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884822Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#711812}
-
Abigail Klein authored
Bug: 785493 Change-Id: I4522d70bcf2841dbd554bdae37bcfebbdc55239d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857542 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711811}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/48233ad3d45b..7f77b2e8669a git log 48233ad3d45b..7f77b2e8669a --date=short --no-merges --format='%ad %ae %s' 2019-11-01 cepheus@frii.com Bump version. Created with: gclient setdep -r src/third_party/glslang/src@7f77b2e8669a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: Ia89f0ea5a3de8429f9f03f22d406a4ed03a6ba69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711810}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=rsleevi@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Iab984c0c745ec8316f5a7d23f15db4d42d63aae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893542 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711809}
-
Jamie Madill authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/e5d3a6655e13..d253f41e17e2 $ git log e5d3a6655..d253f41e1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/spirv-cross/spirv-cross TBR=dsinclair@chromium.org Bug: angleproject:2634 Change-Id: I51409fe8d8b0521609d0f679c60213b17307f92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895758Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#711808}
-
Kelvin Jiang authored
This CL adds a new "unpacked" value which could be specied under the "location" key for extension features. APIs/events specified as "unpacked" will only be available for unpacked and command line extensions. This change was motivated by the declarativeNetRequest.OnRuleMatchedDebug event which should only be available for unpacked extensions. Bug: 1017934 Change-Id: Iafe0a64160dc4ca083bcf58393aba94a87bfd3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892212 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711807}
-
Torne (Richard Coles) authored
The new implementation of CookieManager::SetAcceptFileSchemeCookies introduced by the network servicification can deadlock when the embedding app is using the CookieManager API in a silly (but not forbidden) way. The deadlock occurs because the calling thread holds accept_file_scheme_cookies_lock_ while waiting synchronously for a task to complete on the CookieManagerClient thread, but it's possible that a task was already queued on that thread which is going to call GetCookieStore() and then attempt to acquire accept_file_scheme_cookies_lock_ to create the cookie store. Avoid this by moving the code which updates accept_file_scheme_cookies_ to run as part of the posted task instead. Also, add thread annotations to CookieManager to clarify which locks protect which state, as the existing comment was not correct. Fixed: 992829 Change-Id: I61aa3a505add2866fdf4317ffa7cf33e684ddc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890953Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#711806}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=kbr@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I2bfb718aa066e09050197565d36f8f11b34e8a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894882 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711805}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/076fae010165..fe26bae45243 git log 076fae010165..fe26bae45243 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 lehoangq@gmail.com Metal backend implementation pt 2 Created with: gclient setdep -r src/third_party/angle@fe26bae45243 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Ia39e3e8ea03a9cc5dfa2659873d47e77c8cd78c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894689Reviewed-by:
-
David Benjamin authored
&vector[0] is invalid if vector is empty. Instead, use vector.data(). This fixes a crash when building with _LIBCPP_DEBUG=0. Bug: 923166 Change-Id: I1de75f3fb4da62c3e70da90c8478e7672b0f16e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894309 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=seantopping@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I5caea21fdb526caf65a2d918b64a58661e552019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895653 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#711802}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable these tests as they are being run and are flaking. Tbr: jamiewalch@chromium.org Bug: 1020591 Change-Id: I245e2d8c4fcf59f35698561385cc8cc8a453b807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895780Reviewed-by:
-
Karan Bhatia authored
Instead use the generated flat::RemoveHeaderType enum introduced in r709187. BUG=974391 Change-Id: I28c91cce82160f112edb458df552de27398e8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894066 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711800}
-
Sky Malice authored
Bug: 1020359 Change-Id: I78e3ba760cd00c0f8b7d49452881e6547649a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894471Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#711799}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fda994c63075..855e8b1bc29d git log fda994c63075..855e8b1bc29d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 natsu@google.com Allow concurrent eglSwapBuffers() with same display but different surfaces 2019-11-01 natsu@google.com Move egl locking code from main.cpp to libEGL.cpp Created with: gclient setdep -r src/third_party/swiftshader@855e8b1bc29d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/135742693,chromium:b/135742693 Change-Id: I0d0c629ea807e0f9cfd4b1fa39e9a8827fe7d7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894681Reviewed-by:
-
Ben Pastene authored
Will revert if/when they get marked informational. Bug: 1006681 Change-Id: I82ac85781c3f20b749eb4b1963e1673534a7cd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895314 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#711797}
-
Manu Cornet authored
The general idea here is to encapsulate more of the hotseat's behavior into its own class rather than have it all over the shelf layout manager. Eventually, I hope to get rid of the huge "CalculateHotseatState" method by setting the hotseat state to the appropriate values from the relevant places. Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711796}
-
Shimi Zhang authored
Since we are not using jsObjectName until the next navigation, it will only until then we could tell if the parameter is valid or not, if it is not valid, the injection will fail sliently. We want to provide a early exception for developer to know if the object name is valid or not. Since it is hard for us to valid the full set of the allowed JavaScript variable name, we limited the scope to a manageable subset of it. Bug: 918065 Change-Id: I74909768fc9695e6d33302d880eb211a4b250c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894181 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
rbpotter authored
|activeUser| was left undefined, so the Polymer binding in the destination select never flipped hidden to true. Fix by setting the activeUser to empty explicitly in when cloud print is disabled. Fixed: 1018488 Change-Id: Id3b3271acf755617813e6c4f677f51095095e71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892061 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#711794}
-
Oksana Zhuravlova authored
This change is preparation for DocumentInterfaceBroker removal. Since the |document_interface_broker_blink_handle| will no longer be passed, blink will now pass a bool value to indicate whether BrowserInterfaceBroker connection needs to be re-established. Bug: 985120 Change-Id: Ifb5ac6aaf3acba529acc2aabb84301cf3640d126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893983 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=fdoray@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Idfdf967c4953e8293e420579ba6abc2d6f9e66f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895650 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#711792}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5e1ef7e22ff0..c93813be129d git log 5e1ef7e22ff0..c93813be129d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 tneda@google.com Merge "perfetto-ui: Button to minimize/maximize track with heap profile flamegraph" 2019-11-01 eseckler@google.com Merge "processor: Remove stale memory_tracker.h/cc files" 2019-11-01 primiano@google.com Merge "Fix CI script to actually delete directory" 2019-11-01 primiano@google.com Merge "UI: Fix undefined in scroll handler" Created with: gclient setdep -r src/third_party/perfetto@c93813be129d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic60df3fdad376d20278777dc29bd280eb692487e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894684Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=skyostil@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I4bb88f91272c322e1056dfcb9b117f4ed21b6c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895651 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#711790}
-
